Re: [PHP-DEV] Re: [RFC] [DISCUSSION] More precise float value

2015-09-28 Thread Yasuo Ohgaki
Hi all and Ferenc, On Mon, Sep 28, 2015 at 4:51 AM, Anatol Belski wrote: >> -Original Message- >> From: jakub@gmail.com [mailto:jakub@gmail.com] On Behalf Of Jakub >> Zelenka >> > Exactly, so my question was - why it still needs to do "if (mode == 0) >> >

Re: [PHP-DEV] Re: [RFC] [DISCUSSION] More precise float value

2015-09-27 Thread Jakub Zelenka
Hi Yasuo, On Fri, Sep 25, 2015 at 1:10 AM, Yasuo Ohgaki wrote: > Hi all, > > On Fri, Sep 25, 2015 at 7:49 AM, Yasuo Ohgaki wrote: > > No problem. I'll update so that 0 mode is for 7.1. > > JSON's is better to use larger precision. So this change is

Re: [PHP-DEV] Re: [RFC] [DISCUSSION] More precise float value

2015-09-27 Thread Jakub Zelenka
Hi Anatol, On Sat, Sep 26, 2015 at 8:31 PM, Anatol Belski wrote: > Hi Yasuo, > > > > Thanks for the ping. IMHO this is the stuff for 7.1. I actually saw the > > discussions previously, but was rather thinking you was targeting 7.1 as > that was > > already the time of the

RE: [PHP-DEV] Re: [RFC] [DISCUSSION] More precise float value

2015-09-27 Thread Anatol Belski
Hi Jakub, > -Original Message- > From: jakub@gmail.com [mailto:jakub@gmail.com] On Behalf Of Jakub > Zelenka > > Exactly, so my question was - why it still needs to do "if (mode == 0) > > ndigit = 17;" in snprintf at the place I've linked? It won't have any > > effect as zend_dtoa

RE: [PHP-DEV] Re: [RFC] [DISCUSSION] More precise float value

2015-09-26 Thread Anatol Belski
Hi Yasuo, > > Thanks for the ping. IMHO this is the stuff for 7.1. I actually saw the > discussions previously, but was rather thinking you was targeting 7.1 as that > was > already the time of the feature freeze. > > No problem. I'll update so that 0 mode is for 7.1. > JSON's is better to use

Re: [PHP-DEV] Re: [RFC] [DISCUSSION] More precise float value

2015-09-24 Thread Yasuo Ohgaki
Sommer Nielsen <ka...@php.net> >> Cc: Anatoliy Belsky <a...@php.net>; Ferenc Kovacs <tyr...@gmail.com>; >> internals@lists.php.net >> Subject: Re: [PHP-DEV] Re: [RFC] [DISCUSSION] More precise float value >> >> Hi Anatol and Ferenc, >> >> On

Re: [PHP-DEV] Re: [RFC] [DISCUSSION] More precise float value

2015-09-24 Thread Yasuo Ohgaki
Hi all, On Fri, Sep 25, 2015 at 7:49 AM, Yasuo Ohgaki wrote: > No problem. I'll update so that 0 mode is for 7.1. > JSON's is better to use larger precision. So this change is targeted > to 5.6 and 7.0. > > Let me know if you have comments on this. The RFC is updated.

RE: [PHP-DEV] Re: [RFC] [DISCUSSION] More precise float value

2015-09-21 Thread Anatol Belski
lt;tyr...@gmail.com>; > internals@lists.php.net > Subject: Re: [PHP-DEV] Re: [RFC] [DISCUSSION] More precise float value > > Hi Anatol and Ferenc, > > On Sat, Sep 19, 2015 at 7:15 AM, Kalle Sommer Nielsen <ka...@php.net> wrote: > > I'm sorry I have not caught this any

Re: [PHP-DEV] Re: [RFC] [DISCUSSION] More precise float value

2015-09-20 Thread Yasuo Ohgaki
Hi Anatol and Ferenc, On Sat, Sep 19, 2015 at 7:15 AM, Kalle Sommer Nielsen wrote: > I'm sorry I have not caught this any earlier, but even without > consulting with Anatol, I'm not keen on adding this into 7.0, we are > in RC stage, and I want us to focus on a stable release

Re: [PHP-DEV] Re: [RFC] [DISCUSSION] More precise float value

2015-09-18 Thread Kalle Sommer Nielsen
Hi Yasuo 2015-09-18 23:28 GMT+02:00 Yasuo Ohgaki : > It's been 2 weeks and no comment for this. > I'll start voting. I'm sorry I have not caught this any earlier, but even without consulting with Anatol, I'm not keen on adding this into 7.0, we are in RC stage, and I want us

Re: [PHP-DEV] Re: [RFC] [DISCUSSION] More precise float value

2015-09-18 Thread Matt Wilmas
Hi Yasuo, - Original Message - From: "Yasuo Ohgaki" Sent: Friday, September 18, 2015 Hi all, On Fri, Sep 4, 2015 at 9:41 AM, Yasuo Ohgaki wrote: IEEE 754 double cannot express exact float values. That said, float values expressed by

[PHP-DEV] Re: [RFC] [DISCUSSION] More precise float value

2015-09-18 Thread Yasuo Ohgaki
Hi all, On Fri, Sep 4, 2015 at 9:41 AM, Yasuo Ohgaki wrote: > IEEE 754 double cannot express exact float values. That said, > float values expressed by json/serialize/var_export/echo/print > are not precise enough in many cases. > > Issues: > - json_encode() uses