Re: [PHP-DEV] About dropping magic_quotes in 5.3 (was: Re: [PHP-DEV] Re: PHP 5.2.7 + magic_quotes_gpc broken)

2008-12-11 Thread Raphael Geissert
Hannes Magnusson wrote: [...] We really need to work on our relationship with other distros, starting with marking security fixes as security fixes. Yes, please do mark them as such. -Hannes Cheers, -- Raphael Geissert - Debian Maintainer www.debian.org - get.debian.net -- PHP

Re: [PHP-DEV] About dropping magic_quotes in 5.3 (was: Re: [PHP-DEV] Re: PHP 5.2.7 + magic_quotes_gpc broken)

2008-12-09 Thread Marcus Boerger
Hello Ilia, we would stick to the rule of only adding to internal APIs in a minor branch series. Using the pre x.y.0 for time to add, change and delete functions. I'll write more in a separate thread. marcus Monday, December 8, 2008, 10:19:32 PM, you wrote: How would that model relate to

Re: [PHP-DEV] Re: PHP 5.2.7 + magic_quotes_gpc broken

2008-12-08 Thread Ilia Alshanetsky
Should the 5.3 release be re-branched perhaps as well, since it too has this problem? On 7-Dec-08, at 1:33 PM, Marcus Boerger wrote: Hello Ilia, brilliant :-) Sunday, December 7, 2008, 7:16:43 PM, you wrote: I will be re-branching 5.2.7 with this revert for the purpose of 5.2.8 this

Re: [PHP-DEV] Re: PHP 5.2.7 + magic_quotes_gpc broken

2008-12-08 Thread Pierre Joye
hi, On Mon, Dec 8, 2008 at 3:15 PM, Ilia Alshanetsky [EMAIL PROTECTED] wrote: Should the 5.3 release be re-branched perhaps as well, since it too has this problem? I do not think it is necessary for 5.3. It is an alpha release after all and seriously, anyone who plans to move to 5.3.0 and

Re: [PHP-DEV] Re: PHP 5.2.7 + magic_quotes_gpc broken

2008-12-08 Thread Hannes Magnusson
On Mon, Dec 8, 2008 at 15:24, Pierre Joye [EMAIL PROTECTED] wrote: hi, On Mon, Dec 8, 2008 at 3:15 PM, Ilia Alshanetsky [EMAIL PROTECTED] wrote: Should the 5.3 release be re-branched perhaps as well, since it too has this problem? I do not think it is necessary for 5.3. It is an alpha

Re: [PHP-DEV] Re: PHP 5.2.7 + magic_quotes_gpc broken

2008-12-08 Thread Pierre Joye
On Mon, Dec 8, 2008 at 4:06 PM, Hannes Magnusson [EMAIL PROTECTED] wrote: On Mon, Dec 8, 2008 at 15:24, Pierre Joye [EMAIL PROTECTED] wrote: hi, On Mon, Dec 8, 2008 at 3:15 PM, Ilia Alshanetsky [EMAIL PROTECTED] wrote: Should the 5.3 release be re-branched perhaps as well, since it too has

Re: [PHP-DEV] Re: PHP 5.2.7 + magic_quotes_gpc broken

2008-12-08 Thread Kalle Sommer Nielsen
2008/12/8 Pierre Joye [EMAIL PROTECTED]: On Mon, Dec 8, 2008 at 4:06 PM, Hannes Magnusson [EMAIL PROTECTED] wrote: On Mon, Dec 8, 2008 at 15:24, Pierre Joye [EMAIL PROTECTED] wrote: hi, On Mon, Dec 8, 2008 at 3:15 PM, Ilia Alshanetsky [EMAIL PROTECTED] wrote: Should the 5.3 release be

[PHP-DEV] About dropping magic_quotes in 5.3 (was: Re: [PHP-DEV] Re: PHP 5.2.7 + magic_quotes_gpc broken)

2008-12-08 Thread Johannes Schlüter
Hi, let's take this to a new thread so it'S not hidden in other discussions: On Mon, 2008-12-08 at 16:06 +0100, Hannes Magnusson wrote: I do not think it is necessary for 5.3. It is an alpha release after all and seriously, anyone who plans to move to 5.3.0 and still relies on magic quotes

Re: [PHP-DEV] Re: PHP 5.2.7 + magic_quotes_gpc broken

2008-12-08 Thread Johannes Schlüter
On Mon, 2008-12-08 at 09:15 -0500, Ilia Alshanetsky wrote: Should the 5.3 release be re-branched perhaps as well, since it too has this problem? The 5.3 alpha release is hopefully not used in production by anybody so I don't think it's critical there. Maybe it motivates somebody to think

Re: [PHP-DEV] About dropping magic_quotes in 5.3 (was: Re: [PHP-DEV] Re: PHP 5.2.7 + magic_quotes_gpc broken)

2008-12-08 Thread Richard Quadling
2008/12/8 Johannes Schlüter [EMAIL PROTECTED]: Hi, let's take this to a new thread so it'S not hidden in other discussions: On Mon, 2008-12-08 at 16:06 +0100, Hannes Magnusson wrote: I do not think it is necessary for 5.3. It is an alpha release after all and seriously, anyone who plans

Re: [PHP-DEV] Re: PHP 5.2.7 + magic_quotes_gpc broken

2008-12-08 Thread Marcus Boerger
Hello Pierre, Monday, December 8, 2008, 4:08:49 PM, you wrote: On Mon, Dec 8, 2008 at 4:06 PM, Hannes Magnusson [EMAIL PROTECTED] wrote: On Mon, Dec 8, 2008 at 15:24, Pierre Joye [EMAIL PROTECTED] wrote: hi, On Mon, Dec 8, 2008 at 3:15 PM, Ilia Alshanetsky [EMAIL PROTECTED] wrote: Should

Re: [PHP-DEV] About dropping magic_quotes in 5.3 (was: Re: [PHP-DEV] Re: PHP 5.2.7 + magic_quotes_gpc broken)

2008-12-08 Thread Hannes Magnusson
On Mon, Dec 8, 2008 at 16:57, Pierre Joye [EMAIL PROTECTED] wrote: On Mon, Dec 8, 2008 at 4:47 PM, Johannes Schlüter [EMAIL PROTECTED] wrote: When dropping magic_quotes the hosting company can do one of two things: a) not update to 5.3 so we either have to maintain 5.2 for some time or let

Re: [PHP-DEV] About dropping magic_quotes in 5.3 (was: Re: [PHP-DEV] Re: PHP 5.2.7 + magic_quotes_gpc broken)

2008-12-08 Thread Johannes Schlüter
Hi, On Mon, 2008-12-08 at 16:03 +, Richard Quadling wrote: But I also understand it is pretty shitty to miss a 1 liner (magic quotes removed) and find everything broken and then to be told RTFM/RTFCL. There's a difference between this and other breaks: Most other BC breaks change the

Re: [PHP-DEV] About dropping magic_quotes in 5.3 (was: Re: [PHP-DEV] Re: PHP 5.2.7 + magic_quotes_gpc broken)

2008-12-08 Thread Marcus Boerger
Hello Pierre, Monday, December 8, 2008, 4:57:17 PM, you wrote: On Mon, Dec 8, 2008 at 4:47 PM, Johannes Schlüter [EMAIL PROTECTED] wrote: Hi, let's take this to a new thread so it'S not hidden in other discussions: On Mon, 2008-12-08 at 16:06 +0100, Hannes Magnusson wrote: I do not think

Re: [PHP-DEV] Re: PHP 5.2.7 + magic_quotes_gpc broken

2008-12-08 Thread Cristian Rodríguez
Pierre Joye escribió: I would even like to drop it (and the other things as well) in 5.3.0 :) Yes, please :) but throw an error when use is detected. -- We have art in order not to die of the truth - Friedrich Nietzsche Cristian Rodríguez R. Platform/OpenSUSE - Core Services SUSE LINUX

Re: [PHP-DEV] About dropping magic_quotes in 5.3 (was: Re: [PHP-DEV] Re: PHP 5.2.7 + magic_quotes_gpc broken)

2008-12-08 Thread Sean Coates
I don't safe stuff relying on magic_quotes is safe but kicking it will open up way more attack vectors... :-( In my opinion, this isn't about opening attack vectors (one hole is all it takes, so they're probably already vulnerable), but removing mqgpc without fair warning to end users could

Re: [PHP-DEV] About dropping magic_quotes in 5.3 (was: Re: [PHP-DEV] Re: PHP 5.2.7 + magic_quotes_gpc broken)

2008-12-08 Thread Philip Olson
On 8 Dec 2008, at 08:18, Hannes Magnusson wrote: On Mon, Dec 8, 2008 at 16:57, Pierre Joye [EMAIL PROTECTED] wrote: On Mon, Dec 8, 2008 at 4:47 PM, Johannes Schlüter [EMAIL PROTECTED] wrote: When dropping magic_quotes the hosting company can do one of two things: a) not update to 5.3

Re: [PHP-DEV] About dropping magic_quotes in 5.3 (was: Re: [PHP-DEV] Re: PHP 5.2.7 + magic_quotes_gpc broken)

2008-12-08 Thread Cristian Rodríguez
Johannes Schlüter escribió: I don't safe stuff relying on magic_quotes is safe but kicking it will open up way more attack vectors... :-( A false sense of security is worst than no security at all. -- We have art in order not to die of the truth - Friedrich Nietzsche Cristian Rodríguez R.

Re: [PHP-DEV] About dropping magic_quotes in 5.3 (was: Re: [PHP-DEV] Re: PHP 5.2.7 + magic_quotes_gpc broken)

2008-12-08 Thread Scott MacVicar
On 8 Dec 2008, at 16:35, Philip Olson [EMAIL PROTECTED] wrote: On 8 Dec 2008, at 08:18, Hannes Magnusson wrote: On Mon, Dec 8, 2008 at 16:57, Pierre Joye [EMAIL PROTECTED] wrote: On Mon, Dec 8, 2008 at 4:47 PM, Johannes Schlüter [EMAIL PROTECTED] net wrote: When dropping magic_quotes the

Re: [PHP-DEV] About dropping magic_quotes in 5.3 (was: Re: [PHP-DEV] Re: PHP 5.2.7 + magic_quotes_gpc broken)

2008-12-08 Thread Steph Fox
Hi Scott, Agreed, going from on by default to removed just feels odd. I'd disable it by default in 5.3 and lets start throwing a strict error if the configuration enables it. Why do we have E_DEPRECATED if we're not going to use it? - Steph -- PHP Internals - PHP Runtime Development

Re: [PHP-DEV] About dropping magic_quotes in 5.3 (was: Re: [PHP-DEV] Re: PHP 5.2.7 + magic_quotes_gpc broken)

2008-12-08 Thread Scott MacVicar
Steph Fox wrote: Hi Scott, Agreed, going from on by default to removed just feels odd. I'd disable it by default in 5.3 and lets start throwing a strict error if the configuration enables it. Why do we have E_DEPRECATED if we're not going to use it? That's the one I meant, no idea why

Re: [PHP-DEV] About dropping magic_quotes in 5.3 (was: Re: [PHP-DEV] Re: PHP 5.2.7 + magic_quotes_gpc broken)

2008-12-08 Thread Pierre Joye
hi, On Mon, Dec 8, 2008 at 5:53 PM, Scott MacVicar [EMAIL PROTECTED] wrote: I'd disable it by default in 5.3 and lets start throwing a strict error if the configuration enables it. A fatal error could be more effective. And the message can make the reason behind the error very clear. By the

Re: [PHP-DEV] About dropping magic_quotes in 5.3 (was: Re: [PHP-DEV] Re: PHP 5.2.7 + magic_quotes_gpc broken)

2008-12-08 Thread Scott MacVicar
Pierre Joye wrote: hi, On Mon, Dec 8, 2008 at 5:53 PM, Scott MacVicar [EMAIL PROTECTED] wrote: I'd disable it by default in 5.3 and lets start throwing a strict error if the configuration enables it. A fatal error could be more effective. And the message can make the reason behind the

Re: [PHP-DEV] About dropping magic_quotes in 5.3 (was: Re: [PHP-DEV] Re: PHP 5.2.7 + magic_quotes_gpc broken)

2008-12-08 Thread Steph Fox
Hi Pierre, A fatal error could be more effective. And the message can make the reason behind the error very clear. It's a very big jump from 'enabled by default' to 'fatal error'. It will break a lot of legacy code with no prior warning. By the way and for the record here, they (magic

Re: [PHP-DEV] About dropping magic_quotes in 5.3 (was: Re: [PHP-DEV] Re: PHP 5.2.7 + magic_quotes_gpc broken)

2008-12-08 Thread Ilia Alshanetsky
In my opinion a big change like droping something that was and still used by many people are a security measure, albeit a poor one is something that can only be done in a major release. On 8-Dec-08, at 10:47 AM, Johannes Schlüter wrote: Hi, let's take this to a new thread so it'S not

Re: [PHP-DEV] About dropping magic_quotes in 5.3 (was: Re: [PHP-DEV] Re: PHP 5.2.7 + magic_quotes_gpc broken)

2008-12-08 Thread Derick Rethans
On Mon, 8 Dec 2008, Ilia Alshanetsky wrote: In my opinion a big change like droping something that was and still used by many people are a security measure, albeit a poor one is something that can only be done in a major release. I concur. regards, Derick -- HEAD before 5_3!:

Re: [PHP-DEV] About dropping magic_quotes in 5.3 (was: Re: [PHP-DEV] Re: PHP 5.2.7 + magic_quotes_gpc broken)

2008-12-08 Thread Hannes Magnusson
On Mon, Dec 8, 2008 at 20:15, Derick Rethans [EMAIL PROTECTED] wrote: On Mon, 8 Dec 2008, Ilia Alshanetsky wrote: In my opinion a big change like droping something that was and still used by many people are a security measure, albeit a poor one is something that can only be done in a major

Re: [PHP-DEV] About dropping magic_quotes in 5.3 (was: Re: [PHP-DEV] Re: PHP 5.2.7 + magic_quotes_gpc broken)

2008-12-08 Thread Pierre Joye
On Mon, Dec 8, 2008 at 8:38 PM, Hannes Magnusson [EMAIL PROTECTED] wrote: On Mon, Dec 8, 2008 at 20:15, Derick Rethans [EMAIL PROTECTED] wrote: On Mon, 8 Dec 2008, Ilia Alshanetsky wrote: In my opinion a big change like droping something that was and still used by many people are a security

Re: [PHP-DEV] About dropping magic_quotes in 5.3 (was: Re: [PHP-DEV] Re: PHP 5.2.7 + magic_quotes_gpc broken)

2008-12-08 Thread Ilia Alshanetsky
As much as I hate the feature, I am not certain that is a good idea in a minor release. On 8-Dec-08, at 2:38 PM, Hannes Magnusson wrote: On Mon, Dec 8, 2008 at 20:15, Derick Rethans [EMAIL PROTECTED] wrote: On Mon, 8 Dec 2008, Ilia Alshanetsky wrote: In my opinion a big change like

Re: [PHP-DEV] About dropping magic_quotes in 5.3 (was: Re: [PHP-DEV] Re: PHP 5.2.7 + magic_quotes_gpc broken)

2008-12-08 Thread Steph Fox
As much as I hate the feature, I am not certain that is a good idea in a minor release. If not now, when? - Steph -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] About dropping magic_quotes in 5.3 (was: Re: [PHP-DEV] Re: PHP 5.2.7 + magic_quotes_gpc broken)

2008-12-08 Thread Ilia Alshanetsky
6.0 iirc its already off by default in that branch. On 8-Dec-08, at 3:12 PM, Steph Fox wrote: As much as I hate the feature, I am not certain that is a good idea in a minor release. If not now, when? - Steph Ilia Alshanetsky -- PHP Internals - PHP Runtime Development Mailing List

Re: [PHP-DEV] About dropping magic_quotes in 5.3 (was: Re: [PHP-DEV] Re: PHP 5.2.7 + magic_quotes_gpc broken)

2008-12-08 Thread Pierre Joye
hi, On Mon, Dec 8, 2008 at 9:48 PM, Ilia Alshanetsky [EMAIL PROTECTED] wrote: 6.0 iirc its already off by default in that branch. It is not off by default, it has been removed completely. I re introduced the check function (returning always false) later. Cheers, -- Pierre

Re: [PHP-DEV] About dropping magic_quotes in 5.3 (was: Re: [PHP-DEV] Re: PHP 5.2.7 + magic_quotes_gpc broken)

2008-12-08 Thread Steph Fox
6.0 iirc its already off by default in that branch. Ilia, it doesn't *exist* in that branch! - Steph -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] About dropping magic_quotes in 5.3 (was: Re: [PHP-DEV] Re: PHP 5.2.7 + magic_quotes_gpc broken)

2008-12-08 Thread Marcus Boerger
Hello Ilia, given our current development model I completely agree. Thus I would like to change it as described earlier. I am convinced that only following the even=stable odd=dev/testing model allows for longer maintenanance cycles and fast development at the same time. marcus Monday,

Re: [PHP-DEV] About dropping magic_quotes in 5.3 (was: Re: [PHP-DEV] Re: PHP 5.2.7 + magic_quotes_gpc broken)

2008-12-08 Thread Ilia Alshanetsky
How would that model relate to patch, minor, major release schemes we have right now. What you are proposing works for linux, where there is only one branch and they can effectively do the odd/even approach. But, what would it mean for PHP and our current versioning schema? On 8-Dec-08,

Re: [PHP-DEV] Re: PHP 5.2.7 + magic_quotes_gpc broken

2008-12-08 Thread Lukas Kahwe Smith
On 08.12.2008, at 16:08, Pierre Joye wrote: On Mon, Dec 8, 2008 at 4:06 PM, Hannes Magnusson [EMAIL PROTECTED] wrote: On Mon, Dec 8, 2008 at 15:24, Pierre Joye [EMAIL PROTECTED] wrote: hi, On Mon, Dec 8, 2008 at 3:15 PM, Ilia Alshanetsky [EMAIL PROTECTED] wrote: Should the 5.3 release be

Re: [PHP-DEV] Re: PHP 5.2.7 + magic_quotes_gpc broken

2008-12-08 Thread Lukas Kahwe Smith
On 08.12.2008, at 16:08, Pierre Joye wrote: On Mon, Dec 8, 2008 at 4:06 PM, Hannes Magnusson [EMAIL PROTECTED] wrote: On Mon, Dec 8, 2008 at 15:24, Pierre Joye [EMAIL PROTECTED] wrote: hi, On Mon, Dec 8, 2008 at 3:15 PM, Ilia Alshanetsky [EMAIL PROTECTED] wrote: Should the 5.3 release be

Re: [PHP-DEV] Re: PHP 5.2.7 + magic_quotes_gpc broken

2008-12-08 Thread Lukas Kahwe Smith
On 08.12.2008, at 16:08, Pierre Joye wrote: On Mon, Dec 8, 2008 at 4:06 PM, Hannes Magnusson [EMAIL PROTECTED] wrote: On Mon, Dec 8, 2008 at 15:24, Pierre Joye [EMAIL PROTECTED] wrote: hi, On Mon, Dec 8, 2008 at 3:15 PM, Ilia Alshanetsky [EMAIL PROTECTED] wrote: Should the 5.3 release be

Re: [PHP-DEV] Re: PHP 5.2.7 + magic_quotes_gpc broken

2008-12-08 Thread mike
Mon, Dec 8, 2008 at 1:40 PM, Lukas Kahwe Smith [EMAIL PROTECTED] wrote: the drop was planned for 6.0 for a reason. i also do not think we need to make a 5.3 release just for this. lets focus on getting feedback on namespaces and the other changes and have this fixed on beta1 early 2009.

Re: [PHP-DEV] Re: PHP 5.2.7 + magic_quotes_gpc broken

2008-12-08 Thread Pierre Joye
On Tue, Dec 9, 2008 at 12:20 AM, mike [EMAIL PROTECTED] wrote: Mon, Dec 8, 2008 at 1:40 PM, Lukas Kahwe Smith [EMAIL PROTECTED] wrote: the drop was planned for 6.0 for a reason. i also do not think we need to make a 5.3 release just for this. lets focus on getting feedback on namespaces and

Re: [PHP-DEV] About dropping magic_quotes in 5.3 (was: Re: [PHP-DEV] Re: PHP 5.2.7 + magic_quotes_gpc broken)

2008-12-08 Thread Jeremy Darwood
Hello, I don't post here often, but I wanted to input my thoughts. For the most part, I am a end user who developers PHP applications for mine and others needs. We can't just drop something so soon and expect others to catch up and be able to operate with no problems at all. There is tons

Re: [PHP-DEV] Re: PHP 5.2.7 + magic_quotes_gpc broken

2008-12-08 Thread Hannes Magnusson
On Mon, Dec 8, 2008 at 22:40, Lukas Kahwe Smith [EMAIL PROTECTED] wrote: On 08.12.2008, at 16:08, Pierre Joye wrote: On Mon, Dec 8, 2008 at 4:06 PM, Hannes Magnusson [EMAIL PROTECTED] wrote: On Mon, Dec 8, 2008 at 15:24, Pierre Joye [EMAIL PROTECTED] wrote: hi, On Mon, Dec 8, 2008 at

[PHP-DEV] Re: PHP 5.2.7 + magic_quotes_gpc broken

2008-12-07 Thread Ilia Alshanetsky
I will be re-branching 5.2.7 with this revert for the purpose of 5.2.8 this week. This will allow the normal 5.2 bug fixing to continue as normal. On 6-Dec-08, at 3:35 PM, Scott MacVicar wrote: Hey, There have been several bug reports about magic_quotes_gpc being broken, at the moment

Re: [PHP-DEV] Re: PHP 5.2.7 + magic_quotes_gpc broken

2008-12-07 Thread Marcus Boerger
Hello Ilia, brilliant :-) Sunday, December 7, 2008, 7:16:43 PM, you wrote: I will be re-branching 5.2.7 with this revert for the purpose of 5.2.8 this week. This will allow the normal 5.2 bug fixing to continue as normal. On 6-Dec-08, at 3:35 PM, Scott MacVicar wrote: Hey, There

Re: [PHP-DEV] Re: PHP 5.2.7 + magic_quotes_gpc broken

2008-12-07 Thread mike
In the meantime shouldn't this be posted on php.net? Uninformed people are thinking that 5.2.7 is good to go. On Sun, Dec 7, 2008 at 10:16 AM, Ilia Alshanetsky [EMAIL PROTECTED] wrote: I will be re-branching 5.2.7 with this revert for the purpose of 5.2.8 this week. This will allow the normal