Re: [PHP-DEV] Revive Number Format Separator RFC

2019-05-02 Thread Thomas Punt
> On Wed, May 02, 2019 at 03:00 AM Bishop Bettini > mailto:bis...@php.net>> wrote: > > Great, thanks Tom. Theodore and I are polishing the RFC, then will tackle the > implementation. Besides the necessary merge fixes, are there any > changes/improvements you specifically want to make in the new

Re: [PHP-DEV] Revive Number Format Separator RFC

2019-05-01 Thread Bishop Bettini
On Wed, May 1, 2019 at 5:42 AM Thomas Punt wrote: > Hi! > > > On Wed, May 01, 2019 at 01:13 AM Bishop Bettini wrote: > > > On Tue, Apr 30, 2019, 19:14 Theodore Brown wrote: > > > > > > On Tue, Apr 30, 2019 at 3:59 PM Bishop Bettini wrote: > > > > > > > Excellent. I hope we can make the case

Re: [PHP-DEV] Revive Number Format Separator RFC

2019-05-01 Thread Thomas Punt
Hi! > On Wed, May 01, 2019 at 01:13 AM Bishop Bettini wrote: > > On Tue, Apr 30, 2019, 19:14 Theodore Brown > > > On Tue, Apr 30, 2019 at 3:59 PM Bishop Bettini wrote: > > > > > Excellent. I hope we can make the case this time. Please > > > request Wiki karma [1], and we'll iterate on it

Re: [PHP-DEV] Revive Number Format Separator RFC

2019-04-30 Thread Bishop Bettini
On Tue, Apr 30, 2019, 19:14 Theodore Brown On Tue, Apr 30, 2019 at 3:59 PM Bishop Bettini wrote: > > > Excellent. I hope we can make the case this time. Please > > request Wiki karma [1], and we'll iterate on it there. > > I was granted karma, and published an initial RFC draft: >

Re: [PHP-DEV] Revive Number Format Separator RFC

2019-04-30 Thread Bishop Bettini
On Tue, Apr 30, 2019 at 4:41 PM Theodore Brown wrote: > On Mon, Apr 29, 2019 at 2:33 AM Bishop Bettini wrote: > > > Well said. > > > > One need not agree with an implementation to appreciate the improved > > readability. > > > > If you'd like to re-open this for voting, I'm able to assist with

Re: [PHP-DEV] Revive Number Format Separator RFC

2019-04-30 Thread Theodore Brown
On Mon, Apr 29, 2019 at 2:33 AM Bishop Bettini wrote: > Well said. > > One need not agree with an implementation to appreciate the improved > readability. > > If you'd like to re-open this for voting, I'm able to assist with > the RFC process and any code changes. Thanks! I drafted a

Re: [PHP-DEV] Revive Number Format Separator RFC

2019-04-29 Thread Bishop Bettini
On Sun, Apr 28, 2019 at 1:47 PM Theodore Brown wrote: > On Sat, Apr 27, 2019 at 10:25 PM Stanislav Malyshev > wrote: > > > I am not exactly against this feature, but the potential for abuse > > \- like enabling people using integers for things that are not > > integers and should not be stored

Re: [PHP-DEV] Revive Number Format Separator RFC

2019-04-28 Thread Theodore Brown
On Sat, Apr 27, 2019 at 10:25 PM Stanislav Malyshev wrote: > I am not exactly against this feature, but the potential for abuse > \- like enabling people using integers for things that are not > integers and should not be stored as integers - worries me now. Based on the usage analysis Bishop

Re: [PHP-DEV] Revive Number Format Separator RFC

2019-04-27 Thread Stanislav Malyshev
Hi! > A cursory scan of current usage suggests that number format separator might > be used in scenarios such as: > > Phone numbers > 919_555_1234 > 49_89_636_48018 Just noting here that using integers as phone numbers is not something we want to support, enable or promote. > Date time values

Re: [PHP-DEV] Revive Number Format Separator RFC

2019-04-27 Thread Rowan Collins
On 27 April 2019 13:51:11 BST, Lester Caine wrote: >On 27/04/2019 13:37, Rowan Collins wrote: >> The only way I've seen dates stored as integers is as a number of >> seconds / milliseconds / whatever since some epoch, most commonly >> seconds since 1970-01-01 00:00:00 UTC > >Use of a days count

Re: [PHP-DEV] Revive Number Format Separator RFC

2019-04-27 Thread Lester Caine
On 27/04/2019 13:37, Rowan Collins wrote: The only way I've seen dates stored as integers is as a number of seconds / milliseconds / whatever since some epoch, most commonly seconds since 1970-01-01 00:00:00 UTC Use of a days count rather than a seconds count makes dates a lot easier to work

Re: [PHP-DEV] Revive Number Format Separator RFC

2019-04-27 Thread Rowan Collins
On 27/04/2019 12:18, Thomas Punt wrote: Storing dates in an integer format can be a valid use case if performance is a concern. It is far faster and more compact to store and compare integer-based dates than using objects for everything. The only way I've seen dates stored as integers is as

Re: [PHP-DEV] Revive Number Format Separator RFC

2019-04-27 Thread Thomas Punt
Hi! > On Fri, Apr 26, 2019 at 4:30 PM Theodore Brown wrote: > > > On Fri, Apr 26, 2019 at 6:10 AM Rowan Collins > > wrote: > > > > I'm not particularly against this proposal, but I'm not sure how often I'd > > use it. > > How often you use numeric separators depends on what you are doing. > I

Re: [PHP-DEV] Revive Number Format Separator RFC

2019-04-26 Thread Theodore Brown
On Fri, Apr 26, 2019 at 6:10 AM Rowan Collins wrote: > On Thu, Apr 25, 2019 at 6:07 PM Theodore Brown wrote: > > > Is there any chance the Number Format Separator RFC [1] could be revived > > for PHP 7.4? I looked at the discussion from a few years ago and it's > > not clear why many people

Re: [PHP-DEV] Revive Number Format Separator RFC

2019-04-26 Thread Lester Caine
On 26/04/2019 12:10, Rowan Collins wrote: This is a poor example, because phone numbers shouldn't be stored as integers; there's nothing you can do with them mathematically, and outside of North America it's extremely common for them to have significant leading zeroes. Along with flagging the

Re: [PHP-DEV] Revive Number Format Separator RFC

2019-04-26 Thread Rowan Collins
> > On Thu, Apr 25, 2019 at 6:07 PM Theodore Brown > > wrote: > > > >> Is there any chance the Number Format Separator RFC [1] could be revived > >> for PHP 7.4? I looked at the discussion from a few years ago and it's > not > >> clear why many people originally voted against it. > Hi, I'm not

Re: [PHP-DEV] Revive Number Format Separator RFC

2019-04-25 Thread Bishop Bettini
On Thu, Apr 25, 2019 at 9:28 PM Bishop Bettini wrote: > On Thu, Apr 25, 2019 at 6:07 PM Theodore Brown > wrote: > >> Is there any chance the Number Format Separator RFC [1] could be revived >> for PHP 7.4? I looked at the discussion from a few years ago and it's not >> clear why many people

Re: [PHP-DEV] Revive Number Format Separator RFC

2019-04-25 Thread Bishop Bettini
On Thu, Apr 25, 2019 at 6:07 PM Theodore Brown wrote: > Is there any chance the Number Format Separator RFC [1] could be revived > for PHP 7.4? I looked at the discussion from a few years ago and it's not > clear why many people originally voted against it. > > JavaScript and Python have both

[PHP-DEV] Revive Number Format Separator RFC

2019-04-25 Thread Theodore Brown
Is there any chance the Number Format Separator RFC [1] could be revived for PHP 7.4? I looked at the discussion from a few years ago and it's not clear why many people originally voted against it. JavaScript and Python have both gotten this feature recently and it's something I really miss in