Re: [PHP-DEV] VM kinds

2021-11-10 Thread Tim Starling
OK, thanks for the answer. My PR is up now, with a fixme comment for the GOTO and SWITCH VMs. I'm still not sure how to make them work. https://github.com/php/php-src/pull/7642 -- Tim Starling On 10/11/21 8:10 pm, Dmitry Stogov wrote: > I prefer to keep GOTO and SWITCH VMs. It's easy to drop

Re: [PHP-DEV] VM kinds

2021-11-10 Thread Dmitry Stogov
I prefer to keep GOTO and SWITCH VMs. It's easy to drop something, but it's going to be much more complex to reimplement it again. Note that HYBRID VM (based on CALL and GOTO VMs) was introduced only in PHP-7.2, because GOTO was already implemented a long time ago. In the future, it's possible to

Re: [PHP-DEV] VM kinds

2021-11-10 Thread Nikita Popov
On Wed, Nov 10, 2021 at 8:13 AM Tim Starling wrote: > What are VM kinds for? Are they just a prototyping tool to allow > different implementation strategies to be benchmarked? Or are they > permanent? Does anyone use them? > > I ask because I'm working on a VM bug, and non-default VM kinds make

[PHP-DEV] VM kinds

2021-11-09 Thread Tim Starling
What are VM kinds for? Are they just a prototyping tool to allow different implementation strategies to be benchmarked? Or are they permanent? Does anyone use them? I ask because I'm working on a VM bug, and non-default VM kinds make already complex code even more complex and harder to edit. --