Hi Alexander,
I've updated the files according to your notes, except
php_uint32/MD5_u32plus.
However new version breaks ext/hash md4. (ext/hash/tests/md4.phpt is
broken).
Sara, did you have a solution for this issue?
Or could you look into it please?
Thanks. Dmitry.
Solar Designer wrote:
Hi Dmitry,
On Thu, Feb 07, 2008 at 01:11:38PM +0300, Dmitry Stogov wrote:
I've updated the files according to your notes, except
php_uint32/MD5_u32plus.
...and except for adding a note that I'm not the only author (not of the
modified code). That's fine, if it's your preference, I don't care
On Thu, Feb 07, 2008 at 01:11:38PM +0300, Dmitry Stogov wrote:
However new version breaks ext/hash md4. (ext/hash/tests/md4.phpt is
broken).
Oh, I am able to reproduce this with my original patch:
PASS hmac-md5 algorithm [ext/hash/tests/hmac-md5.phpt]
PASS md2 algorithm
I wrote:
Oh, I am able to reproduce this with my original patch:
PASS hmac-md5 algorithm [ext/hash/tests/hmac-md5.phpt]
PASS md2 algorithm [ext/hash/tests/md2.phpt]
FAIL md4 algorithm [ext/hash/tests/md4.phpt]
PASS md5 algorithm [ext/hash/tests/md5.phpt]
PASS ripemd128 algorithm
Hi,
We are going to include your md5() implementation into php-5.3.0.
I confirm at least 25% md5() speedup on my Core2 3GHz, however license
issues are not clear.
We are going to distribute files under standard PHP license including
your original copyright notes.
The files which are going to
Dmitry,
On Tue, 2008-02-05 at 14:34 +0300, Dmitry Stogov wrote:
/*
* * This is an OpenSSL-compatible implementation of the RSA Data Security,
* * Inc. MD5 Message-Digest Algorithm (RFC 1321).
**
[...]
looks like your editor has gone wild on that comment in md5.c ;-)
johannes
--
Hi Dmitry and all,
First of all, please accept my apologies for failing to find the time to
participate in the licensing issues discussion in December. It is a
topic that I would like to discuss and arrive at a conclusion as I often
happen to write code that I'd like to release to the public
Malyshev [EMAIL PROTECTED]; Andi Gutmans [EMAIL PROTECTED];
PHP Internals List internals@lists.php.net
Sent: Tuesday, February 05, 2008 11:50 PM
Subject: Re: [PHP-DEV] faster public domain MD5 implementation
Hi Dmitry and all,
First of all, please accept my apologies for failing to find
Hi Steph,
On Wed, Feb 06, 2008 at 12:18:37AM -, Steph Fox wrote:
Stupid question maybe, but why can't you use your given name for this?
I can, and I don't mind you replacing all occurrences of Solar
Designer with Alexander Peslyak in these two files - or would you
like me to do that myself?
On 21.12.2007 05:15, Martin Alterisio wrote:
http://cvsweb.openwall.com/cgi/cvsweb.cgi/Owl/packages/popa3d/popa3d/md5/
Tried that one and it is about 30% faster indeed (on md5-only benchmark,
32-bit Linux on AMD Opteron. Anybody objects to accepting this?
Just one, but is a mere formality.
isn't public domain specific enough?
On 12/21/07, Martin Alterisio [EMAIL PROTECTED] wrote:
2007/12/20, Stanislav Malyshev [EMAIL PROTECTED]:
Attached is a quick patch for PHP 5.2.5 that replaces RSA's copyrighted
implementation of MD5 with my public domain one:
Alexey Zakhlestin wrote:
isn't public domain specific enough?
Public Domain actually isn't a universal concept, and it isn't
recognized everywhere in law. A very open BSD style license first,
followed by granting it to the public domain, should cover all bases.
Even somewhere that doesn't
Hello Solar,
thanks again for offering this. What we require is to have the PHP License
in the code. If you are fine with this we will gladly replace the existing
code with yours. You can of course put more header information in there to
stress out further that it is your code and where it can
No, public domain isn't recognized by copyright law as a copyright notice.
An extra line should be added that says something like no copyright is
claimed, and attach a year range where the copyright is in effect (since
copyright expires, if I remember correctly). Anyway, the keyword here is
Not entirely correct. As I pointed out in the other thread, not all
countries have the concept of transferrable copyright. Therefor, a
note should be added that explicitly states that everyone is free to
use it without permission, fees etc. Much like a BSD or MIT license,
but without the
Thanks! I didn't know about that.
2007/12/21, David Zülke [EMAIL PROTECTED]:
Not entirely correct. As I pointed out in the other thread, not all
countries have the concept of transferrable copyright. Therefor, a
note should be added that explicitly states that everyone is free to
use it
Attached is a quick patch for PHP 5.2.5 that replaces RSA's copyrighted
implementation of MD5 with my public domain one:
http://cvsweb.openwall.com/cgi/cvsweb.cgi/Owl/packages/popa3d/popa3d/md5/
Tried that one and it is about 30% faster indeed (on md5-only benchmark,
32-bit Linux on
2007/12/20, Stanislav Malyshev [EMAIL PROTECTED]:
Attached is a quick patch for PHP 5.2.5 that replaces RSA's copyrighted
implementation of MD5 with my public domain one:
http://cvsweb.openwall.com/cgi/cvsweb.cgi/Owl/packages/popa3d/popa3d/md5/
Tried that one and it is about 30% faster
Hi,
Attached is a quick patch for PHP 5.2.5 that replaces RSA's copyrighted
implementation of MD5 with my public domain one:
http://cvsweb.openwall.com/cgi/cvsweb.cgi/Owl/packages/popa3d/popa3d/md5/
This also results in faster and slightly smaller code (both source and
binary). On a
19 matches
Mail list logo
