Re: [PHP-DEV] zend_inline_hash_function reimplementation

2008-07-21 Thread Lukas Kahwe Smith
On 21.07.2008, at 17:29, Michal Dziemianko wrote: Hello, I have looked into Zend/zend_hash.h and I guess it might be sped up a little. So far it uses D. Bernstein's hash which is quite fast, but I think it might be worth replacing it with MurmurHash. I have tried comparison of speed for

RE: [PHP-DEV] zend_inline_hash_function reimplementation

2008-07-21 Thread Andi Gutmans
Hi Michal, Can you please send a link to the patch so we can review? I didn't get the attachment. Thanks, Andi -Original Message- From: Michal Dziemianko [mailto:[EMAIL PROTECTED] Sent: Monday, July 21, 2008 8:29 AM To: internals@lists.php.net Subject: [PHP-DEV]

Re: [PHP-DEV] zend_inline_hash_function reimplementation

2008-07-21 Thread Scott MacVicar
Hi Andi, The patch is attached for 5_3. I've got some time allocated tomorrow to review all of Michal's patches that have been produced for the GSoC. I'll try to post some figures from real life apps. Scott Andi Gutmans wrote: Hi Michal, Can you please send a link to the patch so we can

RE: [PHP-DEV] zend_inline_hash_function reimplementation

2008-07-21 Thread Andi Gutmans
: [PHP-DEV] zend_inline_hash_function reimplementation Hi Andi, The patch is attached for 5_3. I've got some time allocated tomorrow to review all of Michal's patches that have been produced for the GSoC. I'll try to post some figures from real life apps. Scott Andi Gutmans wrote

Re: [PHP-DEV] zend_inline_hash_function reimplementation

2008-07-21 Thread Stanislav Malyshev
Hi! I understand this patch has potential portability issues for architectures that won't be able to read int's unaligned. Maybe we could keep both of them and do some configure test to see if it works fine, if not - use the old one? Also I understand that this function returns uint while

Re: [PHP-DEV] zend_inline_hash_function reimplementation

2008-07-21 Thread Scott MacVicar
There is an aligned version of the algorithm available but its slower, there is also a 64-bit version in the works. I emailed the author about its progress to check. At the moment adding both looks the way forward, i'll benchmark a PPC version of the algorithm shortly. Scott On 21 Jul