Re: [PHP-DEV] Changing the default value of SQLite3::enableExceptions()

2019-05-18 Thread Kalle Sommer Nielsen
Hi Den fre. 17. maj 2019 kl. 23.20 skrev Robert Kopack : > > I feel like changing the default value of $enableExceptions to TRUE > makes more sense since that is what you would expect from the original > function call as it stands and is the least breakage of anything > already existing (since

Re: [PHP-DEV] Changing the default value of SQLite3::enableExceptions()

2019-05-17 Thread Robert Kopack
I feel like changing the default value of $enableExceptions to TRUE makes more sense since that is what you would expect from the original function call as it stands and is the least breakage of anything already existing (since making it a required variable would throw ArgumentCountError for any

[PHP-DEV] Changing the default value of SQLite3::enableExceptions()

2019-05-17 Thread Kalle Sommer Nielsen
Evening Internals While reviewing a PR[1], which proposes to add two new methods to ext/sqlite3, one being an option to toggle on/off, I've noticed that there already is another method which also enables the extension to toggle on/off behavior, in this case; whether or not to throw exceptions