Re: [Ipmitool-devel] Reg issue with password having 16 bytes [ID:3184687]

2012-05-01 Thread Hank Bruning
Duncan, maybe you should use a different model in programming. Object Oriented vs Procedural. Make a class with a public API as below, It handles 16 and 20 bytes passwords with all the underling IPMI 2.0 cipher suits.

Re: [Ipmitool-devel] Reg issue with password having 16 bytes [ID:3184687]

2012-05-01 Thread Jim Mankovich
Hank, I wasn't working on IPMI 5 years ago when this was all settled so I'm having to piece it together from bug reports on code someone else wrote and an industry standard specification.I'm just trying to help out the best I can. -- Jim Mankovich | jm...@hp.com -- On 5/1/2012 5:42 AM,

Re: [Ipmitool-devel] Reg issue with password having 16 bytes [ID:3184687]

2012-05-01 Thread Hank Bruning
Jim, It was working 5 years ago. Document the problem and submit it. No big deal. h...@jblade.com On Tue, May 1, 2012 at 12:18 PM, Jim Mankovich jm...@hp.com wrote: Hank, I wasn't working on IPMI 5 years ago when this was all settled so I'm having to piece it together from bug reports on

Re: [Ipmitool-devel] Reg issue with password having 16 bytes [ID:3184687]

2012-05-01 Thread Duncan Idaho
Great! Can we get back to patching ipmitool now? --Duncan On Tue, May 1, 2012 at 4:39 PM, Hank Bruning h...@jblade.com wrote: Jim, It was working 5 years ago. Document the problem and submit it. No big deal. h...@jblade.com On Tue, May 1, 2012 at 12:18 PM, Jim Mankovich jm...@hp.com

Re: [Ipmitool-devel] Reg issue with password having 16 bytes [ID:3184687]

2012-05-01 Thread Jim Mankovich
Duncan, This patch looks good to me. Thanks, -- Jim Mankovich | jm...@hp.com -- On 5/1/2012 5:12 AM, Duncan Idaho wrote: Jim, it is all right. Attached is v2 which covers user name longer than 16 bytes. I've also checked the code, again, and password length restrain will work for all

[Ipmitool-devel] FRU print with satellite controllers

2012-05-01 Thread Michael L. Winiarski
All, I would like to request a code review of this before I submit it to the CVS repository. This has had an initial internal review (by Jim Mankovich). I would like to plan to submit this by May 15, 2012. The issue that this patch addresses is when the platform supports satellite

Re: [Ipmitool-devel] Reg issue with password having 16 bytes [ID:3184687]

2012-05-01 Thread Duncan Idaho
Jim, as it turns out, I can't attach anything to artifact that I don't own(which makes some ... ehm ... sense). Anyway. Patch is attached including commit message. Your call now :) --Duncan On Tue, May 1, 2012 at 5:49 PM, Jim Mankovich jm...@hp.com wrote: Duncan,   This patch looks good to