Re: [Ironpython-users] Patch

2012-02-24 Thread Slide
*On Behalf Of *Dino > Viehland > *Sent:* Thursday, February 23, 2012 10:16 PM > *To:* Slide; [email protected] > *Subject:* Re: [Ironpython-users] Patch > > ** ** > > This is awesome, a couple comments: > > Can AssemblyRes

Re: [Ironpython-users] Patch

2012-02-24 Thread Slide
I'll update the GlobalAssemblyCache check before pushing. On Thu, Feb 23, 2012 at 11:16 PM, Dino Viehland wrote: > This is awesome, a couple comments: > > Can AssemblyResolve be moved into PythonOps? It looks > like it keys off of Assembly.GetEntryAssembly() and so doesn’t

Re: [Ironpython-users] Patch

2012-02-24 Thread Slide
Good point, I'll make the change before pushing. On Thu, Feb 23, 2012 at 9:32 PM, Jeff Hardy wrote: > On Thu, Feb 23, 2012 at 7:55 PM, Slide wrote: > > Just wanted to get this out for review before I push it. I would have > done > > it through my fork on github and issued a pull request, but my

Re: [Ironpython-users] Patch

2012-02-23 Thread Dino Viehland
; [email protected] Subject: Re: [Ironpython-users] Patch This is awesome, a couple comments: Can AssemblyResolve be moved into PythonOps? It looks like it keys off of Assembly.GetEntryAssembly() and so doesn't rely on anything in the generated assembly. That'

Re: [Ironpython-users] Patch

2012-02-23 Thread Dino Viehland
This is awesome, a couple comments: Can AssemblyResolve be moved into PythonOps? It looks like it keys off of Assembly.GetEntryAssembly() and so doesn't rely on anything in the generated assembly. That'd make it easier to read and update the code. Maybe I missed something that

Re: [Ironpython-users] Patch

2012-02-23 Thread Jeff Hardy
On Thu, Feb 23, 2012 at 7:55 PM, Slide wrote: > Just wanted to get this out for review before I push it. I would have done > it through my fork on github and issued a pull request, but my fork is > currently messed up. Let me know if you see anything out of the ordinary. > > Fixes 32288 and 26706

Re: [Ironpython-users] Patch: Warn user when using old print syntax

2011-10-17 Thread Markus Schaber
Hi, Dino, Von: Dino Viehland [mailto:[email protected]] >> [... reporting warnings for old print statement syntax ...] > You could add a thread static bool which tracks whether or not we're > already reporting the warning, and if so don't recurse and report again. That would fix the problem wit

Re: [Ironpython-users] Patch: Warn user when using old print syntax

2011-10-14 Thread Dino Viehland
python.org] On Behalf Of Markus Schaber Sent: Thursday, October 13, 2011 1:26 AM To: Markus Schaber; Discussion of IronPython Subject: Re: [Ironpython-users] Patch: Warn user when using old print syntax Hi, Von: [email protected] > Von: Markus Sc

Re: [Ironpython-users] Patch: Warn user when using old print syntax

2011-10-13 Thread Markus Schaber
Hi, Von: [email protected] > Von: Markus Schaber > > The patch below emits a warning during Compilation for print > > statements whose argument list does not start with a '(' if Py3k warnings > are enabled. > > Somehow, this patch leads to a StackOverFl

Re: [Ironpython-users] Patch: Warn user when using old print syntax

2011-10-13 Thread Markus Schaber
Hi, Von: Markus Schaber > The patch below emits a warning during Compilation for print statements > whose argument list does not start with a '(' if Py3k warnings are enabled. Somehow, this patch leads to a StackOverFlowException in some cases, so please don't apply it. (It seemed to work fine

Re: [Ironpython-users] Patch: Warn user when using old print syntax

2011-10-12 Thread Jeff Hardy
Thanks! Can you make this a pull request on GitHub? It's much easier to manage patches from there. - Jeff On Wed, Oct 12, 2011 at 7:44 AM, Markus Schaber wrote: > Hi, > > Von: Markus Schaber >> Von: Dino Viehland [mailto:[email protected]] >> > So you want to warn if the file contains a print