[jira] [Reopened] (LANG-637) There should be a DifferenceBuilder with a ReflectionDifferenceBuilder implementation

2014-11-17 Thread Duncan Jones (JIRA)
[ https://issues.apache.org/jira/browse/LANG-637?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duncan Jones reopened LANG-637: --- The reflection-based builder was never completed. Hence I'm opening this again as a reminder that it is

[jira] [Closed] (LANG-637) There should be a DifferenceBuilder with a ReflectionDifferenceBuilder implementation

2014-11-17 Thread Duncan Jones (JIRA)
[ https://issues.apache.org/jira/browse/LANG-637?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duncan Jones closed LANG-637. - Resolution: Fixed There should be a DifferenceBuilder with a ReflectionDifferenceBuilder implementation

[jira] [Comment Edited] (LANG-637) There should be a DifferenceBuilder with a ReflectionDifferenceBuilder implementation

2014-11-17 Thread Duncan Jones (JIRA)
[ https://issues.apache.org/jira/browse/LANG-637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14214633#comment-14214633 ] Duncan Jones edited comment on LANG-637 at 11/17/14 1:11 PM: -

[jira] [Created] (LANG-1067) Add a reflection-based variant of DiffBuilder

2014-11-17 Thread Duncan Jones (JIRA)
Duncan Jones created LANG-1067: -- Summary: Add a reflection-based variant of DiffBuilder Key: LANG-1067 URL: https://issues.apache.org/jira/browse/LANG-1067 Project: Commons Lang Issue Type:

[jira] [Updated] (LANG-1067) Add a reflection-based variant of DiffBuilder

2014-11-17 Thread Duncan Jones (JIRA)
[ https://issues.apache.org/jira/browse/LANG-1067?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duncan Jones updated LANG-1067: --- Affects Version/s: (was: Patch Needed) 3.3.2 Fix Version/s: Patch

[jira] [Comment Edited] (LANG-637) There should be a DifferenceBuilder with a ReflectionDifferenceBuilder implementation

2014-11-17 Thread Duncan Jones (JIRA)
[ https://issues.apache.org/jira/browse/LANG-637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14214633#comment-14214633 ] Duncan Jones edited comment on LANG-637 at 11/17/14 1:18 PM: -

[jira] [Commented] (VFS-546) VFS very slow resolving FTP files

2014-11-17 Thread JIRA
[ https://issues.apache.org/jira/browse/VFS-546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14214684#comment-14214684 ] Sergio Fernández commented on VFS-546: -- Thanks for the reply, [~b.eckenfels]. We've

[jira] [Commented] (LANG-671) Add indexOf() lastIndexOf() methods for Whitespace and Non-whitespae to StringUtils

2014-11-17 Thread James Sawle (JIRA)
[ https://issues.apache.org/jira/browse/LANG-671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14214780#comment-14214780 ] James Sawle commented on LANG-671: -- Is there any reason why this is still awaiting review?

[jira] [Commented] (LANG-1013) Adding to StringUtils truncate method and test cases

2014-11-17 Thread James Sawle (JIRA)
[ https://issues.apache.org/jira/browse/LANG-1013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14214788#comment-14214788 ] James Sawle commented on LANG-1013: --- I suppose the logic was to allow the feature to be

[jira] [Commented] (LANG-1050) Change nullToEmpty methods to generics

2014-11-17 Thread James Sawle (JIRA)
[ https://issues.apache.org/jira/browse/LANG-1050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14214792#comment-14214792 ] James Sawle commented on LANG-1050: --- Do I need to make this change or will it be handled

[jira] [Commented] (LANG-1013) Adding to StringUtils truncate method and test cases

2014-11-17 Thread Thiago Andrade (JIRA)
[ https://issues.apache.org/jira/browse/LANG-1013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14214878#comment-14214878 ] Thiago Andrade commented on LANG-1013: -- I've fixed the code according to your

[jira] [Commented] (LANG-701) StringUtils join with var args

2014-11-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/LANG-701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14214930#comment-14214930 ] ASF GitHub Bot commented on LANG-701: - GitHub user jamessawle opened a pull request:

[jira] [Commented] (LANG-1031) Annotation @ToStringExclude

2014-11-17 Thread Felipe Adorno (JIRA)
[ https://issues.apache.org/jira/browse/LANG-1031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14214992#comment-14214992 ] Felipe Adorno commented on LANG-1031: - I can reorganize the imports and edit the code

[jira] [Commented] (LANG-1050) Change nullToEmpty methods to generics

2014-11-17 Thread Sebb (JIRA)
[ https://issues.apache.org/jira/browse/LANG-1050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14215191#comment-14215191 ] Sebb commented on LANG-1050: Which change are you referring to? Change nullToEmpty methods to

[jira] [Updated] (VFS-142) Clear ThreadData after all streams are closed, fixes a memory leak

2014-11-17 Thread Ryan Boettcher (JIRA)
[ https://issues.apache.org/jira/browse/VFS-142?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ryan Boettcher updated VFS-142: --- Attachment: threadlocal_setNull_vs_remove_bug.patch Here's a patch against a fresh checkout for what I

[jira] [Updated] (VFS-309) ThreadLocal memory leak in DefaultFileContent

2014-11-17 Thread Ryan Boettcher (JIRA)
[ https://issues.apache.org/jira/browse/VFS-309?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ryan Boettcher updated VFS-309: --- Attachment: threadlocal_setNull_vs_remove_bug.patch Attaching same patch as I just attached to the

[jira] [Commented] (VALIDATOR-342) URLValidator returns false for http://example.rocks

2014-11-17 Thread Sebb (JIRA)
[ https://issues.apache.org/jira/browse/VALIDATOR-342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14215221#comment-14215221 ] Sebb commented on VALIDATOR-342: The method does indeed check the domain. I don't know

[jira] [Commented] (VALIDATOR-342) URLValidator returns false for http://example.rocks

2014-11-17 Thread Sebb (JIRA)
[ https://issues.apache.org/jira/browse/VALIDATOR-342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14215223#comment-14215223 ] Sebb commented on VALIDATOR-342: Note: changed to enhancement; the existing code is

[jira] [Updated] (VALIDATOR-342) URLValidator returns false for http://example.rocks

2014-11-17 Thread Sebb (JIRA)
[ https://issues.apache.org/jira/browse/VALIDATOR-342?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sebb updated VALIDATOR-342: --- Issue Type: New Feature (was: Bug) URLValidator returns false for http://example.rocks

[jira] [Commented] (VALIDATOR-342) URLValidator returns false for http://example.rocks

2014-11-17 Thread Donal Murtagh (JIRA)
[ https://issues.apache.org/jira/browse/VALIDATOR-342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14215238#comment-14215238 ] Donal Murtagh commented on VALIDATOR-342: - Can you explain why you think the

[jira] [Commented] (VFS-142) Clear ThreadData after all streams are closed, fixes a memory leak

2014-11-17 Thread Bernd Eckenfels (JIRA)
[ https://issues.apache.org/jira/browse/VFS-142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14215249#comment-14215249 ] Bernd Eckenfels commented on VFS-142: - Hm, I don't see really a difference. Both methods

[jira] [Commented] (VALIDATOR-342) URLValidator returns false for http://example.rocks

2014-11-17 Thread Sebb (JIRA)
[ https://issues.apache.org/jira/browse/VALIDATOR-342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14215256#comment-14215256 ] Sebb commented on VALIDATOR-342: The .rocks TLD is quite recent and is (I assume) not

[jira] [Commented] (VFS-142) Clear ThreadData after all streams are closed, fixes a memory leak

2014-11-17 Thread Bernd Eckenfels (JIRA)
[ https://issues.apache.org/jira/browse/VFS-142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14215263#comment-14215263 ] Bernd Eckenfels commented on VFS-142: - Ah stupid me... I reverse-read the patch. Yes

[jira] [Comment Edited] (VFS-142) Clear ThreadData after all streams are closed, fixes a memory leak

2014-11-17 Thread Bernd Eckenfels (JIRA)
[ https://issues.apache.org/jira/browse/VFS-142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14215263#comment-14215263 ] Bernd Eckenfels edited comment on VFS-142 at 11/17/14 10:09 PM:

[jira] [Commented] (VFS-142) Clear ThreadData after all streams are closed, fixes a memory leak

2014-11-17 Thread Bernd Eckenfels (JIRA)
[ https://issues.apache.org/jira/browse/VFS-142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14215295#comment-14215295 ] Bernd Eckenfels commented on VFS-142: - Commited (at least I tried to, it reported Rev

[jira] [Comment Edited] (VFS-142) Clear ThreadData after all streams are closed, fixes a memory leak

2014-11-17 Thread Bernd Eckenfels (JIRA)
[ https://issues.apache.org/jira/browse/VFS-142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14215295#comment-14215295 ] Bernd Eckenfels edited comment on VFS-142 at 11/17/14 10:35 PM:

[jira] [Commented] (VFS-309) ThreadLocal memory leak in DefaultFileContent

2014-11-17 Thread Bernd Eckenfels (JIRA)
[ https://issues.apache.org/jira/browse/VFS-309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14215696#comment-14215696 ] Bernd Eckenfels commented on VFS-309: - As commented in VFS-142 there are two problems.

[jira] [Resolved] (VFS-142) Clear ThreadData after all streams are closed, fixes a memory leak

2014-11-17 Thread Bernd Eckenfels (JIRA)
[ https://issues.apache.org/jira/browse/VFS-142?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bernd Eckenfels resolved VFS-142. - Resolution: Fixed Fix Version/s: 2.1 Ok tested it: with remove() there is a leak of

[jira] [Updated] (VFS-309) ThreadLocal memory leak in DefaultFileContent

2014-11-17 Thread Bernd Eckenfels (JIRA)
[ https://issues.apache.org/jira/browse/VFS-309?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bernd Eckenfels updated VFS-309: Priority: Blocker (was: Major) ThreadLocal memory leak in DefaultFileContent