[GitHub] commons-lang issue #141: Lang 1195: Enhance MethodUtils to allow invocation ...

2016-06-05 Thread Derek-Ashmore
Github user Derek-Ashmore commented on the issue: https://github.com/apache/commons-lang/pull/141 Thank you! Without your pull request suggestion and additional support, it never would have gone anywhere. Please let me know if I can ever return the favor. On Jun 5,

[GitHub] commons-lang issue #137: Adding to StringUtils truncate method and test case...

2016-06-05 Thread PascalSchumacher
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-lang/pull/137 Thanks! :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] commons-lang pull request #137: Adding to StringUtils truncate method and te...

2016-06-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/commons-lang/pull/137 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[jira] [Resolved] (LANG-1013) Adding to StringUtils truncate method and test cases

2016-06-05 Thread Pascal Schumacher (JIRA)
[ https://issues.apache.org/jira/browse/LANG-1013?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pascal Schumacher resolved LANG-1013. - Resolution: Fixed Assignee: Pascal Schumacher (was: Benedikt Ritter) Fix

[jira] [Resolved] (LANG-1195) Enhance MethodUtils to allow invocation of private methods

2016-06-05 Thread Pascal Schumacher (JIRA)
[ https://issues.apache.org/jira/browse/LANG-1195?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pascal Schumacher resolved LANG-1195. - Resolution: Fixed Assignee: Pascal Schumacher Pull request merged. Thanks! >

[GitHub] commons-lang issue #141: Lang 1195: Enhance MethodUtils to allow invocation ...

2016-06-05 Thread PascalSchumacher
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-lang/pull/141 Thanks! :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[jira] [Commented] (LANG-1195) Enhance MethodUtils to allow invocation of private methods

2016-06-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/LANG-1195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15315983#comment-15315983 ] ASF GitHub Bot commented on LANG-1195: -- Github user asfgit closed the pull request at:

[GitHub] commons-lang pull request #141: Lang 1195: Enhance MethodUtils to allow invo...

2016-06-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/commons-lang/pull/141 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] commons-lang issue #137: Adding to StringUtils truncate method and test case...

2016-06-05 Thread coveralls
Github user coveralls commented on the issue: https://github.com/apache/commons-lang/pull/137 [![Coverage Status](https://coveralls.io/builds/6469639/badge)](https://coveralls.io/builds/6469639) Coverage increased (+0.2%) to 93.448% when pulling

[GitHub] commons-lang issue #137: Adding to StringUtils truncate method and test case...

2016-06-05 Thread thiagoh
Github user thiagoh commented on the issue: https://github.com/apache/commons-lang/pull/137 @PascalSchumacher I think now thats. Could you confirm that? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[jira] [Commented] (FILEUPLOAD-274) File Upload fails to recognize RFC 5987-compliant filename

2016-06-05 Thread Jochen Wiedmann (JIRA)
[ https://issues.apache.org/jira/browse/FILEUPLOAD-274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15315980#comment-15315980 ] Jochen Wiedmann commented on FILEUPLOAD-274: Okay, in that case:Vsevolod, as you seem to

[jira] [Updated] (LANG-1195) Enhance MethodUtils to allow invocation of private methods

2016-06-05 Thread Pascal Schumacher (JIRA)
[ https://issues.apache.org/jira/browse/LANG-1195?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pascal Schumacher updated LANG-1195: Description: Currently, MethodUtils is restricted to finding and invoking accessible

[GitHub] commons-lang issue #163: LANG-1197: Prepare Java 9 detection (unfinished)

2016-06-05 Thread coveralls
Github user coveralls commented on the issue: https://github.com/apache/commons-lang/pull/163 [![Coverage Status](https://coveralls.io/builds/6469522/badge)](https://coveralls.io/builds/6469522) Coverage increased (+0.04%) to 93.45% when pulling

[jira] [Commented] (LANG-1197) Prepare Java 9 detection

2016-06-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/LANG-1197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15315975#comment-15315975 ] ASF GitHub Bot commented on LANG-1197: -- Github user coveralls commented on the issue:

[GitHub] commons-lang pull request #163: LANG-1197: Prepare Java 9 detection (unfinis...

2016-06-05 Thread PascalSchumacher
GitHub user PascalSchumacher opened a pull request: https://github.com/apache/commons-lang/pull/163 LANG-1197: Prepare Java 9 detection (unfinished) Not complete: `JavaVersion` expects the `java.version` system property to return `1.x` but for java 9 it will return `9*`. Not sure

[jira] [Commented] (LANG-1197) Prepare Java 9 detection

2016-06-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/LANG-1197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15315974#comment-15315974 ] ASF GitHub Bot commented on LANG-1197: -- GitHub user PascalSchumacher opened a pull request:

[jira] [Commented] (LANG-1199) Fix implementation of StringUtils.getJaroWinklerDistance()

2016-06-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/LANG-1199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15315930#comment-15315930 ] ASF GitHub Bot commented on LANG-1199: -- Github user PascalSchumacher closed the pull request at:

[jira] [Commented] (LANG-1199) Fix implementation of StringUtils.getJaroWinklerDistance()

2016-06-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/LANG-1199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15315929#comment-15315929 ] ASF GitHub Bot commented on LANG-1199: -- Github user PascalSchumacher commented on the issue:

[GitHub] commons-lang pull request #148: LANG-1199: Incorrect implementation of Strin...

2016-06-05 Thread PascalSchumacher
Github user PascalSchumacher closed the pull request at: https://github.com/apache/commons-lang/pull/148 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] commons-lang issue #148: LANG-1199: Incorrect implementation of StringUtils#...

2016-06-05 Thread PascalSchumacher
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-lang/pull/148 merged: https://github.com/apache/commons-lang/commit/c35a04102274b330aa833030c15f722b00062812 --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] commons-lang issue #141: Lang 1195: Enhance MethodUtils to allow invocation ...

2016-06-05 Thread PascalSchumacher
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-lang/pull/141 You are right. I missed that. It is impossible to use the parameter order I suggested, because it would clash with the existing `invokeMethod` signature. Sorry. --- If your project

[jira] [Resolved] (LANG-1199) Fix implementation of StringUtils.getJaroWinklerDistance()

2016-06-05 Thread Pascal Schumacher (JIRA)
[ https://issues.apache.org/jira/browse/LANG-1199?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pascal Schumacher resolved LANG-1199. - Resolution: Fixed Assignee: Pascal Schumacher Fix Version/s: 3.5 Fixed by

[jira] [Updated] (LANG-1199) Fix implementation of StringUtils.getJaroWinklerDistance()

2016-06-05 Thread Pascal Schumacher (JIRA)
[ https://issues.apache.org/jira/browse/LANG-1199?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pascal Schumacher updated LANG-1199: Summary: Fix implementation of StringUtils.getJaroWinklerDistance() (was: Incorrect

[GitHub] commons-lang issue #141: Lang 1195: Enhance MethodUtils to allow invocation ...

2016-06-05 Thread Derek-Ashmore
Github user Derek-Ashmore commented on the issue: https://github.com/apache/commons-lang/pull/141 I originally thought the same thing. The problems is the "Object... args" support. The fact that it's optional means that you can put an optional boolean at the end easily and tell the

[jira] [Commented] (LANG-1230) Remove unnecessary synchronization from registry lookup

2016-06-05 Thread Pascal Schumacher (JIRA)
[ https://issues.apache.org/jira/browse/LANG-1230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15315919#comment-15315919 ] Pascal Schumacher commented on LANG-1230: - [~garydgregory] It would be nice if you could take a

[jira] [Commented] (LANG-1229) Performance regression due to cyclic hashCode guard

2016-06-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/LANG-1229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15315913#comment-15315913 ] ASF GitHub Bot commented on LANG-1229: -- Github user PascalSchumacher commented on the issue:

[GitHub] commons-lang issue #142: LANG-1229 Performance regression in HashCodeBuilder

2016-06-05 Thread PascalSchumacher
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-lang/pull/142 To keep the code clean the pull request should also undo the other additions to `HashCodeBuilderTest` done with

[GitHub] commons-lang issue #141: Lang 1195: Enhance MethodUtils to allow invocation ...

2016-06-05 Thread PascalSchumacher
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-lang/pull/141 Hi Derek, sorry for the delay. I took another look at the code and compared it with `FieldUitls`. Maybe it is a good idea to change the method parameter order to

[jira] [Commented] (FILEUPLOAD-274) File Upload fails to recognize RFC 5987-compliant filename

2016-06-05 Thread Sebb (JIRA)
[ https://issues.apache.org/jira/browse/FILEUPLOAD-274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15315897#comment-15315897 ] Sebb commented on FILEUPLOAD-274: - AFAICT that's not quite it. The parameter name (i.e. 'filename' in

[jira] [Commented] (FILEUPLOAD-274) File Upload fails to recognize RFC 5987-compliant filename

2016-06-05 Thread Jochen Wiedmann (JIRA)
[ https://issues.apache.org/jira/browse/FILEUPLOAD-274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15315886#comment-15315886 ] Jochen Wiedmann commented on FILEUPLOAD-274: Let me summarize this in a few words: If the

[jira] [Updated] (BCEL-231) Remove deprecated methods and classes

2016-06-05 Thread Sebb (JIRA)
[ https://issues.apache.org/jira/browse/BCEL-231?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sebb updated BCEL-231: -- Fix Version/s: (was: 6.0) > Remove deprecated methods and classes > - > >

[jira] [Reopened] (BCEL-231) Remove deprecated methods and classes

2016-06-05 Thread Sebb (JIRA)
[ https://issues.apache.org/jira/browse/BCEL-231?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sebb reopened BCEL-231: --- Mostly reverted > Remove deprecated methods and classes > - > > Key:

[jira] [Created] (CSV-186) SIte archives archive links don't work

2016-06-05 Thread Sebb (JIRA)
Sebb created CSV-186: Summary: SIte archives archive links don't work Key: CSV-186 URL: https://issues.apache.org/jira/browse/CSV-186 Project: Commons CSV Issue Type: Bug Reporter: Sebb

[jira] [Created] (CSV-185) SIte archives download links don't work

2016-06-05 Thread Sebb (JIRA)
Sebb created CSV-185: Summary: SIte archives download links don't work Key: CSV-185 URL: https://issues.apache.org/jira/browse/CSV-185 Project: Commons CSV Issue Type: Bug Reporter: Sebb