[jira] [Commented] (RNG-37) Ziggurat algorithm

2017-10-09 Thread Bruno P. Kinoshita (JIRA)
[ https://issues.apache.org/jira/browse/RNG-37?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16198178#comment-16198178 ] Bruno P. Kinoshita commented on RNG-37: --- >I've checked, all samplers in >commons-rng-sa

[jira] [Commented] (LANG-1355) TimeZone.getTimeZone() in FastDateParser causes resource contention

2017-10-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/LANG-1355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16198117#comment-16198117 ] ASF GitHub Bot commented on LANG-1355: -- Github user coveralls commented on the issue:

[GitHub] commons-lang issue #296: LANG-1355: Add FastTimeZone to decrease TimeZone.ge...

2017-10-09 Thread coveralls
Github user coveralls commented on the issue: https://github.com/apache/commons-lang/pull/296 [![Coverage Status](https://coveralls.io/builds/13642621/badge)](https://coveralls.io/builds/13642621) Coverage decreased (-0.01%) to 95.192% when pulling **0476df2d4276da567e5f

[jira] [Updated] (LANG-1355) TimeZone.getTimeZone() in FastDateParser causes resource contention

2017-10-09 Thread Charles Honton (JIRA)
[ https://issues.apache.org/jira/browse/LANG-1355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Charles Honton updated LANG-1355: - Assignee: Charles Honton > TimeZone.getTimeZone() in FastDateParser causes resource contention > --

[jira] [Commented] (TEXT-74) StrSubstitutor: Ability to turn off substitution in values

2017-10-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TEXT-74?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16197859#comment-16197859 ] ASF GitHub Bot commented on TEXT-74: Github user coveralls commented on the issue: h

[jira] [Commented] (TEXT-74) StrSubstitutor: Ability to turn off substitution in values

2017-10-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TEXT-74?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16197858#comment-16197858 ] ASF GitHub Bot commented on TEXT-74: Github user coveralls commented on the issue: h

[GitHub] commons-lang pull request #:

2017-10-09 Thread garydgregory
Github user garydgregory commented on the pull request: https://github.com/apache/commons-lang/commit/d848328a7aa54f73117b8f13ce6e67049dc9502e#commitcomment-24866944 "3.6 already requires java 7." I think it is nice to state the plaform requirement for any component. Often time, one i

[GitHub] commons-lang pull request #:

2017-10-09 Thread PascalSchumacher
Github user PascalSchumacher commented on the pull request: https://github.com/apache/commons-lang/commit/d848328a7aa54f73117b8f13ce6e67049dc9502e#commitcomment-24866834 `3.6` already requires java 7. Also the builds on travis fail with: ```There are 8 errors reported

[GitHub] commons-lang issue #297: Add a rule of Locale.ENGLISH to String.toUpperCase(...

2017-10-09 Thread garydgregory
Github user garydgregory commented on the issue: https://github.com/apache/commons-lang/pull/297 I fixed some tests and code main code here and there and I think all the changes we need are in. If you feel otherwise, please update this PR based on git master. Thank you! ---

[jira] [Commented] (VFS-524) The uri include ipv6 address can't be parsed out correctly

2017-10-09 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/VFS-524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16197676#comment-16197676 ] Gary Gregory commented on VFS-524: -- I just need a fresh PR ;-) > The uri include ipv6 addre

[jira] [Closed] (CSV-217) Add autoFlush option for CSVPrinter

2017-10-09 Thread Korolyov Alexei (JIRA)
[ https://issues.apache.org/jira/browse/CSV-217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Korolyov Alexei closed CSV-217. --- Thank you! > Add autoFlush option for CSVPrinter > --- > > K

[jira] [Closed] (LANG-1357) org.apache.commons.lang3.time.FastDateParser should use toUpperCase(Locale)

2017-10-09 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/LANG-1357?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Gregory closed LANG-1357. -- Resolution: Fixed Fix Version/s: 3.7 Closing: In git master. > org.apache.commons.lang3.time.Fast

[jira] [Commented] (VFS-524) The uri include ipv6 address can't be parsed out correctly

2017-10-09 Thread David So (JIRA)
[ https://issues.apache.org/jira/browse/VFS-524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16197650#comment-16197650 ] David So commented on VFS-524: -- (y) That will be great. > The uri include ipv6 address can't be

[jira] [Updated] (LANG-1357) org.apache.commons.lang3.time.FastDateParser should use toUpperCase(Locale)

2017-10-09 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/LANG-1357?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Gregory updated LANG-1357: --- Description: The class org.apache.commons.lang3.time.FastDateParser should use {{toUpperCase(Locale)}}

[jira] [Commented] (LANG-1357) org.apache.commons.lang3.time.FastDateParser should use toUpperCase(Locale)

2017-10-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/LANG-1357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16197643#comment-16197643 ] ASF GitHub Bot commented on LANG-1357: -- Github user garydgregory commented on the issu

[GitHub] commons-lang issue #297: Add a rule of Locale.ENGLISH to String.toUpperCase(...

2017-10-09 Thread garydgregory
Github user garydgregory commented on the issue: https://github.com/apache/commons-lang/pull/297 I am splitting out the FastDateParser changes here: https://issues.apache.org/jira/browse/LANG-1357 ---

[jira] [Created] (LANG-1357) org.apache.commons.lang3.time.FastDateParser should use toUpperCase(Locale)

2017-10-09 Thread Gary Gregory (JIRA)
Gary Gregory created LANG-1357: -- Summary: org.apache.commons.lang3.time.FastDateParser should use toUpperCase(Locale) Key: LANG-1357 URL: https://issues.apache.org/jira/browse/LANG-1357 Project: Commons

[jira] [Resolved] (CSV-217) Add autoFlush option for CSVPrinter

2017-10-09 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/CSV-217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Gregory resolved CSV-217. -- Resolution: Fixed Fix Version/s: 1.6 In git master. Please verify and close. > Add autoFlush option

[GitHub] commons-lang issue #297: Add a rule of Locale.ENGLISH to String.toUpperCase(...

2017-10-09 Thread coveralls
Github user coveralls commented on the issue: https://github.com/apache/commons-lang/pull/297 [![Coverage Status](https://coveralls.io/builds/13637420/badge)](https://coveralls.io/builds/13637420) Coverage remained the same at 95.213% when pulling **989d02714efd99dad7638

[GitHub] commons-lang pull request #297: Add a rule of Locale.ENGLISH to String.toUpp...

2017-10-09 Thread PascalSchumacher
Github user PascalSchumacher commented on a diff in the pull request: https://github.com/apache/commons-lang/pull/297#discussion_r143555903 --- Diff: src/main/java/org/apache/commons/lang3/time/FormatCache.java --- @@ -240,7 +240,7 @@ public boolean equals(final Object obj) {

[jira] [Updated] (CSV-217) Add autoFlush option for CSVPrinter

2017-10-09 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/CSV-217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Gregory updated CSV-217: - Description: CsvPrinter doesn't flush data on close. Looks like a bug, for me. Updated: Add an option "autoF

[jira] [Updated] (CSV-217) Add autoFlush option for CSVPrinter

2017-10-09 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/CSV-217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Gregory updated CSV-217: - Summary: Add autoFlush option for CSVPrinter (was: Add autoFlush option for CsvPrinter) > Add autoFlush opt

[jira] [Updated] (CSV-217) Add autoFlush option for CsvPrinter

2017-10-09 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/CSV-217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Gregory updated CSV-217: - Summary: Add autoFlush option for CsvPrinter (was: Add autoFlush option to CsvPrinter) > Add autoFlush opti

[jira] [Updated] (CSV-217) Add autoFlush option to CsvPrinter

2017-10-09 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/CSV-217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Gregory updated CSV-217: - Summary: Add autoFlush option to CsvPrinter (was: CsvPrinter doesn't flush on close) > Add autoFlush option

[GitHub] commons-lang issue #298: Add an instanceof test in the implementation of equ...

2017-10-09 Thread BruceKuiLiu
Github user BruceKuiLiu commented on the issue: https://github.com/apache/commons-lang/pull/298 I am sorry, I cannot provide any test cases. We found it is a potential vulnerability. ---

[GitHub] commons-lang pull request #297: Add a rule of Locale.ENGLISH to String.toUpp...

2017-10-09 Thread BruceKuiLiu
GitHub user BruceKuiLiu reopened a pull request: https://github.com/apache/commons-lang/pull/297 Add a rule of Locale.ENGLISH to String.toUpperCase() method. A String is being converted to upper case, using the platform's default encoding. This may result in improper conversions

[jira] [Commented] (RNG-37) Ziggurat algorithm

2017-10-09 Thread OlgaK (JIRA)
[ https://issues.apache.org/jira/browse/RNG-37?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16197495#comment-16197495 ] OlgaK commented on RNG-37: -- thanks [~kinow] for your reply and comments. I've made a new [pull reque

[GitHub] commons-lang issue #298: Add an instanceof test in the implementation of equ...

2017-10-09 Thread PascalSchumacher
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-lang/pull/298 The comment above the statement explains why it is done this way. In case this is merged the comment should be removed. ---

[GitHub] commons-lang issue #298: Add an instanceof test in the implementation of equ...

2017-10-09 Thread kinow
Github user kinow commented on the issue: https://github.com/apache/commons-lang/pull/298 I think it makes sense. Any chance to include a unit test to protect against regressions in the future? Thanks ---

[GitHub] commons-lang issue #298: Add an instanceof test in the implementation of equ...

2017-10-09 Thread coveralls
Github user coveralls commented on the issue: https://github.com/apache/commons-lang/pull/298 [![Coverage Status](https://coveralls.io/builds/13636221/badge)](https://coveralls.io/builds/13636221) Coverage remained the same at 95.213% when pulling **0ee26c5f74558628740b8

[GitHub] commons-lang pull request #298: Add an instanceof test in the implementation...

2017-10-09 Thread BruceKuiLiu
GitHub user BruceKuiLiu opened a pull request: https://github.com/apache/commons-lang/pull/298 Add an instanceof test in the implementation of equals(Object obj). The equals(Object obj) method shouldn't make any assumptions about the type of obj. It should simply return false if obj

[GitHub] commons-lang pull request #297: Add a rule of Locale.ENGLISH to String.toUpp...

2017-10-09 Thread BruceKuiLiu
Github user BruceKuiLiu closed the pull request at: https://github.com/apache/commons-lang/pull/297 ---

[GitHub] commons-lang issue #297: Add a rule of Locale.ENGLISH to String.toUpperCase(...

2017-10-09 Thread BruceKuiLiu
Github user BruceKuiLiu commented on the issue: https://github.com/apache/commons-lang/pull/297 Right, Locale.ROOT should be the most appropriate. ---

[GitHub] commons-lang issue #297: Add a rule of Locale.ENGLISH to String.toUpperCase(...

2017-10-09 Thread garydgregory
Github user garydgregory commented on the issue: https://github.com/apache/commons-lang/pull/297 Shouldn't this be done with Locale.ROOT? ---

[jira] [Commented] (DAEMON-376) Update Daemon to also search registry for JRE with Java 9 JRE location

2017-10-09 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/DAEMON-376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16197250#comment-16197250 ] Gary Gregory commented on DAEMON-376: - Patches welcome! :-) > Update Daemon to also s

[GitHub] commons-lang issue #297: Add a rule of Locale.ENGLISH to String.toUpperCase(...

2017-10-09 Thread BruceKuiLiu
Github user BruceKuiLiu commented on the issue: https://github.com/apache/commons-lang/pull/297 Thanks. ---

[GitHub] commons-lang issue #297: Add a rule of Locale.ENGLISH to String.toUpperCase(...

2017-10-09 Thread coveralls
Github user coveralls commented on the issue: https://github.com/apache/commons-lang/pull/297 [![Coverage Status](https://coveralls.io/builds/13633085/badge)](https://coveralls.io/builds/13633085) Coverage remained the same at 95.213% when pulling **37223825a39a6cb57124d

[GitHub] commons-lang issue #297: Add a rule of Locale.ENGLISH to String.toUpperCase(...

2017-10-09 Thread coveralls
Github user coveralls commented on the issue: https://github.com/apache/commons-lang/pull/297 [![Coverage Status](https://coveralls.io/builds/13632762/badge)](https://coveralls.io/builds/13632762) Coverage increased (+0.02%) to 95.233% when pulling **989d02714efd99dad763

[GitHub] commons-lang issue #297: Add a rule of Locale.ENGLISH to String.toUpperCase(...

2017-10-09 Thread coveralls
Github user coveralls commented on the issue: https://github.com/apache/commons-lang/pull/297 [![Coverage Status](https://coveralls.io/builds/13632706/badge)](https://coveralls.io/builds/13632706) Coverage remained the same at 95.213% when pulling **989d02714efd99dad7638

[GitHub] commons-lang issue #297: Add a rule of Locale.ENGLISH to String.toUpperCase(...

2017-10-09 Thread coveralls
Github user coveralls commented on the issue: https://github.com/apache/commons-lang/pull/297 [![Coverage Status](https://coveralls.io/builds/13632652/badge)](https://coveralls.io/builds/13632652) Coverage remained the same at 95.213% when pulling **c3711c3d6d93fdc996bdd

[GitHub] commons-lang issue #297: Add a rule of Locale.ENGLISH to String.toUpperCase(...

2017-10-09 Thread coveralls
Github user coveralls commented on the issue: https://github.com/apache/commons-lang/pull/297 [![Coverage Status](https://coveralls.io/builds/13632390/badge)](https://coveralls.io/builds/13632390) Coverage remained the same at 95.213% when pulling **ac6ea81247282d7fd9291

[GitHub] commons-lang pull request #297: Add a rule of Locale.ENGLISH to String.toUpp...

2017-10-09 Thread BruceKuiLiu
GitHub user BruceKuiLiu opened a pull request: https://github.com/apache/commons-lang/pull/297 Add a rule of Locale.ENGLISH to String.toUpperCase() method. A String is being converted to upper case, using the platform's default encoding. This may result in improper conversions w

[jira] [Commented] (RNG-37) Ziggurat algorithm

2017-10-09 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/RNG-37?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16196960#comment-16196960 ] Gilles commented on RNG-37: --- Sorry for the delay. Bruno, thanks a lot for the review and advice. :)

[jira] [Created] (DAEMON-376) Update Daemon to also search registry for JRE with Java 9 JRE location

2017-10-09 Thread Mark Thomas (JIRA)
Mark Thomas created DAEMON-376: -- Summary: Update Daemon to also search registry for JRE with Java 9 JRE location Key: DAEMON-376 URL: https://issues.apache.org/jira/browse/DAEMON-376 Project: Commons Dae

[jira] [Commented] (RNG-37) Ziggurat algorithm

2017-10-09 Thread Bruno P. Kinoshita (JIRA)
[ https://issues.apache.org/jira/browse/RNG-37?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16196788#comment-16196788 ] Bruno P. Kinoshita commented on RNG-37: --- Submitted some comments to the pull request. Bu

[jira] [Commented] (LOGGING-165) Add Automatic-Module-Name Manifest Header for Java 9 compatibility

2017-10-09 Thread JIRA
[ https://issues.apache.org/jira/browse/LOGGING-165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16196601#comment-16196601 ] 陈宝仪 commented on LOGGING-165: - Hi I tested the jar build from trunk. This is works for me. I