[jira] [Closed] (DBCP-497) Deprecate use of PStmtKeyCPDS in favor of PStmtKey

2018-06-08 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/DBCP-497?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Gregory closed DBCP-497. - Resolution: Fixed In git master. > Deprecate use of PStmtKeyCPDS in favor of PStmtKey >

[jira] [Created] (DBCP-497) Deprecate use of PStmtKeyCPDS in favor of PStmtKey

2018-06-08 Thread Gary Gregory (JIRA)
Gary Gregory created DBCP-497: - Summary: Deprecate use of PStmtKeyCPDS in favor of PStmtKey Key: DBCP-497 URL: https://issues.apache.org/jira/browse/DBCP-497 Project: Commons DBCP Issue Type:

[jira] [Closed] (DBCP-496) Add support for pooling CallableStatements to the org.apache.commons.dbcp2.cpdsadapter package

2018-06-08 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/DBCP-496?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Gregory closed DBCP-496. - Resolution: Fixed Fix Version/s: 2.4.0 In git master. > Add support for pooling CallableStatements

[GitHub] commons-lang issue #327: (doc) Remove invalid example of `lastIndexOf` from ...

2018-06-08 Thread printfcoder
Github user printfcoder commented on the issue: https://github.com/apache/commons-lang/pull/327 @fedochet Oh ! base on your explaining, it is ok. But the param `startPos ` means `start`, I’m totally confused, I think it should be renamed as `endPos`, aHa ?. ---

[jira] [Created] (DBCP-496) Add support for pooling CallableStatements to the org.apache.commons.dbcp2.cpdsadapter package

2018-06-08 Thread Gary Gregory (JIRA)
Gary Gregory created DBCP-496: - Summary: Add support for pooling CallableStatements to the org.apache.commons.dbcp2.cpdsadapter package Key: DBCP-496 URL: https://issues.apache.org/jira/browse/DBCP-496

[jira] [Closed] (DBCP-495) Remove duplicate code in org.apache.commons.dbcp2.cpdsadapter.PStmtKeyCPDS

2018-06-08 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/DBCP-495?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Gregory closed DBCP-495. - Resolution: Fixed Fix Version/s: 2.3.1 In git master. > Remove duplicate code in

[jira] [Created] (DBCP-495) Remove duplicate code in org.apache.commons.dbcp2.cpdsadapter.PStmtKeyCPDS

2018-06-08 Thread Gary Gregory (JIRA)
Gary Gregory created DBCP-495: - Summary: Remove duplicate code in org.apache.commons.dbcp2.cpdsadapter.PStmtKeyCPDS Key: DBCP-495 URL: https://issues.apache.org/jira/browse/DBCP-495 Project: Commons DBCP

[jira] [Closed] (DBCP-494) org.apache.commons.dbcp2.PStmtKey should make copies of given arrays in constructors

2018-06-08 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/DBCP-494?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Gregory closed DBCP-494. - Resolution: Fixed Fix Version/s: 2.3.1 In git master. > org.apache.commons.dbcp2.PStmtKey should

[jira] [Updated] (DBCP-494) org.apache.commons.dbcp2.PStmtKey should make copies of given arrays in constructors

2018-06-08 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/DBCP-494?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Gregory updated DBCP-494: -- Description: The class {{org.apache.commons.dbcp2.PStmtKey}} should make copies of given arrays in

[jira] [Created] (DBCP-494) org.apache.commons.dbcp2.PStmtKey should make copies of given arrays in constructors

2018-06-08 Thread Gary Gregory (JIRA)
Gary Gregory created DBCP-494: - Summary: org.apache.commons.dbcp2.PStmtKey should make copies of given arrays in constructors Key: DBCP-494 URL: https://issues.apache.org/jira/browse/DBCP-494 Project:

[jira] [Commented] (IO-579) FilenameUtils.isExtension() is case-sensitive

2018-06-08 Thread Ohad R (JIRA)
[ https://issues.apache.org/jira/browse/IO-579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16506318#comment-16506318 ] Ohad R commented on IO-579: --- is it possible then to add another "isExtension" method, that get an extra-parameter,

[jira] [Closed] (IO-580) Update org.apache.commons.io.FilenameUtils.isExtension(String, String[]) to use var args.

2018-06-08 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/IO-580?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Gregory closed IO-580. --- Resolution: Fixed Fix Version/s: 2.7 In git master. > Update

[jira] [Created] (IO-580) Update org.apache.commons.io.FilenameUtils.isExtension(String, String[]) to use var args.

2018-06-08 Thread Gary Gregory (JIRA)
Gary Gregory created IO-580: --- Summary: Update org.apache.commons.io.FilenameUtils.isExtension(String, String[]) to use var args. Key: IO-580 URL: https://issues.apache.org/jira/browse/IO-580 Project:

[jira] [Comment Edited] (IO-579) FilenameUtils.isExtension() is case-sensitive

2018-06-08 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/IO-579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16506252#comment-16506252 ] Gary Gregory edited comment on IO-579 at 6/8/18 4:57 PM: - We are attempting top

[jira] [Comment Edited] (IO-579) FilenameUtils.isExtension() is case-sensitive

2018-06-08 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/IO-579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16506252#comment-16506252 ] Gary Gregory edited comment on IO-579 at 6/8/18 4:56 PM: - We are attempting top

[jira] [Commented] (IO-572) Refactor duplicate code in org.apache.commons.io.FileUtils

2018-06-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/IO-572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16506255#comment-16506255 ] ASF GitHub Bot commented on IO-572: --- Github user asfgit closed the pull request at:

[jira] [Commented] (IO-579) FilenameUtils.isExtension() is case-sensitive

2018-06-08 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/IO-579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16506252#comment-16506252 ] Gary Gregory commented on IO-579: - We are attempting top abstract things like case-sensitivity in a new enum

[jira] [Commented] (IO-579) FilenameUtils.isExtension() is case-sensitive

2018-06-08 Thread Ohad R (JIRA)
[ https://issues.apache.org/jira/browse/IO-579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16506242#comment-16506242 ] Ohad R commented on IO-579: --- thanks [~garydgregory] for your supoer-quick reply.   In my case, I have an

[jira] [Commented] (LANG-1392) StringUtils.firstNonBlank and firstNonEmpty

2018-06-08 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/LANG-1392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16506238#comment-16506238 ] Gary Gregory commented on LANG-1392: The Javadoc needs improvement: What is a "blank"? IMO, the text

[jira] [Comment Edited] (LANG-1392) StringUtils.firstNonBlank and firstNonEmpty

2018-06-08 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/LANG-1392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16506238#comment-16506238 ] Gary Gregory edited comment on LANG-1392 at 6/8/18 4:33 PM: The Javadoc needs

[jira] [Resolved] (LANG-1392) StringUtils.firstNonBlank and firstNonEmpty

2018-06-08 Thread Pascal Schumacher (JIRA)
[ https://issues.apache.org/jira/browse/LANG-1392?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pascal Schumacher resolved LANG-1392. - Resolution: Fixed Assignee: Pascal Schumacher Fix Version/s: 3.8 >

[jira] [Commented] (LANG-1392) StringUtils.firstNonBlank and firstNonEmpty

2018-06-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/LANG-1392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16506195#comment-16506195 ] ASF GitHub Bot commented on LANG-1392: -- Github user PascalSchumacher commented on the issue:

[jira] [Commented] (LANG-1392) StringUtils.firstNonBlank and firstNonEmpty

2018-06-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/LANG-1392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16506200#comment-16506200 ] ASF GitHub Bot commented on LANG-1392: -- Github user asfgit closed the pull request at:

[GitHub] commons-lang pull request #325: LANG-1392 methods for getting first non empt...

2018-06-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/commons-lang/pull/325 ---

[GitHub] commons-lang issue #325: LANG-1392 methods for getting first non empty or no...

2018-06-08 Thread PascalSchumacher
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-lang/pull/325 Thanks! 👍 ---

[GitHub] commons-lang issue #333: (doc) Fix typos in classes of tuple package

2018-06-08 Thread PascalSchumacher
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-lang/pull/333 Thanks! :+1: ---

[GitHub] commons-lang pull request #333: (doc) Fix typos in classes of tuple package

2018-06-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/commons-lang/pull/333 ---

[jira] [Commented] (IO-579) FilenameUtils.isExtension() is case-sensitive

2018-06-08 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/IO-579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16506120#comment-16506120 ] Gary Gregory commented on IO-579: - Hello [~ohadr], Case-sensitivity for file names depends on the file

[jira] [Comment Edited] (IO-554) FileUtils.copyToFile(InputStream source, File destination) closes input stream

2018-06-08 Thread Thomas Mortagne (JIRA)
[ https://issues.apache.org/jira/browse/IO-554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16505803#comment-16505803 ] Thomas Mortagne edited comment on IO-554 at 6/8/18 2:54 PM: It does not make any

[jira] [Updated] (IO-579) FilenameUtils.isExtension() is case-sensitive

2018-06-08 Thread Ohad R (JIRA)
[ https://issues.apache.org/jira/browse/IO-579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ohad R updated IO-579: -- Description: FilenameUtils.isExtension() is case-sensitive.  All 3 implementations of this method call String.equals()

[jira] [Commented] (IO-554) FileUtils.copyToFile(InputStream source, File destination) closes input stream

2018-06-08 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/IO-554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16506089#comment-16506089 ] Gary Gregory commented on IO-554: - We should pull this change in, this is just a plain old bug. >

[jira] [Created] (IO-579) FilenameUtils.isExtension() is case-sensitive

2018-06-08 Thread Ohad R (JIRA)
Ohad R created IO-579: - Summary: FilenameUtils.isExtension() is case-sensitive Key: IO-579 URL: https://issues.apache.org/jira/browse/IO-579 Project: Commons IO Issue Type: Bug Components:

[jira] [Commented] (IO-559) FilenameUtils.normalize should verify hostname syntax in UNC path

2018-06-08 Thread Maria Dima (JIRA)
[ https://issues.apache.org/jira/browse/IO-559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16506033#comment-16506033 ] Maria Dima commented on IO-559: --- Ok, thanks for the feedback! > FilenameUtils.normalize should verify hostname

[GitHub] commons-lang issue #327: (doc) Remove invalid example of `lastIndexOf` from ...

2018-06-08 Thread fedochet
Github user fedochet commented on the issue: https://github.com/apache/commons-lang/pull/327 @printfcoder according to [docs](https://commons.apache.org/proper/commons-lang/apidocs/org/apache/commons/lang3/StringUtils.html), ``` (lastIndexOf) Returns the index within seq of

[GitHub] commons-lang issue #327: (doc) Remove invalid example of `lastIndexOf` from ...

2018-06-08 Thread printfcoder
Github user printfcoder commented on the issue: https://github.com/apache/commons-lang/pull/327 `StringUtils.lastIndexOf("aabaabaa", "b", 1) = -1` Could you please explain why the result is `1`,please? I see it shoud be 2, because that `to search starts at 1 position and b

[GitHub] commons-lang pull request #333: (doc) Fix typos in classes of tuple package

2018-06-08 Thread amseager
GitHub user amseager opened a pull request: https://github.com/apache/commons-lang/pull/333 (doc) Fix typos in classes of tuple package You can merge this pull request into a Git repository by running: $ git pull https://github.com/amseager/commons-lang master Alternatively