[jira] [Commented] (BEANUTILS-500) Upgrade from Apache Commons Collections 3 to 4

2018-06-20 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/BEANUTILS-500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16518693#comment-16518693 ] Gary Gregory commented on BEANUTILS-500: Soon-ish. I'd like to push out Commons Pool and

[GitHub] commons-lang issue #334: Code refactoring and cleaning

2018-06-20 Thread PascalSchumacher
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-lang/pull/334 @kinow Changes to throws declaration are binary compatible (see: https://docs.oracle.com/javase/specs/jls/se7/html/jls-13.html#jls-13.4.21). Removing checked exceptions from a throws

[jira] [Commented] (COLLECTIONS-687) Moved tests from JUnit 3 to JUnit 4 nomenclature

2018-06-20 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/COLLECTIONS-687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16518586#comment-16518586 ] Gary Gregory commented on COLLECTIONS-687: -- Patch applied, thank you. I am leaving this

[jira] [Commented] (COLLECTIONS-687) Moved tests from JUnit 3 to JUnit 4 nomenclature

2018-06-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/COLLECTIONS-687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16518585#comment-16518585 ] ASF GitHub Bot commented on COLLECTIONS-687: Github user asfgit closed the pull request

[jira] [Commented] (COLLECTIONS-687) Moved tests from JUnit 3 to JUnit 4 nomenclature

2018-06-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/COLLECTIONS-687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16518584#comment-16518584 ] ASF GitHub Bot commented on COLLECTIONS-687: Github user asfgit closed the pull request

[jira] [Commented] (COLLECTIONS-687) Moved tests from JUnit 3 to JUnit 4 nomenclature

2018-06-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/COLLECTIONS-687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16518502#comment-16518502 ] ASF GitHub Bot commented on COLLECTIONS-687: Github user coveralls commented on the

[jira] [Created] (COLLECTIONS-687) Moved tests from JUnit 3 to JUnit 4 nomenclature

2018-06-20 Thread Stephan Fuhrmann (JIRA)
Stephan Fuhrmann created COLLECTIONS-687: Summary: Moved tests from JUnit 3 to JUnit 4 nomenclature Key: COLLECTIONS-687 URL: https://issues.apache.org/jira/browse/COLLECTIONS-687 Project:

[jira] [Closed] (DBCP-508) Prepared statement keys should take a Connection's schema into account

2018-06-20 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/DBCP-508?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Gregory closed DBCP-508. - Resolution: Fixed Fix Version/s: 2.5.0 In git master. > Prepared statement keys should take a

[jira] [Updated] (DBCP-508) Prepared statement keys should take a Connection's schema into account

2018-06-20 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/DBCP-508?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Gregory updated DBCP-508: -- Assignee: Gary Gregory > Prepared statement keys should take a Connection's schema into account >

[jira] [Created] (DBCP-508) Prepared statement keys should take a Connection's schema into account

2018-06-20 Thread Gary Gregory (JIRA)
Gary Gregory created DBCP-508: - Summary: Prepared statement keys should take a Connection's schema into account Key: DBCP-508 URL: https://issues.apache.org/jira/browse/DBCP-508 Project: Commons DBCP

[GitHub] commons-lang issue #334: Code refactoring and cleaning

2018-06-20 Thread ingvarc
Github user ingvarc commented on the issue: https://github.com/apache/commons-lang/pull/334 @kinow Since the pull request aims to refactor and to clean the code I think it makes sense. Speaking of unchecked exceptions in 'throws' clause they are backward compatible since the

[GitHub] commons-lang issue #334: Code refactoring and cleaning

2018-06-20 Thread kinow
Github user kinow commented on the issue: https://github.com/apache/commons-lang/pull/334 I'm fine either way (I believe even some classes in the JDK have some [unchecked

[GitHub] commons-lang issue #334: Code refactoring and cleaning

2018-06-20 Thread coveralls
Github user coveralls commented on the issue: https://github.com/apache/commons-lang/pull/334 [![Coverage Status](https://coveralls.io/builds/17585970/badge)](https://coveralls.io/builds/17585970) Coverage increased (+0.01%) to 95.241% when pulling

[GitHub] commons-lang pull request #334: Code refactoring and cleaning

2018-06-20 Thread ingvarc
GitHub user ingvarc opened a pull request: https://github.com/apache/commons-lang/pull/334 Code refactoring and cleaning - **removes unchecked exceptions declared in 'throws' clause**; Effective Java: "Use the Javadoc @throws tag to document each exception that a method can

[jira] [Commented] (BEANUTILS-500) Upgrade from Apache Commons Collections 3 to 4

2018-06-20 Thread Petar Tahchiev (JIRA)
[ https://issues.apache.org/jira/browse/BEANUTILS-500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16517833#comment-16517833 ] Petar Tahchiev commented on BEANUTILS-500: -- Hey guys, any plans to have 2.0 release soon? >