[
https://issues.apache.org/jira/browse/GEOMETRY-9?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16605168#comment-16605168
]
Matt Juntunen commented on GEOMETRY-9:
--
# This is something I've been going back and forth on. We
[
https://issues.apache.org/jira/browse/DBCP-520?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gary Gregory resolved DBCP-520.
---
Resolution: Fixed
Fix Version/s: 2.6.0
[~zhfeng],
Thank you for your patch. This is in git
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/354
+1
---
Github user kinow commented on the issue:
https://github.com/apache/commons-lang/pull/340
Good progress so far @HiuKwok . Understanding the problem well is a good
first step to solve it ð my next development cycle for Apache will probably
be for a release for Apache Commons
[
https://issues.apache.org/jira/browse/LANG-1406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16604916#comment-16604916
]
ASF GitHub Bot commented on LANG-1406:
--
Github user kinow commented on the issue:
[
https://issues.apache.org/jira/browse/LANG-1406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16604694#comment-16604694
]
Michael Ryan edited comment on LANG-1406 at 9/5/18 5:30 PM:
I've been thinking
[
https://issues.apache.org/jira/browse/LANG-1406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16604694#comment-16604694
]
Michael Ryan commented on LANG-1406:
I've been thinking - how do case-insensitive regular expressions
[
https://issues.apache.org/jira/browse/GEOMETRY-9?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16604607#comment-16604607
]
Gilles commented on GEOMETRY-9:
---
Sorry I missed that a PR was available...
There are some design issues:
#
[
https://issues.apache.org/jira/browse/LANG-1406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16604572#comment-16604572
]
ASF GitHub Bot commented on LANG-1406:
--
Github user HiuKwok commented on the issue:
Github user HiuKwok commented on the issue:
https://github.com/apache/commons-lang/pull/340
To whom who interested in this issue, here is some founding that I
discovered throughout this month of issue solving.
Problem:
- The exception would happened when any String
[
https://issues.apache.org/jira/browse/CONFIGURATION-713?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Oliver Heger resolved CONFIGURATION-713.
Resolution: Fixed
Fix Version/s: 2.4
Patch applied in SVN revision
Github user coveralls commented on the issue:
https://github.com/apache/commons-lang/pull/355
[](https://coveralls.io/builds/18840189)
Coverage remained the same at 95.253% when pulling
GitHub user britter opened a pull request:
https://github.com/apache/commons-lang/pull/355
Use @ParameterizedTest to iterate over available locales
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/britter/commons-lang
Github user coveralls commented on the issue:
https://github.com/apache/commons-lang/pull/354
[](https://coveralls.io/builds/18838060)
Coverage remained the same at 95.253% when pulling
Github user britter commented on the issue:
https://github.com/apache/commons-lang/pull/354
@kinow @PascalSchumacher @chtompki WDYT?
---
GitHub user britter opened a pull request:
https://github.com/apache/commons-lang/pull/354
Convert tests for Validate.isTrue overloads to @Nested test
Proposal for a better structure of tests using `@Nested`. Each method
should have it's own `@Nested` container which is called like
[
https://issues.apache.org/jira/browse/LANG-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16604269#comment-16604269
]
ASF GitHub Bot commented on LANG-1416:
--
Github user smoyer64 commented on the issue:
[
https://issues.apache.org/jira/browse/LANG-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16604270#comment-16604270
]
ASF GitHub Bot commented on LANG-1416:
--
Github user smoyer64 closed the pull request at:
Github user smoyer64 commented on the issue:
https://github.com/apache/commons-lang/pull/353
@kinow
> Alternatively, you can update the PR with some base work that you think
might be useful for the next iterations. Up to you
If the intention is to use the conversion
Github user smoyer64 closed the pull request at:
https://github.com/apache/commons-lang/pull/353
---
[
https://issues.apache.org/jira/browse/LANG-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16604235#comment-16604235
]
ASF GitHub Bot commented on LANG-1416:
--
Github user kinow commented on the issue:
Github user kinow commented on the issue:
https://github.com/apache/commons-lang/pull/353
I think so @smoyer64 , but not meaning giving up on the task, just split it
into smaller changes, or a complete change but with less distractions from the
main work. Alternatively, you can
[
https://issues.apache.org/jira/browse/LANG-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16604223#comment-16604223
]
ASF GitHub Bot commented on LANG-1416:
--
Github user smoyer64 commented on the issue:
Github user smoyer64 commented on the issue:
https://github.com/apache/commons-lang/pull/353
Sounds like the vote is to close this PR then? I certainly don''t disagree
that it's hard (impossible?) to review the conversion of the entire test "set".
---
[
https://issues.apache.org/jira/browse/LANG-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16604052#comment-16604052
]
ASF GitHub Bot commented on LANG-1416:
--
Github user kinow commented on the issue:
Github user kinow commented on the issue:
https://github.com/apache/commons-lang/pull/353
>In general it's hard to review gigantic change sets which have been
created automatically, so I'd welcome an approach where we migrate one test
case after another.
+1, and bonus points
[
https://issues.apache.org/jira/browse/LANG-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16604006#comment-16604006
]
ASF GitHub Bot commented on LANG-1416:
--
Github user britter commented on the issue:
Github user britter commented on the issue:
https://github.com/apache/commons-lang/pull/353
In general it's hard to review gigantic change sets which have been created
automatically, so I'd welcome an approach where we migrate one test case after
another.
---
[
https://issues.apache.org/jira/browse/LANG-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16603967#comment-16603967
]
ASF GitHub Bot commented on LANG-1416:
--
Github user britter commented on the issue:
Github user britter commented on the issue:
https://github.com/apache/commons-lang/pull/353
It looks like an approach that can potentially some some work. I personally
would do it by hand. There is a lot of stuff that can't be detected
automatically. For example we have some tests
30 matches
Mail list logo
