[jira] [Work logged] (MATH-1651) junit flaky tests in commons-math-neuralnet

2022-11-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MATH-1651?focusedWorklogId=822938=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-822938 ] ASF GitHub Bot logged work on MATH-1651: Author: ASF GitHub Bot

[GitHub] [commons-math] anantdahiya8 commented on pull request #213: [MATH-1651] fix flaky test in commons-math-neuralnet

2022-11-02 Thread GitBox
anantdahiya8 commented on PR #213: URL: https://github.com/apache/commons-math/pull/213#issuecomment-1301671318 @aherbert I have updated the code and sent a mail for removing this flaky test. -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [commons-bcel] garydgregory commented on a diff in pull request #162: improve test coverage to bcel/generic and UtilityTest

2022-11-02 Thread GitBox
garydgregory commented on code in PR #162: URL: https://github.com/apache/commons-bcel/pull/162#discussion_r1012389784 ## src/test/java/org/apache/bcel/classfile/UtilityTestCase.java: ## @@ -59,4 +63,70 @@ public void testSignatureToStringWithGenerics() throws Exception {

[GitHub] [commons-bcel] garydgregory merged pull request #161: Typo in error message

2022-11-02 Thread GitBox
garydgregory merged PR #161: URL: https://github.com/apache/commons-bcel/pull/161 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [commons-collections] Claudenw commented on pull request #335: [Collections-834][bloom filters] bit count producer operation is not clearly defined

2022-11-02 Thread GitBox
Claudenw commented on PR #335: URL: https://github.com/apache/commons-collections/pull/335#issuecomment-1301446517 @aherbert The changes are in. Have a look please -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [commons-bcel] nbauma109 opened a new pull request, #163: added accessors to model and unit tests, javadoc comments

2022-11-02 Thread GitBox
nbauma109 opened a new pull request, #163: URL: https://github.com/apache/commons-bcel/pull/163 - Added getters to module classes which had no accessors for their private fields (removed TODO comments) - compactClassName only seemed to make sense for uses/provides,

[jira] [Commented] (JEXL-381) Change default JEXL configuration to a more security-friendly behaviour

2022-11-02 Thread Dmitri Blinov (Jira)
[ https://issues.apache.org/jira/browse/JEXL-381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17627881#comment-17627881 ] Dmitri Blinov commented on JEXL-381: [~henrib] The sandbox is not part of Jexl, rather part of some

[jira] [Work logged] (NUMBERS-29) Move combinatorics utilities from "Commons Math"

2022-11-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/NUMBERS-29?focusedWorklogId=822791=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-822791 ] ASF GitHub Bot logged work on NUMBERS-29: - Author: ASF GitHub Bot

[jira] [Resolved] (NUMBERS-29) Move combinatorics utilities from "Commons Math"

2022-11-02 Thread Alex Herbert (Jira)
[ https://issues.apache.org/jira/browse/NUMBERS-29?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Herbert resolved NUMBERS-29. - Resolution: Implemented Added in commit 916d8ad09f1c9da2cbe00798281c0d179f33f8e9 > Move

[jira] [Work logged] (NUMBERS-29) Move combinatorics utilities from "Commons Math"

2022-11-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/NUMBERS-29?focusedWorklogId=822792=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-822792 ] ASF GitHub Bot logged work on NUMBERS-29: - Author: ASF GitHub Bot

[GitHub] [commons-numbers] aherbert commented on pull request #126: NUMBERS-29: Add computation of Stirling number of the second kind

2022-11-02 Thread GitBox
aherbert commented on PR #126: URL: https://github.com/apache/commons-numbers/pull/126#issuecomment-1300896738 Closed by 916d8ad09f1c9da2cbe00798281c0d179f33f8e9 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [commons-numbers] aherbert closed pull request #126: NUMBERS-29: Add computation of Stirling number of the second kind

2022-11-02 Thread GitBox
aherbert closed pull request #126: NUMBERS-29: Add computation of Stirling number of the second kind URL: https://github.com/apache/commons-numbers/pull/126 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [commons-bcel] samabcde commented on a diff in pull request #162: improve test coverage to bcel/generic and UtilityTest

2022-11-02 Thread GitBox
samabcde commented on code in PR #162: URL: https://github.com/apache/commons-bcel/pull/162#discussion_r1011965812 ## src/test/java/org/apache/bcel/generic/IREMTestCase.java: ## @@ -0,0 +1,37 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[GitHub] [commons-bcel] samabcde commented on a diff in pull request #162: improve test coverage to bcel/generic and UtilityTest

2022-11-02 Thread GitBox
samabcde commented on code in PR #162: URL: https://github.com/apache/commons-bcel/pull/162#discussion_r1011963343 ## src/test/java/org/apache/bcel/generic/DMULTestCase.java: ## @@ -0,0 +1,35 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[GitHub] [commons-bcel] samabcde commented on a diff in pull request #162: improve test coverage to bcel/generic and UtilityTest

2022-11-02 Thread GitBox
samabcde commented on code in PR #162: URL: https://github.com/apache/commons-bcel/pull/162#discussion_r1011962014 ## src/test/java/org/apache/bcel/generic/BREAKPOINTTestCase.java: ## @@ -0,0 +1,31 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more +

[GitHub] [commons-bcel] samabcde commented on a diff in pull request #162: improve test coverage to bcel/generic and UtilityTest

2022-11-02 Thread GitBox
samabcde commented on code in PR #162: URL: https://github.com/apache/commons-bcel/pull/162#discussion_r1011962395 ## src/test/java/org/apache/bcel/generic/CountVisitor.java: ## @@ -0,0 +1,2012 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[GitHub] [commons-bcel] samabcde commented on a diff in pull request #162: improve test coverage to bcel/generic and UtilityTest

2022-11-02 Thread GitBox
samabcde commented on code in PR #162: URL: https://github.com/apache/commons-bcel/pull/162#discussion_r1011818719 ## src/test/java/org/apache/bcel/generic/CountVisitor.java: ## @@ -0,0 +1,2012 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[GitHub] [commons-bcel] garydgregory commented on a diff in pull request #162: improve test coverage to bcel/generic and UtilityTest

2022-11-02 Thread GitBox
garydgregory commented on code in PR #162: URL: https://github.com/apache/commons-bcel/pull/162#discussion_r1011812884 ## src/test/java/org/apache/bcel/generic/IREMTestCase.java: ## @@ -0,0 +1,37 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[GitHub] [commons-bcel] garydgregory commented on a diff in pull request #162: improve test coverage to bcel/generic and UtilityTest

2022-11-02 Thread GitBox
garydgregory commented on code in PR #162: URL: https://github.com/apache/commons-bcel/pull/162#discussion_r1011812884 ## src/test/java/org/apache/bcel/generic/IREMTestCase.java: ## @@ -0,0 +1,37 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[GitHub] [commons-bcel] garydgregory commented on a diff in pull request #162: improve test coverage to bcel/generic and UtilityTest

2022-11-02 Thread GitBox
garydgregory commented on code in PR #162: URL: https://github.com/apache/commons-bcel/pull/162#discussion_r1011811645 ## src/test/java/org/apache/bcel/generic/DMULTestCase.java: ## @@ -0,0 +1,35 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[GitHub] [commons-jcs] tvand merged pull request #118: Bump actions/upload-artifact from 3.1.0 to 3.1.1

2022-11-02 Thread GitBox
tvand merged PR #118: URL: https://github.com/apache/commons-jcs/pull/118 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [commons-bcel] garydgregory commented on a diff in pull request #162: improve test coverage to bcel/generic and UtilityTest

2022-11-02 Thread GitBox
garydgregory commented on code in PR #162: URL: https://github.com/apache/commons-bcel/pull/162#discussion_r1011810774 ## src/test/java/org/apache/bcel/generic/CountVisitor.java: ## @@ -0,0 +1,2012 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more +

[GitHub] [commons-bcel] garydgregory commented on a diff in pull request #162: improve test coverage to bcel/generic and UtilityTest

2022-11-02 Thread GitBox
garydgregory commented on code in PR #162: URL: https://github.com/apache/commons-bcel/pull/162#discussion_r1011810182 ## src/test/java/org/apache/bcel/generic/CountVisitor.java: ## @@ -0,0 +1,2012 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more +

[GitHub] [commons-bcel] garydgregory commented on a diff in pull request #162: improve test coverage to bcel/generic and UtilityTest

2022-11-02 Thread GitBox
garydgregory commented on code in PR #162: URL: https://github.com/apache/commons-bcel/pull/162#discussion_r1011806687 ## src/test/java/org/apache/bcel/generic/BREAKPOINTTestCase.java: ## @@ -0,0 +1,31 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [commons-bcel] garydgregory commented on a diff in pull request #162: improve test coverage to bcel/generic and UtilityTest

2022-11-02 Thread GitBox
garydgregory commented on code in PR #162: URL: https://github.com/apache/commons-bcel/pull/162#discussion_r1011800810 ## src/test/java/org/apache/bcel/generic/BREAKPOINTTestCase.java: ## @@ -0,0 +1,31 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [commons-bcel] samabcde commented on a diff in pull request #162: improve test coverage to bcel/generic and UtilityTest

2022-11-02 Thread GitBox
samabcde commented on code in PR #162: URL: https://github.com/apache/commons-bcel/pull/162#discussion_r1011775699 ## src/test/java/org/apache/bcel/generic/BREAKPOINTTest.java: ## @@ -0,0 +1,31 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[jira] [Comment Edited] (MATH-1652) comments about the formula of binomialCoefficient wrong

2022-11-02 Thread Alex Herbert (Jira)
[ https://issues.apache.org/jira/browse/MATH-1652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17627648#comment-17627648 ] Alex Herbert edited comment on MATH-1652 at 11/2/22 11:40 AM: -- This is now in

[jira] [Commented] (MATH-1652) comments about the formula of binomialCoefficient wrong

2022-11-02 Thread Alex Herbert (Jira)
[ https://issues.apache.org/jira/browse/MATH-1652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17627648#comment-17627648 ] Alex Herbert commented on MATH-1652: This is now in the combinatorics package of Commons Numbers:

[jira] [Comment Edited] (MATH-1652) comments about the formula of binomialCoefficient wrong

2022-11-02 Thread Alex Herbert (Jira)
[ https://issues.apache.org/jira/browse/MATH-1652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17627648#comment-17627648 ] Alex Herbert edited comment on MATH-1652 at 11/2/22 11:39 AM: -- This is now in

[jira] [Comment Edited] (MATH-1652) comments about the formula of binomialCoefficient wrong

2022-11-02 Thread Alex Herbert (Jira)
[ https://issues.apache.org/jira/browse/MATH-1652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17627648#comment-17627648 ] Alex Herbert edited comment on MATH-1652 at 11/2/22 11:39 AM: -- This is now in

[jira] [Commented] (MATH-1652) comments about the formula of binomialCoefficient wrong

2022-11-02 Thread Gilles Sadowski (Jira)
[ https://issues.apache.org/jira/browse/MATH-1652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17627622#comment-17627622 ] Gilles Sadowski commented on MATH-1652: --- See second formula

[jira] [Updated] (MATH-1652) comments about the formula of binomialCoefficient wrong

2022-11-02 Thread nimo mayr (Jira)
[ https://issues.apache.org/jira/browse/MATH-1652?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] nimo mayr updated MATH-1652: Description: The class {code:java} org.apache.commons.math3.util.CombinatoricsUtils{code} within the method 

[jira] [Updated] (MATH-1652) comments about the formula of binomialCoefficient wrong

2022-11-02 Thread nimo mayr (Jira)
[ https://issues.apache.org/jira/browse/MATH-1652?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] nimo mayr updated MATH-1652: Description: The class {color:#d8d8d8} {color} {code:java}

[jira] [Updated] (MATH-1652) comments about the formula of binomialCoefficient wrong

2022-11-02 Thread nimo mayr (Jira)
[ https://issues.apache.org/jira/browse/MATH-1652?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] nimo mayr updated MATH-1652: Description: The class  {color:#d8d8d8} org.apache.commons.math3.util.CombinatoricsUtils{color} within the

[jira] [Updated] (MATH-1652) comments about the formula of binomialCoefficient wrong

2022-11-02 Thread nimo mayr (Jira)
[ https://issues.apache.org/jira/browse/MATH-1652?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] nimo mayr updated MATH-1652: Description: The class  {color:#d8d8d8} org.apache.commons.math3.util.CombinatoricsUtils{color} within the

[jira] [Updated] (MATH-1652) comments about the formula of binomialCoefficient wrong

2022-11-02 Thread nimo mayr (Jira)
[ https://issues.apache.org/jira/browse/MATH-1652?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] nimo mayr updated MATH-1652: Description: The class  {color:#d8d8d8} org.apache.commons.math3.util.CombinatoricsUtils{color} within the

[jira] [Updated] (MATH-1652) comments about the formula of binomialCoefficient wrong

2022-11-02 Thread nimo mayr (Jira)
[ https://issues.apache.org/jira/browse/MATH-1652?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] nimo mayr updated MATH-1652: Description: The class  {color:#d8d8d8} org.apache.commons.math3.util.CombinatoricsUtils{color} within the

[jira] [Created] (MATH-1652) comments about the formula of binomialCoefficient wrong

2022-11-02 Thread nimo mayr (Jira)
nimo mayr created MATH-1652: --- Summary: comments about the formula of binomialCoefficient wrong Key: MATH-1652 URL: https://issues.apache.org/jira/browse/MATH-1652 Project: Commons Math Issue Type:

[jira] [Updated] (JEXL-383) Inconsistent behavior after overriding toBoolean method in JexlArithmetic

2022-11-02 Thread Xu Pengcheng (Jira)
[ https://issues.apache.org/jira/browse/JEXL-383?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xu Pengcheng updated JEXL-383: -- Description: I tried to overriding "toBoolean" method of JexlArithmetic for 'strict' mode. {code:java}

[jira] [Created] (JEXL-383) Inconsistent behavior after overriding toBoolean method in JexlArithmetic

2022-11-02 Thread Xu Pengcheng (Jira)
Xu Pengcheng created JEXL-383: - Summary: Inconsistent behavior after overriding toBoolean method in JexlArithmetic Key: JEXL-383 URL: https://issues.apache.org/jira/browse/JEXL-383 Project: Commons JEXL

[GitHub] [commons-jxpath] kyakdan commented on pull request #26: Fix CVE-2022-41852

2022-11-02 Thread GitBox
kyakdan commented on PR #26: URL: https://github.com/apache/commons-jxpath/pull/26#issuecomment-1299950916 @garydgregory Thanks in advance for the feedback. Any estimation of when you would be able to have a look? -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [commons-cli] chingjustwe opened a new pull request, #143: Change method visibility

2022-11-02 Thread GitBox
chingjustwe opened a new pull request, #143: URL: https://github.com/apache/commons-cli/pull/143 Change the visibility of method `handleUnknownToken()` to `protected`, give end engineer a change to handle such case themselves (I just need to ignore the exception `ParseException` here ).