[GitHub] [commons-collections] aherbert commented on a diff in pull request #360: Fix flaky test in CollectionUtilsTest.Java

2022-11-07 Thread GitBox
aherbert commented on code in PR #360: URL: https://github.com/apache/commons-collections/pull/360#discussion_r1016232266 ## src/test/java/org/apache/commons/collections4/CollectionUtilsTest.java: ## @@ -687,7 +687,9 @@ public void get() { assertEquals(2,

[GitHub] [commons-collections] aherbert commented on pull request #360: Fix flaky test in CollectionUtilsTest.Java

2022-11-07 Thread GitBox
aherbert commented on PR #360: URL: https://github.com/apache/commons-collections/pull/360#issuecomment-1306755028 I believe this is fixing a non-issue artificially introduced by the `nondex` plugin. The HashMap has an unspecified iteration order, but it is a deterministic data structure.

[GitHub] [commons-collections] codecov-commenter commented on pull request #360: Fix flaky test in CollectionUtilsTest.Java

2022-11-07 Thread GitBox
codecov-commenter commented on PR #360: URL: https://github.com/apache/commons-collections/pull/360#issuecomment-1306733536 #

[GitHub] [commons-collections] yannizhou05 opened a new pull request, #360: Fix flaky test in CollectionUtilsTest.Java

2022-11-07 Thread GitBox
yannizhou05 opened a new pull request, #360: URL: https://github.com/apache/commons-collections/pull/360 The test below in `CollectionUtilsTest.java` was found flaky because of the ordering of result HashMap. The orders of elements in the HashMap are not the same as every time the test

[jira] [Comment Edited] (JEXL-384) Improve control over JexlArithmetic null argument handling

2022-11-07 Thread Hussachai Puripunpinyo (Jira)
[ https://issues.apache.org/jira/browse/JEXL-384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17630185#comment-17630185 ] Hussachai Puripunpinyo edited comment on JEXL-384 at 11/8/22 5:31 AM: --

[jira] [Commented] (JEXL-384) Improve control over JexlArithmetic null argument handling

2022-11-07 Thread Hussachai Puripunpinyo (Jira)
[ https://issues.apache.org/jira/browse/JEXL-384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17630185#comment-17630185 ] Hussachai Puripunpinyo commented on JEXL-384: - I think what I mentioned, you already addressed

[GitHub] [commons-collections] XenoAmess opened a new pull request, #359: add function CollectionUtils.sizeIsNotEmpty

2022-11-07 Thread GitBox
XenoAmess opened a new pull request, #359: URL: https://github.com/apache/commons-collections/pull/359 as it is really useful sometimes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [commons-imaging] kinow merged pull request #247: Bump spotbugs-maven-plugin from 4.7.2.1 to 4.7.2.2

2022-11-07 Thread GitBox
kinow merged PR #247: URL: https://github.com/apache/commons-imaging/pull/247 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [commons-collections] aherbert commented on a diff in pull request #357: Added Hasher.isEmpty() and appropriate tests

2022-11-07 Thread GitBox
aherbert commented on code in PR #357: URL: https://github.com/apache/commons-collections/pull/357#discussion_r1015814250 ## src/main/java/org/apache/commons/collections4/bloomfilter/Hasher.java: ## @@ -61,4 +61,15 @@ default IndexProducer uniqueIndices(Shape shape) {

[GitHub] [commons-collections] aherbert commented on a diff in pull request #358: Collections-817: Reworked calculations and updated javadoc for estimateN(), estimateIntersection() and estimateUnion()

2022-11-07 Thread GitBox
aherbert commented on code in PR #358: URL: https://github.com/apache/commons-collections/pull/358#discussion_r1015794910 ## src/main/java/org/apache/commons/collections4/bloomfilter/BloomFilter.java: ## @@ -245,16 +268,43 @@ default int estimateUnion(final BloomFilter other)

[GitHub] [commons-collections] aherbert commented on a diff in pull request #358: Collections-817: Reworked calculations and updated javadoc for estimateN(), estimateIntersection() and estimateUnion()

2022-11-07 Thread GitBox
aherbert commented on code in PR #358: URL: https://github.com/apache/commons-collections/pull/358#discussion_r1015789750 ## src/main/java/org/apache/commons/collections4/bloomfilter/BloomFilter.java: ## @@ -214,26 +215,48 @@ default boolean isFull() { * By default this

[jira] [Created] (JEXL-385) Support disabling fortran-style relational operators syntax

2022-11-07 Thread Dmitri Blinov (Jira)
Dmitri Blinov created JEXL-385: -- Summary: Support disabling fortran-style relational operators syntax Key: JEXL-385 URL: https://issues.apache.org/jira/browse/JEXL-385 Project: Commons JEXL

[GitHub] [commons-jexl] dmitri-blinov opened a new pull request, #139: Support disabling fortran-style relational operators syntax

2022-11-07 Thread GitBox
dmitri-blinov opened a new pull request, #139: URL: https://github.com/apache/commons-jexl/pull/139 Introduce JexlFeature to disable 'eq','ne','gt','ge','le','lt' as operators, treat as plain identifiers -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [commons-collections] Claudenw commented on a diff in pull request #357: Added Hasher.isEmpty() and appropriate tests

2022-11-07 Thread GitBox
Claudenw commented on code in PR #357: URL: https://github.com/apache/commons-collections/pull/357#discussion_r1015757510 ## src/main/java/org/apache/commons/collections4/bloomfilter/HasherCollection.java: ## @@ -66,6 +66,16 @@ public HasherCollection(Hasher... hashers) {

[GitHub] [commons-collections] Claudenw commented on a diff in pull request #357: Added Hasher.isEmpty() and appropriate tests

2022-11-07 Thread GitBox
Claudenw commented on code in PR #357: URL: https://github.com/apache/commons-collections/pull/357#discussion_r1015756682 ## src/test/java/org/apache/commons/collections4/bloomfilter/AbstractHasherTest.java: ## @@ -85,4 +86,7 @@ public void testHashing(int k, int m) {

[GitHub] [commons-collections] Claudenw commented on a diff in pull request #357: Added Hasher.isEmpty() and appropriate tests

2022-11-07 Thread GitBox
Claudenw commented on code in PR #357: URL: https://github.com/apache/commons-collections/pull/357#discussion_r1015757174 ## src/test/java/org/apache/commons/collections4/bloomfilter/EnhancedDoubleHasherTest.java: ## @@ -52,6 +53,11 @@ protected int getHasherSize(Hasher

[jira] [Created] (NUMBERS-191) Stirling number of the first kind

2022-11-07 Thread Alex Herbert (Jira)
Alex Herbert created NUMBERS-191: Summary: Stirling number of the first kind Key: NUMBERS-191 URL: https://issues.apache.org/jira/browse/NUMBERS-191 Project: Commons Numbers Issue Type: New

[GitHub] [commons-imaging] dependabot[bot] opened a new pull request, #247: Bump spotbugs-maven-plugin from 4.7.2.1 to 4.7.2.2

2022-11-07 Thread GitBox
dependabot[bot] opened a new pull request, #247: URL: https://github.com/apache/commons-imaging/pull/247 Bumps [spotbugs-maven-plugin](https://github.com/spotbugs/spotbugs-maven-plugin) from 4.7.2.1 to 4.7.2.2. Release notes Sourced from

[GitHub] [commons-jxpath] ecki commented on pull request #26: Fix CVE-2022-41852

2022-11-07 Thread GitBox
ecki commented on PR #26: URL: https://github.com/apache/commons-jxpath/pull/26#issuecomment-1305849264 As I understand it, it is about untrusted expressions not about untrusted payload instances or object trees. But I could be wrong, I’d it both?

[GitHub] [commons-net] garydgregory merged pull request #88: Simplify conditions avoiding extra operations.

2022-11-07 Thread GitBox
garydgregory merged PR #88: URL: https://github.com/apache/commons-net/pull/88 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [commons-jxpath] JanHron commented on pull request #26: Fix CVE-2022-41852

2022-11-07 Thread GitBox
JanHron commented on PR #26: URL: https://github.com/apache/commons-jxpath/pull/26#issuecomment-1305809446 > In short: no. I am a volunteer here, so I don't get paid, I have other priorities and interests; I work here on a best-effort basis based on my POV. This is the classic story of

[GitHub] [commons-net] garydgregory commented on pull request #119: JUnit5 assertThrows TestNtpPacket

2022-11-07 Thread GitBox
garydgregory commented on PR #119: URL: https://github.com/apache/commons-net/pull/119#issuecomment-1305792668 @nhojpatrick Did you test these changes? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [commons-net] garydgregory merged pull request #120: JUnit5 assertThrows TestTimeInfo

2022-11-07 Thread GitBox
garydgregory merged PR #120: URL: https://github.com/apache/commons-net/pull/120 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [commons-net] garydgregory merged pull request #121: JUnit5 assertThrows SimpleSMTPHeaderTestCase

2022-11-07 Thread GitBox
garydgregory merged PR #121: URL: https://github.com/apache/commons-net/pull/121 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [commons-net] garydgregory commented on pull request #118: NET-642 Fix review requested changes

2022-11-07 Thread GitBox
garydgregory commented on PR #118: URL: https://github.com/apache/commons-net/pull/118#issuecomment-1305779010 @gremi64 PR #90 has been merged. Please verify and close this PR if your use case works. -- This is an automated message from the Apache Git Service. To respond to the

[jira] [Updated] (NET-642) FTPSClient execPROT removes proxy settings

2022-11-07 Thread Gary D. Gregory (Jira)
[ https://issues.apache.org/jira/browse/NET-642?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory updated NET-642: Summary: FTPSClient execPROT removes proxy settings (was: using execPROT on FTPSClients with Proxy

[jira] [Resolved] (NET-642) using execPROT on FTPSClients with Proxy Settings removes Proxy Settings

2022-11-07 Thread Gary D. Gregory (Jira)
[ https://issues.apache.org/jira/browse/NET-642?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory resolved NET-642. - Fix Version/s: 3.9.0 Resolution: Fixed > using execPROT on FTPSClients with Proxy Settings

[GitHub] [commons-net] garydgregory merged pull request #90: NET-642 using execPROT on FTPSClients with Proxy Settings removes Pro…

2022-11-07 Thread GitBox
garydgregory merged PR #90: URL: https://github.com/apache/commons-net/pull/90 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Updated] (NET-711) Add FTP option to toggle use of return host like CURL

2022-11-07 Thread Gary D. Gregory (Jira)
[ https://issues.apache.org/jira/browse/NET-711?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory updated NET-711: Description: Make the default false to ignore such hosts. To restore the pre-3.9.0 behavior, either:

[jira] [Updated] (NET-711) Add FTP option to toggle use of return host like CURL

2022-11-07 Thread Gary D. Gregory (Jira)
[ https://issues.apache.org/jira/browse/NET-711?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory updated NET-711: Description: Make the default false to ignore such hosts. To restore the pre-3.9.0 behavior, either:

[jira] [Updated] (NET-711) Add FTP option to toggle use of return host like CURL

2022-11-07 Thread Gary D. Gregory (Jira)
[ https://issues.apache.org/jira/browse/NET-711?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory updated NET-711: Description: Make the default false to ignore such hosts. To restore the pre-3.9.0 behavior, either:

[jira] [Resolved] (NET-711) Add FTP option to toggle use of return host like CURL

2022-11-07 Thread Gary D. Gregory (Jira)
[ https://issues.apache.org/jira/browse/NET-711?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory resolved NET-711. - Fix Version/s: 3.9.0 Resolution: Fixed > Add FTP option to toggle use of return host like

[GitHub] [commons-jexl] henrib merged pull request #137: Bump checkstyle from 10.3.4 to 10.4

2022-11-07 Thread GitBox
henrib merged PR #137: URL: https://github.com/apache/commons-jexl/pull/137 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Updated] (JEXL-384) Improve control over JexlArithmetic null argument handling

2022-11-07 Thread Henri Biestro (Jira)
[ https://issues.apache.org/jira/browse/JEXL-384?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Henri Biestro updated JEXL-384: --- Summary: Improve control over JexlArithmetic null argument handling (was: Revert null + String

[GitHub] [commons-jexl] henrib closed pull request #136: JEXL-384 revert null literal + string behavior

2022-11-07 Thread GitBox
henrib closed pull request #136: JEXL-384 revert null literal + string behavior URL: https://github.com/apache/commons-jexl/pull/136 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [commons-jexl] henrib commented on pull request #136: JEXL-384 revert null literal + string behavior

2022-11-07 Thread GitBox
henrib commented on PR #136: URL: https://github.com/apache/commons-jexl/pull/136#issuecomment-1305717249 Moved relevant code to the JEXL-384 branch and pr -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[jira] [Commented] (JEXL-381) Change default JEXL configuration to a more security-friendly behaviour

2022-11-07 Thread Henri Biestro (Jira)
[ https://issues.apache.org/jira/browse/JEXL-381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17629851#comment-17629851 ] Henri Biestro commented on JEXL-381: Added permission check to load class; Added features to control n

[GitHub] [commons-collections] aherbert commented on pull request #358: Collections-817: Reworked calculations and updated javadoc.

2022-11-07 Thread GitBox
aherbert commented on PR #358: URL: https://github.com/apache/commons-collections/pull/358#issuecomment-1305317909 The git diff line for AbstractBloomFilterTest:291 does not match the compile error on the CI build. So I cannot see what is wrong. Since there are new changes in master if

[GitHub] [commons-collections] aherbert commented on a diff in pull request #357: Added Hasher.isEmpty() and appropriate tests

2022-11-07 Thread GitBox
aherbert commented on code in PR #357: URL: https://github.com/apache/commons-collections/pull/357#discussion_r1015160690 ## src/main/java/org/apache/commons/collections4/bloomfilter/Hasher.java: ## @@ -61,4 +61,10 @@ default IndexProducer uniqueIndices(Shape shape) {

[GitHub] [commons-collections] Claudenw commented on pull request #358: Collections-817: Reworked calculations and updated javadoc.

2022-11-07 Thread GitBox
Claudenw commented on PR #358: URL: https://github.com/apache/commons-collections/pull/358#issuecomment-1305301426 @aherbert I can not figure out why the checks are failing. It looks like the code the checks are using is out of sync with the actual code base. Do you have any suggestions

[jira] [Created] (CSV-306) The User Guide examples use deprecated methods

2022-11-07 Thread Oscar (Jira)
Oscar created CSV-306: - Summary: The User Guide examples use deprecated methods Key: CSV-306 URL: https://issues.apache.org/jira/browse/CSV-306 Project: Commons CSV Issue Type: Bug Components: