[jira] [Commented] (GEOMETRY-155) Implement getMidpoint(Vector x)

2023-07-16 Thread Matt Juntunen (Jira)
[ https://issues.apache.org/jira/browse/GEOMETRY-155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17743605#comment-17743605 ] Matt Juntunen commented on GEOMETRY-155: This can be done by multiplying the vector by 0.5.

[GitHub] [commons-statistics] ani5rudh commented on a diff in pull request #49: [STATISTICS-76]: Max Implementation

2023-07-16 Thread via GitHub
ani5rudh commented on code in PR #49: URL: https://github.com/apache/commons-statistics/pull/49#discussion_r1264800171 ## commons-statistics-descriptive/src/test/java/org/apache/commons/statistics/descriptive/MaxTest.java: ## @@ -0,0 +1,187 @@ +/* + * Licensed to the Apache

[jira] [Commented] (GEOMETRY-150) implement isCodirectionalTo(Vector y)

2023-07-16 Thread Matt Juntunen (Jira)
[ https://issues.apache.org/jira/browse/GEOMETRY-150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17743601#comment-17743601 ] Matt Juntunen commented on GEOMETRY-150: I believe this method is general enough and useful

[jira] [Commented] (GEOMETRY-154) Implement divideVectorWithRatio(Vector x, double ratio)

2023-07-16 Thread Matt Juntunen (Jira)
[ https://issues.apache.org/jira/browse/GEOMETRY-154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17743597#comment-17743597 ] Matt Juntunen commented on GEOMETRY-154: [~dimitrios.efthymiou], I'm not sold on the idea of

[jira] [Commented] (IMAGING-358) "RationalNumber" class is "public"

2023-07-16 Thread Gary Lucas (Jira)
[ https://issues.apache.org/jira/browse/IMAGING-358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17743590#comment-17743590 ] Gary Lucas commented on IMAGING-358: It's been two years since I looked at this (Imaging-285), but

[jira] [Comment Edited] (GEOMETRY-154) Implement divideVectorWithRatio(Vector x, double ratio)

2023-07-16 Thread Dimitrios Efthymiou (Jira)
[ https://issues.apache.org/jira/browse/GEOMETRY-154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17743585#comment-17743585 ] Dimitrios Efthymiou edited comment on GEOMETRY-154 at 7/16/23 11:38 PM:

[jira] [Commented] (GEOMETRY-154) Implement divideVectorWithRatio(Vector x, double ratio)

2023-07-16 Thread Dimitrios Efthymiou (Jira)
[ https://issues.apache.org/jira/browse/GEOMETRY-154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17743585#comment-17743585 ] Dimitrios Efthymiou commented on GEOMETRY-154: -- [~erans] doing it now. Should I send it to

[jira] [Commented] (GEOMETRY-154) Implement divideVectorWithRatio(Vector x, double ratio)

2023-07-16 Thread Gilles Sadowski (Jira)
[ https://issues.apache.org/jira/browse/GEOMETRY-154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17743582#comment-17743582 ] Gilles Sadowski commented on GEOMETRY-154: -- bq. One thing i would love to do is [...] Please

[jira] [Comment Edited] (GEOMETRY-154) Implement divideVectorWithRatio(Vector x, double ratio)

2023-07-16 Thread Dimitrios Efthymiou (Jira)
[ https://issues.apache.org/jira/browse/GEOMETRY-154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17743577#comment-17743577 ] Dimitrios Efthymiou edited comment on GEOMETRY-154 at 7/16/23 11:01 PM:

[jira] [Comment Edited] (GEOMETRY-154) Implement divideVectorWithRatio(Vector x, double ratio)

2023-07-16 Thread Dimitrios Efthymiou (Jira)
[ https://issues.apache.org/jira/browse/GEOMETRY-154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17743577#comment-17743577 ] Dimitrios Efthymiou edited comment on GEOMETRY-154 at 7/16/23 11:00 PM:

[jira] [Comment Edited] (GEOMETRY-154) Implement divideVectorWithRatio(Vector x, double ratio)

2023-07-16 Thread Dimitrios Efthymiou (Jira)
[ https://issues.apache.org/jira/browse/GEOMETRY-154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17743577#comment-17743577 ] Dimitrios Efthymiou edited comment on GEOMETRY-154 at 7/16/23 10:59 PM:

[jira] [Commented] (GEOMETRY-154) Implement divideVectorWithRatio(Vector x, double ratio)

2023-07-16 Thread Dimitrios Efthymiou (Jira)
[ https://issues.apache.org/jira/browse/GEOMETRY-154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17743577#comment-17743577 ] Dimitrios Efthymiou commented on GEOMETRY-154: -- [~mattjuntunen] for example, in graphics,

[jira] [Commented] (GEOMETRY-154) Implement divideVectorWithRatio(Vector x, double ratio)

2023-07-16 Thread Matt Juntunen (Jira)
[ https://issues.apache.org/jira/browse/GEOMETRY-154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17743573#comment-17743573 ] Matt Juntunen commented on GEOMETRY-154: What would be a use case for this method? I'm not

[jira] [Commented] (IMAGING-358) "RationalNumber" class is "public"

2023-07-16 Thread Gary D. Gregory (Jira)
[ https://issues.apache.org/jira/browse/IMAGING-358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17743568#comment-17743568 ] Gary D. Gregory commented on IMAGING-358: - " of Imaging-309, it turned out that the rational

[jira] [Commented] (IMAGING-358) "RationalNumber" class is "public"

2023-07-16 Thread Gilles Sadowski (Jira)
[ https://issues.apache.org/jira/browse/IMAGING-358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17743564#comment-17743564 ] Gilles Sadowski commented on IMAGING-358: - bq. [...] the rational number format used by TIFF

[jira] [Comment Edited] (IMAGING-358) "RationalNumber" class is "public"

2023-07-16 Thread Gary Lucas (Jira)
[ https://issues.apache.org/jira/browse/IMAGING-358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17743563#comment-17743563 ] Gary Lucas edited comment on IMAGING-358 at 7/16/23 8:11 PM: - Well, there

[jira] [Commented] (IMAGING-358) "RationalNumber" class is "public"

2023-07-16 Thread Gary Lucas (Jira)
[ https://issues.apache.org/jira/browse/IMAGING-358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17743563#comment-17743563 ] Gary Lucas commented on IMAGING-358: Well, there always a trade off with this kind of thing.  In

[GitHub] [commons-lang] garydgregory commented on a diff in pull request #786: Lang-1657: Diff Result Type Constraint

2023-07-16 Thread via GitHub
garydgregory commented on code in PR #786: URL: https://github.com/apache/commons-lang/pull/786#discussion_r1264740474 ## src/test/java/org/apache/commons/lang3/builder/DiffBuilderTest.java: ## @@ -495,4 +519,16 @@ public void testTriviallyEqualTestEnabled() {

[jira] [Updated] (COLLECTIONS-844) Counting Bloom filter expects counts (cells) to be ints

2023-07-16 Thread Claude Warren (Jira)
[ https://issues.apache.org/jira/browse/COLLECTIONS-844?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Claude Warren updated COLLECTIONS-844: -- Summary: Counting Bloom filter expects counts (cells) to be ints (was: Counting

[GitHub] [commons-lang] garydgregory commented on pull request #786: Lang-1657: Diff Result Type Constraint

2023-07-16 Thread via GitHub
garydgregory commented on PR #786: URL: https://github.com/apache/commons-lang/pull/786#issuecomment-1637177513 @greatmastermario Hm, I'm having trouble apply the patch locally on master with `git apply`. Would you rebase on master please? -- This is an automated message from the

[GitHub] [commons-lang] greatmastermario commented on pull request #786: Lang-1657: Diff Result Type Constraint

2023-07-16 Thread via GitHub
greatmastermario commented on PR #786: URL: https://github.com/apache/commons-lang/pull/786#issuecomment-1637176458 Since it has been a bit since I opened this PR, let me know if any edits are required. On Sun, Jul 16, 2023, 12:39 PM Gary Gregory ***@***.***> wrote: >

[GitHub] [commons-lang] garydgregory commented on pull request #786: Lang-1657: Diff Result Type Constraint

2023-07-16 Thread via GitHub
garydgregory commented on PR #786: URL: https://github.com/apache/commons-lang/pull/786#issuecomment-1637173471 Looking... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [commons-lang] Osdel commented on pull request #786: Lang-1657: Diff Result Type Constraint

2023-07-16 Thread via GitHub
Osdel commented on PR #786: URL: https://github.com/apache/commons-lang/pull/786#issuecomment-1637170747 What happened to this pull request? This change is really needed. Having the `DiffBuilder.append()` constraint on passing a `DiffResult` is not ideal. Ideally you want to recursively

[GitHub] [commons-digester] garydgregory closed pull request #27: Bump junit from 4.13 to 4.13.1 in /core

2023-07-16 Thread via GitHub
garydgregory closed pull request #27: Bump junit from 4.13 to 4.13.1 in /core URL: https://github.com/apache/commons-digester/pull/27 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [commons-digester] garydgregory commented on pull request #27: Bump junit from 4.13 to 4.13.1 in /core

2023-07-16 Thread via GitHub
garydgregory commented on PR #27: URL: https://github.com/apache/commons-digester/pull/27#issuecomment-1637168427 Done elsewhere. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [commons-statistics] kinow commented on a diff in pull request #49: [STATISTICS-76]: Max Implementation

2023-07-16 Thread via GitHub
kinow commented on code in PR #49: URL: https://github.com/apache/commons-statistics/pull/49#discussion_r1264731414 ## commons-statistics-descriptive/src/test/java/org/apache/commons/statistics/descriptive/MaxTest.java: ## @@ -0,0 +1,187 @@ +/* + * Licensed to the Apache

[jira] [Commented] (POOL-410) EHN Max Concurrent Connections in Stats

2023-07-16 Thread Phil Steitz (Jira)
[ https://issues.apache.org/jira/browse/POOL-410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17743558#comment-17743558 ] Phil Steitz commented on POOL-410: -- Moving a comment from PR to here.  I think I now understand at least

[GitHub] [commons-collections] aherbert commented on pull request #406: COLLECTIONS-844 - allow counting Bloom filters with cell size other than Integer.SIZE

2023-07-16 Thread via GitHub
aherbert commented on PR #406: URL: https://github.com/apache/commons-collections/pull/406#issuecomment-1637156007 Some extra checkstyle files were added. I hope to have time to review in the next few days. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [commons-collections] Claudenw opened a new pull request, #406: COLLECTIONS-844 added maxValue() to CountingBloomFilter

2023-07-16 Thread via GitHub
Claudenw opened a new pull request, #406: URL: https://github.com/apache/commons-collections/pull/406 Counting bloom filter tests are dependant upon the maximum value that can be stored in a cell in a Bloom filter. This patch adds a `maxValue()` method to the CountingBloomFilter

[GitHub] [commons-statistics] ani5rudh opened a new pull request, #49: [STATISTICS-76]: Max Implementation

2023-07-16 Thread via GitHub
ani5rudh opened a new pull request, #49: URL: https://github.com/apache/commons-statistics/pull/49 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[jira] [Created] (COLLECTIONS-844) Counting Bloomfilter tests expect counts to be ints

2023-07-16 Thread Claude Warren (Jira)
Claude Warren created COLLECTIONS-844: - Summary: Counting Bloomfilter tests expect counts to be ints Key: COLLECTIONS-844 URL: https://issues.apache.org/jira/browse/COLLECTIONS-844 Project:

[GitHub] [commons-digester] garydgregory commented on pull request #4: refine travis-ci scripts

2023-07-16 Thread via GitHub
garydgregory commented on PR #4: URL: https://github.com/apache/commons-digester/pull/4#issuecomment-1637133010 Closing: we no longer use Travis CI. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [commons-digester] garydgregory closed pull request #4: refine travis-ci scripts

2023-07-16 Thread via GitHub
garydgregory closed pull request #4: refine travis-ci scripts URL: https://github.com/apache/commons-digester/pull/4 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [commons-digester] garydgregory commented on pull request #46: JUnit5 assertThrows IncludeTest

2023-07-16 Thread via GitHub
garydgregory commented on PR #46: URL: https://github.com/apache/commons-digester/pull/46#issuecomment-1637132832 Hi @nhojpatrick I've fixed and modernized the build and it is now green. Would you please rebase your PRs? -- This is an automated message from the Apache Git Service. To

[GitHub] [commons-digester] garydgregory merged pull request #81: [StepSecurity] ci: Harden GitHub Actions

2023-07-16 Thread via GitHub
garydgregory merged PR #81: URL: https://github.com/apache/commons-digester/pull/81 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [commons-digester] step-security-bot opened a new pull request, #81: [StepSecurity] ci: Harden GitHub Actions

2023-07-16 Thread via GitHub
step-security-bot opened a new pull request, #81: URL: https://github.com/apache/commons-digester/pull/81 ## Summary This pull request is created by [Secure Repo](https://app.stepsecurity.io/securerepo) at the request of @garydgregory. Please merge the Pull Request to incorporate

[GitHub] [commons-digester] garydgregory merged pull request #32: Bump exec-maven-plugin from 1.1 to 3.1.0

2023-07-16 Thread via GitHub
garydgregory merged PR #32: URL: https://github.com/apache/commons-digester/pull/32 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [commons-digester] garydgregory merged pull request #78: Bump junit from 4.13.1 to 4.13.2

2023-07-16 Thread via GitHub
garydgregory merged PR #78: URL: https://github.com/apache/commons-digester/pull/78 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [commons-digester] garydgregory merged pull request #79: Bump jarjar-maven-plugin from 1.5 to 1.9

2023-07-16 Thread via GitHub
garydgregory merged PR #79: URL: https://github.com/apache/commons-digester/pull/79 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [commons-digester] garydgregory merged pull request #80: Bump findbugs-maven-plugin from 2.3.2 to 3.0.5

2023-07-16 Thread via GitHub
garydgregory merged PR #80: URL: https://github.com/apache/commons-digester/pull/80 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [commons-digester] garydgregory commented on pull request #32: Bump exec-maven-plugin from 1.1 to 3.1.0

2023-07-16 Thread via GitHub
garydgregory commented on PR #32: URL: https://github.com/apache/commons-digester/pull/32#issuecomment-1637120479 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [commons-digester] garydgregory merged pull request #9: Bump cglib from 3.2.5 to 3.3.0

2023-07-16 Thread via GitHub
garydgregory merged PR #9: URL: https://github.com/apache/commons-digester/pull/9 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [commons-digester] garydgregory closed pull request #64: Bump maven-javadoc-plugin from 2.8 to 3.5.0

2023-07-16 Thread via GitHub
garydgregory closed pull request #64: Bump maven-javadoc-plugin from 2.8 to 3.5.0 URL: https://github.com/apache/commons-digester/pull/64 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [commons-digester] garydgregory merged pull request #63: Bump actions/upload-artifact from 3.1.0 to 3.1.2

2023-07-16 Thread via GitHub
garydgregory merged PR #63: URL: https://github.com/apache/commons-digester/pull/63 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [commons-digester] garydgregory merged pull request #68: Bump actions/cache from 3.0.8 to 3.3.1

2023-07-16 Thread via GitHub
garydgregory merged PR #68: URL: https://github.com/apache/commons-digester/pull/68 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [commons-digester] garydgregory merged pull request #69: Bump actions/setup-java from 3.5.1 to 3.11.0

2023-07-16 Thread via GitHub
garydgregory merged PR #69: URL: https://github.com/apache/commons-digester/pull/69 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [commons-digester] garydgregory commented on pull request #69: Bump actions/setup-java from 3.5.1 to 3.11.0

2023-07-16 Thread via GitHub
garydgregory commented on PR #69: URL: https://github.com/apache/commons-digester/pull/69#issuecomment-1637117074 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [commons-digester] garydgregory merged pull request #75: Bump actions/checkout from 3.0.2 to 3.5.3

2023-07-16 Thread via GitHub
garydgregory merged PR #75: URL: https://github.com/apache/commons-digester/pull/75 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [commons-digester] garydgregory merged pull request #77: Bump junit from 4.13 to 4.13.1 in /commons-digester3-core

2023-07-16 Thread via GitHub
garydgregory merged PR #77: URL: https://github.com/apache/commons-digester/pull/77 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [commons-digester] garydgregory commented on pull request #72: Bump maven-scm-publish-plugin from 1.0-beta-2 to 3.2.1

2023-07-16 Thread via GitHub
garydgregory commented on PR #72: URL: https://github.com/apache/commons-digester/pull/72#issuecomment-1637116567 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Commented] (IMAGING-358) "RationalNumber" class is "public"

2023-07-16 Thread Gary D. Gregory (Jira)
[ https://issues.apache.org/jira/browse/IMAGING-358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17743539#comment-17743539 ] Gary D. Gregory commented on IMAGING-358: - IMO and in general, I would move all of Imaging's

[GitHub] [commons-exec] garydgregory merged pull request #112: EXEC-105: fix documentation

2023-07-16 Thread via GitHub
garydgregory merged PR #112: URL: https://github.com/apache/commons-exec/pull/112 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Comment Edited] (GEOMETRY-154) Implement divideVectorWithRatio(Vector x, double ratio)

2023-07-16 Thread Dimitrios Efthymiou (Jira)
[ https://issues.apache.org/jira/browse/GEOMETRY-154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17743530#comment-17743530 ] Dimitrios Efthymiou edited comment on GEOMETRY-154 at 7/16/23 1:57 PM:

[jira] [Commented] (GEOMETRY-154) Implement divideVectorWithRatio(Vector x, double ratio)

2023-07-16 Thread Gilles Sadowski (Jira)
[ https://issues.apache.org/jira/browse/GEOMETRY-154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17743536#comment-17743536 ] Gilles Sadowski commented on GEOMETRY-154: -- IIUC, this says that there are at least 2 ways a

[GitHub] [commons-exec] garydgregory commented on a diff in pull request #112: EXEC-105: fixed documentation

2023-07-16 Thread via GitHub
garydgregory commented on code in PR #112: URL: https://github.com/apache/commons-exec/pull/112#discussion_r1264685302 ## src/site/apt/tutorial.apt: ## @@ -169,7 +169,7 @@ executor.execute(cmdLine, resultHandler); // some time later the result handler callback was invoked so

[GitHub] [commons-exec] garydgregory commented on a diff in pull request #112: EXEC-105: fixed documentation

2023-07-16 Thread via GitHub
garydgregory commented on code in PR #112: URL: https://github.com/apache/commons-exec/pull/112#discussion_r1264685302 ## src/site/apt/tutorial.apt: ## @@ -169,7 +169,7 @@ executor.execute(cmdLine, resultHandler); // some time later the result handler callback was invoked so

[jira] [Commented] (GEOMETRY-154) Implement divideVectorWithRatio(Vector x, double ratio)

2023-07-16 Thread Dimitrios Efthymiou (Jira)
[ https://issues.apache.org/jira/browse/GEOMETRY-154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17743530#comment-17743530 ] Dimitrios Efthymiou commented on GEOMETRY-154: -- [~erans] In a sense yes. the way I

[GitHub] [commons-exec] ecki commented on a diff in pull request #112: EXEC-105: fixed documentation

2023-07-16 Thread via GitHub
ecki commented on code in PR #112: URL: https://github.com/apache/commons-exec/pull/112#discussion_r1264679931 ## src/site/apt/tutorial.apt: ## @@ -169,7 +169,7 @@ executor.execute(cmdLine, resultHandler); // some time later the result handler callback was invoked so we //

[GitHub] [commons-text] kinow commented on a diff in pull request #430: TEXT-227: removed unnecessary IF statement

2023-07-16 Thread via GitHub
kinow commented on code in PR #430: URL: https://github.com/apache/commons-text/pull/430#discussion_r1264679028 ## src/main/java/org/apache/commons/text/AlphabetConverter.java: ## @@ -87,9 +87,6 @@ public final class AlphabetConverter { * @see

[jira] [Updated] (IMAGING-358) "RationalNumber" class is "public"

2023-07-16 Thread Gilles Sadowski (Jira)
[ https://issues.apache.org/jira/browse/IMAGING-358?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gilles Sadowski updated IMAGING-358: Summary: "RationalNumber" class is "public" (was: "RationalNumer" class is "public") >

[jira] [Created] (IMAGING-358) "RationalNumer" class is "public"

2023-07-16 Thread Gilles Sadowski (Jira)
Gilles Sadowski created IMAGING-358: --- Summary: "RationalNumer" class is "public" Key: IMAGING-358 URL: https://issues.apache.org/jira/browse/IMAGING-358 Project: Commons Imaging Issue

[GitHub] [commons-text] aherbert commented on a diff in pull request #430: TEXT-227: removed unnecessary IF statement

2023-07-16 Thread via GitHub
aherbert commented on code in PR #430: URL: https://github.com/apache/commons-text/pull/430#discussion_r1264670367 ## src/main/java/org/apache/commons/text/AlphabetConverter.java: ## @@ -87,9 +87,6 @@ public final class AlphabetConverter { * @see

[jira] [Commented] (GEOMETRY-154) Implement divideVectorWithRatio(Vector x, double ratio)

2023-07-16 Thread Gilles Sadowski (Jira)
[ https://issues.apache.org/jira/browse/GEOMETRY-154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17743517#comment-17743517 ] Gilles Sadowski commented on GEOMETRY-154: -- [~dimitrios.efthymiou], Is this

[jira] [Commented] (TEXT-227) Remove unnecessary IF statement in AlphabetConverter

2023-07-16 Thread Dimitrios Efthymiou (Jira)
[ https://issues.apache.org/jira/browse/TEXT-227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17743508#comment-17743508 ] Dimitrios Efthymiou commented on TEXT-227: -- [~aherbert] PR on GitHub

[jira] [Updated] (TEXT-227) Remove unnecessary IF statement in AlphabetConverter

2023-07-16 Thread Dimitrios Efthymiou (Jira)
[ https://issues.apache.org/jira/browse/TEXT-227?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dimitrios Efthymiou updated TEXT-227: - Description: Removed unnecessary IF statement in AlphabetConverter, because the

[jira] [Created] (STATISTICS-76) Implement Max

2023-07-16 Thread Anirudh Joshi (Jira)
Anirudh Joshi created STATISTICS-76: --- Summary: Implement Max Key: STATISTICS-76 URL: https://issues.apache.org/jira/browse/STATISTICS-76 Project: Commons Statistics Issue Type: Sub-task

[jira] [Resolved] (STATISTICS-72) Implement Min

2023-07-16 Thread Alex Herbert (Jira)
[ https://issues.apache.org/jira/browse/STATISTICS-72?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Herbert resolved STATISTICS-72. Resolution: Implemented Added in commit: c9ed0a61e16e8083dc0e4b1f8afa33086d195f40 >

[GitHub] [commons-statistics] asfgit closed pull request #46: [STATISTICS-71]: Add base interfaces for all statistic implementations.

2023-07-16 Thread via GitHub
asfgit closed pull request #46: [STATISTICS-71]: Add base interfaces for all statistic implementations. URL: https://github.com/apache/commons-statistics/pull/46 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Commented] (TEXT-227) Remove unnecessary IF statement in AlphabetConverter

2023-07-16 Thread Alex Herbert (Jira)
[ https://issues.apache.org/jira/browse/TEXT-227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17743499#comment-17743499 ] Alex Herbert commented on TEXT-227: --- Some more context would be useful here. I presume the current code

[GitHub] [commons-email] aherbert commented on a diff in pull request #153: EMAIL-205: removed dead code

2023-07-16 Thread via GitHub
aherbert commented on code in PR #153: URL: https://github.com/apache/commons-email/pull/153#discussion_r1264625263 ## src/main/java/org/apache/commons/mail/EmailUtils.java: ## @@ -295,10 +295,6 @@ static String encodeUrl(final String input) throws UnsupportedEncodingException

[GitHub] [commons-statistics] aherbert commented on pull request #46: [STATISTICS-71]: Add base interfaces for all statistic implementations.

2023-07-16 Thread via GitHub
aherbert commented on PR #46: URL: https://github.com/apache/commons-statistics/pull/46#issuecomment-1637001699 The `foundation` branch requires more commits to reopen this PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [commons-statistics] aherbert closed pull request #48: [STATISTICS-71]: Add base interfaces for all statistic implementations.

2023-07-16 Thread via GitHub
aherbert closed pull request #48: [STATISTICS-71]: Add base interfaces for all statistic implementations. URL: https://github.com/apache/commons-statistics/pull/48 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [commons-statistics] aherbert commented on pull request #48: [STATISTICS-71]: Add base interfaces for all statistic implementations.

2023-07-16 Thread via GitHub
aherbert commented on PR #48: URL: https://github.com/apache/commons-statistics/pull/48#issuecomment-1637001364 See #46 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [commons-statistics] kinow commented on pull request #46: [STATISTICS-71]: Add base interfaces for all statistic implementations.

2023-07-16 Thread via GitHub
kinow commented on PR #46: URL: https://github.com/apache/commons-statistics/pull/46#issuecomment-1636997295 This branch is showing 0 commits now. You probably have to push what you have in the other branch to this pull request and maybe close the other PR (hovering the reopen pull