Re: [PR] Support for loom [commons-pool]

2024-02-26 Thread via GitHub
zenghu1chen commented on PR #230: URL: https://github.com/apache/commons-pool/pull/230#issuecomment-1965954534 @psteitz Thank you for your suggestion. I have already resubmitted the code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[PR] CLI-326: make option.getKey() public [commons-cli]

2024-02-26 Thread via GitHub
Claudenw opened a new pull request, #239: URL: https://github.com/apache/commons-cli/pull/239 Fix for CLI-326 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[jira] [Updated] (CLI-326) Make options.getKey() public

2024-02-26 Thread Claude Warren (Jira)
[ https://issues.apache.org/jira/browse/CLI-326?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Claude Warren updated CLI-326: -- Assignee: Claude Warren > Make options.getKey() public > > >

[jira] [Created] (CLI-326) Make options.getKey() public

2024-02-26 Thread Claude Warren (Jira)
Claude Warren created CLI-326: - Summary: Make options.getKey() public Key: CLI-326 URL: https://issues.apache.org/jira/browse/CLI-326 Project: Commons CLI Issue Type: Bug Components:

Re: [PR] Update the tests to JUnit 5 [commons-cli]

2024-02-26 Thread via GitHub
Claudenw commented on PR #238: URL: https://github.com/apache/commons-cli/pull/238#issuecomment-1965928143 I like the idea and I know it is a big task. I did similar work for the RAT project recently. -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] [IMAGING-340] Support PNG extension [commons-imaging]

2024-02-26 Thread via GitHub
StefanOltmann commented on PR #269: URL: https://github.com/apache/commons-imaging/pull/269#issuecomment-1965886632 @Glavo Thank you! I don’t know if this PR will ever be pulled, because by now I think that this project is pretty much dead. But you did not waste your time on

[jira] [Commented] (COMPRESS-659) TarArchiveOutputStream should use Commons IO Charsets instead of Commons Codec Charsets

2024-02-26 Thread Marc Nuri (Jira)
[ https://issues.apache.org/jira/browse/COMPRESS-659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17820986#comment-17820986 ] Marc Nuri commented on COMPRESS-659: Thanks for the quick turnaround, this change was also breaking

Re: [PR] [IMAGING-319] Bugfix for lost characters & fixed test [commons-imaging]

2024-02-26 Thread via GitHub
StefanOltmann commented on PR #367: URL: https://github.com/apache/commons-imaging/pull/367#issuecomment-1965854050 > > ? > > Er... we are volunteers with busy lives ;-) Tomorrow... I'll have to find out if we can use a file licensed under the "Unsplash license".

Re: [PR] [IMAGING-319] Bugfix for lost characters & fixed test [commons-imaging]

2024-02-26 Thread via GitHub
garydgregory commented on PR #367: URL: https://github.com/apache/commons-imaging/pull/367#issuecomment-1965664900 > ? Er... we are volunteers with busy lives ;-) Tomorrow... I'll have to find out if we can use a file licensed under the "Unsplash license". -- This is an automated

Re: [PR] CLI-325: properties from multiple arguments with value separator. [commons-cli]

2024-02-26 Thread via GitHub
garydgregory merged PR #237: URL: https://github.com/apache/commons-cli/pull/237 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Update the tests to JUnit 5 [commons-cli]

2024-02-26 Thread via GitHub
garydgregory commented on PR #238: URL: https://github.com/apache/commons-cli/pull/238#issuecomment-1965652727 Hello @DamnedElric Thank you for your PR. Run `mvn` by itself to run the default Maven goal and catch all build errors. -- This is an automated message from

[PR] Update the tests to JUnit 5 [commons-cli]

2024-02-26 Thread via GitHub
DamnedElric opened a new pull request, #238: URL: https://github.com/apache/commons-cli/pull/238 This removes references to JUnit 4 test constructions and switches all tests to JUnit 5. Unfortunately, JUnit 5's assertions have swapped the optional "message" argument from first to

Re: [PR] [IMAGING-319] Bugfix for lost characters & fixed test [commons-imaging]

2024-02-26 Thread via GitHub
StefanOltmann commented on PR #367: URL: https://github.com/apache/commons-imaging/pull/367#issuecomment-1965193264 ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] Calculate GCD for longs more efficiently [commons-numbers]

2024-02-26 Thread via GitHub
mlangc commented on PR #140: URL: https://github.com/apache/commons-numbers/pull/140#issuecomment-1965186381 I did some further benchmarks, and it seems that the implementation for int is actually better left as is. I'll look more closely tomorrow or after tomorrow & share the results with

Re: [PR] Calculate GCD for longs more efficiently [commons-numbers]

2024-02-26 Thread via GitHub
mlangc commented on PR #140: URL: https://github.com/apache/commons-numbers/pull/140#issuecomment-1964714521 > Interesting analysis on your blog. It would be helpful if you apply the same changes to `public static int gcd(int p, int q)` too. Makes sense - I just pushed another commit

[jira] [Created] (CONFIGURATION-838) Properties parser stack overflows on large single-key inputs

2024-02-26 Thread Ian Lynagh (Jira)
Ian Lynagh created CONFIGURATION-838: Summary: Properties parser stack overflows on large single-key inputs Key: CONFIGURATION-838 URL: https://issues.apache.org/jira/browse/CONFIGURATION-838

[jira] [Created] (CLI-325) When properties are retrieve for an Option that has both multiple arguments and a value separator only the first is retrieved.

2024-02-26 Thread Claude Warren (Jira)
Claude Warren created CLI-325: - Summary: When properties are retrieve for an Option that has both multiple arguments and a value separator only the first is retrieved. Key: CLI-325 URL:

Re: [PR] BEANUTILS-539/BEANUTILS-509: Switch WeakFastHashMap for ConcurrentWeakHashMap [commons-beanutils]

2024-02-26 Thread via GitHub
garydgregory commented on PR #56: URL: https://github.com/apache/commons-beanutils/pull/56#issuecomment-1964181601 > @garydgregory any time for review it pls?I think this refinition critical... I'll take a look tonight or tomorrow. -- This is an automated message from the Apache

Re: [PR] BEANUTILS-539/BEANUTILS-509: Switch WeakFastHashMap for ConcurrentWeakHashMap [commons-beanutils]

2024-02-26 Thread via GitHub
XenoAmess commented on PR #56: URL: https://github.com/apache/commons-beanutils/pull/56#issuecomment-1964148047 @garydgregory any time for review it pls?I think this refinition critical... -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] BEANUTILS-539/BEANUTILS-509: Switch WeakFastHashMap for ConcurrentWeakHashMap [commons-beanutils]

2024-02-26 Thread via GitHub
melloware commented on PR #56: URL: https://github.com/apache/commons-beanutils/pull/56#issuecomment-1963920216 Open for over 3 years. No activity. I am tired of fixing conflicts. So I closed it let someone else reopen it. -- This is an automated message from the Apache Git Service. To

Re: [PR] BEANUTILS-539/BEANUTILS-509: Switch WeakFastHashMap for ConcurrentWeakHashMap [commons-beanutils]

2024-02-26 Thread via GitHub
XenoAmess commented on PR #56: URL: https://github.com/apache/commons-beanutils/pull/56#issuecomment-1963819062 Hi. why this clised? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific