Re: [PR] Calculate GCD for longs more efficiently [commons-numbers]

2024-03-02 Thread via GitHub
mlangc commented on PR #140: URL: https://github.com/apache/commons-numbers/pull/140#issuecomment-1975073213 Thanks a lot for the detailed analysis. I've adapted the benchmark according to your suggestions: I've changed the default number of pairs to 100_000 and generate new pairs after

[jira] [Updated] (LANG-1730) DateUtils.parseDateWithLeniency() doesn't accept "GMT" as "zzz" timezone on Android

2024-03-02 Thread Hai Zhang (Jira)
[ https://issues.apache.org/jira/browse/LANG-1730?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hai Zhang updated LANG-1730: Description: Commons Lang3 3.14.0 DateUtils, i.e. FastDateParser under the hood, doesn't accept "GMT" as a

[jira] [Updated] (LANG-1730) DateUtils.parseDateWithLeniency() doesn't accept "GMT" as "zzz" timezone on Android

2024-03-02 Thread Hai Zhang (Jira)
[ https://issues.apache.org/jira/browse/LANG-1730?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hai Zhang updated LANG-1730: Description: Commons Lang3 3.14.0 DateUtils, i.e. FastDateParser under the hood, doesn't accept "GMT" as a

[jira] [Created] (LANG-1730) DateUtils.parseDateWithLeniency() doesn't accept "GMT" as "zzz" timezone on Android

2024-03-02 Thread Hai Zhang (Jira)
Hai Zhang created LANG-1730: --- Summary: DateUtils.parseDateWithLeniency() doesn't accept "GMT" as "zzz" timezone on Android Key: LANG-1730 URL: https://issues.apache.org/jira/browse/LANG-1730 Project:

Re: [PR] [CLI-327] Fix for expected textual date values. [commons-cli]

2024-03-02 Thread via GitHub
garydgregory commented on PR #244: URL: https://github.com/apache/commons-cli/pull/244#issuecomment-1974886621 Hi @Claudenw Thank you for your PR. The explanation in the description of this PR needs to be a comment in the test to warn people NOT to write the old style of test again.

[jira] [Commented] (CLI-327) Date processing tests fail on some systems

2024-03-02 Thread Gary D. Gregory (Jira)
[ https://issues.apache.org/jira/browse/CLI-327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17822855#comment-17822855 ] Gary D. Gregory commented on CLI-327: - Hi [~claude]  This could be the same type of fun issues we see

[PR] [CLI-327] Fix for expected textual date values. [commons-cli]

2024-03-02 Thread via GitHub
Claudenw opened a new pull request, #244: URL: https://github.com/apache/commons-cli/pull/244 Fixes for CLI-327 In some cases the time zone for the expected date string is different than the hard coded version. This change creates the expected value from a known simple date format

[jira] [Commented] (CLI-327) Date processing tests fail on some systems

2024-03-02 Thread Claude Warren (Jira)
[ https://issues.apache.org/jira/browse/CLI-327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17822854#comment-17822854 ] Claude Warren commented on CLI-327: --- Errors include   {{[ERROR] Tests run: 55, Failures: 1, Errors: 0,

[jira] [Updated] (CLI-327) Date processing tests fail on some systems

2024-03-02 Thread Claude Warren (Jira)
[ https://issues.apache.org/jira/browse/CLI-327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Claude Warren updated CLI-327: -- Assignee: Claude Warren > Date processing tests fail on some systems >

[jira] [Created] (CLI-327) Date processing tests fail on some systems

2024-03-02 Thread Claude Warren (Jira)
Claude Warren created CLI-327: - Summary: Date processing tests fail on some systems Key: CLI-327 URL: https://issues.apache.org/jira/browse/CLI-327 Project: Commons CLI Issue Type: Bug

Re: [PR] Calculate GCD for longs more efficiently [commons-numbers]

2024-03-02 Thread via GitHub
aherbert commented on PR #140: URL: https://github.com/apache/commons-numbers/pull/140#issuecomment-1974831748 Installed the numbers-core module locally (forgot to do this at first). MacBook Pro M2: ``` mvn -v Apache Maven 3.9.4 (dfbb324ad4a7c8fb0bf182e6d91b0ae20e3d2dd9)

Re: [PR] Bump logback.version from 1.3.12 to 1.5.1 [commons-logging]

2024-03-02 Thread via GitHub
garydgregory commented on PR #223: URL: https://github.com/apache/commons-logging/pull/223#issuecomment-1974830147 Requires Java 11. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Resolved] (COMPRESS-668) Commons-Compress is missing OSGI export packages for some Java packages

2024-03-02 Thread Gary D. Gregory (Jira)
[ https://issues.apache.org/jira/browse/COMPRESS-668?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory resolved COMPRESS-668. -- Fix Version/s: 1.26.1 Resolution: Fixed > Commons-Compress is missing OSGI

[jira] [Commented] (COMPRESS-668) Commons-Compress is missing OSGI export packages for some Java packages

2024-03-02 Thread Gary D. Gregory (Jira)
[ https://issues.apache.org/jira/browse/COMPRESS-668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17822836#comment-17822836 ] Gary D. Gregory commented on COMPRESS-668: -- [~stevon]  If all goes well, 1.26.1 will be out

Re: [PR] Calculate GCD for longs more efficiently [commons-numbers]

2024-03-02 Thread via GitHub
mlangc commented on code in PR #140: URL: https://github.com/apache/commons-numbers/pull/140#discussion_r1509950338 ## commons-numbers-examples/examples-jmh/src/main/java/org/apache/commons/numbers/examples/jmh/core/GcdPerformance.java: ## @@ -0,0 +1,236 @@ +package

Re: [PR] Calculate GCD for longs more efficiently [commons-numbers]

2024-03-02 Thread via GitHub
mlangc commented on code in PR #140: URL: https://github.com/apache/commons-numbers/pull/140#discussion_r1509950259 ## commons-numbers-examples/examples-jmh/src/main/java/org/apache/commons/numbers/examples/jmh/core/GcdPerformance.java: ## @@ -0,0 +1,236 @@ +package

Re: [PR] Calculate GCD for longs more efficiently [commons-numbers]

2024-03-02 Thread via GitHub
mlangc commented on code in PR #140: URL: https://github.com/apache/commons-numbers/pull/140#discussion_r1509910402 ## commons-numbers-examples/examples-jmh/src/main/java/org/apache/commons/numbers/examples/jmh/core/GcdPerformance.java: ## @@ -0,0 +1,236 @@ +package

Re: [PR] Calculate GCD for longs more efficiently [commons-numbers]

2024-03-02 Thread via GitHub
mlangc commented on code in PR #140: URL: https://github.com/apache/commons-numbers/pull/140#discussion_r1509909938 ## commons-numbers-examples/examples-jmh/src/main/java/org/apache/commons/numbers/examples/jmh/core/GcdPerformance.java: ## @@ -0,0 +1,236 @@ +package