Re: [PR] Minor Grammatical changes and some minor code changes. [commons-dbcp]

2024-03-04 Thread via GitHub
garydgregory commented on code in PR #355: URL: https://github.com/apache/commons-dbcp/pull/355#discussion_r1511983504 ## src/main/java/org/apache/commons/dbcp2/DataSourceConnectionFactory.java: ## @@ -16,6 +16,8 @@ */ package org.apache.commons.dbcp2; +import static

[jira] [Commented] (COMPRESS-669) Allow usage of non-Pack200 features without Commons Lang 3

2024-03-04 Thread Basil Crow (Jira)
[ https://issues.apache.org/jira/browse/COMPRESS-669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17823359#comment-17823359 ] Basil Crow commented on COMPRESS-669: - I agree. I would be willing to review a PR as well. > Allow

[jira] [Commented] (COMPRESS-669) Allow usage of non-Pack200 features without Commons Lang 3

2024-03-04 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/COMPRESS-669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17823355#comment-17823355 ] Michael Osipov commented on COMPRESS-669: - Nope, but as said if the code isn't too complex it

[jira] [Commented] (COMPRESS-669) Allow usage of non-Pack200 features without Commons Lang 3

2024-03-04 Thread Basil Crow (Jira)
[ https://issues.apache.org/jira/browse/COMPRESS-669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17823349#comment-17823349 ] Basil Crow commented on COMPRESS-669: - I have not. Have you? > Allow usage of non-Pack200 features

[jira] [Commented] (COMPRESS-669) Allow usage of non-Pack200 features without Commons Lang 3

2024-03-04 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/COMPRESS-669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17823347#comment-17823347 ] Michael Osipov commented on COMPRESS-669: - Have you tried to change that spot? > Allow usage

[jira] [Commented] (COMPRESS-661) commons-compress 1.26.0 breaks Apache Tika 2.9.1

2024-03-04 Thread Gary D. Gregory (Jira)
[ https://issues.apache.org/jira/browse/COMPRESS-661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17823334#comment-17823334 ] Gary D. Gregory commented on COMPRESS-661: -- Hi All I added the attached jar file as a test

[jira] (COMPRESS-598) NullPointerException in ZipArchiveInputStream.getCompressedCount()

2024-03-04 Thread Gary D. Gregory (Jira)
[ https://issues.apache.org/jira/browse/COMPRESS-598 ] Gary D. Gregory deleted comment on COMPRESS-598: -- was (Author: garydgregory): I added the attached jar file as a test fixture for {{org.apache.commons.compress.archivers.ListerTest}}.

[jira] [Commented] (COMPRESS-598) NullPointerException in ZipArchiveInputStream.getCompressedCount()

2024-03-04 Thread Gary D. Gregory (Jira)
[ https://issues.apache.org/jira/browse/COMPRESS-598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1782#comment-1782 ] Gary D. Gregory commented on COMPRESS-598: -- I added the attached jar file as a test fixture

[jira] [Commented] (COMPRESS-669) Allow usage of non-Pack200 features without Commons Lang 3

2024-03-04 Thread Basil Crow (Jira)
[ https://issues.apache.org/jira/browse/COMPRESS-669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17823320#comment-17823320 ] Basil Crow commented on COMPRESS-669: - Yes, that is the problematic usage. > Allow usage of

Re: [PR] Calculate GCD for longs more efficiently [commons-numbers]

2024-03-04 Thread via GitHub
mlangc commented on PR #140: URL: https://github.com/apache/commons-numbers/pull/140#issuecomment-1977345525 Sounds good  , I can look into that in the coming days. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[jira] [Commented] (COMPRESS-669) Allow usage of non-Pack200 features without Commons Lang 3

2024-03-04 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/COMPRESS-669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17823310#comment-17823310 ] Michael Osipov commented on COMPRESS-669: - Are we talking about:

[jira] [Created] (COMPRESS-669) Allow usage of non-Pack200 features without Commons Lang 3

2024-03-04 Thread Basil Crow (Jira)
Basil Crow created COMPRESS-669: --- Summary: Allow usage of non-Pack200 features without Commons Lang 3 Key: COMPRESS-669 URL: https://issues.apache.org/jira/browse/COMPRESS-669 Project: Commons Compress

[jira] [Created] (CODEC-320) Wrong output of DoubleMetaphone in 1.16.1

2024-03-04 Thread Martin Frydl (Jira)
Martin Frydl created CODEC-320: -- Summary: Wrong output of DoubleMetaphone in 1.16.1 Key: CODEC-320 URL: https://issues.apache.org/jira/browse/CODEC-320 Project: Commons Codec Issue Type: Bug

[jira] [Commented] (CODEC-318) Possible path traversal vulnerability in the Digest class CLI

2024-03-04 Thread Gary D. Gregory (Jira)
[ https://issues.apache.org/jira/browse/CODEC-318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17823216#comment-17823216 ] Gary D. Gregory commented on CODEC-318: --- [~arthur.chan]  If you want to report a vulnerability, you

[jira] [Resolved] (COMPRESS-644) ArchiveStreamFactory.detect(InputStream) returns TAR for ICO file

2024-03-04 Thread Gary D. Gregory (Jira)
[ https://issues.apache.org/jira/browse/COMPRESS-644?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory resolved COMPRESS-644. -- Fix Version/s: 1.26.1 Resolution: Fixed >

Re: [PR] COMPRESS-644 -- do not allow zero by entries when detecting magic-less tar [commons-compress]

2024-03-04 Thread via GitHub
garydgregory commented on code in PR #386: URL: https://github.com/apache/commons-compress/pull/386#discussion_r1511235353 ## src/main/java/org/apache/commons/compress/archivers/ArchiveStreamFactory.java: ## @@ -268,7 +278,15 @@ public static String detect(final InputStream in)

[jira] [Updated] (COMPRESS-644) ArchiveStreamFactory.detect(InputStream) returns TAR for ICO file

2024-03-04 Thread Gary D. Gregory (Jira)
[ https://issues.apache.org/jira/browse/COMPRESS-644?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory updated COMPRESS-644: - Summary: ArchiveStreamFactory.detect(InputStream) returns TAR for ICO file (was:

[jira] [Commented] (CODEC-319) DeferredFileOutputStream does not delete the temporary file created

2024-03-04 Thread Sheung Chi Chan (Jira)
[ https://issues.apache.org/jira/browse/CODEC-319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17823194#comment-17823194 ] Sheung Chi Chan commented on CODEC-319: --- Wrong issue, should post to Commons-IO instead. >

[jira] [Created] (IO-849) DeferredFileOutputStream does not delete the temporary file created

2024-03-04 Thread Sheung Chi Chan (Jira)
Sheung Chi Chan created IO-849: -- Summary: DeferredFileOutputStream does not delete the temporary file created Key: IO-849 URL: https://issues.apache.org/jira/browse/IO-849 Project: Commons IO

[jira] [Closed] (CODEC-319) DeferredFileOutputStream does not delete the temporary file created

2024-03-04 Thread Sheung Chi Chan (Jira)
[ https://issues.apache.org/jira/browse/CODEC-319?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sheung Chi Chan closed CODEC-319. - Resolution: Abandoned > DeferredFileOutputStream does not delete the temporary file created >

[jira] [Created] (CODEC-319) DeferredFileOutputStream does not delete the temporary file created

2024-03-04 Thread Sheung Chi Chan (Jira)
Sheung Chi Chan created CODEC-319: - Summary: DeferredFileOutputStream does not delete the temporary file created Key: CODEC-319 URL: https://issues.apache.org/jira/browse/CODEC-319 Project: Commons

Re: [PR] Split Commons Compress into multiple artifacts [commons-compress]

2024-03-04 Thread via GitHub
elharo commented on PR #490: URL: https://github.com/apache/commons-compress/pull/490#issuecomment-1976603939 Yes, a good BOM is a workaround; but it's still only a workaround. and one that operates post facto. That is, first the developer sees their project break. Then they spend an hour

[jira] [Created] (CODEC-318) Possible path traversal vulnerability in the Digest class CLI

2024-03-04 Thread Sheung Chi Chan (Jira)
Sheung Chi Chan created CODEC-318: - Summary: Possible path traversal vulnerability in the Digest class CLI Key: CODEC-318 URL: https://issues.apache.org/jira/browse/CODEC-318 Project: Commons Codec

Re: [PR] Split Commons Compress into multiple artifacts [commons-compress]

2024-03-04 Thread via GitHub
ppkarwasz commented on PR #490: URL: https://github.com/apache/commons-compress/pull/490#issuecomment-1976543279 > The problem of deep dependencies can be solved if Compress provides a BOM POM and my app depends on this BOM POM (commons-compress-bom). I think the point that @elharo

Re: [PR] Make `commons-lang3` optional [commons-compress]

2024-03-04 Thread via GitHub
garydgregory closed pull request #489: Make `commons-lang3` optional URL: https://github.com/apache/commons-compress/pull/489 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] Make `commons-lang3` optional [commons-compress]

2024-03-04 Thread via GitHub
garydgregory commented on PR #489: URL: https://github.com/apache/commons-compress/pull/489#issuecomment-1976543212 Closing: Information provided; see #490 for a possible alternate path. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] Calculate GCD for longs more efficiently [commons-numbers]

2024-03-04 Thread via GitHub
aherbert commented on PR #140: URL: https://github.com/apache/commons-numbers/pull/140#issuecomment-1976524897 Intel(R) Xeon(R) CPU E5-1680 v3 @ 3.20GHz ``` JDK 11.0.22, OpenJDK 64-Bit Server VM, 11.0.22+7-post-Ubuntu-0ubuntu220.04.1 Benchmark

Re: [PR] Split Commons Compress into multiple artifacts [commons-compress]

2024-03-04 Thread via GitHub
garydgregory commented on PR #490: URL: https://github.com/apache/commons-compress/pull/490#issuecomment-1976481820 The problem of deep dependencies can be solved if Compress provides a BOM POM and my app depends on this BOM POM (commons-compress-bom). The refactored Compress can contain

[jira] [Commented] (COMPRESS-659) TarArchiveOutputStream should use Commons IO Charsets instead of Commons Codec Charsets

2024-03-04 Thread Gary D. Gregory (Jira)
[ https://issues.apache.org/jira/browse/COMPRESS-659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17823146#comment-17823146 ] Gary D. Gregory commented on COMPRESS-659: -- [~norrisjeremy]  I should be able to get to it

[jira] [Commented] (COMPRESS-659) TarArchiveOutputStream should use Commons IO Charsets instead of Commons Codec Charsets

2024-03-04 Thread Jeremy Norris (Jira)
[ https://issues.apache.org/jira/browse/COMPRESS-659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17823137#comment-17823137 ] Jeremy Norris commented on COMPRESS-659: Just checking again if there is any progress on a

Re: [PR] Split Commons Compress into multiple artifacts [commons-compress]

2024-03-04 Thread via GitHub
ppkarwasz commented on PR #490: URL: https://github.com/apache/commons-compress/pull/490#issuecomment-1976210334 > The basic problem is that a project can have the old commons-compress deep in the transitive dependency tree. > > One then updates some other library to a new version

Re: [PR] Split Commons Compress into multiple artifacts [commons-compress]

2024-03-04 Thread via GitHub
vy commented on PR #490: URL: https://github.com/apache/commons-compress/pull/490#issuecomment-1975996682 > The basic problem is that a project can have the old commons-compress deep in the transitive dependency tree. > > One then updates some other library to a new version that now