[jira] [Commented] (CSV-91) Distinguish quoted tokens?

2012-03-31 Thread Emmanuel Bourg (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/CSV-91?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13243151#comment-13243151 ] Emmanuel Bourg commented on CSV-91: --- Why not a distinct token if it helps the lexer, but I

[jira] [Commented] (CSV-52) Keep track of record numbers

2012-03-31 Thread Emmanuel Bourg (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/CSV-52?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13243152#comment-13243152 ] Emmanuel Bourg commented on CSV-52: --- Yes excellent idea. I see a few questions: # do we

[jira] [Commented] (CSV-53) Allow to always enclose printed values into quotes

2012-03-27 Thread Emmanuel Bourg (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/CSV-53?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13239318#comment-13239318 ] Emmanuel Bourg commented on CSV-53: --- The Python CSV module has a similar concept, it offers

[jira] [Commented] (CSV-88) Not possible to create a CSVFormat from scratch

2012-03-27 Thread Emmanuel Bourg (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/CSV-88?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13239341#comment-13239341 ] Emmanuel Bourg commented on CSV-88: --- +0 for a no arg constructor equivalent to the default

[jira] [Commented] (CSV-89) Rename withLineSeparator as withOutputLineSeparator

2012-03-27 Thread Emmanuel Bourg (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/CSV-89?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13239457#comment-13239457 ] Emmanuel Bourg commented on CSV-89: --- -1 this is too long. Documenting this properly is

[jira] [Commented] (CSV-53) Allow to always enclose printed values into quotes

2012-03-27 Thread Emmanuel Bourg (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/CSV-53?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13239465#comment-13239465 ] Emmanuel Bourg commented on CSV-53: --- I agree that numeric fields are not to be converted to

[jira] [Commented] (CSV-82) CSVRecord inconsistent behaviour when header mapping is not found

2012-03-26 Thread Emmanuel Bourg (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/CSV-82?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13238343#comment-13238343 ] Emmanuel Bourg commented on CSV-82: --- I don't find this inconsistent. There are two cases to

[jira] [Commented] (CSV-78) Use Character instead of char for char fields except delimiter

2012-03-26 Thread Emmanuel Bourg (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/CSV-78?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13238354#comment-13238354 ] Emmanuel Bourg commented on CSV-78: --- I'm fine with Characters instead of primitives if there

[jira] [Commented] (CSV-82) CSVRecord inconsistent behaviour when header mapping is not found

2012-03-26 Thread Emmanuel Bourg (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/CSV-82?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13238440#comment-13238440 ] Emmanuel Bourg commented on CSV-82: --- The header line should indeed identify all the columns

[jira] [Commented] (CSV-72) CSVFormat.DEFAULT should be renamed as RFC4180

2012-03-26 Thread Emmanuel Bourg (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/CSV-72?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13238450#comment-13238450 ] Emmanuel Bourg commented on CSV-72: --- Because RFC 4180 is the only internet standard related

[jira] [Commented] (CSV-77) RFC 4180 (DEFAULT) format is wrong; should not ignore spaces or blank lines

2012-03-26 Thread Emmanuel Bourg (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/CSV-77?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13238484#comment-13238484 ] Emmanuel Bourg commented on CSV-77: --- Section 2.4 relates to a field value, but a blank line

[jira] [Commented] (CSV-73) HSQLDB supports two different field separators

2012-03-26 Thread Emmanuel Bourg (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/CSV-73?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13238529#comment-13238529 ] Emmanuel Bourg commented on CSV-73: --- I don't understand the problem they tried to solve. The

[jira] [Commented] (CSV-64) CSVPrinter does not distinguish null and the empty string

2012-03-26 Thread Emmanuel Bourg (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/CSV-64?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13238610#comment-13238610 ] Emmanuel Bourg commented on CSV-64: --- PostgreSQL can also use a special string for null

[jira] [Commented] (CSV-77) RFC 4180 (DEFAULT) format is wrong; should not ignore spaces or blank lines

2012-03-26 Thread Emmanuel Bourg (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/CSV-77?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13238630#comment-13238630 ] Emmanuel Bourg commented on CSV-77: --- DEFAULT follows RFC 4180 for printing. For parsing it

[jira] [Commented] (CSV-85) Allow comments to be returned in CSVRecord

2012-03-26 Thread Emmanuel Bourg (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/CSV-85?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13238831#comment-13238831 ] Emmanuel Bourg commented on CSV-85: --- How do you define a comment associated to a record?

[jira] [Commented] (CSV-84) Comment handling

2012-03-26 Thread Emmanuel Bourg (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/CSV-84?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13238843#comment-13238843 ] Emmanuel Bourg commented on CSV-84: --- I have never seen trailing comments in the wild, is

[jira] [Commented] (CSV-83) Provide a header encapsulator class

2012-03-26 Thread Emmanuel Bourg (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/CSV-83?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13238848#comment-13238848 ] Emmanuel Bourg commented on CSV-83: --- For what concrete purpose would this be useful?

[jira] [Commented] (CSV-76) Move CSVParser.getRecord() into a separate class?

2012-03-26 Thread Emmanuel Bourg (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/CSV-76?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13238855#comment-13238855 ] Emmanuel Bourg commented on CSV-76: --- I don't see the need to extract a 30 lines long method

[jira] [Commented] (CSV-84) Comment handling

2012-03-26 Thread Emmanuel Bourg (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/CSV-84?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13238879#comment-13238879 ] Emmanuel Bourg commented on CSV-84: --- That's most likely unintentional. This case is not

[jira] [Commented] (CSV-85) Allow comments to be returned in CSVRecord

2012-03-26 Thread Emmanuel Bourg (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/CSV-85?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13238900#comment-13238900 ] Emmanuel Bourg commented on CSV-85: --- Assuming that inline comments are dropped, I would

[jira] [Commented] (CSV-85) Allow comments to be returned in CSVRecord

2012-03-26 Thread Emmanuel Bourg (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/CSV-85?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13238931#comment-13238931 ] Emmanuel Bourg commented on CSV-85: --- Ok for ignoring the comments before the header.

[jira] [Commented] (CSV-77) RFC 4180 (DEFAULT) format is wrong; should not ignore spaces or blank lines

2012-03-26 Thread Emmanuel Bourg (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/CSV-77?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13238939#comment-13238939 ] Emmanuel Bourg commented on CSV-77: --- {{CSVFormat.RFC4180}} adds little value to the API. For

[jira] [Commented] (CSV-83) Provide a header encapsulator class

2012-03-26 Thread Emmanuel Bourg (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/CSV-83?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13238966#comment-13238966 ] Emmanuel Bourg commented on CSV-83: --- Sorry but without a real use case this tends to light

[jira] [Commented] (CSV-77) RFC 4180 (DEFAULT) format is wrong; should not ignore spaces or blank lines

2012-03-26 Thread Emmanuel Bourg (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/CSV-77?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13239013#comment-13239013 ] Emmanuel Bourg commented on CSV-77: --- What's the point of adding a useless constant? It

[jira] [Commented] (CSV-75) ExtendedBufferReader does not handle EOL consistently

2012-03-26 Thread Emmanuel Bourg (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/CSV-75?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13239052#comment-13239052 ] Emmanuel Bourg commented on CSV-75: --- I added a test demonstrating the issue. I wonder if

[jira] [Commented] (CSV-87) CSVParser.getRecords() returns null rather than empty List at EOF

2012-03-26 Thread Emmanuel Bourg (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/CSV-87?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13239071#comment-13239071 ] Emmanuel Bourg commented on CSV-87: --- +1 CSVParser.getRecords() returns

[jira] [Commented] (CSV-72) CSVFormat.DEFAULT should be renamed as RFC4180

2012-03-17 Thread Emmanuel Bourg (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/CSV-72?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13231897#comment-13231897 ] Emmanuel Bourg commented on CSV-72: --- Why do you find it confusing? Most people don't know

[jira] [Commented] (CSV-68) Use Builder pattern for CSVFormat

2012-03-17 Thread Emmanuel Bourg (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/CSV-68?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13231899#comment-13231899 ] Emmanuel Bourg commented on CSV-68: --- I suggest to remove the validation completely. No other

[jira] [Commented] (CSV-67) UnicodeUnescapeReader should not be applied before parsing

2012-03-16 Thread Emmanuel Bourg (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/CSV-67?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13230965#comment-13230965 ] Emmanuel Bourg commented on CSV-67: --- Good point but I'm not sure it actually happens. So far

[jira] [Commented] (CSV-69) Eliminate CSVPrinterTest.equals(String[][], String[][]) by using Assert.assertArrayEquals

2012-03-16 Thread Emmanuel Bourg (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/CSV-69?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13231344#comment-13231344 ] Emmanuel Bourg commented on CSV-69: --- There is a similar proposal in the code attached to

[jira] [Commented] (CSV-68) Use Builder pattern for CSVFormat

2012-03-16 Thread Emmanuel Bourg (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/CSV-68?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13231390#comment-13231390 ] Emmanuel Bourg commented on CSV-68: --- This one would satisfy me: {code} new

[jira] [Commented] (CSV-71) Add convenience Methods to CSVLexer

2012-03-16 Thread Emmanuel Bourg (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/CSV-71?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13231402#comment-13231402 ] Emmanuel Bourg commented on CSV-71: --- How is the performance with this patch?

[jira] [Commented] (CSV-68) Use Builder pattern for CSVFormat

2012-03-16 Thread Emmanuel Bourg (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/CSV-68?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13231522#comment-13231522 ] Emmanuel Bourg commented on CSV-68: --- Ok it's shorter but it doesn't make sense, what is the

[jira] [Commented] (CSV-69) Eliminate CSVPrinterTest.equals(String[][], String[][]) by using Assert.assertArrayEquals

2012-03-16 Thread Emmanuel Bourg (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/CSV-69?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13231611#comment-13231611 ] Emmanuel Bourg commented on CSV-69: --- I thought it would be worth adding his contribution,

[jira] [Commented] (CSV-65) Header support

2012-03-16 Thread Emmanuel Bourg (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/CSV-65?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13231716#comment-13231716 ] Emmanuel Bourg commented on CSV-65: --- I found an issue with the initialization in the

[jira] [Commented] (CSV-65) Header support

2012-03-15 Thread Emmanuel Bourg (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/CSV-65?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13229961#comment-13229961 ] Emmanuel Bourg commented on CSV-65: --- Ok, what about {{CSVFormat.withHeader(String...)}} ?

[jira] [Commented] (CSV-65) Header support

2012-03-15 Thread Emmanuel Bourg (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/CSV-65?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13230090#comment-13230090 ] Emmanuel Bourg commented on CSV-65: --- Yes it is. I'm attaching my suggested implementation.

[jira] [Commented] (CSV-65) Header support

2012-03-15 Thread Emmanuel Bourg (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/CSV-65?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13230111#comment-13230111 ] Emmanuel Bourg commented on CSV-65: --- Ok for initializing the header in the constructor. I

[jira] [Commented] (CSV-65) Header support

2012-03-15 Thread Emmanuel Bourg (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/CSV-65?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13230158#comment-13230158 ] Emmanuel Bourg commented on CSV-65: --- Ok. I'm going to commit what I have and we'll work out

[jira] [Commented] (CSV-59) Is CharBuffer really needed, now that StringBuilder is available?

2012-03-14 Thread Emmanuel Bourg (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/CSV-59?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13229349#comment-13229349 ] Emmanuel Bourg commented on CSV-59: --- That's a good point. I checked quickly the performance,

[jira] [Commented] (CSV-60) .CSVParser.iterator().remove() should throw throw new UnsupportedOperationException()

2012-03-14 Thread Emmanuel Bourg (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/CSV-60?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13229408#comment-13229408 ] Emmanuel Bourg commented on CSV-60: --- If you want, but the iterator is really there for the

[jira] [Commented] (CSV-61) CSVFormat combines input and output settings in a single class; might be clearer as separate classes

2012-03-14 Thread Emmanuel Bourg (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/CSV-61?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13229506#comment-13229506 ] Emmanuel Bourg commented on CSV-61: --- I'm -1 on this, this will make the API more complex for

[jira] [Commented] (CSV-62) Should CSVFormat.lineSeparator default to \r\n even on Unix systems?

2012-03-14 Thread Emmanuel Bourg (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/CSV-62?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13229512#comment-13229512 ] Emmanuel Bourg commented on CSV-62: --- Yes this is specified by RFC 4180:

[jira] [Commented] (CSV-63) CSVPrinter always quotes empty string if it is the first on a line

2012-03-14 Thread Emmanuel Bourg (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/CSV-63?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13229514#comment-13229514 ] Emmanuel Bourg commented on CSV-63: --- There is a comment in the code explaining why: {code}

[jira] [Commented] (CSV-63) CSVPrinter always quotes empty string if it is the first on a line

2012-03-14 Thread Emmanuel Bourg (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/CSV-63?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13229558#comment-13229558 ] Emmanuel Bourg commented on CSV-63: --- Then let's quote the first field only if quotes are

[jira] [Commented] (CSV-63) CSVPrinter always quotes empty string if it is the first on a line

2012-03-14 Thread Emmanuel Bourg (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/CSV-63?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13229686#comment-13229686 ] Emmanuel Bourg commented on CSV-63: --- There is also the possibility that the format allows

[jira] [Commented] (CSV-61) CSVFormat combines input and output settings in a single class; might be clearer as separate classes

2012-03-14 Thread Emmanuel Bourg (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/CSV-61?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13229690#comment-13229690 ] Emmanuel Bourg commented on CSV-61: --- I want to be able to read and write files with the same

[jira] [Commented] (CSV-64) CSVPrinter does not distinguish null and the empty string

2012-03-14 Thread Emmanuel Bourg (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/CSV-64?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13229755#comment-13229755 ] Emmanuel Bourg commented on CSV-64: --- This was discussed in CSV-13, the empty string is the

[jira] [Commented] (CSV-58) Unicode escapes are lost if escape character is backslash

2012-03-14 Thread Emmanuel Bourg (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/CSV-58?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13229762#comment-13229762 ] Emmanuel Bourg commented on CSV-58: --- Understood. The whole escaping logic is dubious, there

[jira] [Commented] (CSV-44) Merging OpenCSV

2012-03-14 Thread Emmanuel Bourg (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/CSV-44?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13229809#comment-13229809 ] Emmanuel Bourg commented on CSV-44: --- I filed CSV-65 and CSV-66 for the separate issues

[jira] [Commented] (CSV-34) CSVFormat describes itself as immutable, but it is not - in particular it is not thread-safe

2012-03-12 Thread Emmanuel Bourg (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/CSV-34?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13227352#comment-13227352 ] Emmanuel Bourg commented on CSV-34: --- volatile prevents the variables from being cached in

[jira] [Commented] (CSV-54) Confusing semantic of the ignore leading/trailing spaces parameters

2012-03-12 Thread Emmanuel Bourg (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/CSV-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13227540#comment-13227540 ] Emmanuel Bourg commented on CSV-54: --- I suggest replacing {{leading/trailingSpacesIgnored}}

[jira] [Commented] (CSV-56) Do not use exotic escape characters for sequences like \r or \n

2012-03-12 Thread Emmanuel Bourg (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/CSV-56?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13227660#comment-13227660 ] Emmanuel Bourg commented on CSV-56: --- I agree, I also think it should be possible to disable

[jira] [Commented] (CSV-54) Confusing semantic of the ignore leading/trailing spaces parameters

2012-03-12 Thread Emmanuel Bourg (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/CSV-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13227699#comment-13227699 ] Emmanuel Bourg commented on CSV-54: --- The reason for enclosing the values into quotes is to

[jira] [Commented] (CSV-57) CSVParser.getRecords() contract is confusing

2012-03-12 Thread Emmanuel Bourg (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/CSV-57?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13227754#comment-13227754 ] Emmanuel Bourg commented on CSV-57: --- The use case it to first read the headers, and then the

[jira] [Commented] (CSV-57) CSVParser.getRecords() contract is confusing

2012-03-12 Thread Emmanuel Bourg (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/CSV-57?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13227785#comment-13227785 ] Emmanuel Bourg commented on CSV-57: --- Or simply make {{String[] getRecord()}} public.

[jira] [Commented] (CSV-57) CSVParser.getRecords() contract is confusing

2012-03-12 Thread Emmanuel Bourg (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/CSV-57?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13227896#comment-13227896 ] Emmanuel Bourg commented on CSV-57: --- Let's discuss the headers on the list, there are many

[jira] [Commented] (CSV-51) Support unicode line separators

2012-03-12 Thread Emmanuel Bourg (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/CSV-51?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13228079#comment-13228079 ] Emmanuel Bourg commented on CSV-51: --- They would be used in addition to the existing line

[jira] [Commented] (CSV-34) CSVFormat describes itself as immutable, but it is not - in particular it is not thread-safe

2012-03-11 Thread Emmanuel Bourg (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/CSV-34?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13227264#comment-13227264 ] Emmanuel Bourg commented on CSV-34: --- Eventually I removed the volatile modifier, it was

[jira] [Commented] (CSV-43) CSVFormat fluent API is rather inefficient

2012-03-10 Thread Emmanuel Bourg (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/CSV-43?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13226848#comment-13226848 ] Emmanuel Bourg commented on CSV-43: --- What is the efficiency issue you are concerned with? Is

[jira] [Commented] (CSV-43) CSVFormat fluent API is rather inefficient

2012-03-10 Thread Emmanuel Bourg (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/CSV-43?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13226898#comment-13226898 ] Emmanuel Bourg commented on CSV-43: --- It's less efficient than a direct instantiation, but

[jira] [Commented] (SANDBOX-406) CSV Parser loops inifinitely if last line starts with a comment char

2012-03-09 Thread Emmanuel Bourg (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/SANDBOX-406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13225964#comment-13225964 ] Emmanuel Bourg commented on SANDBOX-406: Thank you for the feedback Edgar. I

[jira] [Commented] (SANDBOX-408) CSVFormat describes itself as immutable, but it is not - in particular it is not thread-safe

2012-03-09 Thread Emmanuel Bourg (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/SANDBOX-408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13226187#comment-13226187 ] Emmanuel Bourg commented on SANDBOX-408: After checking the JLS and the excellent

[jira] [Commented] (SANDBOX-413) CSVFormat fluent API is rather inefficient

2012-03-09 Thread Emmanuel Bourg (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/SANDBOX-413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13226447#comment-13226447 ] Emmanuel Bourg commented on SANDBOX-413: Instances of CSVFormat cannot become

[jira] [Commented] (SANDBOX-291) Lots of possible changes

2012-03-07 Thread Emmanuel Bourg (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/SANDBOX-291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13224219#comment-13224219 ] Emmanuel Bourg commented on SANDBOX-291: There are a lot of good suggestions, I

[jira] [Commented] (SANDBOX-408) CSVFormat describes itself as immutable, but it is not - in particular it is not thread-safe

2012-03-07 Thread Emmanuel Bourg (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/SANDBOX-408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13224834#comment-13224834 ] Emmanuel Bourg commented on SANDBOX-408: Thank you for showing how this can be

[jira] [Commented] (SANDBOX-309) raw record read by the parser

2012-03-06 Thread Emmanuel Bourg (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/SANDBOX-309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13223425#comment-13223425 ] Emmanuel Bourg commented on SANDBOX-309: Pino, what is the raw record and why do

[jira] [Commented] (SANDBOX-408) CSVFormat describes itself as immutable, but it is not - in particular it is not thread-safe

2012-03-06 Thread Emmanuel Bourg (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/SANDBOX-408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13223691#comment-13223691 ] Emmanuel Bourg commented on SANDBOX-408: Could you elaborate a bit in this issue

[jira] [Commented] (SANDBOX-408) CSVFormat describes itself as immutable, but it is not - in particular it is not thread-safe

2012-03-06 Thread Emmanuel Bourg (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/SANDBOX-408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13223765#comment-13223765 ] Emmanuel Bourg commented on SANDBOX-408: CSVFormat doesn't claim to be thread

[jira] [Commented] (SANDBOX-406) CSV Parser loops inifinitely if last line starts with a comment char

2012-03-05 Thread Emmanuel Bourg (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/SANDBOX-406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=1379#comment-1379 ] Emmanuel Bourg commented on SANDBOX-406: Thank you for the report Edgar. This

[jira] [Commented] (SANDBOX-406) CSV Parser loops inifinitely if last line starts with a comment char

2012-03-05 Thread Emmanuel Bourg (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/SANDBOX-406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13222350#comment-13222350 ] Emmanuel Bourg commented on SANDBOX-406: Glad to hear it works! There is no

[jira] [Commented] (CONFIGURATION-477) PropertyListConfiguration cannot deal with comments

2012-02-21 Thread Emmanuel Bourg (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/CONFIGURATION-477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13212534#comment-13212534 ] Emmanuel Bourg commented on CONFIGURATION-477: -- The specification I

[jira] [Commented] (FUNCTOR-10) throw NullPointerException for illegal null values

2012-01-23 Thread Emmanuel Bourg (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/FUNCTOR-10?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13190940#comment-13190940 ] Emmanuel Bourg commented on FUNCTOR-10: --- I tend to think that convenience for the

[jira] [Commented] (FUNCTOR-10) throw NullPointerException for illegal null values

2012-01-22 Thread Emmanuel Bourg (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/FUNCTOR-10?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13190803#comment-13190803 ] Emmanuel Bourg commented on FUNCTOR-10: --- Doesn't this create a risk that people will

[jira] [Commented] (CONFIGURATION-473) Number to Boolean conversion

2012-01-04 Thread Emmanuel Bourg (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/CONFIGURATION-473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13179622#comment-13179622 ] Emmanuel Bourg commented on CONFIGURATION-473: -- You meant 1 == true,

[jira] [Commented] (CONFIGURATION-473) Number to Boolean conversion

2012-01-04 Thread Emmanuel Bourg (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/CONFIGURATION-473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13179692#comment-13179692 ] Emmanuel Bourg commented on CONFIGURATION-473: -- Well I'm mostly

[jira] [Commented] (CLI-224) OptionBuilder only has static methods, yet many return an OptionBuilder instance

2011-12-15 Thread Emmanuel Bourg (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/CLI-224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13170117#comment-13170117 ] Emmanuel Bourg commented on CLI-224: Thank you for the code Brian, a revamped builder

[jira] [Commented] (CLI-216) Optional support for concatenated option in the DefaultParser

2011-11-24 Thread Emmanuel Bourg (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/CLI-216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13156679#comment-13156679 ] Emmanuel Bourg commented on CLI-216: It's not necessarily related to CLI-217. If there

[jira] [Commented] (CLI-216) Optional support for concatenated option in the DefaultParser

2011-11-16 Thread Emmanuel Bourg (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/CLI-216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13151101#comment-13151101 ] Emmanuel Bourg commented on CLI-216: I was thinking at something like v, e, r short

[jira] [Commented] (CLI-216) Optional support for concatenated option in the DefaultParser

2011-11-15 Thread Emmanuel Bourg (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/CLI-216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13150613#comment-13150613 ] Emmanuel Bourg commented on CLI-216: It would be disabled on the parser, the definition

[jira] [Commented] (CLI-217) Optional partial matching for long options

2011-11-14 Thread Emmanuel Bourg (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/CLI-217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13149939#comment-13149939 ] Emmanuel Bourg commented on CLI-217: Thank you for the patch Hartmut. If I understand

[jira] [Commented] (CONFIGURATION-470) Extract classes generated by JavaCC

2011-11-11 Thread Emmanuel Bourg (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/CONFIGURATION-470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13148475#comment-13148475 ] Emmanuel Bourg commented on CONFIGURATION-470: -- I adapted my

[jira] [Commented] (SANDBOX-269) Decide whether to keep the csv.writer subpackage

2011-11-11 Thread Emmanuel Bourg (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/SANDBOX-269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13148479#comment-13148479 ] Emmanuel Bourg commented on SANDBOX-269: I suggest removing the writer package

[jira] [Commented] (SANDBOX-163) Create Strategy for RFC4180

2011-11-11 Thread Emmanuel Bourg (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/SANDBOX-163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13148864#comment-13148864 ] Emmanuel Bourg commented on SANDBOX-163: I conducted some tests, it seems [csv]

[jira] [Commented] (SANDBOX-242) Encapsulated csv line strategy

2011-11-11 Thread Emmanuel Bourg (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/SANDBOX-242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13148909#comment-13148909 ] Emmanuel Bourg commented on SANDBOX-242: You simply have to run it twice through

[jira] [Commented] (SANDBOX-279) CSVStrategy has modifiable public static variables

2011-11-09 Thread Emmanuel Bourg (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/SANDBOX-279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13147026#comment-13147026 ] Emmanuel Bourg commented on SANDBOX-279: +1 for refactoring the class and make it

[jira] [Commented] (SANDBOX-220) CSVParser.nextValue() seems pointless

2011-11-09 Thread Emmanuel Bourg (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/SANDBOX-220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13147074#comment-13147074 ] Emmanuel Bourg commented on SANDBOX-220: I agree as well, unless lines are too

[jira] [Commented] (SANDBOX-311) Merging OpenCSV

2011-11-09 Thread Emmanuel Bourg (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/SANDBOX-311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13147140#comment-13147140 ] Emmanuel Bourg commented on SANDBOX-311: Is the bean mapping the only feature

[jira] [Commented] (SANDBOX-250) add a getter for input reader

2011-11-09 Thread Emmanuel Bourg (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/SANDBOX-250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13147407#comment-13147407 ] Emmanuel Bourg commented on SANDBOX-250: I agree with Jacopo, the reader can be

[jira] [Commented] (SANDBOX-311) Merging OpenCSV

2011-11-09 Thread Emmanuel Bourg (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/SANDBOX-311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13147410#comment-13147410 ] Emmanuel Bourg commented on SANDBOX-311: I upgraded the API to use Java 5 today,

[jira] [Commented] (SANDBOX-209) NullPointerException in CSVPrinter.print()/println()

2011-11-09 Thread Emmanuel Bourg (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/SANDBOX-209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13147425#comment-13147425 ] Emmanuel Bourg commented on SANDBOX-209: I found the null handling a bit dubious

[jira] [Commented] (CONFIGURATION-470) Extract classes generated by JavaCC

2011-11-07 Thread Emmanuel Bourg (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/CONFIGURATION-470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13145928#comment-13145928 ] Emmanuel Bourg commented on CONFIGURATION-470: -- I preferred keeping

[jira] [Commented] (COMPRESS-156) XZ compression support

2011-11-04 Thread Emmanuel Bourg (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/COMPRESS-156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13143867#comment-13143867 ] Emmanuel Bourg commented on COMPRESS-156: - Also, a snapshot of the next release

[jira] [Commented] (CONFIGURATION-469) ConfigurationRuntimeException: Bean class is not specified!

2011-10-27 Thread Emmanuel Bourg (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/CONFIGURATION-469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13136903#comment-13136903 ] Emmanuel Bourg commented on CONFIGURATION-469: -- And what's the content

[jira] [Commented] (CONFIGURATION-469) ConfigurationRuntimeException: Bean class is not specified!

2011-10-26 Thread Emmanuel Bourg (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/CONFIGURATION-469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13136048#comment-13136048 ] Emmanuel Bourg commented on CONFIGURATION-469: -- Could you tell us how

[jira] [Commented] (CONFIGURATION-342) DatabaseConfiguration.copy() loses list/array values

2011-10-24 Thread Emmanuel Bourg (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/CONFIGURATION-342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13133884#comment-13133884 ] Emmanuel Bourg commented on CONFIGURATION-342: -- I suggest two

[jira] [Commented] (CONFIGURATION-204) Observable configurations

2011-10-24 Thread Emmanuel Bourg (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/CONFIGURATION-204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13133920#comment-13133920 ] Emmanuel Bourg commented on CONFIGURATION-204: -- Configurations are

[jira] [Commented] (CONFIGURATION-204) Observable configurations

2011-10-24 Thread Emmanuel Bourg (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/CONFIGURATION-204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13134441#comment-13134441 ] Emmanuel Bourg commented on CONFIGURATION-204: -- You are right, thank

[jira] [Commented] (CONFIGURATION-312) WindowsConfiguration

2011-10-24 Thread Emmanuel Bourg (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/CONFIGURATION-312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13134453#comment-13134453 ] Emmanuel Bourg commented on CONFIGURATION-312: -- There is also a

[jira] [Commented] (CONFIGURATION-467) Unable to persist CombinedConfiguration changes to the Filesystem.

2011-10-21 Thread Emmanuel Bourg (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/CONFIGURATION-467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13132650#comment-13132650 ] Emmanuel Bourg commented on CONFIGURATION-467: -- There is a proposal to

  1   2   >