[GitHub] [commons-configuration] dependabot[bot] opened a new pull request, #268: Bump mockito-core from 4.11.0 to 5.0.0

2023-01-20 Thread GitBox
dependabot[bot] opened a new pull request, #268: URL: https://github.com/apache/commons-configuration/pull/268 Bumps [mockito-core](https://github.com/mockito/mockito) from 4.11.0 to 5.0.0. Release notes Sourced from https://github.com/mockito/mockito/releases;>mockito-core's

[GitHub] [commons-csv] DamjanJovanovic commented on a diff in pull request #295: Add support for trailing text after the closing quote, and EOF without a final closing quote, for Excel compatibility

2023-01-20 Thread GitBox
DamjanJovanovic commented on code in PR #295: URL: https://github.com/apache/commons-csv/pull/295#discussion_r1082679746 ## src/main/java/org/apache/commons/csv/CSVFormat.java: ## @@ -846,6 +881,8 @@ public CSVFormat getFormat() { public static final CSVFormat EXCEL =

[GitHub] [commons-csv] garydgregory commented on a diff in pull request #295: Add support for trailing text after the closing quote, and EOF without a final closing quote, for Excel compatibility

2023-01-20 Thread GitBox
garydgregory commented on code in PR #295: URL: https://github.com/apache/commons-csv/pull/295#discussion_r1082447049 ## src/main/java/org/apache/commons/csv/CSVFormat.java: ## @@ -846,6 +881,8 @@ public CSVFormat getFormat() { public static final CSVFormat EXCEL =

[GitHub] [commons-csv] dependabot[bot] opened a new pull request, #302: Bump mockito-core from 4.11.0 to 5.0.0

2023-01-20 Thread GitBox
dependabot[bot] opened a new pull request, #302: URL: https://github.com/apache/commons-csv/pull/302 Bumps [mockito-core](https://github.com/mockito/mockito) from 4.11.0 to 5.0.0. Release notes Sourced from https://github.com/mockito/mockito/releases;>mockito-core's releases.

[GitHub] [commons-build-plugin] garydgregory merged pull request #126: Bump maven-plugin-tools-ant from 3.7.0 to 3.7.1

2023-01-20 Thread GitBox
garydgregory merged PR #126: URL: https://github.com/apache/commons-build-plugin/pull/126 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [commons-build-plugin] garydgregory merged pull request #127: Bump maven-plugin-plugin from 3.7.0 to 3.7.1

2023-01-20 Thread GitBox
garydgregory merged PR #127: URL: https://github.com/apache/commons-build-plugin/pull/127 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [commons-build-plugin] garydgregory merged pull request #125: Bump github/codeql-action from 2.1.38 to 2.1.39

2023-01-20 Thread GitBox
garydgregory merged PR #125: URL: https://github.com/apache/commons-build-plugin/pull/125 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [commons-skin] garydgregory merged pull request #37: Bump github/codeql-action from 2.1.38 to 2.1.39

2023-01-20 Thread GitBox
garydgregory merged PR #37: URL: https://github.com/apache/commons-skin/pull/37 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [commons-parent] garydgregory merged pull request #208: Bump github/codeql-action from 2.1.38 to 2.1.39

2023-01-20 Thread GitBox
garydgregory merged PR #208: URL: https://github.com/apache/commons-parent/pull/208 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [commons-parent] dependabot[bot] opened a new pull request, #208: Bump github/codeql-action from 2.1.38 to 2.1.39

2023-01-20 Thread GitBox
dependabot[bot] opened a new pull request, #208: URL: https://github.com/apache/commons-parent/pull/208 Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2.1.38 to 2.1.39. Changelog Sourced from

[GitHub] [commons-skin] dependabot[bot] opened a new pull request, #37: Bump github/codeql-action from 2.1.38 to 2.1.39

2023-01-20 Thread GitBox
dependabot[bot] opened a new pull request, #37: URL: https://github.com/apache/commons-skin/pull/37 Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2.1.38 to 2.1.39. Changelog Sourced from

[GitHub] [commons-dbutils] dependabot[bot] opened a new pull request, #176: Bump mockito-core from 4.11.0 to 5.0.0

2023-01-20 Thread GitBox
dependabot[bot] opened a new pull request, #176: URL: https://github.com/apache/commons-dbutils/pull/176 Bumps [mockito-core](https://github.com/mockito/mockito) from 4.11.0 to 5.0.0. Release notes Sourced from https://github.com/mockito/mockito/releases;>mockito-core's releases.

[GitHub] [commons-build-plugin] dependabot[bot] opened a new pull request, #127: Bump maven-plugin-plugin from 3.7.0 to 3.7.1

2023-01-19 Thread GitBox
dependabot[bot] opened a new pull request, #127: URL: https://github.com/apache/commons-build-plugin/pull/127 Bumps [maven-plugin-plugin](https://github.com/apache/maven-plugin-tools) from 3.7.0 to 3.7.1. Release notes Sourced from

[GitHub] [commons-build-plugin] dependabot[bot] opened a new pull request, #126: Bump maven-plugin-tools-ant from 3.7.0 to 3.7.1

2023-01-19 Thread GitBox
dependabot[bot] opened a new pull request, #126: URL: https://github.com/apache/commons-build-plugin/pull/126 Bumps maven-plugin-tools-ant from 3.7.0 to 3.7.1. [![Dependabot compatibility

[GitHub] [commons-build-plugin] dependabot[bot] opened a new pull request, #125: Bump github/codeql-action from 2.1.38 to 2.1.39

2023-01-19 Thread GitBox
dependabot[bot] opened a new pull request, #125: URL: https://github.com/apache/commons-build-plugin/pull/125 Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2.1.38 to 2.1.39. Changelog Sourced from

[GitHub] [commons-compress] dependabot[bot] opened a new pull request, #354: Bump mockito.version from 4.11.0 to 5.0.0

2023-01-19 Thread GitBox
dependabot[bot] opened a new pull request, #354: URL: https://github.com/apache/commons-compress/pull/354 Bumps `mockito.version` from 4.11.0 to 5.0.0. Updates `mockito-core` from 4.11.0 to 5.0.0 Release notes Sourced from

[GitHub] [commons-dbcp] dependabot[bot] opened a new pull request, #258: Bump mockito-core from 4.11.0 to 5.0.0

2023-01-19 Thread GitBox
dependabot[bot] opened a new pull request, #258: URL: https://github.com/apache/commons-dbcp/pull/258 Bumps [mockito-core](https://github.com/mockito/mockito) from 4.11.0 to 5.0.0. Release notes Sourced from https://github.com/mockito/mockito/releases;>mockito-core's releases.

[GitHub] [commons-io] dependabot[bot] opened a new pull request, #426: Bump mockito-inline from 4.11.0 to 5.0.0

2023-01-19 Thread GitBox
dependabot[bot] opened a new pull request, #426: URL: https://github.com/apache/commons-io/pull/426 Bumps [mockito-inline](https://github.com/mockito/mockito) from 4.11.0 to 5.0.0. Release notes Sourced from https://github.com/mockito/mockito/releases;>mockito-inline's releases.

[GitHub] [commons-imaging] garydgregory commented on pull request #271: Unit test : make tests in memory instead of writing hundred of tmp files

2023-01-19 Thread GitBox
garydgregory commented on PR #271: URL: https://github.com/apache/commons-imaging/pull/271#issuecomment-1397741352 I was referring to GitHub Actions builds being resource constrained (to what extent I don't know exactly). -- This is an automated message from the Apache Git Service. To

[GitHub] [commons-imaging] kpouer commented on pull request #271: Unit test : make tests in memory instead of writing hundred of tmp files

2023-01-19 Thread GitBox
kpouer commented on PR #271: URL: https://github.com/apache/commons-imaging/pull/271#issuecomment-1397599109 Hi @kinow, About the new methods, it is utility that get various information about the image. Some format are not detected only from their data and the file extension is

[GitHub] [commons-imaging] garydgregory commented on pull request #271: Unit test : make tests in memory instead of writing hundred of tmp files

2023-01-19 Thread GitBox
garydgregory commented on PR #271: URL: https://github.com/apache/commons-imaging/pull/271#issuecomment-1397563684 Keep in mind that tests must be able to run in containers that may not provide much memory. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [commons-imaging] codecov-commenter commented on pull request #271: Unit test : make tests in memory instead of writing hundred of tmp files

2023-01-19 Thread GitBox
codecov-commenter commented on PR #271: URL: https://github.com/apache/commons-imaging/pull/271#issuecomment-1397538958 #

[GitHub] [commons-imaging] kpouer opened a new pull request, #271: Unit test : make tests in memory instead of writing hundred of tmp files

2023-01-19 Thread GitBox
kpouer opened a new pull request, #271: URL: https://github.com/apache/commons-imaging/pull/271 An attempt to perform unit tests in memory using byte array when possible instead of writing temporary files. Tests pass much faster and do not make useless write on my SSD. I know that

[GitHub] [commons-net] mawiesne commented on pull request #141: Fixes many grammar issues and typos in JavaDoc and code comments

2023-01-19 Thread GitBox
mawiesne commented on PR #141: URL: https://github.com/apache/commons-net/pull/141#issuecomment-1397412009 Thanks for the constructive feedback while processing the PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [commons-net] garydgregory commented on pull request #141: Fixes many grammar issues and typos in JavaDoc and code comments

2023-01-19 Thread GitBox
garydgregory commented on PR #141: URL: https://github.com/apache/commons-net/pull/141#issuecomment-1397409005 TY @mawiesne TY @sebbASF -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [commons-net] garydgregory merged pull request #141: Fixes many grammar issues and typos in JavaDoc and code comments

2023-01-19 Thread GitBox
garydgregory merged PR #141: URL: https://github.com/apache/commons-net/pull/141 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [commons-io] garydgregory commented on pull request #66: Avoid Code Duplication: Reuse Sleep from ThreadMonitor

2023-01-19 Thread GitBox
garydgregory commented on PR #66: URL: https://github.com/apache/commons-io/pull/66#issuecomment-1397225773 @DaGeRe Done differently in git master, please review your use cases. You are credited in `changes.xml`. -- This is an automated message from the Apache Git Service. To respond

[GitHub] [commons-io] garydgregory closed pull request #66: Avoid Code Duplication: Reuse Sleep from ThreadMonitor

2023-01-19 Thread GitBox
garydgregory closed pull request #66: Avoid Code Duplication: Reuse Sleep from ThreadMonitor URL: https://github.com/apache/commons-io/pull/66 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [commons-vfs] garydgregory commented on pull request #300: VFS-824 HttpFileSystem free Unused Resources lead to HttpClient Conn…

2023-01-19 Thread GitBox
garydgregory commented on PR #300: URL: https://github.com/apache/commons-vfs/pull/300#issuecomment-1397014194 I need to look at this more closely over the weekend: I don't know why the HTTP providers have to be unique and different compared to all the others. Is the use of concepts in

[GitHub] [commons-io] garydgregory commented on pull request #418: [IO-784] Add support for Appendable to HexDump

2023-01-19 Thread GitBox
garydgregory commented on PR #418: URL: https://github.com/apache/commons-io/pull/418#issuecomment-1396977636 I need to look at this more closely over the weekend: I don't know why the HTTP providers have to be unique and different compared to all the others. Is the use of concepts in this

[GitHub] [commons-io] garydgregory closed pull request #297: IO-552: Honor tilde as a valid character for file and directory names

2023-01-19 Thread GitBox
garydgregory closed pull request #297: IO-552: Honor tilde as a valid character for file and directory names URL: https://github.com/apache/commons-io/pull/297 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [commons-io] garydgregory commented on pull request #297: IO-552: Honor tilde as a valid character for file and directory names

2023-01-19 Thread GitBox
garydgregory commented on PR #297: URL: https://github.com/apache/commons-io/pull/297#issuecomment-1396901440 I am still -1 on this one because `~` is only a Unix-like shells and `~.txt` is a legal file name on Windows 10. So I will close this PR. -- This is an automated message from the

[GitHub] [commons-net] mawiesne commented on pull request #141: Fixes many grammar issues and typos in JavaDoc and code comments

2023-01-19 Thread GitBox
mawiesne commented on PR #141: URL: https://github.com/apache/commons-net/pull/141#issuecomment-1396602275 @sebbASF My latest commit contained JavaDoc only changes. However, ``` Error: Errors: Error:TFTPServerPathTest.testWriteOutsideHome:116 � Bind Address already in

[GitHub] [commons-lang] garydgregory commented on pull request #1021: Created a new function for the StringUtils class.

2023-01-18 Thread GitBox
garydgregory commented on PR #1021: URL: https://github.com/apache/commons-lang/pull/1021#issuecomment-1396339399 -1 does not belong in this component IMO and you can't convert a sentence into a palindrome anyway. -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [commons-lang] emeraldswag312 opened a new pull request, #1021: Created a new function for the StringUtils class.

2023-01-18 Thread GitBox
emeraldswag312 opened a new pull request, #1021: URL: https://github.com/apache/commons-lang/pull/1021 Created a new function called palindrome to create a palindrome from an input string. -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [commons-net] sebbASF commented on a diff in pull request #141: Fixes many grammar issues and typos in JavaDoc and code comments

2023-01-18 Thread GitBox
sebbASF commented on code in PR #141: URL: https://github.com/apache/commons-net/pull/141#discussion_r1080653735 ## src/main/java/org/apache/commons/net/ftp/FTPSClient.java: ## @@ -375,7 +375,7 @@ public int execADAT(final byte[] data) throws IOException { /** * AUTH

[GitHub] [commons-io] garydgregory merged pull request #418: [IO-784] Add support for Appendable to HexDump util

2023-01-18 Thread GitBox
garydgregory merged PR #418: URL: https://github.com/apache/commons-io/pull/418 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [commons-crypto] markwkern commented on pull request #165: CRYPTO-162 openSslCipher support engine.

2023-01-18 Thread GitBox
markwkern commented on PR #165: URL: https://github.com/apache/commons-crypto/pull/165#issuecomment-1387678224 You could use the Intel rdrand engine in the unit test. It's always available in OpenSSL for machines of the Ivy Bridge or later generation. % openssl engine -v (rdrand)

[GitHub] [commons-net] garydgregory commented on pull request #141: Fixes many grammar issues and typos in JavaDoc and code comments

2023-01-18 Thread GitBox
garydgregory commented on PR #141: URL: https://github.com/apache/commons-net/pull/141#issuecomment-1387593903 @sebbASF Have all your concerns been addressed? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [commons-vfs] garydgregory merged pull request #367: [VFS-683] Class loader thread safety

2023-01-18 Thread GitBox
garydgregory merged PR #367: URL: https://github.com/apache/commons-vfs/pull/367 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [commons-vfs] ivakegg commented on pull request #367: fixes #VFS-683: class loader thread safety

2023-01-18 Thread GitBox
ivakegg commented on PR #367: URL: https://github.com/apache/commons-vfs/pull/367#issuecomment-1387115776 This is ready for a final review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [commons-pool] garydgregory closed pull request #209: NullPointerException can occur in GenericObjectPool#use

2023-01-17 Thread GitBox
garydgregory closed pull request #209: NullPointerException can occur in GenericObjectPool#use URL: https://github.com/apache/commons-pool/pull/209 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [commons-pool] garydgregory commented on pull request #209: NullPointerException can occur in GenericObjectPool#use

2023-01-17 Thread GitBox
garydgregory commented on PR #209: URL: https://github.com/apache/commons-pool/pull/209#issuecomment-1385912505 @reda-alaoui Thank you for your PR. I did the same slightly differently; please check out git master or a snapshot build here:

[GitHub] [commons-pool] reda-alaoui commented on pull request #209: NullPointerException can occur in GenericObjectPool#use

2023-01-17 Thread GitBox
reda-alaoui commented on PR #209: URL: https://github.com/apache/commons-pool/pull/209#issuecomment-1385794431 Hello @kinow , It happened via commons-dbcp. Here is a part of the stacktrace: ```java Caused by: java.lang.NullPointerException: Cannot invoke

[GitHub] [commons-pool] codecov-commenter commented on pull request #209: NullPointerException can occur in GenericObjectPool#use

2023-01-17 Thread GitBox
codecov-commenter commented on PR #209: URL: https://github.com/apache/commons-pool/pull/209#issuecomment-1385749194 #

[GitHub] [commons-vfs] ivakegg commented on pull request #367: fixes #VFS-683: class loader thread safety

2023-01-17 Thread GitBox
ivakegg commented on PR #367: URL: https://github.com/apache/commons-vfs/pull/367#issuecomment-1385602942 Well, everything appears to have passed this time. I will up the number of threads in the test to see if I can force the failures again. -- This is an automated message from the

[GitHub] [commons-vfs] ivakegg commented on pull request #367: fixes #VFS-683: class loader thread safety

2023-01-17 Thread GitBox
ivakegg commented on PR #367: URL: https://github.com/apache/commons-vfs/pull/367#issuecomment-1385497909 I will try to track down the fails in the macos vms. I will have to instrument the test case to see what is going on. -- This is an automated message from the Apache Git Service. To

[GitHub] [commons-imaging] kinow merged pull request #270: Fix unit test

2023-01-16 Thread GitBox
kinow merged PR #270: URL: https://github.com/apache/commons-imaging/pull/270 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [commons-imaging] codecov-commenter commented on pull request #270: Fix unit test

2023-01-16 Thread GitBox
codecov-commenter commented on PR #270: URL: https://github.com/apache/commons-imaging/pull/270#issuecomment-1384546615 #

[GitHub] [commons-imaging] kpouer opened a new pull request, #270: Fix unit test

2023-01-16 Thread GitBox
kpouer opened a new pull request, #270: URL: https://github.com/apache/commons-imaging/pull/270 Fix two unit tests that were broken. PixelDensityRoundtrip was now writing data in a byte array instead of a tmp file, but was trying to read the tmp file anyway. And

[GitHub] [commons-release-plugin] garydgregory merged pull request #168: Bump maven.plugin.version from 3.7.0 to 3.7.1

2023-01-16 Thread GitBox
garydgregory merged PR #168: URL: https://github.com/apache/commons-release-plugin/pull/168 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [commons-release-plugin] dependabot[bot] opened a new pull request, #168: Bump maven.plugin.version from 3.7.0 to 3.7.1

2023-01-16 Thread GitBox
dependabot[bot] opened a new pull request, #168: URL: https://github.com/apache/commons-release-plugin/pull/168 Bumps `maven.plugin.version` from 3.7.0 to 3.7.1. Updates `maven-plugin-annotations` from 3.7.0 to 3.7.1 Release notes Sourced from

[GitHub] [commons-validator] garydgregory commented on pull request #29: Add Getters for IBANValidator's RegexValidator its patterns

2023-01-16 Thread GitBox
garydgregory commented on PR #29: URL: https://github.com/apache/commons-validator/pull/29#issuecomment-1384317132 @arnaudfnr Done in git master, with a defensive copy of the pattern array. -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [commons-validator] garydgregory closed pull request #29: Add Getters for IBANValidator's RegexValidator its patterns

2023-01-16 Thread GitBox
garydgregory closed pull request #29: Add Getters for IBANValidator's RegexValidator its patterns URL: https://github.com/apache/commons-validator/pull/29 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [commons-validator] garydgregory closed pull request #115: add IBAN Validator for Djibouti DJ as listed in iban-registry.pdf ...

2023-01-16 Thread GitBox
garydgregory closed pull request #115: add IBAN Validator for Djibouti DJ as listed in iban-registry.pdf ... URL: https://github.com/apache/commons-validator/pull/115 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [commons-validator] garydgregory commented on pull request #115: add IBAN Validator for Djibouti DJ as listed in iban-registry.pdf ...

2023-01-16 Thread GitBox
garydgregory commented on PR #115: URL: https://github.com/apache/commons-validator/pull/115#issuecomment-1384298175 Done in git master with another PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [commons-validator] garydgregory merged pull request #88: Adding new countries to IBAN list

2023-01-16 Thread GitBox
garydgregory merged PR #88: URL: https://github.com/apache/commons-validator/pull/88 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [commons-validator] codecov-commenter commented on pull request #115: add IBAN Validator for Djibouti DJ as listed in iban-registry.pdf ...

2023-01-16 Thread GitBox
codecov-commenter commented on PR #115: URL: https://github.com/apache/commons-validator/pull/115#issuecomment-1384292310 #

[GitHub] [commons-validator] homebeaver opened a new pull request, #115: add IBAN Validator for Djibouti DJ as listed in iban-registry.pdf ...

2023-01-16 Thread GitBox
homebeaver opened a new pull request, #115: URL: https://github.com/apache/commons-validator/pull/115 ... Release 92 – May 2022 see https://issues.apache.org/jira/browse/VALIDATOR-486 Hi @garydgregory this is the validator for DJ regards EUGen -- This is an automated

[GitHub] [commons-validator] garydgregory commented on pull request #88: Adding new countries to IBAN list

2023-01-16 Thread GitBox
garydgregory commented on PR #88: URL: https://github.com/apache/commons-validator/pull/88#issuecomment-1384288061 @tatiana-scda FYI, I resolved the conflict. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [commons-parent] garydgregory merged pull request #207: Bump maven-surefire-plugin from 3.0.0-M7 to 3.0.0-M8

2023-01-16 Thread GitBox
garydgregory merged PR #207: URL: https://github.com/apache/commons-parent/pull/207 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [commons-net] mawiesne commented on a diff in pull request #141: Fixes many grammar issues and typos in JavaDoc and code comments

2023-01-16 Thread GitBox
mawiesne commented on code in PR #141: URL: https://github.com/apache/commons-net/pull/141#discussion_r1070935486 ## src/main/java/org/apache/commons/net/ftp/parser/UnixFTPEntryParser.java: ## @@ -110,7 +110,7 @@ public class UnixFTPEntryParser extends

[GitHub] [commons-net] mawiesne commented on a diff in pull request #141: Fixes many grammar issues and typos in JavaDoc and code comments

2023-01-15 Thread GitBox
mawiesne commented on code in PR #141: URL: https://github.com/apache/commons-net/pull/141#discussion_r1070928496 ## src/main/java/org/apache/commons/net/ftp/FTPSClient.java: ## @@ -204,7 +204,7 @@ public FTPSClient(final String protocol, final boolean isImplicit) { /**

[GitHub] [commons-net] mawiesne commented on a diff in pull request #141: Fixes many grammar issues and typos in JavaDoc and code comments

2023-01-15 Thread GitBox
mawiesne commented on code in PR #141: URL: https://github.com/apache/commons-net/pull/141#discussion_r1070914027 ## src/main/java/org/apache/commons/net/nntp/NNTPClient.java: ## @@ -268,9 +268,9 @@ public Iterable iterateArticleInfo(final long lowArticleNumber, final l }

[GitHub] [commons-email] dependabot[bot] closed pull request #132: Bump maven-checkstyle-plugin from 3.2.0 to 3.2.1

2023-01-15 Thread GitBox
dependabot[bot] closed pull request #132: Bump maven-checkstyle-plugin from 3.2.0 to 3.2.1 URL: https://github.com/apache/commons-email/pull/132 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [commons-email] dependabot[bot] commented on pull request #132: Bump maven-checkstyle-plugin from 3.2.0 to 3.2.1

2023-01-15 Thread GitBox
dependabot[bot] commented on PR #132: URL: https://github.com/apache/commons-email/pull/132#issuecomment-1383348229 Looks like org.apache.maven.plugins:maven-checkstyle-plugin is up-to-date now, so this is no longer needed. -- This is an automated message from the Apache Git Service. To

[GitHub] [commons-imaging] Glavo commented on pull request #254: [IMAGING-339] Basic WebP Support

2023-01-15 Thread GitBox
Glavo commented on PR #254: URL: https://github.com/apache/commons-imaging/pull/254#issuecomment-1383319953 I updated this PR, added the `@since` tag and more detailed javadoc. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [commons-jcs] garydgregory merged pull request #132: Bump actions/cache from 3.2.2 to 3.2.3

2023-01-15 Thread GitBox
garydgregory merged PR #132: URL: https://github.com/apache/commons-jcs/pull/132 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [commons-scxml] dependabot[bot] opened a new pull request, #104: Bump Saxon-HE from 11.4 to 12.0

2023-01-15 Thread GitBox
dependabot[bot] opened a new pull request, #104: URL: https://github.com/apache/commons-scxml/pull/104 Bumps Saxon-HE from 11.4 to 12.0. [![Dependabot compatibility

[GitHub] [commons-jexl] henrib merged pull request #158: Bump maven-checkstyle-plugin from 3.2.0 to 3.2.1

2023-01-15 Thread GitBox
henrib merged PR #158: URL: https://github.com/apache/commons-jexl/pull/158 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [commons-io] menscikov commented on pull request #377: IO-769: FileUtils copyDirectory() should not use COPY_ATTRIBUTES

2023-01-15 Thread GitBox
menscikov commented on PR #377: URL: https://github.com/apache/commons-io/pull/377#issuecomment-1383174106 Hello, `FileUtils.copyInputStreamToFile()` has the same issue starting from **2.9** version. Please fix it also. -- This is an automated message from the Apache Git Service. To

[GitHub] [commons-net] garydgregory commented on a diff in pull request #141: Fixes many grammar issues and typos in JavaDoc and code comments

2023-01-15 Thread GitBox
garydgregory commented on code in PR #141: URL: https://github.com/apache/commons-net/pull/141#discussion_r1070608034 ## src/main/java/org/apache/commons/net/ftp/parser/UnixFTPEntryParser.java: ## @@ -110,7 +110,7 @@ public class UnixFTPEntryParser extends

[GitHub] [commons-imaging] Glavo commented on pull request #269: [IMAGING-340] Support PNG extension

2023-01-15 Thread GitBox
Glavo commented on PR #269: URL: https://github.com/apache/commons-imaging/pull/269#issuecomment-1383153151 The javadoc has been updated to add the `@since` tag. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [commons-imaging] kinow commented on a diff in pull request #269: [IMAGING-340] Support PNG extension

2023-01-15 Thread GitBox
kinow commented on code in PR #269: URL: https://github.com/apache/commons-imaging/pull/269#discussion_r1070592972 ## src/main/java/org/apache/commons/imaging/formats/png/package-info.java: ## @@ -16,7 +16,14 @@ */ /** - * The PNG image format. + * The PNG (Portable

[GitHub] [commons-net] sebbASF commented on a diff in pull request #141: Fixes many grammar issues and typos in JavaDoc and code comments

2023-01-15 Thread GitBox
sebbASF commented on code in PR #141: URL: https://github.com/apache/commons-net/pull/141#discussion_r1070583181 ## src/main/java/org/apache/commons/net/ftp/parser/UnixFTPEntryParser.java: ## @@ -110,7 +110,7 @@ public class UnixFTPEntryParser extends

[GitHub] [commons-net] sebbASF commented on a diff in pull request #141: Fixes many grammar issues and typos in JavaDoc and code comments

2023-01-15 Thread GitBox
sebbASF commented on code in PR #141: URL: https://github.com/apache/commons-net/pull/141#discussion_r1070574537 ## src/main/java/org/apache/commons/net/ftp/FTPSClient.java: ## @@ -375,7 +375,7 @@ public int execADAT(final byte[] data) throws IOException { /** * AUTH

[GitHub] [commons-net] garydgregory commented on a diff in pull request #141: Fixes many grammar issues and typos in JavaDoc and code comments

2023-01-15 Thread GitBox
garydgregory commented on code in PR #141: URL: https://github.com/apache/commons-net/pull/141#discussion_r1070581110 ## src/main/java/org/apache/commons/net/ftp/parser/UnixFTPEntryParser.java: ## @@ -110,7 +110,7 @@ public class UnixFTPEntryParser extends

[GitHub] [commons-net] garydgregory commented on pull request #141: Fixes many grammar issues and typos in JavaDoc and code comments

2023-01-15 Thread GitBox
garydgregory commented on PR #141: URL: https://github.com/apache/commons-net/pull/141#issuecomment-1383139388 Up to you. When you are done with edits here, I will review the PR again (hopefully for the last time). -- This is an automated message from the Apache Git Service. To respond

[GitHub] [commons-net] mawiesne commented on a diff in pull request #141: Fixes many grammar issues and typos in JavaDoc and code comments

2023-01-15 Thread GitBox
mawiesne commented on code in PR #141: URL: https://github.com/apache/commons-net/pull/141#discussion_r1070580668 ## src/main/java/org/apache/commons/net/ftp/parser/UnixFTPEntryParser.java: ## @@ -110,7 +110,7 @@ public class UnixFTPEntryParser extends

[GitHub] [commons-net] garydgregory commented on a diff in pull request #141: Fixes many grammar issues and typos in JavaDoc and code comments

2023-01-15 Thread GitBox
garydgregory commented on code in PR #141: URL: https://github.com/apache/commons-net/pull/141#discussion_r1070580429 ## src/main/java/org/apache/commons/net/ftp/parser/UnixFTPEntryParser.java: ## @@ -110,7 +110,7 @@ public class UnixFTPEntryParser extends

[GitHub] [commons-imaging] Glavo commented on pull request #269: [IMAGING-340] Support PNG extension

2023-01-14 Thread GitBox
Glavo commented on PR #269: URL: https://github.com/apache/commons-imaging/pull/269#issuecomment-1383022457 I updated this PR, followed the requirements of IMAGING-341, and recorded the standard version in the document. Can someone review this PR? -- This is an automated message

[GitHub] [commons-net] garydgregory commented on a diff in pull request #141: Fixes many grammar issues and typos in JavaDoc and code comments

2023-01-14 Thread GitBox
garydgregory commented on code in PR #141: URL: https://github.com/apache/commons-net/pull/141#discussion_r1070441477 ## src/main/java/org/apache/commons/net/ftp/FTPSClient.java: ## @@ -204,7 +204,7 @@ public FTPSClient(final String protocol, final boolean isImplicit) {

[GitHub] [commons-net] mawiesne commented on a diff in pull request #141: Fixes many grammar issues and typos in JavaDoc and code comments

2023-01-14 Thread GitBox
mawiesne commented on code in PR #141: URL: https://github.com/apache/commons-net/pull/141#discussion_r1070427636 ## src/main/java/org/apache/commons/net/ftp/FTPSClient.java: ## @@ -204,7 +204,7 @@ public FTPSClient(final String protocol, final boolean isImplicit) { /**

[GitHub] [commons-crypto] garydgregory merged pull request #209: Bump jna from 5.12.1 to 5.13.0

2023-01-14 Thread GitBox
garydgregory merged PR #209: URL: https://github.com/apache/commons-crypto/pull/209 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [commons-crypto] dependabot[bot] closed pull request #208: Bump maven-checkstyle-plugin from 3.2.0 to 3.2.1

2023-01-14 Thread GitBox
dependabot[bot] closed pull request #208: Bump maven-checkstyle-plugin from 3.2.0 to 3.2.1 URL: https://github.com/apache/commons-crypto/pull/208 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [commons-crypto] dependabot[bot] commented on pull request #208: Bump maven-checkstyle-plugin from 3.2.0 to 3.2.1

2023-01-14 Thread GitBox
dependabot[bot] commented on PR #208: URL: https://github.com/apache/commons-crypto/pull/208#issuecomment-1382914839 Looks like org.apache.maven.plugins:maven-checkstyle-plugin is up-to-date now, so this is no longer needed. -- This is an automated message from the Apache Git Service. To

[GitHub] [commons-dbutils] dependabot[bot] closed pull request #175: Bump spotbugs-maven-plugin from 4.4.2 to 4.7.3.0

2023-01-14 Thread GitBox
dependabot[bot] closed pull request #175: Bump spotbugs-maven-plugin from 4.4.2 to 4.7.3.0 URL: https://github.com/apache/commons-dbutils/pull/175 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [commons-dbutils] dependabot[bot] closed pull request #174: Bump spotbugs from 4.2.3 to 4.7.3

2023-01-14 Thread GitBox
dependabot[bot] closed pull request #174: Bump spotbugs from 4.2.3 to 4.7.3 URL: https://github.com/apache/commons-dbutils/pull/174 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [commons-dbutils] dependabot[bot] commented on pull request #175: Bump spotbugs-maven-plugin from 4.4.2 to 4.7.3.0

2023-01-14 Thread GitBox
dependabot[bot] commented on PR #175: URL: https://github.com/apache/commons-dbutils/pull/175#issuecomment-1382903964 Looks like com.github.spotbugs:spotbugs-maven-plugin is up-to-date now, so this is no longer needed. -- This is an automated message from the Apache Git Service. To

[GitHub] [commons-dbutils] dependabot[bot] commented on pull request #174: Bump spotbugs from 4.2.3 to 4.7.3

2023-01-14 Thread GitBox
dependabot[bot] commented on PR #174: URL: https://github.com/apache/commons-dbutils/pull/174#issuecomment-1382903961 Looks like com.github.spotbugs:spotbugs is up-to-date now, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [commons-crypto] codecov-commenter commented on pull request #209: Bump jna from 5.12.1 to 5.13.0

2023-01-14 Thread GitBox
codecov-commenter commented on PR #209: URL: https://github.com/apache/commons-crypto/pull/209#issuecomment-1382901707 #

[GitHub] [commons-crypto] dependabot[bot] opened a new pull request, #209: Bump jna from 5.12.1 to 5.13.0

2023-01-14 Thread GitBox
dependabot[bot] opened a new pull request, #209: URL: https://github.com/apache/commons-crypto/pull/209 Bumps [jna](https://github.com/java-native-access/jna) from 5.12.1 to 5.13.0. Changelog Sourced from https://github.com/java-native-access/jna/blob/master/CHANGES.md;>jna's

[GitHub] [commons-net] garydgregory commented on a diff in pull request #141: Fixes many grammar issues and typos in JavaDoc and code comments

2023-01-14 Thread GitBox
garydgregory commented on code in PR #141: URL: https://github.com/apache/commons-net/pull/141#discussion_r1070388783 ## src/main/java/org/apache/commons/net/ftp/FTPSClient.java: ## @@ -204,7 +204,7 @@ public FTPSClient(final String protocol, final boolean isImplicit) {

[GitHub] [commons-net] garydgregory commented on a diff in pull request #141: Fixes many grammar issues and typos in JavaDoc and code comments

2023-01-14 Thread GitBox
garydgregory commented on code in PR #141: URL: https://github.com/apache/commons-net/pull/141#discussion_r1070388783 ## src/main/java/org/apache/commons/net/ftp/FTPSClient.java: ## @@ -204,7 +204,7 @@ public FTPSClient(final String protocol, final boolean isImplicit) {

[GitHub] [commons-net] garydgregory commented on a diff in pull request #141: Fixes many grammar issues and typos in JavaDoc and code comments

2023-01-14 Thread GitBox
garydgregory commented on code in PR #141: URL: https://github.com/apache/commons-net/pull/141#discussion_r1070388572 ## src/main/java/org/apache/commons/net/nntp/NNTPClient.java: ## @@ -583,12 +583,12 @@ private void parseArticlePointer(final String reply, final ArticleInfo

[GitHub] [commons-vfs] garydgregory commented on pull request #368: Bump mockito-core from 4.11.0 to 5.0.0

2023-01-14 Thread GitBox
garydgregory commented on PR #368: URL: https://github.com/apache/commons-vfs/pull/368#issuecomment-1382751568 Mockito 5 requires Java 11. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [commons-vfs] garydgregory merged pull request #369: Bump httpcore5 from 5.1.5 to 5.2.1

2023-01-14 Thread GitBox
garydgregory merged PR #369: URL: https://github.com/apache/commons-vfs/pull/369 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [commons-vfs] dependabot[bot] opened a new pull request, #369: Bump httpcore5 from 5.1.5 to 5.2.1

2023-01-14 Thread GitBox
dependabot[bot] opened a new pull request, #369: URL: https://github.com/apache/commons-vfs/pull/369 Bumps [httpcore5](https://github.com/apache/httpcomponents-core) from 5.1.5 to 5.2.1. Changelog Sourced from

[GitHub] [commons-vfs] dependabot[bot] opened a new pull request, #368: Bump mockito-core from 4.11.0 to 5.0.0

2023-01-14 Thread GitBox
dependabot[bot] opened a new pull request, #368: URL: https://github.com/apache/commons-vfs/pull/368 Bumps [mockito-core](https://github.com/mockito/mockito) from 4.11.0 to 5.0.0. Release notes Sourced from https://github.com/mockito/mockito/releases;>mockito-core's releases.

[GitHub] [commons-vfs] garydgregory commented on pull request #88: Fix for failed test cases when running with root

2023-01-14 Thread GitBox
garydgregory commented on PR #88: URL: https://github.com/apache/commons-vfs/pull/88#issuecomment-1382740720 Closing, no reply in months. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

  1   2   3   4   5   6   7   8   9   10   >