[GitHub] commons-lang pull request: random length strings within range

2016-05-08 Thread PascalSchumacher
Github user PascalSchumacher commented on the pull request: https://github.com/apache/commons-lang/pull/101#issuecomment-217720683 I still think these methods should be added to commons-lang. They are a very useful extensions of RandomStringUtils feature set. I created https

[GitHub] commons-lang pull request: Add tests for some missed branches in S...

2016-05-08 Thread PascalSchumacher
Github user PascalSchumacher commented on the pull request: https://github.com/apache/commons-lang/pull/135#issuecomment-217714266 Thanks! :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] commons-lang pull request: [LANG-1205] NumberUtils.createNumber() ...

2016-05-08 Thread PascalSchumacher
Github user PascalSchumacher commented on the pull request: https://github.com/apache/commons-lang/pull/130#issuecomment-217714251 Thanks! :+1: Commit has been merged: https://github.com/apache/commons-lang/commit/b877fb9abef4a19eec9cc7329acbd433648b8f7b --- If your project is set

[GitHub] commons-lang pull request: LANG-781 Added methods to ObjectUtils c...

2016-05-08 Thread PascalSchumacher
Github user PascalSchumacher commented on the pull request: https://github.com/apache/commons-lang/pull/108#issuecomment-217712963 @vanta It would be nice if you could update the pull request according to garys comments. Thanks! --- If your project is set up for it, you can

[GitHub] commons-lang pull request: Fix some typos in Javadoc

2016-05-08 Thread PascalSchumacher
Github user PascalSchumacher commented on the pull request: https://github.com/apache/commons-lang/pull/134#issuecomment-217709083 Thanks! :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] commons-lang pull request: Adding to StringUtils truncate method a...

2016-05-08 Thread PascalSchumacher
Github user PascalSchumacher commented on a diff in the pull request: https://github.com/apache/commons-lang/pull/137#discussion_r62429807 --- Diff: src/main/java/org/apache/commons/lang3/StringUtils.java --- @@ -460,6 +460,108 @@ public static String trimToEmpty(final String str

[GitHub] commons-lang pull request: Adding unwrap and unwrapFull methods to...

2016-05-08 Thread PascalSchumacher
Github user PascalSchumacher commented on a diff in the pull request: https://github.com/apache/commons-lang/pull/136#discussion_r62429812 --- Diff: src/main/java/org/apache/commons/lang3/StringUtils.java --- @@ -8471,4 +8471,384 @@ public static String wrap(final String str, final

[GitHub] commons-lang pull request: LANG-1184: StringUtils#normalizeSpace n...

2016-04-24 Thread PascalSchumacher
Github user PascalSchumacher commented on the pull request: https://github.com/apache/commons-lang/pull/113#issuecomment-213900174 Hi all, an comments? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] commons-lang pull request:

2016-04-24 Thread PascalSchumacher
Github user PascalSchumacher commented on the pull request: https://github.com/apache/commons-lang/commit/b877fb9abef4a19eec9cc7329acbd433648b8f7b#commitcomment-17226478 Hi Chas, just wanted to let you know if you remove the "github" part e.g. "closes #87&qu

[GitHub] commons-lang pull request: LANG-1184: StringUtils#normalizeSpace n...

2016-01-26 Thread PascalSchumacher
Github user PascalSchumacher commented on the pull request: https://github.com/apache/commons-lang/pull/113#issuecomment-175231559 Hi Gary, 3.0 had the same behavior as 3.3.2, but I guess this is not a productive discussion. I know that `Character.isWhitespace

[GitHub] commons-lang pull request: LANG-1184: StringUtils#normalizeSpace n...

2016-01-17 Thread PascalSchumacher
Github user PascalSchumacher commented on the pull request: https://github.com/apache/commons-lang/pull/113#issuecomment-172354689 @garydgregory @hen Thanks for the reviews. :) As mentioned in the jira issue the goal of this pull request is not to add anything, but to restore

[GitHub] commons-lang pull request: LANG-1184: StringUtils#normalizeSpace n...

2016-01-17 Thread PascalSchumacher
Github user PascalSchumacher commented on the pull request: https://github.com/apache/commons-lang/pull/113#issuecomment-172357021 @hen Thanks again for the in-depth review. Part of the is `isEmpty()` is necessary, because `normalizeSpace` has to return `null` for `null

[GitHub] commons-lang pull request: LANG-1182: adding clarifying examples t...

2015-11-08 Thread PascalSchumacher
GitHub user PascalSchumacher opened a pull request: https://github.com/apache/commons-lang/pull/114 LANG-1182: adding clarifying examples to StringUtils#containsAny javadoc as suggested by Larry West in https://issues.apache.org/jira/browse/LANG-1182 You can merge this pull

[GitHub] commons-lang pull request: LANG-1184: StringUtils#normalizeSpace n...

2015-11-06 Thread PascalSchumacher
GitHub user PascalSchumacher opened a pull request: https://github.com/apache/commons-lang/pull/113 LANG-1184: StringUtils#normalizeSpace no longer normalizes unicode no… …n-breaking spaces (\u00A0) and does not trim control chars at the end anymore https

[GitHub] commons-lang pull request:

2015-11-05 Thread PascalSchumacher
Github user PascalSchumacher commented on the pull request: https://github.com/apache/commons-lang/commit/b1762bd557c3d7605490e026bdf31096d83b4dde#commitcomment-14219204 In src/main/java/org/apache/commons/lang3/StringUtils.java: In src/main/java/org/apache/commons/lang3

[GitHub] commons-lang pull request:

2015-11-05 Thread PascalSchumacher
Github user PascalSchumacher commented on the pull request: https://github.com/apache/commons-lang/commit/b1762bd557c3d7605490e026bdf31096d83b4dde#commitcomment-14219353 Just noticed that * is pseudo code used in a lot of StringUtils javadoc code, so please ignore my previous

[GitHub] commons-lang pull request:

2015-11-05 Thread PascalSchumacher
Github user PascalSchumacher commented on the pull request: https://github.com/apache/commons-lang/commit/b4842f559f0d8b8b5a98a19b1f3795a42c1a2614#commitcomment-14219356 Just noticed that * is pseudo code used in a lot of StringUtils javadoc code, so please ignore my previous

[GitHub] commons-lang pull request:

2015-11-05 Thread PascalSchumacher
Github user PascalSchumacher commented on the pull request: https://github.com/apache/commons-lang/commit/b4842f559f0d8b8b5a98a19b1f3795a42c1a2614#commitcomment-14219121 In src/main/java/org/apache/commons/lang3/StringUtils.java: In src/main/java/org/apache/commons/lang3

[GitHub] commons-lang pull request:

2015-11-05 Thread PascalSchumacher
Github user PascalSchumacher commented on the pull request: https://github.com/apache/commons-lang/commit/b4842f559f0d8b8b5a98a19b1f3795a42c1a2614#commitcomment-14219136 In src/main/java/org/apache/commons/lang3/StringUtils.java: In src/main/java/org/apache/commons/lang3

[GitHub] commons-lang pull request:

2015-11-05 Thread PascalSchumacher
Github user PascalSchumacher commented on the pull request: https://github.com/apache/commons-lang/commit/b1762bd557c3d7605490e026bdf31096d83b4dde#commitcomment-14219185 In src/main/java/org/apache/commons/lang3/StringUtils.java: In src/main/java/org/apache/commons/lang3

[GitHub] commons-lang pull request:

2015-11-05 Thread PascalSchumacher
Github user PascalSchumacher commented on the pull request: https://github.com/apache/commons-lang/commit/b1762bd557c3d7605490e026bdf31096d83b4dde#commitcomment-14219178 In src/main/java/org/apache/commons/lang3/StringUtils.java: In src/main/java/org/apache/commons/lang3

[GitHub] commons-lang pull request:

2015-11-05 Thread PascalSchumacher
Github user PascalSchumacher commented on the pull request: https://github.com/apache/commons-lang/commit/b1762bd557c3d7605490e026bdf31096d83b4dde#commitcomment-14219231 In src/main/java/org/apache/commons/lang3/StringUtils.java: In src/main/java/org/apache/commons/lang3

[GitHub] commons-lang pull request: random length strings within range

2015-11-04 Thread PascalSchumacher
Github user PascalSchumacher commented on the pull request: https://github.com/apache/commons-lang/pull/101#issuecomment-153893954 +1 I would like to use these methods :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] commons-lang pull request: remove compiler warnings from ThreadUti...

2015-05-07 Thread PascalSchumacher
Github user PascalSchumacher commented on the pull request: https://github.com/apache/commons-lang/pull/83#issuecomment-99986258 Thanks for merging! :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] commons-lang pull request: remove compiler warnings of joinWith te...

2015-05-07 Thread PascalSchumacher
Github user PascalSchumacher commented on the pull request: https://github.com/apache/commons-lang/pull/82#issuecomment-99986308 Thanks for merging! :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] commons-lang pull request: @SuppressWarnings(deprecation) to joi...

2015-05-07 Thread PascalSchumacher
Github user PascalSchumacher commented on the pull request: https://github.com/apache/commons-lang/pull/84#issuecomment-99986254 Thanks for merging! :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] commons-lang pull request: remove compiler warnings from ThreadUti...

2015-05-07 Thread PascalSchumacher
Github user PascalSchumacher commented on a diff in the pull request: https://github.com/apache/commons-lang/pull/83#discussion_r29869592 --- Diff: src/main/java/org/apache/commons/lang3/ThreadUtils.java --- @@ -292,12 +292,12 @@ private AlwaysTruePredicate

[GitHub] commons-lang pull request: @SuppressWarnings(deprecation) to joi...

2015-05-06 Thread PascalSchumacher
Github user PascalSchumacher commented on a diff in the pull request: https://github.com/apache/commons-lang/pull/84#discussion_r29793834 --- Diff: src/main/java/org/apache/commons/lang3/StringUtils.java --- @@ -4196,7 +4196,8 @@ public static String join(final Iterable? iterable

[GitHub] commons-lang pull request: remove compiler warnings from ThreadUti...

2015-05-05 Thread PascalSchumacher
GitHub user PascalSchumacher opened a pull request: https://github.com/apache/commons-lang/pull/83 remove compiler warnings from ThreadUtils You can merge this pull request into a Git repository by running: $ git pull https://github.com/PascalSchumacher/commons-lang

[GitHub] commons-lang pull request: remove compiler warnings of joinWith te...

2015-05-05 Thread PascalSchumacher
GitHub user PascalSchumacher opened a pull request: https://github.com/apache/commons-lang/pull/82 remove compiler warnings of joinWith tests You can merge this pull request into a Git repository by running: $ git pull https://github.com/PascalSchumacher/commons-lang

[GitHub] commons-lang pull request: @SuppressWarnings(deprecation) to joi...

2015-05-05 Thread PascalSchumacher
GitHub user PascalSchumacher opened a pull request: https://github.com/apache/commons-lang/pull/84 @SuppressWarnings(deprecation) to joinWith, because it uses the deprecated ObjectUtils.toString(Object) method (which is o.k. to use as long as commons-lang3 does not require java

<    1   2   3   4