[GitHub] commons-lang issue #182: Add maven dependency for JMH framework.

Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-lang/pull/182 Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] commons-lang issue #182: Add maven dependency for JMH framework.

Github user C0rWin commented on the issue: https://github.com/apache/commons-lang/pull/182 I'm fine with it, will add the test from LANG-1110. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] commons-lang issue #182: Add maven dependency for JMH framework.

Github user kinow commented on the issue: https://github.com/apache/commons-lang/pull/182 @C0rWin what about trying to add the test from [LANG-1110](https://issues.apache.org/jira/browse/LANG-1110) to the pull request? Look at the attachments section. --- If your project is set up

[GitHub] commons-lang issue #182: Add maven dependency for JMH framework.

Github user C0rWin commented on the issue: https://github.com/apache/commons-lang/pull/182 Actually once this one will be in, I have a few tests based on JMH which I can push. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] commons-lang issue #182: Add maven dependency for JMH framework.

Github user C0rWin commented on the issue: https://github.com/apache/commons-lang/pull/182 I'd guess it fails since there is no JMH tests available in the project, so it fails to execute them. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] commons-lang issue #182: Add maven dependency for JMH framework.

Github user kinow commented on the issue: https://github.com/apache/commons-lang/pull/182 Tried running the following to test the pull request: ``` $ mvn clean install $ mvn test -Pbenchmark -e -X ``` And it kept failing with: ``` [INFO] BUILD

[GitHub] commons-lang issue #182: Add maven dependency for JMH framework.

Github user kinow commented on the issue: https://github.com/apache/commons-lang/pull/182 Oh, missed that one, will take a look today to compare with [csv]. I've never seen it failing in Jenkins or Travis CI, but I suspect it is run manually, whenever someone needs to work on

[GitHub] commons-lang issue #182: Add maven dependency for JMH framework.

Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-lang/pull/182 As far as I can tell @C0rWin updated the pull request 9 days ago (after your conversation). By the way merging this only makes sense if commons lang actually uses JHM. Do you

[GitHub] commons-lang issue #182: Add maven dependency for JMH framework.

Github user kinow commented on the issue: https://github.com/apache/commons-lang/pull/182 I was waiting for @C0rWin to update the pull request, to have an approach similar to what we have in other commons projects. If he has updated it, then +1 to merging (or maybe check with

[GitHub] commons-lang issue #182: Add maven dependency for JMH framework.

Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-lang/pull/182 I guess this is ready to merge? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] commons-lang issue #182: Add maven dependency for JMH framework.

Github user coveralls commented on the issue: https://github.com/apache/commons-lang/pull/182 [](https://coveralls.io/builds/10113778) Coverage remained the same at 94.536% when pulling

[GitHub] commons-lang issue #182: Add maven dependency for JMH framework.

Github user C0rWin commented on the issue: https://github.com/apache/commons-lang/pull/182 Hi Bruno, On Sun, Feb 12, 2017 at 6:35 AM, Bruno P. Kinoshita < notificati...@github.com> wrote: > Hi @C0rWin > > Some time ago I

[GitHub] commons-lang issue #182: Add maven dependency for JMH framework.

Github user kinow commented on the issue: https://github.com/apache/commons-lang/pull/182 Hi @C0rWin Some time ago I found this pull request and had to learn what was JMH :-) added a comment on [LANG-1110](https://issues.apache.org/jira/browse/LANG-1110), and today had

[GitHub] commons-lang issue #182: Add maven dependency for JMH framework.

Github user C0rWin commented on the issue: https://github.com/apache/commons-lang/pull/182 @PascalSchumacher As far as I know coverage could be reduced only if I've added new code which is not tested or not covered by existing tests. --- If your project is set up for it, you can

[GitHub] commons-lang issue #182: Add maven dependency for JMH framework.

Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-lang/pull/182 @C0rWin The OpenJDK 7 Build did not finish: https://travis-ci.org/apache/commons-lang/jobs/151969189 maybe that caused the change. Or there is a random element in the existing test?

[GitHub] commons-lang issue #182: Add maven dependency for JMH framework.

Github user C0rWin commented on the issue: https://github.com/apache/commons-lang/pull/182 No Java code was involved in this PR, how that possible coverage reduced? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] commons-lang issue #182: Add maven dependency for JMH framework.

Github user coveralls commented on the issue: https://github.com/apache/commons-lang/pull/182 [](https://coveralls.io/builds/7432683) Coverage decreased (-0.02%) to 93.413% when pulling