[GitHub] commons-lang issue #298: Add an instanceof test in the implementation of equ...

2017-10-09 Thread BruceKuiLiu
Github user BruceKuiLiu commented on the issue: https://github.com/apache/commons-lang/pull/298 I am sorry, I cannot provide any test cases. We found it is a potential vulnerability. ---

[GitHub] commons-lang issue #298: Add an instanceof test in the implementation of equ...

2017-10-09 Thread PascalSchumacher
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-lang/pull/298 The comment above the statement explains why it is done this way. In case this is merged the comment should be removed. ---

[GitHub] commons-lang issue #298: Add an instanceof test in the implementation of equ...

2017-10-09 Thread kinow
Github user kinow commented on the issue: https://github.com/apache/commons-lang/pull/298 I think it makes sense. Any chance to include a unit test to protect against regressions in the future? Thanks ---

[GitHub] commons-lang issue #298: Add an instanceof test in the implementation of equ...

2017-10-09 Thread coveralls
Github user coveralls commented on the issue: https://github.com/apache/commons-lang/pull/298 [![Coverage Status](https://coveralls.io/builds/13636221/badge)](https://coveralls.io/builds/13636221) Coverage remained the same at 95.213% when pulling