[GitHub] commons-lang issue #313: LANG-1060: NumberUtils.isNumber assumes number star...

2018-02-11 Thread PascalSchumacher
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-lang/pull/313 Sure, that is fine! ---

[GitHub] commons-lang issue #313: LANG-1060: NumberUtils.isNumber assumes number star...

2018-02-11 Thread piotrkosyoo
Github user piotrkosyoo commented on the issue: https://github.com/apache/commons-lang/pull/313 ok in this same issue number ? ---

[GitHub] commons-lang issue #313: LANG-1060: NumberUtils.isNumber assumes number star...

2018-02-11 Thread PascalSchumacher
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-lang/pull/313 A pull request with tests for the `float` case would be welcome. ---

[GitHub] commons-lang issue #313: LANG-1060: NumberUtils.isNumber assumes number star...

2018-02-11 Thread piotrkosyoo
Github user piotrkosyoo commented on the issue: https://github.com/apache/commons-lang/pull/313 No problem Sir, Calling Number.to Float also works correctly, and I skip this point. but maybe better is add the tests for this case? ---

[GitHub] commons-lang issue #313: LANG-1060: NumberUtils.isNumber assumes number star...

2018-02-11 Thread PascalSchumacher
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-lang/pull/313 Thanks! 👍 ---