[GitHub] commons-lang issue #354: Convert tests for Validate.isTrue overloads to @Nes...

2018-09-06 Thread britter
Github user britter commented on the issue: https://github.com/apache/commons-lang/pull/354 Build failure seems to be unrelated. ---

[GitHub] commons-lang issue #354: Convert tests for Validate.isTrue overloads to @Nes...

2018-09-06 Thread britter
Github user britter commented on the issue: https://github.com/apache/commons-lang/pull/354 Okay, as there is positive feedback for this change, I'm going to migrate the whole `ValidateTest` to this style and then merge it 👍 ---

[GitHub] commons-lang issue #354: Convert tests for Validate.isTrue overloads to @Nes...

2018-09-05 Thread PascalSchumacher
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-lang/pull/354 +1 ---

[GitHub] commons-lang issue #354: Convert tests for Validate.isTrue overloads to @Nes...

2018-09-05 Thread coveralls
Github user coveralls commented on the issue: https://github.com/apache/commons-lang/pull/354 [![Coverage Status](https://coveralls.io/builds/18838060/badge)](https://coveralls.io/builds/18838060) Coverage remained the same at 95.253% when pulling

[GitHub] commons-lang issue #354: Convert tests for Validate.isTrue overloads to @Nes...

2018-09-05 Thread britter
Github user britter commented on the issue: https://github.com/apache/commons-lang/pull/354 @kinow @PascalSchumacher @chtompki WDYT? ---