[
https://issues.apache.org/jira/browse/COMPRESS-380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16319873#comment-16319873
]
Dawid Weiss commented on COMPRESS-380:
--
I agree with you, Stefan. I was only talking about a buffer
[
https://issues.apache.org/jira/browse/COMPRESS-380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16319857#comment-16319857
]
Stefan Bodewig commented on COMPRESS-380:
-
There is an additional danger when we add buffering
[
https://issues.apache.org/jira/browse/COMPRESS-380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16319404#comment-16319404
]
Gary Gregory commented on COMPRESS-380:
---
+1
> Support for ENHANCED_DEFLATED (Deflate64) in ZIP
[
https://issues.apache.org/jira/browse/COMPRESS-380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16319085#comment-16319085
]
Dawid Weiss commented on COMPRESS-380:
--
I'll file another issue for this, I think it's worth an
[
https://issues.apache.org/jira/browse/COMPRESS-380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16319080#comment-16319080
]
Dawid Weiss commented on COMPRESS-380:
--
The thing is: I really like when the compiler makes it
[
https://issues.apache.org/jira/browse/COMPRESS-380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16318963#comment-16318963
]
Gary Gregory commented on COMPRESS-380:
---
Would adding a note the Javadoc of each of our stream
[
https://issues.apache.org/jira/browse/COMPRESS-380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16318920#comment-16318920
]
Dawid Weiss commented on COMPRESS-380:
--
Yeah... I bet there'll be lots of people (like me) who
[
https://issues.apache.org/jira/browse/COMPRESS-380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16318805#comment-16318805
]
Stefan Bodewig commented on COMPRESS-380:
-
We already recommend buffering input, I'd prefer to
[
https://issues.apache.org/jira/browse/COMPRESS-380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16318796#comment-16318796
]
Dawid Weiss commented on COMPRESS-380:
--
In fact, I just decompressed the whole 6 gig archive in
[
https://issues.apache.org/jira/browse/COMPRESS-380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16318790#comment-16318790
]
Dawid Weiss commented on COMPRESS-380:
--
Also... it's really bad if the input stream is not buffered
[
https://issues.apache.org/jira/browse/COMPRESS-380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16318776#comment-16318776
]
Dawid Weiss commented on COMPRESS-380:
--
Yup, much better.
{code}
before throughput: 826,371
[
https://issues.apache.org/jira/browse/COMPRESS-380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16318260#comment-16318260
]
Stefan Bodewig commented on COMPRESS-380:
-
Dawid, could you give commit 32d507b0 a try? I think
[
https://issues.apache.org/jira/browse/COMPRESS-380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16318101#comment-16318101
]
Stefan Bodewig commented on COMPRESS-380:
-
It is good that we've got an implementation that
[
https://issues.apache.org/jira/browse/COMPRESS-380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16317237#comment-16317237
]
Dawid Weiss commented on COMPRESS-380:
--
I just realized that a *lot* of data in that archive is
[
https://issues.apache.org/jira/browse/COMPRESS-380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16317203#comment-16317203
]
Dawid Weiss commented on COMPRESS-380:
--
Yup, I realize that. I wasn't trying to suggest to just
[
https://issues.apache.org/jira/browse/COMPRESS-380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16317187#comment-16317187
]
Gary Gregory commented on COMPRESS-380:
---
Note that your link points to code licensed under the MIT
[
https://issues.apache.org/jira/browse/COMPRESS-380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16317182#comment-16317182
]
Dawid Weiss commented on COMPRESS-380:
--
I've decompressed the entire ~6GB archive without any
[
https://issues.apache.org/jira/browse/COMPRESS-380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16316203#comment-16316203
]
Stefan Bodewig commented on COMPRESS-380:
-
I'm looking at the zlib infback9 files linked in the
[
https://issues.apache.org/jira/browse/COMPRESS-380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16316165#comment-16316165
]
Dawid Weiss commented on COMPRESS-380:
--
Sure, I'll experiment and if it shows any improvement, I'll
[
https://issues.apache.org/jira/browse/COMPRESS-380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16315885#comment-16315885
]
Stefan Bodewig commented on COMPRESS-380:
-
The C code contains even more checks, so I'd rather
[
https://issues.apache.org/jira/browse/COMPRESS-380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16315853#comment-16315853
]
Dawid Weiss commented on COMPRESS-380:
--
I'll check again once I get back home, thanks Stefan. I did
[
https://issues.apache.org/jira/browse/COMPRESS-380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16315732#comment-16315732
]
Stefan Bodewig commented on COMPRESS-380:
-
Thanks Dawid, the first part is what I fixed
[
https://issues.apache.org/jira/browse/COMPRESS-380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16315460#comment-16315460
]
Dawid Weiss commented on COMPRESS-380:
--
Hi Stefan. Seems to be this assertion causing this
[
https://issues.apache.org/jira/browse/COMPRESS-380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16315139#comment-16315139
]
Stefan Bodewig commented on COMPRESS-380:
-
It looks as if I have been able to at least fix this
[
https://issues.apache.org/jira/browse/COMPRESS-380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16315128#comment-16315128
]
Stefan Bodewig commented on COMPRESS-380:
-
Thanks a lot Dawid. With any luck the failing
[
https://issues.apache.org/jira/browse/COMPRESS-380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16314733#comment-16314733
]
Dawid Weiss commented on COMPRESS-380:
--
Just an additional comment -- the large archive's stats of
[
https://issues.apache.org/jira/browse/COMPRESS-380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16314726#comment-16314726
]
Dawid Weiss commented on COMPRESS-380:
--
I isolated a smaller example file that still fails at
[
https://issues.apache.org/jira/browse/COMPRESS-380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16314000#comment-16314000
]
Dawid Weiss commented on COMPRESS-380:
--
Ran a super-quick sanity check on a huge zip of my local
[
https://issues.apache.org/jira/browse/COMPRESS-380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313959#comment-16313959
]
Dawid Weiss commented on COMPRESS-380:
--
I'll take a look and run some tests over the weekend,
[
https://issues.apache.org/jira/browse/COMPRESS-380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313126#comment-16313126
]
Stefan Bodewig commented on COMPRESS-380:
-
I've changed some of the close logic so that the
[
https://issues.apache.org/jira/browse/COMPRESS-380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16312574#comment-16312574
]
Stefan Bodewig commented on COMPRESS-380:
-
Support for {{ZipArchiveInputStream}} is in now, but
[
https://issues.apache.org/jira/browse/COMPRESS-380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16312024#comment-16312024
]
Dawid Weiss commented on COMPRESS-380:
--
Looks good to me. I thought you'd just return 0 and be done
[
https://issues.apache.org/jira/browse/COMPRESS-380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16311543#comment-16311543
]
Stefan Bodewig commented on COMPRESS-380:
-
[
https://issues.apache.org/jira/browse/COMPRESS-380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16311128#comment-16311128
]
Dawid Weiss commented on COMPRESS-380:
--
Makes sense to me. Available must not block -- that's the
[
https://issues.apache.org/jira/browse/COMPRESS-380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16311099#comment-16311099
]
Stefan Bodewig commented on COMPRESS-380:
-
[~chalmagr84] I'd like to remove the
[
https://issues.apache.org/jira/browse/COMPRESS-380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16310990#comment-16310990
]
Stefan Bodewig commented on COMPRESS-380:
-
I've added a first testcase and it passes. The next
[
https://issues.apache.org/jira/browse/COMPRESS-380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16309708#comment-16309708
]
Stefan Bodewig commented on COMPRESS-380:
-
I've started to add the original patch the first
[
https://issues.apache.org/jira/browse/COMPRESS-380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16305358#comment-16305358
]
Stefan Bodewig commented on COMPRESS-380:
-
[~dawid.weiss] thanks!
[~chalmagr84] thanks again,
[
https://issues.apache.org/jira/browse/COMPRESS-380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16305215#comment-16305215
]
Stefan Bodewig commented on COMPRESS-380:
-
I just realized the patch only works for ZipFile and
[
https://issues.apache.org/jira/browse/COMPRESS-380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16305207#comment-16305207
]
Stefan Bodewig commented on COMPRESS-380:
-
[~dawid.weiss], great. I'm not surprised the streams
[
https://issues.apache.org/jira/browse/COMPRESS-380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16305196#comment-16305196
]
Stefan Bodewig commented on COMPRESS-380:
-
@chalmagr84 many thanks. I'm still comparing your
[
https://issues.apache.org/jira/browse/COMPRESS-380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16305188#comment-16305188
]
Stefan Bodewig commented on COMPRESS-380:
-
Is anybody of the people who voted for this issue
[
https://issues.apache.org/jira/browse/COMPRESS-380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16301745#comment-16301745
]
Stefan Bodewig commented on COMPRESS-380:
-
Many thanks [~chalmagr84] and sorry for the delay, I
[
https://issues.apache.org/jira/browse/COMPRESS-380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16289544#comment-16289544
]
Dawid Weiss commented on COMPRESS-380:
--
Unless it's some kind of vulnerability (which should be
[
https://issues.apache.org/jira/browse/COMPRESS-380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16289388#comment-16289388
]
Christian Marquez Grabia commented on COMPRESS-380:
---
[~dawid.weiss] Thanks for the
[
https://issues.apache.org/jira/browse/COMPRESS-380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16288026#comment-16288026
]
Dawid Weiss commented on COMPRESS-380:
--
I'm not a committer, but I looked at the patch and while I
[
https://issues.apache.org/jira/browse/COMPRESS-380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16286212#comment-16286212
]
Stefan Bodewig commented on COMPRESS-380:
-
[~chalmagr84] having "only" decompression support
[
https://issues.apache.org/jira/browse/COMPRESS-380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16275481#comment-16275481
]
Dawid Weiss commented on COMPRESS-380:
--
The workflow would be to provide a patch file (diff) or
[
https://issues.apache.org/jira/browse/COMPRESS-380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16254645#comment-16254645
]
Christian Marquez Grabia commented on COMPRESS-380:
---
I was able to handle
[
https://issues.apache.org/jira/browse/COMPRESS-380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16245322#comment-16245322
]
Stefan Bodewig commented on COMPRESS-380:
-
[~chalmagr84] I'm not aware of anybody actively
[
https://issues.apache.org/jira/browse/COMPRESS-380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16245003#comment-16245003
]
Christian Marquez Grabia commented on COMPRESS-380:
---
I have tried many other options
[
https://issues.apache.org/jira/browse/COMPRESS-380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15839531#comment-15839531
]
Dawid Weiss commented on COMPRESS-380:
--
Not necessarily bad wording -- I may be slow in the
[
https://issues.apache.org/jira/browse/COMPRESS-380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15839521#comment-15839521
]
Stefan Bodewig commented on COMPRESS-380:
-
Ah, bad wording.
No the JDK's zip package doesn't
[
https://issues.apache.org/jira/browse/COMPRESS-380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15839517#comment-15839517
]
Dawid Weiss commented on COMPRESS-380:
--
zip4j doesn't support DEFLATE64 either, just checked.
>
[
https://issues.apache.org/jira/browse/COMPRESS-380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15839507#comment-15839507
]
Dawid Weiss commented on COMPRESS-380:
--
bq. A pure Java DEFLATE64 will certainly be slower than the
[
https://issues.apache.org/jira/browse/COMPRESS-380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15839449#comment-15839449
]
Stefan Bodewig commented on COMPRESS-380:
-
Of course. I just wanted to leave a pointer for
[
https://issues.apache.org/jira/browse/COMPRESS-380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15838156#comment-15838156
]
Dawid Weiss commented on COMPRESS-380:
--
Thanks Stefan! I don't know if I'll have the time to look
[
https://issues.apache.org/jira/browse/COMPRESS-380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15838117#comment-15838117
]
Stefan Bodewig commented on COMPRESS-380:
-
Sounds like a good idea.
Anybody who wants to give
58 matches
Mail list logo
