[
https://issues.apache.org/jira/browse/CRYPTO-74?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15354555#comment-15354555
]
Dapeng Sun commented on CRYPTO-74:
--
Thank Sebb, committed to master
CRYPTO-74: Full class names make code
[
https://issues.apache.org/jira/browse/CRYPTO-74?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15353934#comment-15353934
]
Sebb commented on CRYPTO-74:
I think we can combine this with some of the ideas in CRYPTO-81:
Create an enum
[
https://issues.apache.org/jira/browse/CRYPTO-74?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15352719#comment-15352719
]
Sebb commented on CRYPTO-74:
OK, let's forget SPI here.
I think we still need to hide the implementation class
[
https://issues.apache.org/jira/browse/CRYPTO-74?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15352373#comment-15352373
]
Dapeng Sun commented on CRYPTO-74:
--
I don't think using SPI is much better than factory for CRYPTO, it
[
https://issues.apache.org/jira/browse/CRYPTO-74?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15349879#comment-15349879
]
Sebb commented on CRYPTO-74:
On further reflection, I'm not sure that SPI is worth the extra effort compared
[
https://issues.apache.org/jira/browse/CRYPTO-74?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15348130#comment-15348130
]
Sebb commented on CRYPTO-74:
That will break the API, so it's best to do it now.
In any case, the current API
[
https://issues.apache.org/jira/browse/CRYPTO-74?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15347831#comment-15347831
]
Dapeng Sun commented on CRYPTO-74:
--
if {{SPI only works if the implementations of CryptoRandom provide a
[
https://issues.apache.org/jira/browse/CRYPTO-74?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15346175#comment-15346175
]
Sebb commented on CRYPTO-74:
I've done a quick test.
SPI only works if the implementations of CryptoRandom
[
https://issues.apache.org/jira/browse/CRYPTO-74?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15346093#comment-15346093
]
Sebb commented on CRYPTO-74:
AIUI the custom provider needs to be provided in a separate jar with the file
[
https://issues.apache.org/jira/browse/CRYPTO-74?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15346088#comment-15346088
]
Sebb commented on CRYPTO-74:
Thanks, I think BSF uses that.
What about the annotation that you mentioned?
I
[
https://issues.apache.org/jira/browse/CRYPTO-74?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15346055#comment-15346055
]
Dapeng Sun commented on CRYPTO-74:
--
Thank Joery for your comments, it is very detail.
Sorry, I have a
[
https://issues.apache.org/jira/browse/CRYPTO-74?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15346012#comment-15346012
]
Joerg Schaible commented on CRYPTO-74:
--
SPI is a very old Java concept, it was part of the spec since
[
https://issues.apache.org/jira/browse/CRYPTO-74?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15345975#comment-15345975
]
Joerg Schaible commented on CRYPTO-74:
--
Sorry, but I don't understand this comment. SPI has nothing to
[
https://issues.apache.org/jira/browse/CRYPTO-74?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15345613#comment-15345613
]
Dapeng Sun commented on CRYPTO-74:
--
Thank Joerg for your suggestion, SPI may be not suitable for CRYPTO.
[
https://issues.apache.org/jira/browse/CRYPTO-74?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15345604#comment-15345604
]
Dapeng Sun commented on CRYPTO-74:
--
SGTM, will refactor the code with your suggestion.
> Full class names
[
https://issues.apache.org/jira/browse/CRYPTO-74?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15345414#comment-15345414
]
Sebb commented on CRYPTO-74:
That sounds a good idea. Do you have a pointer to any examples of this?
> Full
[
https://issues.apache.org/jira/browse/CRYPTO-74?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15344144#comment-15344144
]
Joerg Schaible commented on CRYPTO-74:
--
As alternative you might think about an annotation providing
[
https://issues.apache.org/jira/browse/CRYPTO-74?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15343912#comment-15343912
]
Sebb commented on CRYPTO-74:
Sorry, I overlooked that. Yes, that should work.
Though the code should probably
[
https://issues.apache.org/jira/browse/CRYPTO-74?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15343737#comment-15343737
]
Dapeng Sun commented on CRYPTO-74:
--
>>However the patch means that it is no longer possible to use
[
https://issues.apache.org/jira/browse/CRYPTO-74?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15341495#comment-15341495
]
Sebb commented on CRYPTO-74:
That's what I meant by using an alias for the provided implementations.
However
[
https://issues.apache.org/jira/browse/CRYPTO-74?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15341352#comment-15341352
]
Dapeng Sun commented on CRYPTO-74:
--
Hi Sebb, Do you think it is okay to refactor like this
21 matches
Mail list logo
