[jira] [Commented] (IO-486) FileUtils.readFileToString() can immediately return empty string if file length is zero

2015-11-09 Thread Viktor Isaev (JIRA)
[ https://issues.apache.org/jira/browse/IO-486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14996638#comment-14996638 ] Viktor Isaev commented on IO-486: - I'm not speaking against short-circuit in {{IOUtils.toByteArray()}} - I'm

[jira] [Commented] (IO-486) FileUtils.readFileToString() can immediately return empty string if file length is zero

2015-11-09 Thread Sebb (JIRA)
[ https://issues.apache.org/jira/browse/IO-486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14996681#comment-14996681 ] Sebb commented on IO-486: - I've just discovered https://issues.apache.org/jira/browse/IO-453 The code that uses

[jira] [Commented] (IO-486) FileUtils.readFileToString() can immediately return empty string if file length is zero

2015-11-09 Thread Viktor Isaev (JIRA)
[ https://issues.apache.org/jira/browse/IO-486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14996709#comment-14996709 ] Viktor Isaev commented on IO-486: - Great! Then, I guess, this can be closed too. Thanks a lot, Sebb! >

[jira] [Commented] (IO-486) FileUtils.readFileToString() can immediately return empty string if file length is zero

2015-11-09 Thread Sebb (JIRA)
[ https://issues.apache.org/jira/browse/IO-486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14996353#comment-14996353 ] Sebb commented on IO-486: - bq. Here we may as well miss data, if OS returns a file length less then the real data

[jira] [Commented] (IO-486) FileUtils.readFileToString() can immediately return empty string if file length is zero

2015-11-09 Thread Viktor Isaev (JIRA)
[ https://issues.apache.org/jira/browse/IO-486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14996199#comment-14996199 ] Viktor Isaev commented on IO-486: - OK, Sebb, I see your point. But then, if so,

[jira] [Commented] (IO-486) FileUtils.readFileToString() can immediately return empty string if file length is zero

2015-11-06 Thread Sebb (JIRA)
[ https://issues.apache.org/jira/browse/IO-486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14994042#comment-14994042 ] Sebb commented on IO-486: - I'm not sure that is safe. If the file is currently open and being updated, AFAIK some OSes