[jira] [Commented] (LANG-804) Redundant check for zero in HashCodeBuilder ctor

2013-09-27 Thread Benedikt Ritter (JIRA)
[ https://issues.apache.org/jira/browse/LANG-804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13779748#comment-13779748 ] Benedikt Ritter commented on LANG-804: -- {code} Benedikts-MacBook-Pro:lang bene$ svn ci

[jira] [Commented] (LANG-804) Redundant check for zero in HashCodeBuilder ctor

2013-09-04 Thread Allon Mureinik (JIRA)
[ https://issues.apache.org/jira/browse/LANG-804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13757502#comment-13757502 ] Allon Mureinik commented on LANG-804: - There are two issues here: The original issue -

[jira] [Commented] (LANG-804) Redundant check for zero in HashCodeBuilder ctor

2013-09-03 Thread Allon Mureinik (JIRA)
[ https://issues.apache.org/jira/browse/LANG-804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13756951#comment-13756951 ] Allon Mureinik commented on LANG-804: - There's nothing wrong with using negative params

[jira] [Commented] (LANG-804) Redundant check for zero in HashCodeBuilder ctor

2013-09-03 Thread Sebb (JIRA)
[ https://issues.apache.org/jira/browse/LANG-804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13756983#comment-13756983 ] Sebb commented on LANG-804: --- I think that's a slightly different consideration. These are

[jira] [Commented] (LANG-804) Redundant check for zero in HashCodeBuilder ctor

2013-04-20 Thread Thomas Neidhart (JIRA)
[ https://issues.apache.org/jira/browse/LANG-804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13637295#comment-13637295 ] Thomas Neidhart commented on LANG-804: -- We could change the error message to

[jira] [Commented] (LANG-804) Redundant check for zero in HashCodeBuilder ctor

2012-09-29 Thread Sebb (JIRA)
[ https://issues.apache.org/jira/browse/LANG-804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13466196#comment-13466196 ] Sebb commented on LANG-804: --- More to the point, perhaps the ctor should check for positive

[jira] [Commented] (LANG-804) Redundant check for zero in HashCodeBuilder ctor

2012-05-30 Thread Sebb (JIRA)
[ https://issues.apache.org/jira/browse/LANG-804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13286149#comment-13286149 ] Sebb commented on LANG-804: --- Huh? 0 % 2 does not result in / 0 error in the Java compilers I have

[jira] [Commented] (LANG-804) Redundant check for zero in HashCodeBuilder ctor

2012-05-29 Thread Gary D. Gregory (JIRA)
[ https://issues.apache.org/jira/browse/LANG-804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13285330#comment-13285330 ] Gary D. Gregory commented on LANG-804: -- If you remove the == 0 checks, you'd get a /