[
https://issues.apache.org/jira/browse/MATH-1381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16000664#comment-16000664
]
Gilles commented on MATH-1381:
--
Please do! Thanks to both for your work on this.
Refactoring/modularizing the
[
https://issues.apache.org/jira/browse/MATH-1381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16000422#comment-16000422
]
Bruno P. Kinoshita commented on MATH-1381:
--
Pull request looks good. Planning to merge the PR
[
https://issues.apache.org/jira/browse/MATH-1381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1538#comment-1538
]
Kexin Xie commented on MATH-1381:
-
Thanks, [~kinow]! I've updated
[
https://issues.apache.org/jira/browse/MATH-1381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15999838#comment-15999838
]
Bruno P. Kinoshita commented on MATH-1381:
--
Ooohh, makes sense, should have thought about looking
[
https://issues.apache.org/jira/browse/MATH-1381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15999795#comment-15999795
]
Gilles commented on MATH-1381:
--
Hi Bruno.
Thanks for your help.
But it's so sad that you had to spend time
[
https://issues.apache.org/jira/browse/MATH-1381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15999737#comment-15999737
]
Bruno P. Kinoshita commented on MATH-1381:
--
Agree with [~erans] on spending some more time
[
https://issues.apache.org/jira/browse/MATH-1381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15453154#comment-15453154
]
Kexin Xie commented on MATH-1381:
-
Hi [~erans], thanks for looking at the PR. I agree with you that this
[
https://issues.apache.org/jira/browse/MATH-1381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15451537#comment-15451537
]
Gilles commented on MATH-1381:
--
Having just looked at your proposed, I can't be sure that it fixes a potential
[
https://issues.apache.org/jira/browse/MATH-1381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15450960#comment-15450960
]
Kexin Xie commented on MATH-1381:
-
I have a fix in https://github.com/apache/commons-math/pull/43
>
