[jira] [Commented] (NET-619) SubnetUtils creates a binary netmask in a bad way

2017-03-02 Thread Makoto Sakaguchi (JIRA)
[ https://issues.apache.org/jira/browse/NET-619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15893069#comment-15893069 ] Makoto Sakaguchi commented on NET-619: -- I added the comments why the code uses a long rather than an

[jira] [Commented] (NET-619) SubnetUtils creates a binary netmask in a bad way

2017-03-02 Thread Sebb (JIRA)
[ https://issues.apache.org/jira/browse/NET-619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15892095#comment-15892095 ] Sebb commented on NET-619: -- bq. Nor is there any indication why the code uses a long rather than an int. >

[jira] [Commented] (NET-619) SubnetUtils creates a binary netmask in a bad way

2017-03-01 Thread Makoto Sakaguchi (JIRA)
[ https://issues.apache.org/jira/browse/NET-619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15891696#comment-15891696 ] Makoto Sakaguchi commented on NET-619: -- I improved the comments.

[jira] [Commented] (NET-619) SubnetUtils creates a binary netmask in a bad way

2017-03-01 Thread Sebb (JIRA)
[ https://issues.apache.org/jira/browse/NET-619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15891390#comment-15891390 ] Sebb commented on NET-619: -- Thanks, but the comments only say what the terms in the expression represent; they

[jira] [Commented] (NET-619) SubnetUtils creates a binary netmask in a bad way

2017-03-01 Thread Makoto Sakaguchi (JIRA)
[ https://issues.apache.org/jira/browse/NET-619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15891349#comment-15891349 ] Makoto Sakaguchi commented on NET-619: -- I added some comments to the suggestion.

[jira] [Commented] (NET-619) SubnetUtils creates a binary netmask in a bad way

2017-03-01 Thread Sebb (JIRA)
[ https://issues.apache.org/jira/browse/NET-619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15890458#comment-15890458 ] Sebb commented on NET-619: -- Whilst the original is not particularly clear, I'm not convinced that the suggested