[
https://issues.apache.org/jira/browse/DBCP-8?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12828070#action_12828070
]
Sebb commented on DBCP-8:
-
Latest patch looks good, except I'm not sure that CPDSConnectionFactory
[
https://issues.apache.org/jira/browse/DBCP-8?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12828140#action_12828140
]
Sebb commented on DBCP-8:
-
Just noticed a minor issue in the existing testChangePassword() methods:
In
[
https://issues.apache.org/jira/browse/DBCP-8?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12803843#action_12803843
]
Sebb commented on DBCP-8:
-
Seems to me that PerUserPoolDataSource could store the factory in the map,
[
https://issues.apache.org/jira/browse/DBCP-8?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12801941#action_12801941
]
Phil Steitz commented on DBCP-8:
I agree that the code could be modified to do what you are
[
https://issues.apache.org/jira/browse/DBCP-8?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12801949#action_12801949
]
Sebb commented on DBCP-8:
-
The same key is generated for both (foo,bar) and (foob,ar) in
[
https://issues.apache.org/jira/browse/DBCP-8?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12801647#action_12801647
]
Sebb commented on DBCP-8:
-
Seems to me that the only way that the code can know that the password has
[
https://issues.apache.org/jira/browse/DBCP-8?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12801655#action_12801655
]
Phil Steitz commented on DBCP-8:
You are describing one reasonable scenario. The code does not
[
https://issues.apache.org/jira/browse/DBCP-8?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12801656#action_12801656
]
Phil Steitz commented on DBCP-8:
To qualify my first statement above, after the patch the code
[
https://issues.apache.org/jira/browse/DBCP-8?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12801665#action_12801665
]
Sebb commented on DBCP-8:
-
Sorry, I see my previous comment was ambiguous.
What I meant was that the
