Re: [PR] CLI-324 Make adding OptionGroups and Options to existing Options easier [commons-cli]

2024-02-16 Thread via GitHub
garydgregory merged PR #230: URL: https://github.com/apache/commons-cli/pull/230 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] CLI-324 Make adding OptionGroups and Options to existing Options easier [commons-cli]

2024-02-16 Thread via GitHub
Claudenw commented on code in PR #230: URL: https://github.com/apache/commons-cli/pull/230#discussion_r1492652231 ## src/test/java/org/apache/commons/cli/OptionsTest.java: ## @@ -78,6 +79,26 @@ public void testGetOptionsGroups() { assertEquals(2,

Re: [PR] CLI-324 Make adding OptionGroups and Options to existing Options easier [commons-cli]

2024-02-15 Thread via GitHub
garydgregory commented on code in PR #230: URL: https://github.com/apache/commons-cli/pull/230#discussion_r1491174913 ## src/main/java/org/apache/commons/cli/Options.java: ## @@ -54,6 +54,18 @@ public class Options implements Serializable { /** A map of the option groups

Re: [PR] CLI-324 Make adding OptionGroups and Options to existing Options easier [commons-cli]

2024-02-15 Thread via GitHub
Claudenw commented on code in PR #230: URL: https://github.com/apache/commons-cli/pull/230#discussion_r1490712110 ## src/main/java/org/apache/commons/cli/Options.java: ## @@ -231,8 +243,9 @@ public OptionGroup getOptionGroup(final Option opt) { * Gets the OptionGroups

Re: [PR] CLI-324 Make adding OptionGroups and Options to existing Options easier [commons-cli]

2024-02-14 Thread via GitHub
garydgregory commented on code in PR #230: URL: https://github.com/apache/commons-cli/pull/230#discussion_r1489658135 ## src/main/java/org/apache/commons/cli/Options.java: ## @@ -231,8 +243,9 @@ public OptionGroup getOptionGroup(final Option opt) { * Gets the OptionGroups

Re: [PR] CLI-324 Make adding OptionGroups and Options to existing Options easier [commons-cli]

2024-02-08 Thread via GitHub
garydgregory commented on PR #230: URL: https://github.com/apache/commons-cli/pull/230#issuecomment-1934686417 @Claudenw Thank you for your PR. You must provide tests for new features and updates. -- This is an automated message from the Apache Git Service. To respond to the