garydgregory merged PR #232:
URL: https://github.com/apache/commons-beanutils/pull/232
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
doublep commented on PR #232:
URL:
https://github.com/apache/commons-beanutils/pull/232#issuecomment-2131229026
@garydgregory I just pushed some Javadoc changes. Feel free to rewrite or
adjust as you prefer, easier this way than negotiating in advance.
--
This is an automated message
garydgregory commented on PR #232:
URL:
https://github.com/apache/commons-beanutils/pull/232#issuecomment-2129429158
@doublep Do you want to update the Javadoc as part of this PR or a separate
PR?
--
This is an automated message from the Apache Git Service.
To respond to the message,
doublep commented on PR #232:
URL:
https://github.com/apache/commons-beanutils/pull/232#issuecomment-2129000279
I'd say keep all four `getReadMethod()` and `getWriteMethod()` overloads
public. As these method names are very common, searching in publicly available
code doesn't yield useful
garydgregory commented on PR #232:
URL:
https://github.com/apache/commons-beanutils/pull/232#issuecomment-2127934355
@doublep
We can break BC in a major release like 2.0.0. The question really is: What
is the best design? WDYT?
--
This is an automated message from the Apache Git
doublep commented on PR #232:
URL:
https://github.com/apache/commons-beanutils/pull/232#issuecomment-2043202797
I just checked the source code history and this is the commit where
`getWriteMethod(Class, PropertyDescriptor)` was made public:
8f77bd63 [BEANUTILS-456] Provide
doublep commented on PR #232:
URL:
https://github.com/apache/commons-beanutils/pull/232#issuecomment-2042372937
For consistency with getWriteMethod(Class, PropertyDesciptor). But I don't
mind if it is made protected, just not package-private as now.
Paul
On Mon, 8 Apr 2024
garydgregory commented on PR #232:
URL:
https://github.com/apache/commons-beanutils/pull/232#issuecomment-2042363716
If you intend to use it in a subclass, why is it public and not protected?
--
This is an automated message from the Apache Git Service.
To respond to the message, please
