garydgregory commented on PR #480:
URL: https://github.com/apache/commons-compress/pull/480#issuecomment-1937102315
> @garydgregory very good catch! fixed now normally. On the builder point I
had the same thought and I think it is maybe worth to not expose all
constructors (package scope?)
rmannibucau commented on PR #480:
URL: https://github.com/apache/commons-compress/pull/480#issuecomment-1937101399
@garydgregory very good catch! fixed now normally. On the builder point I
had the same thought and I think it is maybe worth to not expose all
constructors (package scope?)
rmannibucau commented on code in PR #480:
URL: https://github.com/apache/commons-compress/pull/480#discussion_r1485215496
##
src/main/java/org/apache/commons/compress/archivers/zip/ExtraFieldUtils.java:
##
@@ -113,24 +116,24 @@ public ZipExtraField onUnparseableExtraField(final
rmannibucau commented on code in PR #480:
URL: https://github.com/apache/commons-compress/pull/480#discussion_r1485215496
##
src/main/java/org/apache/commons/compress/archivers/zip/ExtraFieldUtils.java:
##
@@ -113,24 +116,24 @@ public ZipExtraField onUnparseableExtraField(final
garydgregory commented on code in PR #480:
URL: https://github.com/apache/commons-compress/pull/480#discussion_r1485214180
##
src/main/java/org/apache/commons/compress/archivers/zip/ExtraFieldUtils.java:
##
@@ -113,24 +116,24 @@ public ZipExtraField
rmannibucau commented on code in PR #480:
URL: https://github.com/apache/commons-compress/pull/480#discussion_r1485205287
##
src/main/java/org/apache/commons/compress/archivers/zip/ExtraFieldUtils.java:
##
@@ -379,11 +382,28 @@ public ZipExtraField onUnparseableExtraField(final
garydgregory commented on code in PR #480:
URL: https://github.com/apache/commons-compress/pull/480#discussion_r1485144279
##
src/main/java/org/apache/commons/compress/archivers/zip/ExtraFieldUtils.java:
##
@@ -379,11 +382,28 @@ public ZipExtraField
garydgregory commented on code in PR #480:
URL: https://github.com/apache/commons-compress/pull/480#discussion_r1485144279
##
src/main/java/org/apache/commons/compress/archivers/zip/ExtraFieldUtils.java:
##
@@ -379,11 +382,28 @@ public ZipExtraField
rmannibucau commented on code in PR #480:
URL: https://github.com/apache/commons-compress/pull/480#discussion_r1485036494
##
src/main/java/org/apache/commons/compress/archivers/zip/ExtraFieldUtils.java:
##
@@ -379,11 +382,28 @@ public ZipExtraField onUnparseableExtraField(final
garydgregory commented on code in PR #480:
URL: https://github.com/apache/commons-compress/pull/480#discussion_r1484812539
##
src/main/java/org/apache/commons/compress/archivers/zip/ExtraFieldUtils.java:
##
@@ -379,11 +382,28 @@ public ZipExtraField
10 matches
Mail list logo