garydgregory commented on PR #312:
URL: https://github.com/apache/commons-dbcp/pull/312#issuecomment-1971744646
@rmaucher
All issues have been addressed in git master.
TY!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
garydgregory closed pull request #312: Fix minor issues
URL: https://github.com/apache/commons-dbcp/pull/312
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
garydgregory commented on code in PR #312:
URL: https://github.com/apache/commons-dbcp/pull/312#discussion_r1508027928
##
src/main/java/org/apache/commons/dbcp2/managed/DataSourceXAConnectionFactory.java:
##
@@ -167,8 +167,8 @@ public Connection createConnection() throws
garydgregory commented on code in PR #312:
URL: https://github.com/apache/commons-dbcp/pull/312#discussion_r1507882853
##
src/main/java/org/apache/commons/dbcp2/managed/DataSourceXAConnectionFactory.java:
##
@@ -167,8 +167,8 @@ public Connection createConnection() throws
garydgregory commented on code in PR #312:
URL: https://github.com/apache/commons-dbcp/pull/312#discussion_r1507877935
##
src/main/java/org/apache/commons/dbcp2/cpdsadapter/PooledConnectionImpl.java:
##
@@ -333,7 +334,10 @@ protected PStmtKey createKey(final String sql, final
garydgregory commented on code in PR #312:
URL: https://github.com/apache/commons-dbcp/pull/312#discussion_r1507877548
##
src/main/java/org/apache/commons/dbcp2/BasicDataSourceFactory.java:
##
@@ -422,7 +422,7 @@ public Object getObjectInstance(final Object obj, final
Name
garydgregory commented on code in PR #312:
URL: https://github.com/apache/commons-dbcp/pull/312#discussion_r1368934365
##
src/main/java/org/apache/commons/dbcp2/BasicDataSourceFactory.java:
##
@@ -422,7 +422,7 @@ public Object getObjectInstance(final Object obj, final
Name
