[jira] [Commented] (CLI-120) equals and hashCode are incomplete
[ https://issues.apache.org/jira/browse/CLI-120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13149310#comment-13149310 ] Holger S. commented on CLI-120: --- Hello, I would like to implement the equals method for a few classes. I suggest to implement the methods strightforwardly by calling .equals on all members (or using == if primitive) and returning the ANDed result. Are there any classes where this approach might fail? Is it possible to implement the hashCode method for the other classes like in OptionImpl? I am not experienced in implementing hashCode so I am not sure, whether that approach is possible for all classes. This is a part of a lecture assignment, so I would be very grateful for quick responses :-) Regards, Holger equals and hashCode are incomplete -- Key: CLI-120 URL: https://issues.apache.org/jira/browse/CLI-120 Project: Commons CLI Issue Type: Improvement Components: CLI-2.x Reporter: Andrew Shirley Priority: Minor Fix For: 2.0 there are many classes with equals and hashCode implemented however there are also classes which don't. We need to be consistent and if we are using equals then we need to define it for all classes in the affected hierarchy. For example OptionImpl has an equals but ParentImpl which extends OptionImpl and has several new members doesn't. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (DBCP-370) Please Release Commons Dbcp 1.4.1
[ https://issues.apache.org/jira/browse/DBCP-370?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Phil Steitz closed DBCP-370. Resolution: Invalid Please don't take this as a rude response, but this should be a comment for the dev list, not an issue. Thanks for the feedback / nudge. Please Release Commons Dbcp 1.4.1 - Key: DBCP-370 URL: https://issues.apache.org/jira/browse/DBCP-370 Project: Commons Dbcp Issue Type: Improvement Affects Versions: 1.4.1 Reporter: Yudhi Widyatama Labels: maven Bugs like DBCP-333 causes problem when creating a project using Maven. Without a commons-dbcp 1.4.1 release, artifacts that could be downloaded from Maven repository is limited to 1.4, which still have the bug. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (POOL-192) GenericKeyedObjectPool: clear() clears the keyed pool but does not decrease the item counter
[ https://issues.apache.org/jira/browse/POOL-192?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Phil Steitz updated POOL-192: - Fix Version/s: 1.5.7 Thanks for reporting this. GenericKeyedObjectPool: clear() clears the keyed pool but does not decrease the item counter Key: POOL-192 URL: https://issues.apache.org/jira/browse/POOL-192 Project: Commons Pool Issue Type: Bug Affects Versions: 1.5.6 Reporter: Helge Dannenberg Fix For: 1.5.7 If function 'clear(Object key)' in GenericKeyedObjectPool is called onto a keyed pool, the ObjectQueue (= the keyed pool) is removed from the pool list. Its items are deleteded in the function 'destroy()' afterwards. But as the ObjectQueue is already removed, the itemcounter _totalInternalProcessing is never decreased. As a result of this bug the pool exhausts even if the pool is empty. The solution is to decrease the counter _totalInternalProcessing in 'destroy()' also if ObjectQueue in null. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (POOL-189) close() does not release threads blocked on borrowObject()
[ https://issues.apache.org/jira/browse/POOL-189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Phil Steitz updated POOL-189: - Fix Version/s: 1.5.7 Thanks for reporting this. close() does not release threads blocked on borrowObject() -- Key: POOL-189 URL: https://issues.apache.org/jira/browse/POOL-189 Project: Commons Pool Issue Type: Bug Affects Versions: 1.5.6 Environment: java 1.6.0_24 Reporter: Adrian Nistor Fix For: 1.5.7 Attachments: Test.java Hi, When I call close() and borrowObject() concurrently with no objects in the pool, close() will finish but borrowObject() is blocked forever. The documentation of close() mentions that borrowObject() should fail with IllegalStateException, so I would expect the waiting threads to throw IllegalStateException. I will attach a test that exposes this problem. For this test, the expected output is: 0 1 2 ... 4999 DONE But when the bug manifests (almost always for this test), the output is: 0 1 2 The test does not finish, it just gets stuck after printing several values. Is this a bug or am I reading the documentation wrongly? Is there a patch for this? Thanks! Adrian -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (POOL-190) Add API BaseObjectPool.isOpen()
[ https://issues.apache.org/jira/browse/POOL-190?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Phil Steitz updated POOL-190: - Fix Version/s: (was: 1.5.7) Removing 1.5.7 as this is an API change. Add API BaseObjectPool.isOpen() --- Key: POOL-190 URL: https://issues.apache.org/jira/browse/POOL-190 Project: Commons Pool Issue Type: New Feature Affects Versions: 1.5.6 Environment: Apache Maven 3.0.3 (r1075438; 2011-02-28 12:31:09-0500) Maven home: C:\Java\apache-maven-3.0.3\bin\.. Java version: 1.6.0_24, vendor: Sun Microsystems Inc. Java home: C:\Program Files\Java\jdk1.6.0_24\jre Default locale: en_US, platform encoding: Cp1252 OS name: windows 7, version: 6.1, arch: amd64, family: windows Reporter: Gary D. Gregory Fix For: 2.0 Attachments: isOpen.diff Add API BaseObjectPool.isOpen() -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (POOL-190) Add API BaseObjectPool.isOpen()
[ https://issues.apache.org/jira/browse/POOL-190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13149415#comment-13149415 ] Sebb commented on POOL-190: --- It may be an API change, but it is binary compatible as it just adds a method, so surely could does not require a major version bump? Add API BaseObjectPool.isOpen() --- Key: POOL-190 URL: https://issues.apache.org/jira/browse/POOL-190 Project: Commons Pool Issue Type: New Feature Affects Versions: 1.5.6 Environment: Apache Maven 3.0.3 (r1075438; 2011-02-28 12:31:09-0500) Maven home: C:\Java\apache-maven-3.0.3\bin\.. Java version: 1.6.0_24, vendor: Sun Microsystems Inc. Java home: C:\Program Files\Java\jdk1.6.0_24\jre Default locale: en_US, platform encoding: Cp1252 OS name: windows 7, version: 6.1, arch: amd64, family: windows Reporter: Gary D. Gregory Fix For: 2.0 Attachments: isOpen.diff Add API BaseObjectPool.isOpen() -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (POOL-190) Add API BaseObjectPool.isOpen()
[ https://issues.apache.org/jira/browse/POOL-190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13149417#comment-13149417 ] Phil Steitz commented on POOL-190: -- Not a major version bump, but not appropriate for a patch release. The 1.5.x releases from here on should be bug fix only. It may actually be best to close this as WONT_FIX because BOP has been removed from 2.0. Add API BaseObjectPool.isOpen() --- Key: POOL-190 URL: https://issues.apache.org/jira/browse/POOL-190 Project: Commons Pool Issue Type: New Feature Affects Versions: 1.5.6 Environment: Apache Maven 3.0.3 (r1075438; 2011-02-28 12:31:09-0500) Maven home: C:\Java\apache-maven-3.0.3\bin\.. Java version: 1.6.0_24, vendor: Sun Microsystems Inc. Java home: C:\Program Files\Java\jdk1.6.0_24\jre Default locale: en_US, platform encoding: Cp1252 OS name: windows 7, version: 6.1, arch: amd64, family: windows Reporter: Gary D. Gregory Fix For: 2.0 Attachments: isOpen.diff Add API BaseObjectPool.isOpen() -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
