[GitHub] commons-lang pull request #248: Longs

2017-03-04 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/commons-lang/pull/248 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] commons-lang issue #248: Longs

2017-03-04 Thread PascalSchumacher
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-lang/pull/248 Thanks! :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[jira] [Created] (NET-622) SubnetInfo#getCidrSignature - improve functions

2017-03-04 Thread Makoto Sakaguchi (JIRA)
Makoto Sakaguchi created NET-622: Summary: SubnetInfo#getCidrSignature - improve functions Key: NET-622 URL: https://issues.apache.org/jira/browse/NET-622 Project: Commons Net Issue Type:

[jira] [Updated] (NET-622) SubnetInfo#getCidrSignature - improve functions

2017-03-04 Thread Makoto Sakaguchi (JIRA)
[ https://issues.apache.org/jira/browse/NET-622?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Makoto Sakaguchi updated NET-622: - Description: The processing part of "netmask" is converted an integer to a string to an integer.

[jira] [Updated] (NET-622) SubnetInfo#getCidrSignature - improve functions

2017-03-04 Thread Makoto Sakaguchi (JIRA)
[ https://issues.apache.org/jira/browse/NET-622?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Makoto Sakaguchi updated NET-622: - Description: The processing part of "netmask" is converted an integer to a string to an integer.

[jira] [Updated] (NET-622) SubnetInfo#getCidrSignature - improve functions

2017-03-04 Thread Makoto Sakaguchi (JIRA)
[ https://issues.apache.org/jira/browse/NET-622?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Makoto Sakaguchi updated NET-622: - Description: The processing part of "netmask" is converted an integer to a string to an integer.

[jira] [Updated] (NET-622) SubnetInfo#getCidrSignature - improve functions

2017-03-04 Thread Makoto Sakaguchi (JIRA)
[ https://issues.apache.org/jira/browse/NET-622?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Makoto Sakaguchi updated NET-622: - Description: The processing part of "netmask" is converted an integer to a string to an integer.

[jira] [Updated] (NET-622) SubnetInfo#getCidrSignature - improve functions

2017-03-04 Thread Makoto Sakaguchi (JIRA)
[ https://issues.apache.org/jira/browse/NET-622?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Makoto Sakaguchi updated NET-622: - Description: The processing part of "netmask" is converted an integer to a string to an integer.

[jira] [Commented] (CONFIGURATION-653) ConfigurationUtils.dump and other methods should use ImmutableConfiguration

2017-03-04 Thread Oliver Heger (JIRA)
[ https://issues.apache.org/jira/browse/CONFIGURATION-653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15895709#comment-15895709 ] Oliver Heger commented on CONFIGURATION-653: I had a look at the patch and did some

[GitHub] commons-lang issue #248: Longs

2017-03-04 Thread PascalSchumacher
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-lang/pull/248 +1 to adding the check --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] commons-lang issue #248: Longs

2017-03-04 Thread mureinik
Github user mureinik commented on the issue: https://github.com/apache/commons-lang/pull/248 @PascalSchumacher Using uppercase L for long literals can also easily be enforced by checkstyle. Should I add this check, or would that be more of a nuisance than it's worth? --- If your

[jira] [Commented] (MATH-1405) Kolmogorov-Smirnov fixTies can set minDelta too small for jiggler to have significant effect

2017-03-04 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/MATH-1405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15895689#comment-15895689 ] Gilles commented on MATH-1405: -- Could you please review the following suggested changes to {{hasTies}},

[GitHub] commons-lang pull request #249: Checkstyle for long literals

2017-03-04 Thread mureinik
GitHub user mureinik opened a pull request: https://github.com/apache/commons-lang/pull/249 Checkstyle for long literals PR #248 corrected all the long literals to use the upper case L notation. This patch finishes the job as per the discussion there, and adds a

[GitHub] commons-lang issue #248: Longs

2017-03-04 Thread mureinik
Github user mureinik commented on the issue: https://github.com/apache/commons-lang/pull/248 @PascalSchumacher I posed PR #249 to do so, thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[jira] [Updated] (POOL-320) Use more efficient stack walking mechanisms for usage tracking

2017-03-04 Thread Matt Sicker (JIRA)
[ https://issues.apache.org/jira/browse/POOL-320?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Sicker updated POOL-320: - Assignee: Matt Sicker > Use more efficient stack walking mechanisms for usage tracking >

[jira] [Commented] (TEXT-70) Build failure with java 9-ea+159

2017-03-04 Thread Rob Tompkins (JIRA)
[ https://issues.apache.org/jira/browse/TEXT-70?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15895820#comment-15895820 ] Rob Tompkins commented on TEXT-70: -- This actually seems like it could be an issue with groovy's not being

[GitHub] commons-lang issue #248: Longs

2017-03-04 Thread coveralls
Github user coveralls commented on the issue: https://github.com/apache/commons-lang/pull/248 [![Coverage Status](https://coveralls.io/builds/10436584/badge)](https://coveralls.io/builds/10436584) Coverage increased (+0.04%) to 94.565% when pulling

[GitHub] commons-lang issue #248: Longs

2017-03-04 Thread coveralls
Github user coveralls commented on the issue: https://github.com/apache/commons-lang/pull/248 [![Coverage Status](https://coveralls.io/builds/10436584/badge)](https://coveralls.io/builds/10436584) Coverage increased (+0.04%) to 94.565% when pulling

[GitHub] commons-lang pull request #251: Lang1300: Change CharSequenceUtils to suppor...

2017-03-04 Thread MarkDacek
GitHub user MarkDacek opened a pull request: https://github.com/apache/commons-lang/pull/251 Lang1300: Change CharSequenceUtils to support supplementary characters @chtompki I'm tackling the root cause now. You can merge this pull request into a Git repository by running:

[jira] [Commented] (LANG-1300) Clarify or improve behaviour of int-based methods in StringUtils

2017-03-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/LANG-1300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15895900#comment-15895900 ] ASF GitHub Bot commented on LANG-1300: -- GitHub user MarkDacek opened a pull request:

[jira] [Closed] (POOL-320) Use more efficient stack walking mechanisms for usage tracking

2017-03-04 Thread Matt Sicker (JIRA)
[ https://issues.apache.org/jira/browse/POOL-320?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Sicker closed POOL-320. Resolution: Fixed Fix Version/s: 2.4.3 Added in subversion revision 1785520 in trunk. > Use more

[jira] [Commented] (LANG-1300) Clarify or improve behaviour of int-based methods in StringUtils

2017-03-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/LANG-1300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15895928#comment-15895928 ] ASF GitHub Bot commented on LANG-1300: -- Github user chtompki commented on the issue:

[GitHub] commons-lang issue #250: LANG-1300: Convert CharSequence to String for int-m...

2017-03-04 Thread chtompki
Github user chtompki commented on the issue: https://github.com/apache/commons-lang/pull/250 I'll give this a look this evening. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[jira] [Updated] (NET-623) SubnetUtils - fixed spelling errors

2017-03-04 Thread Makoto Sakaguchi (JIRA)
[ https://issues.apache.org/jira/browse/NET-623?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Makoto Sakaguchi updated NET-623: - Priority: Major (was: Trivial) > SubnetUtils - fixed spelling errors >

[jira] [Updated] (NET-623) SubnetUtils - fixed spelling errors

2017-03-04 Thread Makoto Sakaguchi (JIRA)
[ https://issues.apache.org/jira/browse/NET-623?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Makoto Sakaguchi updated NET-623: - Summary: SubnetUtils - fixed spelling errors (was: SubnetUtils - fixed spelling errors of the fixed

[jira] [Reopened] (POOL-320) Use more efficient stack walking mechanisms for usage tracking

2017-03-04 Thread Matt Sicker (JIRA)
[ https://issues.apache.org/jira/browse/POOL-320?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Sicker reopened POOL-320: -- Reopening to mark as resolved instead of closed as all other issues marked for 2.4.3 are only resolved. >

[jira] [Resolved] (POOL-320) Use more efficient stack walking mechanisms for usage tracking

2017-03-04 Thread Matt Sicker (JIRA)
[ https://issues.apache.org/jira/browse/POOL-320?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Sicker resolved POOL-320. -- Resolution: Fixed > Use more efficient stack walking mechanisms for usage tracking >

[GitHub] commons-lang pull request #250: LANG-1300: Convert CharSequence to String fo...

2017-03-04 Thread MarkDacek
GitHub user MarkDacek opened a pull request: https://github.com/apache/commons-lang/pull/250 LANG-1300: Convert CharSequence to String for int-methods in StringUtils @chtompki [https://issues.apache.org/jira/browse/LANG-1300](url) You can merge this pull request into a Git

[jira] [Commented] (LANG-1300) Clarify or improve behaviour of int-based methods in StringUtils

2017-03-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/LANG-1300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15896031#comment-15896031 ] ASF GitHub Bot commented on LANG-1300: -- Github user MarkDacek commented on the issue:

[GitHub] commons-lang issue #250: LANG-1300: Convert CharSequence to String for int-m...

2017-03-04 Thread MarkDacek
Github user MarkDacek commented on the issue: https://github.com/apache/commons-lang/pull/250 If this is too simplistic of a change, consider the minor change I did here. I based it off of the JDK implementation that handles supplementary characters.

[jira] [Created] (NET-623) SubnetUtils - improved comments

2017-03-04 Thread Makoto Sakaguchi (JIRA)
Makoto Sakaguchi created NET-623: Summary: SubnetUtils - improved comments Key: NET-623 URL: https://issues.apache.org/jira/browse/NET-623 Project: Commons Net Issue Type: Improvement

[jira] [Updated] (NET-623) SubnetUtils - fixed spelling errors

2017-03-04 Thread Makoto Sakaguchi (JIRA)
[ https://issues.apache.org/jira/browse/NET-623?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Makoto Sakaguchi updated NET-623: - Description: Fixed spelling errors in the API document. line 70: the hostcount -> the host count

[jira] [Commented] (LANG-1300) Clarify or improve behaviour of int-based methods in StringUtils

2017-03-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/LANG-1300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15896053#comment-15896053 ] ASF GitHub Bot commented on LANG-1300: -- Github user MarkDacek closed the pull request at:

[GitHub] commons-lang pull request #250: LANG-1300: Convert CharSequence to String fo...

2017-03-04 Thread MarkDacek
Github user MarkDacek closed the pull request at: https://github.com/apache/commons-lang/pull/250 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[jira] [Updated] (NET-623) SubnetUtils - fixed spelling errors of the fixed spelling errors

2017-03-04 Thread Makoto Sakaguchi (JIRA)
[ https://issues.apache.org/jira/browse/NET-623?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Makoto Sakaguchi updated NET-623: - Summary: SubnetUtils - fixed spelling errors of the fixed spelling errors (was: SubnetUtils - fixed

[jira] [Updated] (NET-623) SubnetUtils - fixed spelling errors of the fixed spelling errors of the API document

2017-03-04 Thread Makoto Sakaguchi (JIRA)
[ https://issues.apache.org/jira/browse/NET-623?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Makoto Sakaguchi updated NET-623: - Summary: SubnetUtils - fixed spelling errors of the fixed spelling errors of the API document (was:

[jira] [Updated] (NET-622) SubnetInfo#getCidrSignature - improve functions

2017-03-04 Thread Makoto Sakaguchi (JIRA)
[ https://issues.apache.org/jira/browse/NET-622?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Makoto Sakaguchi updated NET-622: - Description: The processing part of "netmask" is converted an integer to a string to an integer.