[GitHub] commons-lang issue #251: LANG-1300: Change CharSequenceUtils to support supp...

2017-03-09 Thread coveralls
Github user coveralls commented on the issue: https://github.com/apache/commons-lang/pull/251 [![Coverage Status](https://coveralls.io/builds/10513306/badge)](https://coveralls.io/builds/10513306) Coverage increased (+0.004%) to 94.54% when pulling

[jira] [Commented] (LANG-1300) Clarify or improve behaviour of int-based methods in StringUtils

2017-03-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/LANG-1300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15903340#comment-15903340 ] ASF GitHub Bot commented on LANG-1300: -- Github user coveralls commented on the issue:

[jira] [Commented] (LANG-1300) Clarify or improve behaviour of int-based methods in StringUtils

2017-03-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/LANG-1300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15903341#comment-15903341 ] ASF GitHub Bot commented on LANG-1300: -- Github user coveralls commented on the issue:

[GitHub] commons-lang issue #251: LANG-1300: Change CharSequenceUtils to support supp...

2017-03-09 Thread coveralls
Github user coveralls commented on the issue: https://github.com/apache/commons-lang/pull/251 [![Coverage Status](https://coveralls.io/builds/10513306/badge)](https://coveralls.io/builds/10513306) Coverage increased (+0.004%) to 94.54% when pulling

[GitHub] commons-lang issue #251: LANG-1300: Change CharSequenceUtils to support supp...

2017-03-09 Thread coveralls
Github user coveralls commented on the issue: https://github.com/apache/commons-lang/pull/251 [![Coverage Status](https://coveralls.io/builds/10513391/badge)](https://coveralls.io/builds/10513391) Coverage increased (+0.04%) to 94.576% when pulling

[jira] [Commented] (LANG-1300) Clarify or improve behaviour of int-based methods in StringUtils

2017-03-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/LANG-1300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15903350#comment-15903350 ] ASF GitHub Bot commented on LANG-1300: -- Github user coveralls commented on the issue:

[jira] [Updated] (NET-623) SubnetUtils - fixed spelling errors

2017-03-09 Thread Makoto Sakaguchi (JIRA)
[ https://issues.apache.org/jira/browse/NET-623?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Makoto Sakaguchi updated NET-623: - Description: Fixed spelling errors in the API document.

[GitHub] commons-lang pull request #231: Evaluate Architecure

2017-03-09 Thread sebbASF
Github user sebbASF commented on a diff in the pull request: https://github.com/apache/commons-lang/pull/231#discussion_r105178700 --- Diff: src/main/java/org/apache/commons/lang3/tuple/ArchUtilsImproved.java --- @@ -0,0 +1,400 @@ +package org.apache.commons.lang3.tuple; +

[GitHub] commons-lang issue #231: Evaluate Architecure

2017-03-09 Thread sebbASF
Github user sebbASF commented on the issue: https://github.com/apache/commons-lang/pull/231 The new design is more flexible. So one could add Endianness for example. [The code still does not check for duplicate values for the same key] However I'm not sure that the chosen

[jira] [Updated] (NET-624) SubnetInfo#toCidrNotation - allow a subnet mask

2017-03-09 Thread Makoto Sakaguchi (JIRA)
[ https://issues.apache.org/jira/browse/NET-624?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Makoto Sakaguchi updated NET-624: - Description: An IPv4 subnet mask, which is also the network mask, must consist of a set of

[GitHub] commons-lang pull request #253: Added a restart method for convenience

2017-03-09 Thread esend7881
GitHub user esend7881 opened a pull request: https://github.com/apache/commons-lang/pull/253 Added a restart method for convenience The restart function will allow lazy people like me to simple call `stopwatch.reset()` instead of manually calling the `stop`, `restart` `start`

[jira] [Commented] (IMAGING-199) All tEXt chunks are not returned from PngImageParser.getMetadata

2017-03-09 Thread Ric Emery (JIRA)
[ https://issues.apache.org/jira/browse/IMAGING-199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15904115#comment-15904115 ] Ric Emery commented on IMAGING-199: --- Submitted pull request in GitHub -

[jira] [Created] (NET-624) SubnetInfo#toCidrNotation - allow a subnet mask

2017-03-09 Thread Makoto Sakaguchi (JIRA)
Makoto Sakaguchi created NET-624: Summary: SubnetInfo#toCidrNotation - allow a subnet mask Key: NET-624 URL: https://issues.apache.org/jira/browse/NET-624 Project: Commons Net Issue Type:

[GitHub] commons-lang issue #251: LANG-1300: Change CharSequenceUtils to support supp...

2017-03-09 Thread dmjones500
Github user dmjones500 commented on the issue: https://github.com/apache/commons-lang/pull/251 We need to agree on the desired behaviour of the method. Based on the signature, I think we can adjust it to support supplementary characters without violating the implied contract of the

[jira] [Commented] (LANG-1300) Clarify or improve behaviour of int-based methods in StringUtils

2017-03-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/LANG-1300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15904594#comment-15904594 ] ASF GitHub Bot commented on LANG-1300: -- Github user dmjones500 commented on the issue:

[jira] [Updated] (NET-624) SubnetInfo#toCidrNotation: A wrong format subnet mask is allows.

2017-03-09 Thread Makoto Sakaguchi (JIRA)
[ https://issues.apache.org/jira/browse/NET-624?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Makoto Sakaguchi updated NET-624: - Summary: SubnetInfo#toCidrNotation: A wrong format subnet mask is allows. (was:

[jira] [Updated] (NET-624) SubnetInfo#toCidrNotation: a wrong format subnet mask is allows

2017-03-09 Thread Makoto Sakaguchi (JIRA)
[ https://issues.apache.org/jira/browse/NET-624?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Makoto Sakaguchi updated NET-624: - Summary: SubnetInfo#toCidrNotation: a wrong format subnet mask is allows (was:

[jira] [Updated] (NET-624) SubnetInfo#toCidrNotation: A wrong format subnet mask is allows

2017-03-09 Thread Makoto Sakaguchi (JIRA)
[ https://issues.apache.org/jira/browse/NET-624?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Makoto Sakaguchi updated NET-624: - Summary: SubnetInfo#toCidrNotation: A wrong format subnet mask is allows (was:

[jira] [Updated] (NET-624) SubnetInfo#toCidrNotation - a wrong format subnet mask is allows

2017-03-09 Thread Makoto Sakaguchi (JIRA)
[ https://issues.apache.org/jira/browse/NET-624?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Makoto Sakaguchi updated NET-624: - Summary: SubnetInfo#toCidrNotation - a wrong format subnet mask is allows (was:

[jira] [Updated] (NET-624) SubnetInfo#toCidrNotation - a wrong format subnet mask is allows

2017-03-09 Thread Makoto Sakaguchi (JIRA)
[ https://issues.apache.org/jira/browse/NET-624?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Makoto Sakaguchi updated NET-624: - Description: An IPv4 subnet mask, which is also the network mask, must consist of a set of

[jira] [Updated] (NET-624) SubnetInfo#toCidrNotation - a wrong format subnet mask is allows

2017-03-09 Thread Makoto Sakaguchi (JIRA)
[ https://issues.apache.org/jira/browse/NET-624?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Makoto Sakaguchi updated NET-624: - Flags: Patch > SubnetInfo#toCidrNotation - a wrong format subnet mask is allows >

[jira] [Updated] (NET-624) SubnetInfo#toCidrNotation - a wrong format subnet mask is allows

2017-03-09 Thread Makoto Sakaguchi (JIRA)
[ https://issues.apache.org/jira/browse/NET-624?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Makoto Sakaguchi updated NET-624: - Flags: (was: Patch) > SubnetInfo#toCidrNotation - a wrong format subnet mask is allows >

[jira] [Updated] (NET-624) SubnetInfo#toCidrNotation - a wrong format subnet mask is allows

2017-03-09 Thread Makoto Sakaguchi (JIRA)
[ https://issues.apache.org/jira/browse/NET-624?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Makoto Sakaguchi updated NET-624: - Description: An IPv4 subnet mask, which is also the network mask, must consist of a set of

[GitHub] commons-lang pull request #231: Evaluate Architecure

2017-03-09 Thread kinow
Github user kinow commented on a diff in the pull request: https://github.com/apache/commons-lang/pull/231#discussion_r105108009 --- Diff: src/main/java/org/apache/commons/lang3/ArchUtils.java --- @@ -0,0 +1,446 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] commons-lang pull request #231: Evaluate Architecure

2017-03-09 Thread kinow
Github user kinow commented on a diff in the pull request: https://github.com/apache/commons-lang/pull/231#discussion_r105108108 --- Diff: src/main/java/org/apache/commons/lang3/ArchUtils.java --- @@ -0,0 +1,446 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] commons-lang pull request #231: Evaluate Architecure

2017-03-09 Thread kinow
Github user kinow commented on a diff in the pull request: https://github.com/apache/commons-lang/pull/231#discussion_r105108206 --- Diff: src/main/java/org/apache/commons/lang3/ArchUtils.java --- @@ -0,0 +1,446 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] commons-lang pull request #231: Evaluate Architecure

2017-03-09 Thread kinow
Github user kinow commented on a diff in the pull request: https://github.com/apache/commons-lang/pull/231#discussion_r105106940 --- Diff: src/main/java/org/apache/commons/lang3/ArchUtils.java --- @@ -0,0 +1,446 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] commons-lang pull request #231: Evaluate Architecure

2017-03-09 Thread kinow
Github user kinow commented on a diff in the pull request: https://github.com/apache/commons-lang/pull/231#discussion_r105108179 --- Diff: src/main/java/org/apache/commons/lang3/ArchUtils.java --- @@ -0,0 +1,446 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] commons-lang pull request #231: Evaluate Architecure

2017-03-09 Thread kinow
Github user kinow commented on a diff in the pull request: https://github.com/apache/commons-lang/pull/231#discussion_r105108139 --- Diff: src/main/java/org/apache/commons/lang3/ArchUtils.java --- @@ -0,0 +1,446 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] commons-lang pull request #231: Evaluate Architecure

2017-03-09 Thread kinow
Github user kinow commented on a diff in the pull request: https://github.com/apache/commons-lang/pull/231#discussion_r105107852 --- Diff: src/main/java/org/apache/commons/lang3/ArchUtils.java --- @@ -0,0 +1,446 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] commons-lang pull request #231: Evaluate Architecure

2017-03-09 Thread kinow
Github user kinow commented on a diff in the pull request: https://github.com/apache/commons-lang/pull/231#discussion_r105107484 --- Diff: src/main/java/org/apache/commons/lang3/ArchUtils.java --- @@ -0,0 +1,446 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] commons-lang pull request #231: Evaluate Architecure

2017-03-09 Thread kinow
Github user kinow commented on a diff in the pull request: https://github.com/apache/commons-lang/pull/231#discussion_r105108059 --- Diff: src/main/java/org/apache/commons/lang3/ArchUtils.java --- @@ -0,0 +1,446 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] commons-lang pull request #231: Evaluate Architecure

2017-03-09 Thread kinow
Github user kinow commented on a diff in the pull request: https://github.com/apache/commons-lang/pull/231#discussion_r105108338 --- Diff: src/main/java/org/apache/commons/lang3/ArchUtils.java --- @@ -0,0 +1,446 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] commons-lang issue #231: Evaluate Architecure

2017-03-09 Thread sebbASF
Github user sebbASF commented on the issue: https://github.com/apache/commons-lang/pull/231 I wonder why the architecture String constants are not an enum? Also, the various addxxx() methods don't check if there is already an entry, so it's possible to overwrite an existing

[jira] [Resolved] (CLI-269) Introduce CommandLine.Builder

2017-03-09 Thread Benedikt Ritter (JIRA)
[ https://issues.apache.org/jira/browse/CLI-269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benedikt Ritter resolved CLI-269. - Resolution: Fixed > Introduce CommandLine.Builder > - > >

[jira] [Reopened] (CLI-269) Introduce CommandLine.Builder

2017-03-09 Thread Benedikt Ritter (JIRA)
[ https://issues.apache.org/jira/browse/CLI-269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benedikt Ritter reopened CLI-269: - Reopening this issue to set it to "fixed". We only close issues after their fix version has been

[GitHub] commons-lang issue #231: Evaluate Architecure

2017-03-09 Thread sebbASF
Github user sebbASF commented on the issue: https://github.com/apache/commons-lang/pull/231 If the code is not going to allow updates, then there is no need to use ConcurrentHashMap. If updates are allowed at run-time, there is the possibility that different results will be

[GitHub] commons-lang pull request #231: Evaluate Architecure

2017-03-09 Thread Tomschi
Github user Tomschi commented on a diff in the pull request: https://github.com/apache/commons-lang/pull/231#discussion_r105117588 --- Diff: src/main/java/org/apache/commons/lang3/ArchUtils.java --- @@ -0,0 +1,446 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] commons-lang pull request #231: Evaluate Architecure

2017-03-09 Thread kinow
Github user kinow commented on a diff in the pull request: https://github.com/apache/commons-lang/pull/231#discussion_r105108158 --- Diff: src/main/java/org/apache/commons/lang3/ArchUtils.java --- @@ -0,0 +1,446 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] commons-lang pull request #231: Evaluate Architecure

2017-03-09 Thread kinow
Github user kinow commented on a diff in the pull request: https://github.com/apache/commons-lang/pull/231#discussion_r105108037 --- Diff: src/main/java/org/apache/commons/lang3/ArchUtils.java --- @@ -0,0 +1,446 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] commons-lang pull request #231: Evaluate Architecure

2017-03-09 Thread kinow
Github user kinow commented on a diff in the pull request: https://github.com/apache/commons-lang/pull/231#discussion_r105108083 --- Diff: src/main/java/org/apache/commons/lang3/ArchUtils.java --- @@ -0,0 +1,446 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] commons-lang pull request #231: Evaluate Architecure

2017-03-09 Thread kinow
Github user kinow commented on a diff in the pull request: https://github.com/apache/commons-lang/pull/231#discussion_r105107714 --- Diff: src/main/java/org/apache/commons/lang3/ArchUtils.java --- @@ -0,0 +1,446 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[jira] [Commented] (LANG-1315) FastDateParser parse method parses without considering timezone

2017-03-09 Thread Sebb (JIRA)
[ https://issues.apache.org/jira/browse/LANG-1315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15902921#comment-15902921 ] Sebb commented on LANG-1315: The test case is hard to use as it's in two files buried deep in a file

[jira] [Resolved] (LANG-1315) FastDateParser parse method parses without considering timezone

2017-03-09 Thread Sebb (JIRA)
[ https://issues.apache.org/jira/browse/LANG-1315?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sebb resolved LANG-1315. Resolution: Cannot Reproduce > FastDateParser parse method parses without considering timezone >

[GitHub] commons-lang pull request #231: Evaluate Architecure

2017-03-09 Thread sebbASF
Github user sebbASF commented on a diff in the pull request: https://github.com/apache/commons-lang/pull/231#discussion_r105175128 --- Diff: src/main/java/org/apache/commons/lang3/arch/Processor.java --- @@ -0,0 +1,30 @@ +package org.apache.commons.lang3.arch; + +/**

[GitHub] commons-lang issue #231: Evaluate Architecure

2017-03-09 Thread Tomschi
Github user Tomschi commented on the issue: https://github.com/apache/commons-lang/pull/231 I have created a new class ArchUtilsImproved. @sebbASF This approach is more extendable. Is this implementation better for you? --- If your project is set up for it, you can reply to