[GitHub] [commons-io] coveralls commented on pull request #162: Bump junit-pioneer from 0.9.2 to 1.0.0

2020-10-07 Thread GitBox
coveralls commented on pull request #162: URL: https://github.com/apache/commons-io/pull/162#issuecomment-704717567 [![Coverage Status](https://coveralls.io/builds/33986333/badge)](https://coveralls.io/builds/33986333) Coverage decreased (-0.06%) to 89.471% when pulling

[GitHub] [commons-bcel] mureinik commented on a change in pull request #69: BCEL-343 Assertion improvement

2020-10-07 Thread GitBox
mureinik commented on a change in pull request #69: URL: https://github.com/apache/commons-bcel/pull/69#discussion_r500995547 ## File path: src/test/java/org/apache/bcel/EnclosingMethodAttributeTestCase.java ## @@ -89,8 +81,7 @@ public void testAttributeSerializtion() throws

[GitHub] [commons-bcel] mureinik commented on a change in pull request #69: BCEL-343 Assertion improvement

2020-10-07 Thread GitBox
mureinik commented on a change in pull request #69: URL: https://github.com/apache/commons-bcel/pull/69#discussion_r500995873 ## File path: src/test/java/org/apache/bcel/generic/FieldAnnotationsTestCase.java ## @@ -115,9 +115,7 @@ public void testFieldAnnotationModification()

[jira] [Commented] (BCEL-343) Improve assertions

2020-10-07 Thread Allon Mureinik (Jira)
[ https://issues.apache.org/jira/browse/BCEL-343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17209463#comment-17209463 ] Allon Mureinik commented on BCEL-343: - PR posted here: [https://github.com/apache/commons-bcel/pull/69]

[GitHub] [commons-bcel] garydgregory commented on a change in pull request #69: BCEL-343 Assertion improvement

2020-10-07 Thread GitBox
garydgregory commented on a change in pull request #69: URL: https://github.com/apache/commons-bcel/pull/69#discussion_r500974895 ## File path: src/test/java/org/apache/bcel/classfile/JDKClassDumpTestCase.java ## @@ -81,7 +80,8 @@ private void compare(final JavaClass jc, final

[GitHub] [commons-bcel] mureinik commented on a change in pull request #69: BCEL-343 Assertion improvement

2020-10-07 Thread GitBox
mureinik commented on a change in pull request #69: URL: https://github.com/apache/commons-bcel/pull/69#discussion_r500988579 ## File path: src/test/java/org/apache/bcel/classfile/JDKClassDumpTestCase.java ## @@ -81,7 +80,8 @@ private void compare(final JavaClass jc, final

[GitHub] [commons-bcel] mureinik commented on a change in pull request #69: BCEL-343 Assertion improvement

2020-10-07 Thread GitBox
mureinik commented on a change in pull request #69: URL: https://github.com/apache/commons-bcel/pull/69#discussion_r500988579 ## File path: src/test/java/org/apache/bcel/classfile/JDKClassDumpTestCase.java ## @@ -81,7 +80,8 @@ private void compare(final JavaClass jc, final

[GitHub] [commons-bcel] garydgregory commented on pull request #69: BCEL-343 Assertion improvement

2020-10-07 Thread GitBox
garydgregory commented on pull request #69: URL: https://github.com/apache/commons-bcel/pull/69#issuecomment-704908154 https://issues.apache.org/jira/browse/BCEL-343 This is an automated message from the Apache Git Service.

[GitHub] [commons-bcel] mureinik commented on a change in pull request #69: BCEL-343 Assertion improvement

2020-10-07 Thread GitBox
mureinik commented on a change in pull request #69: URL: https://github.com/apache/commons-bcel/pull/69#discussion_r500988579 ## File path: src/test/java/org/apache/bcel/classfile/JDKClassDumpTestCase.java ## @@ -81,7 +80,8 @@ private void compare(final JavaClass jc, final

[GitHub] [commons-bcel] mureinik commented on pull request #69: BCEL-343 Assertion improvement

2020-10-07 Thread GitBox
mureinik commented on pull request #69: URL: https://github.com/apache/commons-bcel/pull/69#issuecomment-704923986 @garydgregory Fixed the formatting issues and answered wrt the usage of `j` (see inline) This is an

[GitHub] [commons-bcel] mureinik opened a new pull request #69: BCEL-343 Assertion improvement

2020-10-07 Thread GitBox
mureinik opened a new pull request #69: URL: https://github.com/apache/commons-bcel/pull/69 As a followup to #68 (BCEL-342), now that the tests are migrated to JUnit Jupiter, it's a good opportunity to go over the assertions and clean them up. The main gain from this PR is improving the

[jira] [Created] (MATH-1555) Wrong declaration of ATan2 class

2020-10-07 Thread Laurent Galluccio (Jira)
Laurent Galluccio created MATH-1555: --- Summary: Wrong declaration of ATan2 class Key: MATH-1555 URL: https://issues.apache.org/jira/browse/MATH-1555 Project: Commons Math Issue Type: Bug

[GitHub] [commons-bcel] mureinik commented on a change in pull request #69: BCEL-343 Assertion improvement

2020-10-07 Thread GitBox
mureinik commented on a change in pull request #69: URL: https://github.com/apache/commons-bcel/pull/69#discussion_r500995426 ## File path: src/test/java/org/apache/bcel/generic/FieldAnnotationsTestCase.java ## @@ -139,38 +137,10 @@ public void checkAnnotatedField(final

[GitHub] [commons-bcel] mureinik commented on a change in pull request #69: BCEL-343 Assertion improvement

2020-10-07 Thread GitBox
mureinik commented on a change in pull request #69: URL: https://github.com/apache/commons-bcel/pull/69#discussion_r500995185 ## File path: src/test/java/org/apache/bcel/generic/GeneratingAnnotatedClassesTestCase.java ## @@ -352,16 +327,14 @@ public void

[jira] [Updated] (BCEL-343) Improve JUnit assertions

2020-10-07 Thread Gary D. Gregory (Jira)
[ https://issues.apache.org/jira/browse/BCEL-343?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory updated BCEL-343: - Summary: Improve JUnit assertions (was: Improve assertions) > Improve JUnit assertions >

[GitHub] [commons-vfs] vadimd02 commented on pull request #26: SMB v. 2 / 3 integration based on SMBJ

2020-10-07 Thread GitBox
vadimd02 commented on pull request #26: URL: https://github.com/apache/commons-vfs/pull/26#issuecomment-705008277 @ahbonsu @markt-asf - can you please advise if this planned to be merged ? This is an automated message from

[GitHub] [commons-bcel] mureinik edited a comment on pull request #69: BCEL-343 Assertion improvement

2020-10-07 Thread GitBox
mureinik edited a comment on pull request #69: URL: https://github.com/apache/commons-bcel/pull/69#issuecomment-704923986 @garydgregory Fixed the formatting issues and answered wrt the usage of `j` (see inline - left that comment unresolved for your decision)

[GitHub] [commons-bcel] garydgregory merged pull request #69: BCEL-343 JUnit Assertion improvement

2020-10-07 Thread GitBox
garydgregory merged pull request #69: URL: https://github.com/apache/commons-bcel/pull/69 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Resolved] (BCEL-343) Improve JUnit assertions

2020-10-07 Thread Gary D. Gregory (Jira)
[ https://issues.apache.org/jira/browse/BCEL-343?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory resolved BCEL-343. -- Fix Version/s: 6.5.1 Resolution: Fixed In git master; please verify git master and close

[jira] [Closed] (BCEL-343) Improve JUnit assertions

2020-10-07 Thread Allon Mureinik (Jira)
[ https://issues.apache.org/jira/browse/BCEL-343?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Allon Mureinik closed BCEL-343. --- > Improve JUnit assertions > > > Key: BCEL-343 >

[GitHub] [commons-bcel] garydgregory merged pull request #66: Bump actions/checkout from v2.3.2 to v2.3.3

2020-10-07 Thread GitBox
garydgregory merged pull request #66: URL: https://github.com/apache/commons-bcel/pull/66 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Commented] (BCEL-343) Improve JUnit assertions

2020-10-07 Thread Allon Mureinik (Jira)
[ https://issues.apache.org/jira/browse/BCEL-343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17209580#comment-17209580 ] Allon Mureinik commented on BCEL-343: - Verified, closing. > Improve JUnit assertions >

[GitHub] [commons-bcel] garydgregory merged pull request #67: Bump actions/setup-java from v1.4.2 to v1.4.3

2020-10-07 Thread GitBox
garydgregory merged pull request #67: URL: https://github.com/apache/commons-bcel/pull/67 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Created] (NET-690) Performance issue when using the FTPClient to retrieve files from z/OS and z/VM

2020-10-07 Thread Payal (Jira)
Payal created NET-690: - Summary: Performance issue when using the FTPClient to retrieve files from z/OS and z/VM Key: NET-690 URL: https://issues.apache.org/jira/browse/NET-690 Project: Commons Net

[GitHub] [commons-io] garydgregory merged pull request #162: Bump junit-pioneer from 0.9.2 to 1.0.0

2020-10-07 Thread GitBox
garydgregory merged pull request #162: URL: https://github.com/apache/commons-io/pull/162 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Commented] (NET-690) Performance issue when using the FTPClient to retrieve files from z/OS and z/VM

2020-10-07 Thread Gary D. Gregory (Jira)
[ https://issues.apache.org/jira/browse/NET-690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17209806#comment-17209806 ] Gary D. Gregory commented on NET-690: - Feel free to provide a PR on GitHub :-) > Performance issue when

[jira] [Updated] (NET-690) Performance issue when using the FTPClient to retrieve files from z/OS and z/VM

2020-10-07 Thread Gary D. Gregory (Jira)
[ https://issues.apache.org/jira/browse/NET-690?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory updated NET-690: Fix Version/s: (was: 3.7.2) > Performance issue when using the FTPClient to retrieve files from

[jira] [Work logged] (IMAGING-265) ArrayIndexOutOfBoundsException on reading simple GeoTIFF

2020-10-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/IMAGING-265?focusedWorklogId=497011=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-497011 ] ASF GitHub Bot logged work on IMAGING-265: -- Author: ASF GitHub Bot

[GitHub] [commons-imaging] gwlucastrig commented on pull request #98: [IMAGING-265] ArrayIndexOutOfBoundsException on reading simple GeoTIFF

2020-10-07 Thread GitBox
gwlucastrig commented on pull request #98: URL: https://github.com/apache/commons-imaging/pull/98#issuecomment-705252894 I believe this completes the work for Imaging-265. This is an automated message from the Apache Git

[jira] [Work logged] (IMAGING-265) ArrayIndexOutOfBoundsException on reading simple GeoTIFF

2020-10-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/IMAGING-265?focusedWorklogId=497067=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-497067 ] ASF GitHub Bot logged work on IMAGING-265: -- Author: ASF GitHub Bot

[GitHub] [commons-imaging] kinow commented on pull request #98: [IMAGING-265] ArrayIndexOutOfBoundsException on reading simple GeoTIFF

2020-10-07 Thread GitBox
kinow commented on pull request #98: URL: https://github.com/apache/commons-imaging/pull/98#issuecomment-705318187 Merged. Here's what I did to merge @gwlucastrig - checked out branch locally - added a commit with the `src/changes/changes.xml` entry for this issue - squashed

[jira] [Updated] (IMAGING-265) ArrayIndexOutOfBoundsException on reading simple GeoTIFF

2020-10-07 Thread Bruno P. Kinoshita (Jira)
[ https://issues.apache.org/jira/browse/IMAGING-265?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno P. Kinoshita updated IMAGING-265: --- Fix Version/s: 1.0-alpha3 > ArrayIndexOutOfBoundsException on reading simple

[jira] [Resolved] (IMAGING-265) ArrayIndexOutOfBoundsException on reading simple GeoTIFF

2020-10-07 Thread Bruno P. Kinoshita (Jira)
[ https://issues.apache.org/jira/browse/IMAGING-265?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno P. Kinoshita resolved IMAGING-265. Resolution: Fixed > ArrayIndexOutOfBoundsException on reading simple GeoTIFF >

[jira] [Commented] (IMAGING-265) ArrayIndexOutOfBoundsException on reading simple GeoTIFF

2020-10-07 Thread Bruno P. Kinoshita (Jira)
[ https://issues.apache.org/jira/browse/IMAGING-265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17209994#comment-17209994 ] Bruno P. Kinoshita commented on IMAGING-265: Fixed in master. Included in the changelog for

[jira] [Work logged] (IMAGING-265) ArrayIndexOutOfBoundsException on reading simple GeoTIFF

2020-10-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/IMAGING-265?focusedWorklogId=497066=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-497066 ] ASF GitHub Bot logged work on IMAGING-265: -- Author: ASF GitHub Bot

[GitHub] [commons-imaging] kinow closed pull request #98: [IMAGING-265] ArrayIndexOutOfBoundsException on reading simple GeoTIFF

2020-10-07 Thread GitBox
kinow closed pull request #98: URL: https://github.com/apache/commons-imaging/pull/98 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Work logged] (IMAGING-265) ArrayIndexOutOfBoundsException on reading simple GeoTIFF

2020-10-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/IMAGING-265?focusedWorklogId=497000=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-497000 ] ASF GitHub Bot logged work on IMAGING-265: -- Author: ASF GitHub Bot

[GitHub] [commons-imaging] coveralls edited a comment on pull request #98: [IMAGING-265] ArrayIndexOutOfBoundsException on reading simple GeoTIFF

2020-10-07 Thread GitBox
coveralls edited a comment on pull request #98: URL: https://github.com/apache/commons-imaging/pull/98#issuecomment-695154317 [![Coverage Status](https://coveralls.io/builds/34011743/badge)](https://coveralls.io/builds/34011743) Coverage increased (+0.06%) to 76.389% when

[jira] [Comment Edited] (IMAGING-201) Significant change in color of output image of tiff file

2020-10-07 Thread Gary Lucas (Jira)
[ https://issues.apache.org/jira/browse/IMAGING-201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17209933#comment-17209933 ] Gary Lucas edited comment on IMAGING-201 at 10/7/20, 11:53 PM: --- I

[jira] [Commented] (IMAGING-201) Significant change in color of output image of tiff file

2020-10-07 Thread Gary Lucas (Jira)
[ https://issues.apache.org/jira/browse/IMAGING-201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17209933#comment-17209933 ] Gary Lucas commented on IMAGING-201: In investigated this further and I have a solution based on the

[jira] [Updated] (IMAGING-201) Significant change in color of output image of tiff file

2020-10-07 Thread Gary Lucas (Jira)
[ https://issues.apache.org/jira/browse/IMAGING-201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Lucas updated IMAGING-201: --- Attachment: Imaging201_CustomPhotometricInterpreter.jpg > Significant change in color of output