garydgregory merged PR #465:
URL: https://github.com/apache/commons-vfs/pull/465
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
StefanOltmann opened a new pull request, #359:
URL: https://github.com/apache/commons-imaging/pull/359
I encountered a bug while testing the Kotlin Multiplatform port
(https://github.com/ashampoo/kim) of a library. The bug is a critical issue
causing metadata corruption during the write
garydgregory merged PR #479:
URL: https://github.com/apache/commons-vfs/pull/479
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
garydgregory commented on PR #359:
URL: https://github.com/apache/commons-imaging/pull/359#issuecomment-1925739767
@StefanOltmann
Thank you for your PR.
You'll need a unit test to avoid future regressions and prove this fixes
something.
--
This is an automated message from the
StefanOltmann commented on PR #359:
URL: https://github.com/apache/commons-imaging/pull/359#issuecomment-1925741116
@garydgregory
Do you want me add the image and add Unsplash attribution to your NOTICE
file like this?
garydgregory commented on PR #229:
URL: https://github.com/apache/commons-codec/pull/229#issuecomment-1925748063
I'm going to close this as I don't see the gain compared to the benefit of
running with more random samples because:
- Note that without any change the whole CI build
garydgregory closed pull request #229: modifying data size in DigestUtilsTest
to speed up MessageDigestAlgor…
URL: https://github.com/apache/commons-codec/pull/229
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
[
https://issues.apache.org/jira/browse/CODEC-303?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gary D. Gregory closed CODEC-303.
-
Resolution: Won't Do
PR closed. See discussion there.
> Refactor NoOpBaseNCodec to improve test
[
https://issues.apache.org/jira/browse/IO-364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17814086#comment-17814086
]
Elliotte Rusty Harold commented on IO-364:
--
I did something like this while working on
[
https://issues.apache.org/jira/browse/CODEC-303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17814087#comment-17814087
]
Gary D. Gregory edited comment on CODEC-303 at 2/4/24 1:31 PM:
---
PR closed.
[
https://issues.apache.org/jira/browse/CODEC-238?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gary D. Gregory closed CODEC-238.
-
Resolution: Fixed
PR closed.
> DigestUtils should make it easier to generate hex strings
[
https://issues.apache.org/jira/browse/CODEC-238?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gary D. Gregory updated CODEC-238:
--
External issue URL: https://github.com/apache/commons-codec/pull/8
> DigestUtils should make it
[
https://issues.apache.org/jira/browse/CODEC-212?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gary D. Gregory updated CODEC-212:
--
Fix Version/s: (was: 1.15)
> Create a minimal Digest command line utility:
>
StefanOltmann commented on PR #359:
URL: https://github.com/apache/commons-imaging/pull/359#issuecomment-1925758043
> I don't see any new tests here.
I did not commit it. I added the file above locally to the test folders
hoping that one of the rewrite tests will pick it up and fail.
[
https://issues.apache.org/jira/browse/IO-199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17814094#comment-17814094
]
Elliotte Rusty Harold commented on IO-199:
--
Also IO-218 is covering some of the same ground.
>
garydgregory merged PR #464:
URL: https://github.com/apache/commons-vfs/pull/464
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
garydgregory commented on PR #217:
URL: https://github.com/apache/commons-cli/pull/217#issuecomment-1925738269
Hi @Claudenw
Run `mvn` locally before you push to catch these build failures.
--
This is an automated message from the Apache Git Service.
To respond to the message,
garydgregory commented on PR #359:
URL: https://github.com/apache/commons-imaging/pull/359#issuecomment-1925741932
@StefanOltmann
Sounds good to me, ty!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
[
https://issues.apache.org/jira/browse/IO-845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17814081#comment-17814081
]
Elliotte Rusty Harold edited comment on IO-845 at 2/4/24 1:26 PM:
--
It would
[
https://issues.apache.org/jira/browse/IO-845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17814081#comment-17814081
]
Elliotte Rusty Harold commented on IO-845:
--
It would be helpful if @eamonnmcmanus could chime in on
[
https://issues.apache.org/jira/browse/CODEC-315?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gary D. Gregory resolved CODEC-315.
---
Fix Version/s: 1.16.1
Resolution: Fixed
PR merged.
> PhoneticEngine.encode throws
[
https://issues.apache.org/jira/browse/CODEC-312?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gary D. Gregory resolved CODEC-312.
---
Fix Version/s: 1.16.1
Resolution: Fixed
PR merged.
>
[
https://issues.apache.org/jira/browse/CODEC-313?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gary D. Gregory resolved CODEC-313.
---
Fix Version/s: 1.16.1
Resolution: Fixed
PR merged.
>
[
https://issues.apache.org/jira/browse/CODEC-311?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gary D. Gregory resolved CODEC-311.
---
Fix Version/s: 1.16.1
Resolution: Fixed
PR merged.
> RefinedSoundex.getMappingCode
StefanOltmann commented on PR #359:
URL: https://github.com/apache/commons-imaging/pull/359#issuecomment-1925750776
Alright, this might take a bit of time. I've added it to the regular test
files, but none of the existing tests are failing. I'm not entirely sure what
they cover, but it
[
https://issues.apache.org/jira/browse/CODEC-285?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gary D. Gregory resolved CODEC-285.
---
Resolution: Fixed
Done in git master.
> Upgrade to JUnit 5
> --
>
>
[
https://issues.apache.org/jira/browse/IO-384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17814090#comment-17814090
]
Elliotte Rusty Harold commented on IO-384:
--
This issue is probably obsolete. FileUtils.copyFile now
[
https://issues.apache.org/jira/browse/CODEC-282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gary D. Gregory closed CODEC-282.
-
Resolution: Fixed
PR closed.
> Spring Clean .gitignore
> ---
>
>
[
https://issues.apache.org/jira/browse/CODEC-247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17814091#comment-17814091
]
Gary D. Gregory commented on CODEC-247:
---
[~oscarlvp]
Feel free to provide a PR on GitHub
>
[
https://issues.apache.org/jira/browse/CODEC-247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17814091#comment-17814091
]
Gary D. Gregory edited comment on CODEC-247 at 2/4/24 1:36 PM:
---
[~oscarlvp]
[
https://issues.apache.org/jira/browse/CODEC-238?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gary D. Gregory updated CODEC-238:
--
Fix Version/s: (was: 1.15)
> DigestUtils should make it easier to generate hex strings
garydgregory commented on PR #359:
URL: https://github.com/apache/commons-imaging/pull/359#issuecomment-1925754311
@StefanOltmann
I don't see any new tests here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
garydgregory commented on PR #359:
URL: https://github.com/apache/commons-imaging/pull/359#issuecomment-1925760731
@StefanOltmann
Thanks for the update. We're glad to get help to improve it all
--
This is an automated message from the Apache Git Service.
To respond to the message,
garydgregory merged PR #362:
URL: https://github.com/apache/commons-parent/pull/362
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
garydgregory merged PR #47:
URL: https://github.com/apache/commons-beanutils/pull/47
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
garydgregory merged PR #478:
URL: https://github.com/apache/commons-vfs/pull/478
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
garydgregory merged PR #143:
URL: https://github.com/apache/commons-exec/pull/143
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
garydgregory commented on PR #1168:
URL: https://github.com/apache/commons-lang/pull/1168#issuecomment-1925880813
@dependabot rebase
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
38 matches
Mail list logo