[PR] typo and Oxford comma [commons-logging]

2024-02-10 Thread via GitHub
elharo opened a new pull request, #210: URL: https://github.com/apache/commons-logging/pull/210 @garydgregory -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[jira] [Resolved] (IO-405) Support threshold=0 in ThresholdingOutputStream

2024-02-10 Thread Gary D. Gregory (Jira)
[ https://issues.apache.org/jira/browse/IO-405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory resolved IO-405. Fix Version/s: 2.16.0 Resolution: Fixed > Support threshold=0 in ThresholdingOutputStream >

[jira] [Commented] (IO-387) IOUtils method to copy File Streams using NIO Channels

2024-02-10 Thread Elliotte Rusty Harold (Jira)
[ https://issues.apache.org/jira/browse/IO-387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17816296#comment-17816296 ] Elliotte Rusty Harold commented on IO-387: -- I like the auto-switch idea, especially if performance

Re: [PR] Drop reflection from ExtraFieldUtils [commons-compress]

2024-02-10 Thread via GitHub
garydgregory commented on code in PR #480: URL: https://github.com/apache/commons-compress/pull/480#discussion_r1485144279 ## src/main/java/org/apache/commons/compress/archivers/zip/ExtraFieldUtils.java: ## @@ -379,11 +382,28 @@ public ZipExtraField

Re: [PR] Drop reflection from ExtraFieldUtils [commons-compress]

2024-02-10 Thread via GitHub
garydgregory commented on code in PR #480: URL: https://github.com/apache/commons-compress/pull/480#discussion_r1485144279 ## src/main/java/org/apache/commons/compress/archivers/zip/ExtraFieldUtils.java: ## @@ -379,11 +382,28 @@ public ZipExtraField

Re: [PR] Drop reflection from ExtraFieldUtils [commons-compress]

2024-02-10 Thread via GitHub
rmannibucau commented on code in PR #480: URL: https://github.com/apache/commons-compress/pull/480#discussion_r1485036494 ## src/main/java/org/apache/commons/compress/archivers/zip/ExtraFieldUtils.java: ## @@ -379,11 +382,28 @@ public ZipExtraField onUnparseableExtraField(final

[jira] [Commented] (IO-405) Support threshold=0 in ThresholdingOutputStream

2024-02-10 Thread Elliotte Rusty Harold (Jira)
[ https://issues.apache.org/jira/browse/IO-405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17816294#comment-17816294 ] Elliotte Rusty Harold commented on IO-405: -- This is fixed now and can be resolve. > Support

[jira] [Commented] (IO-420) Detection of deleted directories fails if the directory does not exist when the observer is created.

2024-02-10 Thread Elliotte Rusty Harold (Jira)
[ https://issues.apache.org/jira/browse/IO-420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17816295#comment-17816295 ] Elliotte Rusty Harold commented on IO-420: -- To expand, is this the current behavior? 1. Observe a

[jira] [Commented] (IO-51) Throttled input and output stream classes

2024-02-10 Thread Elliotte Rusty Harold (Jira)
[ https://issues.apache.org/jira/browse/IO-51?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17816299#comment-17816299 ] Elliotte Rusty Harold commented on IO-51: - This should be resoloved. > Throttled input and output

[jira] [Resolved] (IO-51) Throttled input and output stream classes

2024-02-10 Thread Gary D. Gregory (Jira)
[ https://issues.apache.org/jira/browse/IO-51?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory resolved IO-51. --- Fix Version/s: 2.16.0 Resolution: Fixed > Throttled input and output stream classes >

[jira] [Commented] (IO-387) IOUtils method to copy File Streams using NIO Channels

2024-02-10 Thread Gary D. Gregory (Jira)
[ https://issues.apache.org/jira/browse/IO-387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17816320#comment-17816320 ] Gary D. Gregory commented on IO-387: JMH to the rescue ;) See also: *

[jira] [Comment Edited] (IO-405) Support threshold=0 in ThresholdingOutputStream

2024-02-10 Thread Elliotte Rusty Harold (Jira)
[ https://issues.apache.org/jira/browse/IO-405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17816294#comment-17816294 ] Elliotte Rusty Harold edited comment on IO-405 at 2/10/24 10:57 AM: This

[jira] [Comment Edited] (IO-405) Support threshold=0 in ThresholdingOutputStream

2024-02-10 Thread Elliotte Rusty Harold (Jira)
[ https://issues.apache.org/jira/browse/IO-405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17800172#comment-17800172 ] Elliotte Rusty Harold edited comment on IO-405 at 2/10/24 10:56 AM: I

[jira] [Commented] (IO-420) Detection of deleted directories fails if the directory does not exist when the observer is created.

2024-02-10 Thread Elliotte Rusty Harold (Jira)
[ https://issues.apache.org/jira/browse/IO-420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17816298#comment-17816298 ] Elliotte Rusty Harold commented on IO-420: -- Looks like I don't get a created event either in this

[jira] [Closed] (LOGGING-187) release current state of master as 1.3

2024-02-10 Thread Gary D. Gregory (Jira)
[ https://issues.apache.org/jira/browse/LOGGING-187?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory closed LOGGING-187. --- Fix Version/s: 1.3.0 Resolution: Fixed > release current state of master as 1.3 >

Re: [PR] [site] Typo and Oxford comma [commons-logging]

2024-02-10 Thread via GitHub
garydgregory merged PR #210: URL: https://github.com/apache/commons-logging/pull/210 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Drop reflection from ExtraFieldUtils static initialization [commons-compress]

2024-02-10 Thread via GitHub
garydgregory merged PR #480: URL: https://github.com/apache/commons-compress/pull/480 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Drop reflection from ExtraFieldUtils [commons-compress]

2024-02-10 Thread via GitHub
rmannibucau commented on PR #480: URL: https://github.com/apache/commons-compress/pull/480#issuecomment-1937101399 @garydgregory very good catch! fixed now normally. On the builder point I had the same thought and I think it is maybe worth to not expose all constructors (package scope?)

Re: [PR] Drop reflection from ExtraFieldUtils [commons-compress]

2024-02-10 Thread via GitHub
rmannibucau commented on code in PR #480: URL: https://github.com/apache/commons-compress/pull/480#discussion_r1485215496 ## src/main/java/org/apache/commons/compress/archivers/zip/ExtraFieldUtils.java: ## @@ -113,24 +116,24 @@ public ZipExtraField onUnparseableExtraField(final

Re: [PR] Drop reflection from ExtraFieldUtils [commons-compress]

2024-02-10 Thread via GitHub
garydgregory commented on PR #480: URL: https://github.com/apache/commons-compress/pull/480#issuecomment-1937102315 > @garydgregory very good catch! fixed now normally. On the builder point I had the same thought and I think it is maybe worth to not expose all constructors (package scope?)

Re: [PR] Drop reflection from ExtraFieldUtils static initialization [commons-compress]

2024-02-10 Thread via GitHub
garydgregory commented on PR #480: URL: https://github.com/apache/commons-compress/pull/480#issuecomment-1937141258 @rmannibucau Merged! Thank you for your work  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] Drop reflection from ExtraFieldUtils [commons-compress]

2024-02-10 Thread via GitHub
rmannibucau commented on code in PR #480: URL: https://github.com/apache/commons-compress/pull/480#discussion_r1485205287 ## src/main/java/org/apache/commons/compress/archivers/zip/ExtraFieldUtils.java: ## @@ -379,11 +382,28 @@ public ZipExtraField onUnparseableExtraField(final

Re: [PR] Drop reflection from ExtraFieldUtils [commons-compress]

2024-02-10 Thread via GitHub
garydgregory commented on code in PR #480: URL: https://github.com/apache/commons-compress/pull/480#discussion_r1485214180 ## src/main/java/org/apache/commons/compress/archivers/zip/ExtraFieldUtils.java: ## @@ -113,24 +116,24 @@ public ZipExtraField

Re: [PR] Drop reflection from ExtraFieldUtils [commons-compress]

2024-02-10 Thread via GitHub
rmannibucau commented on code in PR #480: URL: https://github.com/apache/commons-compress/pull/480#discussion_r1485215496 ## src/main/java/org/apache/commons/compress/archivers/zip/ExtraFieldUtils.java: ## @@ -113,24 +116,24 @@ public ZipExtraField onUnparseableExtraField(final

[jira] [Commented] (BCEL-371) BCELifierTestCase fails if run twice in a row.

2024-02-10 Thread Gary D. Gregory (Jira)
[ https://issues.apache.org/jira/browse/BCEL-371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17816342#comment-17816342 ] Gary D. Gregory commented on BCEL-371: -- Maybe, it could be that some tests don't clean up after