[jira] [Commented] (VALIDATOR-487) EmailValidator validates too much

2024-04-10 Thread Olivier Jaquemet (Jira)
[ https://issues.apache.org/jira/browse/VALIDATOR-487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17835667#comment-17835667 ] Olivier Jaquemet commented on VALIDATOR-487: Hello everyone, I'm not an e

[PR] Fix inaccessible object exception [commons-lang]

2024-04-10 Thread via GitHub
stefansimon76 opened a new pull request, #1198: URL: https://github.com/apache/commons-lang/pull/1198 "field.setAccessible(true);" throws an exception on java-17 because java.lang is not open for reflection. The problem cannot be worked around on the client side because "setAccessible(true)

Re: [PR] Fix inaccessible object exception [commons-lang]

2024-04-10 Thread via GitHub
garydgregory commented on PR #1198: URL: https://github.com/apache/commons-lang/pull/1198#issuecomment-2047428265 Hello @stefansimon76 - There is too much copy-pasta in this PR, the same code is duplicated at least 3 times. - The whole point of the feature is to use reflection as the

[jira] [Commented] (VALIDATOR-487) EmailValidator validates too much

2024-04-10 Thread Gary D. Gregory (Jira)
[ https://issues.apache.org/jira/browse/VALIDATOR-487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17835714#comment-17835714 ] Gary D. Gregory commented on VALIDATOR-487: --- It seems a sane way forward for

Re: [PR] New and useful methods for commons.text.CaseUtils [commons-text]

2024-04-10 Thread via GitHub
speters33w commented on PR #528: URL: https://github.com/apache/commons-text/pull/528#issuecomment-2048290598 You make some good points, to have at most one or two methods with a parameter for delimeter. I will revisit this. One concern is the existing char[] for delimeter in the ex