Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/390
Thanks!
---
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/390
Thank for the contribution.
Could you please squash to the commits? Then I will merge the pull request.
---
GitHub user PascalSchumacher opened a pull request:
https://github.com/apache/commons-lang/pull/384
Travis: Stop building with Java 9 and 10, as these are superseded by â¦
â¦Java 11 and not supported anymore.
You can merge this pull request into a Git repository by running
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/381
@kinow What do you think is this a better solution than #340?
---
GitHub user PascalSchumacher opened a pull request:
https://github.com/apache/commons-lang/pull/383
Make whitespace use after tokens consistent and add checkstyle rule tâ¦
â¦o enforce it.
You can merge this pull request into a Git repository by running:
$ git pull https
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/376
Thanks! ð
---
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/376
Looks great, thank you very much! ð
There are just some checkstyle errors related to unused imports left to fix
(see failed travis build).
---
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/375
Thank you very much for this massive effort! ð
---
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/374
Thanks! ð
---
Github user PascalSchumacher commented on a diff in the pull request:
https://github.com/apache/commons-lang/pull/374#discussion_r224137193
--- Diff: pom.xml ---
@@ -543,6 +543,11 @@
junit-vintage-engine
test
+
+ org.junit-pioneer
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/373
Thanks! ð
---
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/372
Thanks! ð
---
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/371
Thanks! ð
---
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/370
Thanks! ð
---
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/369
Thanks! ð
---
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/368
Thanks! ð
---
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/367
Thanks! ð
---
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/366
Thanks! ð
---
GitHub user PascalSchumacher opened a pull request:
https://github.com/apache/commons-lang/pull/365
Travis: Also build with openjdk-ea
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/PascalSchumacher/commons-lang
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/363
Thanks! ð
Merged in
https://github.com/apache/commons-lang/commit/729adb624d3e720afb8686093814ab2bcc2d2f13
Not sure why this pull request was not auto-closed even
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/359
Thanks! ð
---
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/354
+1
---
GitHub user PascalSchumacher opened a pull request:
https://github.com/apache/commons-lang/pull/350
Replace FindBugs with SpotBugs
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/PascalSchumacher/commons-lang spotbugs
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/334
Thanks! ð
---
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/331
@chonton No further review comments by anyone, so I guess this is good to
merge?
---
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/334
@kinow Changes to throws declaration are binary compatible (see:
https://docs.oracle.com/javase/specs/jls/se7/html/jls-13.html#jls-13.4.21).
Removing checked exceptions from a throws
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/275
+1
---
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/325
Thanks! ð
---
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/333
Thanks! :+1:
---
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/331
+1
---
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/330
Thanks for the pull request!
I would be nice if you could amend the commit to add the issue id and
description at the beginning of the commit message.
Thanks!
---
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/329
I updated the pull request to allow failures on Java 11.
---
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/329
When using Java 11 the following test failures occur:
```
[ERROR] Failures:
[ERROR]
FastDateFormat_ParserTest>FastDateParserTest.testLocales_LongNoEra_AD:
GitHub user PascalSchumacher opened a pull request:
https://github.com/apache/commons-lang/pull/329
Travis: Add Java 10 "Oracle JDK", Java 10 "OpenJDK", Java 11 "Oracle â¦
â¦JDK"
You can merge this pull request into a Git repository by running:
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/327
Thanks! ð
---
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/322
Thanks! ð
The file was original generated out of
https://github.com/apache/commons-build-plugin/blob/master/src/main/resources/commons-xdoc-templates/contributing-md
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/321
Thanks! ð
---
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/314
Thanks! ð
---
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/313
Sure, that is fine!
---
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/313
A pull request with tests for the `float` case would be welcome.
---
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/313
Thanks! ð
---
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/281
Thanks! ð
---
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/286
Thanks! ð
---
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/307
Thanks! ð
Sorry for the delay in merging.
---
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/307
created https://issues.apache.org/jira/browse/LANG-1371 to track this
---
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/310
Thanks! ð
---
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/305
Thanks!
---
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/306
Looks like the IBM JDK is not yet supported by the travis jdk-switcher, so
let's wait some time.
---
Github user PascalSchumacher closed the pull request at:
https://github.com/apache/commons-lang/pull/306
---
GitHub user PascalSchumacher opened a pull request:
https://github.com/apache/commons-lang/pull/306
.travis: add IBM JDK 8
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/PascalSchumacher/commons-lang
travis_add_ibm_jdk
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/304
@garydgregory For me too and the build on travis with java 9 has been
sucessfully running for months now.
This seems to be a locale related thing. I can replicated the 8 test
Github user PascalSchumacher commented on a diff in the pull request:
https://github.com/apache/commons-lang/pull/299#discussion_r147560886
--- Diff: .travis.yml ---
@@ -21,8 +21,19 @@ jdk:
- oraclejdk8
- oraclejdk9
+cache:
+ directories
Github user PascalSchumacher closed the pull request at:
https://github.com/apache/commons-lang/pull/209
---
Github user PascalSchumacher closed the pull request at:
https://github.com/apache/commons-lang/pull/204
---
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/303
Thanks! ð
---
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/300
Thanks! ð
---
Github user PascalSchumacher commented on the pull request:
https://github.com/apache/commons-lang/commit/c56b87d6efe530590b6d9a07e41ca00af208ce37#commitcomment-24901481
Travis build fails:
```
Failed tests:
FieldUtilsTest.testGetAllFields:167 array lengths
Github user PascalSchumacher commented on a diff in the pull request:
https://github.com/apache/commons-lang/pull/296#discussion_r143781416
--- Diff: src/main/java/org/apache/commons/lang3/time/FastTimeZone.java ---
@@ -39,10 +43,11 @@ public static TimeZone getGmtTimeZone
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/296
Looks good imho. ð
---
Github user PascalSchumacher commented on the pull request:
https://github.com/apache/commons-lang/commit/d848328a7aa54f73117b8f13ce6e67049dc9502e#commitcomment-24866834
`3.6` already requires java 7.
Also the builds on travis fail with:
```There are 8 errors
Github user PascalSchumacher commented on a diff in the pull request:
https://github.com/apache/commons-lang/pull/297#discussion_r143555903
--- Diff: src/main/java/org/apache/commons/lang3/time/FormatCache.java ---
@@ -240,7 +240,7 @@ public boolean equals(final Object obj
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/298
The comment above the statement explains why it is done this way.
In case this is merged the comment should be removed.
---
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/295
Thanks!
---
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/202
@douddle I created https://issues.apache.org/jira/browse/LANG-1356 to track
the bypass issue.
---
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/292
Great pull request! Thanks! :+1:
merged in
https://github.com/apache/commons-lang/commit/cc6beb2d05347fba64d933906ae2b712b1a43302
---
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/295
Can you close the pull request? (I messed up the commit comment.)
---
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/295
Thanks!
---
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/293
Thanks! :+1:
---
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/289
Thanks!
---
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/287
Thanks! :+1:
---
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/282
I added a test. Thanks for the pull request! :+1:
---
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/284
Thanks! :+1:
---
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/283
Thanks for the pull request! :+1:
It was merged by @garydgregory in
https://github.com/apache/commons-lang/commit/cc94767e7eabdfcf9d1cab1d8d1d8556864394c6
It would
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/282
created https://issues.apache.org/jira/browse/LANG-1349 to track this
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
GitHub user PascalSchumacher opened a pull request:
https://github.com/apache/commons-lang/pull/280
.travis.yml: add oraclejdk9
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/PascalSchumacher/commons-lang
add_jdk9_to_travis
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/273
@Abrasha Thank you very much for the offer, but I think you should give
@qxo some more time (a few days) to fix it himself.
---
If your project is set up for it, you can reply
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/273
@Abrasha You can create a pull request for @qxo fork. If he merges it, it
will be added to this pull request.
---
If your project is set up for it, you can reply to this email
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/273
Thanks for the pull request, but the build fails because of checkstyle
violations, see: https://travis-ci.org/apache/commons-lang/jobs/248359934 for
details.
---
If your project
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/274
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user PascalSchumacher closed the pull request at:
https://github.com/apache/commons-lang/pull/268
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/268
The build works using java 9 locally. I guess its only a few months at most
until jdk 9 will be officially supported on travis, so I won't invest any more
time into this for now
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/271
Not (yet) ready to merge, see my comments at
https://github.com/apache/commons-text/pull/45 for details.
---
If your project is set up for it, you can reply to this email and have
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/268
It is not officially supported, but it is possible.
For example https://github.com/jacoco/jacoco and
https://github.com/apache/logging-log4j2 use jdk 9 on travis
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/268
Another problem is that the maven version used by travis does not work with
jdk 9 as far as I know.
---
If your project is set up for it, you can reply to this email and have your
GitHub user PascalSchumacher opened a pull request:
https://github.com/apache/commons-lang/pull/268
.travis.yml: add oraclejdk9
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/PascalSchumacher/commons-lang
add_jdk9_to_travis
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/223
Thanks! :+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/209
Thanks. :smile:
You won't need this to exclude `null` values when using
`ReflectionToStringBuilder`, see https://github.com/apache/commons-lang/pull/259
Github user PascalSchumacher commented on a diff in the pull request:
https://github.com/apache/commons-lang/pull/223#discussion_r114111595
--- Diff: src/main/java/org/apache/commons/lang3/StringUtils.java ---
@@ -7193,6 +7193,45 @@ public static boolean isAllUpperCase(final
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/225
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/264
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/182
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/191
Support for excluding `null` values was added in
https://github.com/apache/commons-lang/commit/8147cc5b3de5fa7a3a3e8116355efa44367dc3c5
@gabriel-amaral Thanks for the pull
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/263
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/261
Merged. Thank you very much.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/261
@yasserzamani Thanks!
No need to apologize. It is just that we try to be conservative with new
additions (If we add a public method we have to support it for a long time
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/261
If I'm not mistaken the list returned by `getAllSuperclassesAndInterfaces`
can contain the same interface multiple times if it is implemented by more than
one super class. To prevent
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/261
Created https://issues.apache.org/jira/browse/LANG-1321 for the
`ClassUtils#getAllSuperclassesAndInterfaces` addition.
---
If your project is set up for it, you can reply
Github user PascalSchumacher commented on a diff in the pull request:
https://github.com/apache/commons-lang/pull/261#discussion_r112563123
--- Diff: src/main/java/org/apache/commons/lang3/ClassUtils.java ---
@@ -457,6 +457,44 @@ public static String getAbbreviatedName(final String
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/259
@chtompki Sorry for the delay, other open source projects and vacations
interfered.
As the ToStringStyle implementations are singletons, I do not see a save
way to use #209
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/261
@yasserzamani Sorry for the delay, other open source projects and vacations
interfered.
I'm not sure if the priority parameter of `getAllSuperclassesAndInterfaces
1 - 100 of 331 matches
Mail list logo
