[jira] [Commented] (IO-513) Add convenience methods for reading class path resources

[ https://issues.apache.org/jira/browse/IO-513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15691120#comment-15691120 ] ASF GitHub Bot commented on IO-513: --- Github user asfgit closed the pull request at:

[jira] [Commented] (IO-513) Add convenience methods for reading class path resources

[ https://issues.apache.org/jira/browse/IO-513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15689123#comment-15689123 ] Gary Gregory commented on IO-513: - I created a simpler UTF-8 text file and the tests pass. > Add convenience

[jira] [Commented] (IO-513) Add convenience methods for reading class path resources

[ https://issues.apache.org/jira/browse/IO-513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15689121#comment-15689121 ] Gary Gregory commented on IO-513: - I wonder if {{resourceToURL(final String name, final ClassLoader

[jira] [Commented] (IO-513) Add convenience methods for reading class path resources

[ https://issues.apache.org/jira/browse/IO-513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15689047#comment-15689047 ] Gary Gregory commented on IO-513: - Based on Git master and this diff, I get the following failures:

[jira] [Commented] (IO-513) Add convenience methods for reading class path resources

[ https://issues.apache.org/jira/browse/IO-513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15686348#comment-15686348 ] ASF GitHub Bot commented on IO-513: --- GitHub user behrangsa opened a pull request:

[jira] [Commented] (IO-513) Add convenience methods for reading class path resources

[ https://issues.apache.org/jira/browse/IO-513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15490886#comment-15490886 ] Stian Soiland-Reyes commented on IO-513: I agree with Gary that there should be variants with the

[jira] [Commented] (IO-513) Add convenience methods for reading class path resources

[ https://issues.apache.org/jira/browse/IO-513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15481345#comment-15481345 ] Behrang Saeedzadeh commented on IO-513: --- Hi Gary, Any outstanding issues for this to be merged?

[jira] [Commented] (IO-513) Add convenience methods for reading class path resources

[ https://issues.apache.org/jira/browse/IO-513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15445845#comment-15445845 ] Behrang Saeedzadeh commented on IO-513: --- Hi Gary, I added unit tests for NPE. Also what pattern do you

[jira] [Commented] (IO-513) Add convenience methods for reading class path resources

[ https://issues.apache.org/jira/browse/IO-513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15443889#comment-15443889 ] Gary Gregory commented on IO-513: - Well, you do have a point there... I'm OK with the addition then, mod tests

[jira] [Commented] (IO-513) Add convenience methods for reading class path resources

[ https://issues.apache.org/jira/browse/IO-513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15440749#comment-15440749 ] Behrang Saeedzadeh commented on IO-513: --- Hi Gary, Thanks for your feedback. I think that NPE scenario

[jira] [Commented] (IO-513) Add convenience methods for reading class path resources

[ https://issues.apache.org/jira/browse/IO-513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15432943#comment-15432943 ] Gary Gregory commented on IO-513: - Hi All: The current patch for {{resourceToString}} and

[jira] [Commented] (IO-513) Add convenience methods for reading class path resources

[ https://issues.apache.org/jira/browse/IO-513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15432354#comment-15432354 ] Behrang Saeedzadeh commented on IO-513: --- Hi Benedikt, The JavaDoc for {{IOUtils}} says: > General IO

[jira] [Commented] (IO-513) Add convenience methods for reading class path resources

[ https://issues.apache.org/jira/browse/IO-513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15432214#comment-15432214 ] Benedikt Ritter commented on IO-513: I'm currently not convinced this should be added to IOUtils. The API