[jira] [Commented] (LANG-1229) Performance regression due to cyclic hashCode guard

[ https://issues.apache.org/jira/browse/LANG-1229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15321391#comment-15321391 ] Pascal Schumacher commented on LANG-1229: - Pull request applied. Thanks. I reopened LANG-456. >

[jira] [Commented] (LANG-1229) Performance regression due to cyclic hashCode guard

[ https://issues.apache.org/jira/browse/LANG-1229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15321385#comment-15321385 ] ASF GitHub Bot commented on LANG-1229: -- Github user PascalSchumacher commented on the issue:

[jira] [Commented] (LANG-1229) Performance regression due to cyclic hashCode guard

[ https://issues.apache.org/jira/browse/LANG-1229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15321384#comment-15321384 ] ASF GitHub Bot commented on LANG-1229: -- Github user asfgit closed the pull request at:

[jira] [Commented] (LANG-1229) Performance regression due to cyclic hashCode guard

[ https://issues.apache.org/jira/browse/LANG-1229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15315913#comment-15315913 ] ASF GitHub Bot commented on LANG-1229: -- Github user PascalSchumacher commented on the issue:

[jira] [Commented] (LANG-1229) Performance regression due to cyclic hashCode guard

[ https://issues.apache.org/jira/browse/LANG-1229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15305278#comment-15305278 ] Philippe Marschall commented on LANG-1229: -- The patch is indeed missing the new method. I'm unsure

[jira] [Commented] (LANG-1229) Performance regression due to cyclic hashCode guard

[ https://issues.apache.org/jira/browse/LANG-1229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15304216#comment-15304216 ] Pascal Schumacher commented on LANG-1229: - The patch is missing the new method (maybe call it

[jira] [Commented] (LANG-1229) Performance regression due to cyclic hashCode guard

[ https://issues.apache.org/jira/browse/LANG-1229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15284932#comment-15284932 ] Philippe Marschall commented on LANG-1229: -- A potential patch

[jira] [Commented] (LANG-1229) Performance regression due to cyclic hashCode guard

[ https://issues.apache.org/jira/browse/LANG-1229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15284263#comment-15284263 ] Philippe Marschall commented on LANG-1229: -- Personally I don't like boolean flags to methods that

[jira] [Commented] (LANG-1229) Performance regression due to cyclic hashCode guard

[ https://issues.apache.org/jira/browse/LANG-1229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15283890#comment-15283890 ] Gary Gregory commented on LANG-1229: Or maybe the new method is still called append but takes a boolean