[GitHub] [flink-ml] yunfengzhou-hub commented on a change in pull request #32: [FLINK-24817] Add Naive Bayes implementation

2021-12-07 Thread GitBox
yunfengzhou-hub commented on a change in pull request #32: URL: https://github.com/apache/flink-ml/pull/32#discussion_r764623110 ## File path: flink-ml-lib/src/main/java/org/apache/flink/ml/classification/naivebayes/NaiveBayesModelData.java ## @@ -0,0 +1,151 @@ +/* + *

[GitHub] [flink] flinkbot edited a comment on pull request #16582: [FLINK-21504][checkpoint] Introduce notification of subsumed checkpoint

2021-12-07 Thread GitBox
flinkbot edited a comment on pull request #16582: URL: https://github.com/apache/flink/pull/16582#issuecomment-885598535 ## CI report: * 4575a58b2365b9ab070606108ef6ba1b4507dc24 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17692: [FLINK-24489][CEP] The size of entryCache & eventsBufferCache in the SharedBuffer should be defined with a threshold to limit the num

2021-12-07 Thread GitBox
flinkbot edited a comment on pull request #17692: URL: https://github.com/apache/flink/pull/17692#issuecomment-961748638 ## CI report: * 5378879134e1c08ada5239c650d2ce77cff0f3e3 Azure:

[GitHub] [flink] xiangqiao123 commented on a change in pull request #17952: [FLINK-25011][runtime] Introduce vertex parallelism decider and the default implementation.

2021-12-07 Thread GitBox
xiangqiao123 commented on a change in pull request #17952: URL: https://github.com/apache/flink/pull/17952#discussion_r764615819 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptivebatch/DefaultVertexParallelismDecider.java ## @@ -0,0 +1,133

[GitHub] [flink] flinkbot edited a comment on pull request #17939: [FLINK-20370][table] part2: introduce 'table.exec.sink.pk-shuffle' option to auto keyby on sink's pk if parallelism are not the same

2021-12-07 Thread GitBox
flinkbot edited a comment on pull request #17939: URL: https://github.com/apache/flink/pull/17939#issuecomment-981420515 ## CI report: * a124edc8f7930c1f9a7078418b2117646e464a0e Azure:

[jira] [Closed] (FLINK-18165) When savingpoint is restored, select the checkpoint directory and stateBackend

2021-12-07 Thread Yun Tang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18165?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yun Tang closed FLINK-18165. Resolution: Fixed This ticket has been resolved by FLINK-20976 > When savingpoint is restored, select

[GitHub] [flink] flinkbot edited a comment on pull request #17655: [FLINK-24728][tests] Add tests to ensure SQL file sink closes all created files

2021-12-07 Thread GitBox
flinkbot edited a comment on pull request #17655: URL: https://github.com/apache/flink/pull/17655#issuecomment-958717470 ## CI report: * b3867f269b1f83df6e44493def7c78a18e962a5d Azure:

[jira] [Closed] (FLINK-19008) Flink Job runs slow after restore + downscale from an incremental checkpoint (rocksdb)

2021-12-07 Thread Yun Tang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-19008?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yun Tang closed FLINK-19008. Resolution: Information Provided Flink has bumpped RocksDB version to 6.20.3 which adopts this compaction

[GitHub] [flink] flinkbot edited a comment on pull request #17655: [FLINK-24728][tests] Add tests to ensure SQL file sink closes all created files

2021-12-07 Thread GitBox
flinkbot edited a comment on pull request #17655: URL: https://github.com/apache/flink/pull/17655#issuecomment-958717470 ## CI report: * b3867f269b1f83df6e44493def7c78a18e962a5d Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #18050: [FLINK-25034][runtime] Support flexible number of subpartitions in IntermediateResultPartition

2021-12-07 Thread GitBox
flinkbot edited a comment on pull request #18050: URL: https://github.com/apache/flink/pull/18050#issuecomment-988466514 ## CI report: * 5e36ba1eacf427ca4665de18b6f71253fb53f0e8 Azure:

[jira] [Closed] (FLINK-23532) Unify stop-with-savepoint w drain and w/o drain

2021-12-07 Thread Dawid Wysakowicz (Jira)
[ https://issues.apache.org/jira/browse/FLINK-23532?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Wysakowicz closed FLINK-23532. Resolution: Implemented Implemented in

[GitHub] [flink] flinkbot edited a comment on pull request #18014: [FLINK-24857][test][Kafka] Upgrade SourceReaderTestBase t…

2021-12-07 Thread GitBox
flinkbot edited a comment on pull request #18014: URL: https://github.com/apache/flink/pull/18014#issuecomment-986441468 ## CI report: * a00cd7df6de0a7db9dc0517a8eeb9e0cd8465a6a Azure:

[GitHub] [flink] dawidwys merged pull request #17968: [FLINK-23532] Unify stop-with-savepoint without and with drain

2021-12-07 Thread GitBox
dawidwys merged pull request #17968: URL: https://github.com/apache/flink/pull/17968 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] flinkbot edited a comment on pull request #18014: [FLINK-24857][test][Kafka] Upgrade SourceReaderTestBase t…

2021-12-07 Thread GitBox
flinkbot edited a comment on pull request #18014: URL: https://github.com/apache/flink/pull/18014#issuecomment-986441468 ## CI report: * a00cd7df6de0a7db9dc0517a8eeb9e0cd8465a6a Azure:

[jira] [Commented] (FLINK-20996) Using a cryptographically weak Pseudo Random Number Generator (PRNG)

2021-12-07 Thread Yun Tang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-20996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17455009#comment-17455009 ] Yun Tang commented on FLINK-20996: -- [~yaxiao] AbstractTtlStateVerifier is just a class for unit test

[GitHub] [flink] JingsongLi commented on a change in pull request #17939: [FLINK-20370][table] part2: introduce 'table.exec.sink.pk-shuffle' option to auto keyby on sink's pk if parallelism are not th

2021-12-07 Thread GitBox
JingsongLi commented on a change in pull request #17939: URL: https://github.com/apache/flink/pull/17939#discussion_r764598800 ## File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/config/ExecutionConfigOptions.java ## @@ -150,6 +150,25 @@

[GitHub] [flink] flinkbot edited a comment on pull request #17988: [FLINK-25010][Connectors/Hive] Speed up hive's createMRSplits by multi thread

2021-12-07 Thread GitBox
flinkbot edited a comment on pull request #17988: URL: https://github.com/apache/flink/pull/17988#issuecomment-984363654 ## CI report: * 92f5f7c95542c9a08863324d5c885106e554a6c2 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17462: [FLINK-23170] Write metadata after materialization

2021-12-07 Thread GitBox
flinkbot edited a comment on pull request #17462: URL: https://github.com/apache/flink/pull/17462#issuecomment-942024789 ## CI report: * ddc8a47426d41b78f448556c5b9a8bbf3ad8c19b Azure:

[jira] [Closed] (FLINK-21726) Fix checkpoint stuck

2021-12-07 Thread Yun Tang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21726?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yun Tang closed FLINK-21726. Fix Version/s: (was: 1.15.0) (was: 1.14.1) Resolution: Information

[jira] [Commented] (FLINK-22962) Key group is not in KeyGroupRange error while checkpointing

2021-12-07 Thread Yun Tang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17454991#comment-17454991 ] Yun Tang commented on FLINK-22962: -- [~prateekkohli2112] After flink-1.13, we unify the format of

[GitHub] [flink] flinkbot edited a comment on pull request #18049: [FLINK-24813][table-planner-blink] Improve ImplicitTypeConversionITCase

2021-12-07 Thread GitBox
flinkbot edited a comment on pull request #18049: URL: https://github.com/apache/flink/pull/18049#issuecomment-988465299 ## CI report: * da40e9da154b7273f6db5eb12d65c983636cd1e6 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17952: [FLINK-25011][runtime] Introduce vertex parallelism decider and the default implementation.

2021-12-07 Thread GitBox
flinkbot edited a comment on pull request #17952: URL: https://github.com/apache/flink/pull/17952#issuecomment-982356774 ## CI report: * c18948fda6752079a297579c26db0316376390bd Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #18049: [FLINK-24813][table-planner-blink] Improve ImplicitTypeConversionITCase

2021-12-07 Thread GitBox
flinkbot edited a comment on pull request #18049: URL: https://github.com/apache/flink/pull/18049#issuecomment-988465299 ## CI report: * da40e9da154b7273f6db5eb12d65c983636cd1e6 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17952: [FLINK-25011][runtime] Introduce vertex parallelism decider and the default implementation.

2021-12-07 Thread GitBox
flinkbot edited a comment on pull request #17952: URL: https://github.com/apache/flink/pull/17952#issuecomment-982356774 ## CI report: * c18948fda6752079a297579c26db0316376390bd Azure:

[GitHub] [flink] xuyangzhong commented on pull request #18049: [FLINK-24813][table-planner-blink] Improve ImplicitTypeConversionITCase

2021-12-07 Thread GitBox
xuyangzhong commented on pull request #18049: URL: https://github.com/apache/flink/pull/18049#issuecomment-988539996 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [flink] wanglijie95 commented on a change in pull request #17952: [FLINK-25011][runtime] Introduce vertex parallelism decider and the default implementation.

2021-12-07 Thread GitBox
wanglijie95 commented on a change in pull request #17952: URL: https://github.com/apache/flink/pull/17952#discussion_r764582435 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptivebatch/DefaultVertexParallelismDecider.java ## @@ -81,52 +88,36

[jira] [Commented] (FLINK-25132) KafkaSource cannot work with object-reusing DeserializationSchema

2021-12-07 Thread Qingsheng Ren (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17454980#comment-17454980 ] Qingsheng Ren commented on FLINK-25132: --- [~mason6345] I think so. We'll make a back-port on 1.13

[GitHub] [flink] MyLanPangzi commented on a change in pull request #14376: [FLINK-18202][PB format] New Format of protobuf

2021-12-07 Thread GitBox
MyLanPangzi commented on a change in pull request #14376: URL: https://github.com/apache/flink/pull/14376#discussion_r764575993 ## File path: flink-formats/flink-protobuf/src/main/java/org/apache/flink/formats/protobuf/PbFormatUtils.java ## @@ -0,0 +1,166 @@ +/* + * Licensed

[GitHub] [flink] flinkbot edited a comment on pull request #16108: [FLINK-22821][connector-kafka] FlinkKafkaProducerMigrationTest fails …

2021-12-07 Thread GitBox
flinkbot edited a comment on pull request #16108: URL: https://github.com/apache/flink/pull/16108#issuecomment-856641884 ## CI report: * d7d66d77b7ac632cee04bfe17c7671e048535fc1 Azure:

[jira] [Commented] (FLINK-23391) KafkaSourceReaderTest.testKafkaSourceMetrics fails on azure

2021-12-07 Thread Qingsheng Ren (Jira)
[ https://issues.apache.org/jira/browse/FLINK-23391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17454978#comment-17454978 ] Qingsheng Ren commented on FLINK-23391: --- This one is quite similar to FLINK-20928, probably caused

[GitHub] [flink-ml] yunfengzhou-hub commented on a change in pull request #32: [FLINK-24817] Add Naive Bayes implementation

2021-12-07 Thread GitBox
yunfengzhou-hub commented on a change in pull request #32: URL: https://github.com/apache/flink-ml/pull/32#discussion_r764572915 ## File path: flink-ml-lib/src/main/java/org/apache/flink/ml/classification/naivebayes/NaiveBayesModel.java ## @@ -0,0 +1,213 @@ +/* + * Licensed

[GitHub] [flink] flinkbot edited a comment on pull request #18050: [FLINK-25034][runtime] Support flexible number of subpartitions in IntermediateResultPartition

2021-12-07 Thread GitBox
flinkbot edited a comment on pull request #18050: URL: https://github.com/apache/flink/pull/18050#issuecomment-988466514 ## CI report: * 5e36ba1eacf427ca4665de18b6f71253fb53f0e8 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #18050: [FLINK-25034][runtime] Support flexible number of subpartitions in IntermediateResultPartition

2021-12-07 Thread GitBox
flinkbot edited a comment on pull request #18050: URL: https://github.com/apache/flink/pull/18050#issuecomment-988466514 ## CI report: * 5e36ba1eacf427ca4665de18b6f71253fb53f0e8 Azure:

[GitHub] [flink] deadwind4 commented on pull request #18033: [FLINK-25141][connector/elasticsearch] add sink parallelism option

2021-12-07 Thread GitBox
deadwind4 commented on pull request #18033: URL: https://github.com/apache/flink/pull/18033#issuecomment-988524457 @fapaul please review it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [flink] flinkbot edited a comment on pull request #16108: [FLINK-22821][connector-kafka] FlinkKafkaProducerMigrationTest fails …

2021-12-07 Thread GitBox
flinkbot edited a comment on pull request #16108: URL: https://github.com/apache/flink/pull/16108#issuecomment-856641884 ## CI report: * 850a2914588ba4bf362f5b800a053708c32bac22 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #16108: [FLINK-22821][connector-kafka] FlinkKafkaProducerMigrationTest fails …

2021-12-07 Thread GitBox
flinkbot edited a comment on pull request #16108: URL: https://github.com/apache/flink/pull/16108#issuecomment-856641884 ## CI report: * 5f040e7cb9eddcadd58fe0f37047c1fbd872512c Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #16108: [FLINK-22821][connector-kafka] FlinkKafkaProducerMigrationTest fails …

2021-12-07 Thread GitBox
flinkbot edited a comment on pull request #16108: URL: https://github.com/apache/flink/pull/16108#issuecomment-856641884 ## CI report: * 5f040e7cb9eddcadd58fe0f37047c1fbd872512c Azure:

[GitHub] [flink] paul8263 commented on a change in pull request #16108: [FLINK-22821][connector-kafka] FlinkKafkaProducerMigrationTest fails …

2021-12-07 Thread GitBox
paul8263 commented on a change in pull request #16108: URL: https://github.com/apache/flink/pull/16108#discussion_r764562387 ## File path: flink-core/src/main/java/org/apache/flink/util/FileLock.java ## @@ -0,0 +1,110 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [flink] flinkbot edited a comment on pull request #14376: [FLINK-18202][PB format] New Format of protobuf

2021-12-07 Thread GitBox
flinkbot edited a comment on pull request #14376: URL: https://github.com/apache/flink/pull/14376#issuecomment-744252765 ## CI report: * a721a9d5f663117a203628547a19b33b23927ac2 UNKNOWN * 8f1051527a46aeba13aadc2db3c5f34d8aff78d2 UNKNOWN *

[GitHub] [flink] flinkbot edited a comment on pull request #17692: [FLINK-24489][CEP] The size of entryCache & eventsBufferCache in the SharedBuffer should be defined with a threshold to limit the num

2021-12-07 Thread GitBox
flinkbot edited a comment on pull request #17692: URL: https://github.com/apache/flink/pull/17692#issuecomment-961748638 ## CI report: * 5ee2449e410094eec0c7523a4dfee58091668398 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17692: [FLINK-24489][CEP] The size of entryCache & eventsBufferCache in the SharedBuffer should be defined with a threshold to limit the num

2021-12-07 Thread GitBox
flinkbot edited a comment on pull request #17692: URL: https://github.com/apache/flink/pull/17692#issuecomment-961748638 ## CI report: * 5ee2449e410094eec0c7523a4dfee58091668398 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #16108: [FLINK-22821][connector-kafka] FlinkKafkaProducerMigrationTest fails …

2021-12-07 Thread GitBox
flinkbot edited a comment on pull request #16108: URL: https://github.com/apache/flink/pull/16108#issuecomment-856641884 ## CI report: * 5f040e7cb9eddcadd58fe0f37047c1fbd872512c Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #18048: [FLINK-20370][table] part1: Fix wrong results when sink primary key is not the same with query result's changelog upsert key

2021-12-07 Thread GitBox
flinkbot edited a comment on pull request #18048: URL: https://github.com/apache/flink/pull/18048#issuecomment-988409163 ## CI report: * 03c879c08980eedf2bba6b46a6e5eeb0a0df31b8 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #18048: [FLINK-20370][table] part1: Fix wrong results when sink primary key is not the same with query result's changelog upsert key

2021-12-07 Thread GitBox
flinkbot edited a comment on pull request #18048: URL: https://github.com/apache/flink/pull/18048#issuecomment-988409163 ## CI report: * 03c879c08980eedf2bba6b46a6e5eeb0a0df31b8 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #18048: [FLINK-20370][table] part1: Fix wrong results when sink primary key is not the same with query result's changelog upsert key

2021-12-07 Thread GitBox
flinkbot edited a comment on pull request #18048: URL: https://github.com/apache/flink/pull/18048#issuecomment-988409163 ## CI report: * 03c879c08980eedf2bba6b46a6e5eeb0a0df31b8 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #16108: [FLINK-22821][connector-kafka] FlinkKafkaProducerMigrationTest fails …

2021-12-07 Thread GitBox
flinkbot edited a comment on pull request #16108: URL: https://github.com/apache/flink/pull/16108#issuecomment-856641884 ## CI report: * a696994e8970d98e2f77aa7a4e1db93bb0ecbe53 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #16108: [FLINK-22821][connector-kafka] FlinkKafkaProducerMigrationTest fails …

2021-12-07 Thread GitBox
flinkbot edited a comment on pull request #16108: URL: https://github.com/apache/flink/pull/16108#issuecomment-856641884 ## CI report: * a696994e8970d98e2f77aa7a4e1db93bb0ecbe53 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17939: [FLINK-20370][table] part2: introduce 'table.exec.sink.pk-shuffle' option to auto keyby on sink's pk if parallelism are not the same

2021-12-07 Thread GitBox
flinkbot edited a comment on pull request #17939: URL: https://github.com/apache/flink/pull/17939#issuecomment-981420515 ## CI report: * 9ccb311aec0b5f0d14197c5de37a171ea15c6097 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #14376: [FLINK-18202][PB format] New Format of protobuf

2021-12-07 Thread GitBox
flinkbot edited a comment on pull request #14376: URL: https://github.com/apache/flink/pull/14376#issuecomment-744252765 ## CI report: * a721a9d5f663117a203628547a19b33b23927ac2 UNKNOWN * 8f1051527a46aeba13aadc2db3c5f34d8aff78d2 UNKNOWN *

[GitHub] [flink] flinkbot edited a comment on pull request #17939: [FLINK-20370][table] part2: introduce 'table.exec.sink.pk-shuffle' option to auto keyby on sink's pk if parallelism are not the same

2021-12-07 Thread GitBox
flinkbot edited a comment on pull request #17939: URL: https://github.com/apache/flink/pull/17939#issuecomment-981420515 ## CI report: * 9ccb311aec0b5f0d14197c5de37a171ea15c6097 Azure:

[GitHub] [flink] lincoln-lil commented on pull request #17939: [FLINK-20370][table] part2: introduce 'table.exec.sink.pk-shuffle' option to auto keyby on sink's pk if parallelism are not the same for

2021-12-07 Thread GitBox
lincoln-lil commented on pull request #17939: URL: https://github.com/apache/flink/pull/17939#issuecomment-988482409 Thanks for your review! @JingsongLi I've address your comments and update the pr. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [flink] flinkbot edited a comment on pull request #14376: [FLINK-18202][PB format] New Format of protobuf

2021-12-07 Thread GitBox
flinkbot edited a comment on pull request #14376: URL: https://github.com/apache/flink/pull/14376#issuecomment-744252765 ## CI report: * a721a9d5f663117a203628547a19b33b23927ac2 UNKNOWN * 8f1051527a46aeba13aadc2db3c5f34d8aff78d2 UNKNOWN *

[GitHub] [flink] flinkbot edited a comment on pull request #14376: [FLINK-18202][PB format] New Format of protobuf

2021-12-07 Thread GitBox
flinkbot edited a comment on pull request #14376: URL: https://github.com/apache/flink/pull/14376#issuecomment-744252765 ## CI report: * a721a9d5f663117a203628547a19b33b23927ac2 UNKNOWN * 8f1051527a46aeba13aadc2db3c5f34d8aff78d2 UNKNOWN *

[GitHub] [flink] flinkbot edited a comment on pull request #14376: [FLINK-18202][PB format] New Format of protobuf

2021-12-07 Thread GitBox
flinkbot edited a comment on pull request #14376: URL: https://github.com/apache/flink/pull/14376#issuecomment-744252765 ## CI report: * a721a9d5f663117a203628547a19b33b23927ac2 UNKNOWN * 8f1051527a46aeba13aadc2db3c5f34d8aff78d2 UNKNOWN *

[GitHub] [flink] zhuzhurk commented on a change in pull request #17952: [FLINK-25011][runtime] Introduce vertex parallelism decider and the default implementation.

2021-12-07 Thread GitBox
zhuzhurk commented on a change in pull request #17952: URL: https://github.com/apache/flink/pull/17952#discussion_r764533772 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptivebatch/DefaultVertexParallelismDecider.java ## @@ -81,52 +88,36 @@

[GitHub] [flink] flinkbot edited a comment on pull request #14376: [FLINK-18202][PB format] New Format of protobuf

2021-12-07 Thread GitBox
flinkbot edited a comment on pull request #14376: URL: https://github.com/apache/flink/pull/14376#issuecomment-744252765 ## CI report: * a721a9d5f663117a203628547a19b33b23927ac2 UNKNOWN * 8f1051527a46aeba13aadc2db3c5f34d8aff78d2 UNKNOWN *

[GitHub] [flink] flinkbot edited a comment on pull request #14376: [FLINK-18202][PB format] New Format of protobuf

2021-12-07 Thread GitBox
flinkbot edited a comment on pull request #14376: URL: https://github.com/apache/flink/pull/14376#issuecomment-744252765 ## CI report: * a721a9d5f663117a203628547a19b33b23927ac2 UNKNOWN * 8f1051527a46aeba13aadc2db3c5f34d8aff78d2 UNKNOWN *

[jira] [Updated] (FLINK-25218) Performance issues with lookup join accessing external dimension tables

2021-12-07 Thread ZhuoYu Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25218?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ZhuoYu Chen updated FLINK-25218: Affects Version/s: 1.15.0 > Performance issues with lookup join accessing external dimension

[jira] [Created] (FLINK-25218) Performance issues with lookup join accessing external dimension tables

2021-12-07 Thread ZhuoYu Chen (Jira)
ZhuoYu Chen created FLINK-25218: --- Summary: Performance issues with lookup join accessing external dimension tables Key: FLINK-25218 URL: https://issues.apache.org/jira/browse/FLINK-25218 Project:

[GitHub] [flink] flinkbot edited a comment on pull request #14376: [FLINK-18202][PB format] New Format of protobuf

2021-12-07 Thread GitBox
flinkbot edited a comment on pull request #14376: URL: https://github.com/apache/flink/pull/14376#issuecomment-744252765 ## CI report: * a721a9d5f663117a203628547a19b33b23927ac2 UNKNOWN * 8f1051527a46aeba13aadc2db3c5f34d8aff78d2 UNKNOWN *

[GitHub] [flink] flinkbot edited a comment on pull request #14376: [FLINK-18202][PB format] New Format of protobuf

2021-12-07 Thread GitBox
flinkbot edited a comment on pull request #14376: URL: https://github.com/apache/flink/pull/14376#issuecomment-744252765 ## CI report: * a721a9d5f663117a203628547a19b33b23927ac2 UNKNOWN * 8f1051527a46aeba13aadc2db3c5f34d8aff78d2 UNKNOWN *

[GitHub] [flink] maosuhan commented on pull request #14376: [FLINK-18202][PB format] New Format of protobuf

2021-12-07 Thread GitBox
maosuhan commented on pull request #14376: URL: https://github.com/apache/flink/pull/14376#issuecomment-988473669 @MyLanPangzi I have updated the code to adaptively convert between enum of protobuf and numeric/string type of flink and also unit tests are added. Since codegen in java is

[GitHub] [flink] flinkbot edited a comment on pull request #14376: [FLINK-18202][PB format] New Format of protobuf

2021-12-07 Thread GitBox
flinkbot edited a comment on pull request #14376: URL: https://github.com/apache/flink/pull/14376#issuecomment-744252765 ## CI report: * a721a9d5f663117a203628547a19b33b23927ac2 UNKNOWN * 8f1051527a46aeba13aadc2db3c5f34d8aff78d2 UNKNOWN *

[GitHub] [flink] lincoln-lil commented on a change in pull request #17939: [FLINK-20370][table] part2: introduce 'table.exec.sink.pk-shuffle' option to auto keyby on sink's pk if parallelism are not t

2021-12-07 Thread GitBox
lincoln-lil commented on a change in pull request #17939: URL: https://github.com/apache/flink/pull/17939#discussion_r764528915 ## File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/config/ExecutionConfigOptions.java ## @@ -140,6 +140,25 @@

[GitHub] [flink] flinkbot edited a comment on pull request #14376: [FLINK-18202][PB format] New Format of protobuf

2021-12-07 Thread GitBox
flinkbot edited a comment on pull request #14376: URL: https://github.com/apache/flink/pull/14376#issuecomment-744252765 ## CI report: * a721a9d5f663117a203628547a19b33b23927ac2 UNKNOWN * 8f1051527a46aeba13aadc2db3c5f34d8aff78d2 UNKNOWN *

[GitHub] [flink] lincoln-lil commented on a change in pull request #17939: [FLINK-20370][table] part2: introduce 'table.exec.sink.pk-shuffle' option to auto keyby on sink's pk if parallelism are not t

2021-12-07 Thread GitBox
lincoln-lil commented on a change in pull request #17939: URL: https://github.com/apache/flink/pull/17939#discussion_r764527157 ## File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/config/ExecutionConfigOptions.java ## @@ -140,6 +140,25 @@

[GitHub] [flink] flinkbot edited a comment on pull request #18050: [FLINK-25034][runtime] Support flexible number of subpartitions in IntermediateResultPartition

2021-12-07 Thread GitBox
flinkbot edited a comment on pull request #18050: URL: https://github.com/apache/flink/pull/18050#issuecomment-988466514 ## CI report: * 5e36ba1eacf427ca4665de18b6f71253fb53f0e8 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #18049: [FLINK-24813][table-planner-blink] Improve ImplicitTypeConversionITCase

2021-12-07 Thread GitBox
flinkbot edited a comment on pull request #18049: URL: https://github.com/apache/flink/pull/18049#issuecomment-988465299 ## CI report: * da40e9da154b7273f6db5eb12d65c983636cd1e6 Azure:

[GitHub] [flink] flinkbot commented on pull request #18050: [FLINK-25034][runtime] Support flexible number of subpartitions in IntermediateResultPartition

2021-12-07 Thread GitBox
flinkbot commented on pull request #18050: URL: https://github.com/apache/flink/pull/18050#issuecomment-988466514 ## CI report: * 5e36ba1eacf427ca4665de18b6f71253fb53f0e8 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot

[GitHub] [flink] flinkbot commented on pull request #18049: [FLINK-24813][table-planner-blink] Improve ImplicitTypeConversionITCase

2021-12-07 Thread GitBox
flinkbot commented on pull request #18049: URL: https://github.com/apache/flink/pull/18049#issuecomment-988465918 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the

[GitHub] [flink] flinkbot commented on pull request #18050: [FLINK-25034][runtime] Support flexible number of subpartitions in IntermediateResultPartition

2021-12-07 Thread GitBox
flinkbot commented on pull request #18050: URL: https://github.com/apache/flink/pull/18050#issuecomment-988465904 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the

[GitHub] [flink] zhuzhurk commented on a change in pull request #17952: [FLINK-25011][runtime] Introduce vertex parallelism decider and the default implementation.

2021-12-07 Thread GitBox
zhuzhurk commented on a change in pull request #17952: URL: https://github.com/apache/flink/pull/17952#discussion_r764522853 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/adaptivebatch/DefaultVertexParallelismDeciderTest.java ## @@ -58,22 +72,22

[GitHub] [flink] zhuzhurk commented on a change in pull request #17952: [FLINK-25011][runtime] Introduce vertex parallelism decider and the default implementation.

2021-12-07 Thread GitBox
zhuzhurk commented on a change in pull request #17952: URL: https://github.com/apache/flink/pull/17952#discussion_r764522853 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/adaptivebatch/DefaultVertexParallelismDeciderTest.java ## @@ -58,22 +72,22

[GitHub] [flink] flinkbot commented on pull request #18049: [FLINK-24813][table-planner-blink] Improve ImplicitTypeConversionITCase

2021-12-07 Thread GitBox
flinkbot commented on pull request #18049: URL: https://github.com/apache/flink/pull/18049#issuecomment-988465299 ## CI report: * da40e9da154b7273f6db5eb12d65c983636cd1e6 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot

[GitHub] [flink] lincoln-lil commented on a change in pull request #17939: [FLINK-20370][table] part2: introduce 'table.exec.sink.pk-shuffle' option to auto keyby on sink's pk if parallelism are not t

2021-12-07 Thread GitBox
lincoln-lil commented on a change in pull request #17939: URL: https://github.com/apache/flink/pull/17939#discussion_r764522531 ## File path: flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/common/CommonExecSink.java ## @@ -232,26

[jira] [Updated] (FLINK-25034) Support flexible number of subpartitions in IntermediateResultPartition

2021-12-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25034?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-25034: --- Labels: pull-request-available (was: ) > Support flexible number of subpartitions in

[GitHub] [flink] wanglijie95 opened a new pull request #18050: [FLINK-25034][runtime] Support flexible number of subpartitions in IntermediateResultPartition

2021-12-07 Thread GitBox
wanglijie95 opened a new pull request #18050: URL: https://github.com/apache/flink/pull/18050 ## What is the purpose of the change Support flexible number of subpartitions in IntermediateResultPartition. When the consumer parallelism is decided, number of subpartitions should be

[GitHub] [flink] zhuzhurk commented on a change in pull request #17952: [FLINK-25011][runtime] Introduce vertex parallelism decider and the default implementation.

2021-12-07 Thread GitBox
zhuzhurk commented on a change in pull request #17952: URL: https://github.com/apache/flink/pull/17952#discussion_r764522054 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/adaptivebatch/DefaultVertexParallelismDeciderTest.java ## @@ -82,32 +96,32

[GitHub] [flink] xuyangzhong opened a new pull request #18049: [FLINK-24813][table-planner-blink] Improve ImplicitTypeConversionITCase

2021-12-07 Thread GitBox
xuyangzhong opened a new pull request #18049: URL: https://github.com/apache/flink/pull/18049 ## What is the purpose of the change delete the test file ImplicitTypeConversionITCase and union them into the ImplicitConversionEqualsFunctionITCase to have the same code style with

[GitHub] [flink] flinkbot edited a comment on pull request #16108: [FLINK-22821][connector-kafka] FlinkKafkaProducerMigrationTest fails …

2021-12-07 Thread GitBox
flinkbot edited a comment on pull request #16108: URL: https://github.com/apache/flink/pull/16108#issuecomment-856641884 ## CI report: * a696994e8970d98e2f77aa7a4e1db93bb0ecbe53 Azure:

[GitHub] [flink] zhuzhurk commented on a change in pull request #17952: [FLINK-25011][runtime] Introduce vertex parallelism decider and the default implementation.

2021-12-07 Thread GitBox
zhuzhurk commented on a change in pull request #17952: URL: https://github.com/apache/flink/pull/17952#discussion_r764519958 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptivebatch/BlockingResultInfo.java ## @@ -0,0 +1,42 @@ +/* + * Licensed

[GitHub] [flink] lincoln-lil commented on a change in pull request #17939: [FLINK-20370][table] part2: introduce 'table.exec.sink.pk-shuffle' option to auto keyby on sink's pk if parallelism are not t

2021-12-07 Thread GitBox
lincoln-lil commented on a change in pull request #17939: URL: https://github.com/apache/flink/pull/17939#discussion_r764519877 ## File path: flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/common/CommonExecSink.java ## @@ -232,26

[GitHub] [flink] paul8263 commented on a change in pull request #16108: [FLINK-22821][connector-kafka] FlinkKafkaProducerMigrationTest fails …

2021-12-07 Thread GitBox
paul8263 commented on a change in pull request #16108: URL: https://github.com/apache/flink/pull/16108#discussion_r764519555 ## File path: flink-core/src/main/java/org/apache/flink/util/FileLock.java ## @@ -0,0 +1,110 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [flink] flinkbot edited a comment on pull request #16108: [FLINK-22821][connector-kafka] FlinkKafkaProducerMigrationTest fails …

2021-12-07 Thread GitBox
flinkbot edited a comment on pull request #16108: URL: https://github.com/apache/flink/pull/16108#issuecomment-856641884 ## CI report: * a696994e8970d98e2f77aa7a4e1db93bb0ecbe53 Azure:

[GitHub] [flink] paul8263 commented on a change in pull request #16108: [FLINK-22821][connector-kafka] FlinkKafkaProducerMigrationTest fails …

2021-12-07 Thread GitBox
paul8263 commented on a change in pull request #16108: URL: https://github.com/apache/flink/pull/16108#discussion_r764519129 ## File path: flink-core/src/main/java/org/apache/flink/util/FileLock.java ## @@ -0,0 +1,110 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [flink] paul8263 commented on a change in pull request #16108: [FLINK-22821][connector-kafka] FlinkKafkaProducerMigrationTest fails …

2021-12-07 Thread GitBox
paul8263 commented on a change in pull request #16108: URL: https://github.com/apache/flink/pull/16108#discussion_r764518525 ## File path: flink-core/src/main/java/org/apache/flink/util/FileLock.java ## @@ -0,0 +1,110 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [flink] lincoln-lil commented on a change in pull request #17939: [FLINK-20370][table] part2: introduce 'table.exec.sink.pk-shuffle' option to auto keyby on sink's pk if parallelism are not t

2021-12-07 Thread GitBox
lincoln-lil commented on a change in pull request #17939: URL: https://github.com/apache/flink/pull/17939#discussion_r764518374 ## File path: flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/common/CommonExecSink.java ## @@ -232,26

[GitHub] [flink] flinkbot edited a comment on pull request #17988: [FLINK-25010][Connectors/Hive] Speed up hive's createMRSplits by multi thread

2021-12-07 Thread GitBox
flinkbot edited a comment on pull request #17988: URL: https://github.com/apache/flink/pull/17988#issuecomment-984363654 ## CI report: * 28b8d68b9819361880a3893eb021688617a2e5fb Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17988: [FLINK-25010][Connectors/Hive] Speed up hive's createMRSplits by multi thread

2021-12-07 Thread GitBox
flinkbot edited a comment on pull request #17988: URL: https://github.com/apache/flink/pull/17988#issuecomment-984363654 ## CI report: * 28b8d68b9819361880a3893eb021688617a2e5fb Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17988: [FLINK-25010][Connectors/Hive] Speed up hive's createMRSplits by multi thread

2021-12-07 Thread GitBox
flinkbot edited a comment on pull request #17988: URL: https://github.com/apache/flink/pull/17988#issuecomment-984363654 ## CI report: * 28b8d68b9819361880a3893eb021688617a2e5fb Azure:

[jira] [Closed] (FLINK-24730) Support prompt style in SqlCli

2021-12-07 Thread Yubin Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24730?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yubin Li closed FLINK-24730. Resolution: Fixed > Support prompt style in SqlCli > -- > >

[GitHub] [flink] zhuzhurk commented on a change in pull request #17952: [FLINK-25011][runtime] Introduce vertex parallelism decider and the default implementation.

2021-12-07 Thread GitBox
zhuzhurk commented on a change in pull request #17952: URL: https://github.com/apache/flink/pull/17952#discussion_r764514899 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptivebatch/VertexParallelismDecider.java ## @@ -29,17 +29,8 @@ /**

[GitHub] [flink] flinkbot edited a comment on pull request #17462: [FLINK-23170] Write metadata after materialization

2021-12-07 Thread GitBox
flinkbot edited a comment on pull request #17462: URL: https://github.com/apache/flink/pull/17462#issuecomment-942024789 ## CI report: * 459916eaca61c9210c403ee4f4125cfbf3590fa2 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17462: [FLINK-23170] Write metadata after materialization

2021-12-07 Thread GitBox
flinkbot edited a comment on pull request #17462: URL: https://github.com/apache/flink/pull/17462#issuecomment-942024789 ## CI report: * 459916eaca61c9210c403ee4f4125cfbf3590fa2 Azure:

[GitHub] [flink] curcur commented on pull request #17462: [FLINK-23170] Write metadata after materialization

2021-12-07 Thread GitBox
curcur commented on pull request #17462: URL: https://github.com/apache/flink/pull/17462#issuecomment-988451245 squash commits. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [flink] JingsongLi commented on a change in pull request #17939: [FLINK-20370][table] part2: introduce 'table.exec.sink.pk-shuffle' option to auto keyby on sink's pk if parallelism are not th

2021-12-07 Thread GitBox
JingsongLi commented on a change in pull request #17939: URL: https://github.com/apache/flink/pull/17939#discussion_r764512993 ## File path: flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/common/CommonExecSink.java ## @@ -232,26

[GitHub] [flink] JingsongLi commented on a change in pull request #17939: [FLINK-20370][table] part2: introduce 'table.exec.sink.pk-shuffle' option to auto keyby on sink's pk if parallelism are not th

2021-12-07 Thread GitBox
JingsongLi commented on a change in pull request #17939: URL: https://github.com/apache/flink/pull/17939#discussion_r764511680 ## File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/config/ExecutionConfigOptions.java ## @@ -140,6 +140,25 @@

[GitHub] [flink] JingsongLi commented on a change in pull request #17939: [FLINK-20370][table] part2: introduce 'table.exec.sink.pk-shuffle' option to auto keyby on sink's pk if parallelism are not th

2021-12-07 Thread GitBox
JingsongLi commented on a change in pull request #17939: URL: https://github.com/apache/flink/pull/17939#discussion_r764511517 ## File path: flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/common/CommonExecSink.java ## @@ -232,26

[GitHub] [flink] JingsongLi commented on a change in pull request #17939: [FLINK-20370][table] part2: introduce 'table.exec.sink.pk-shuffle' option to auto keyby on sink's pk if parallelism are not th

2021-12-07 Thread GitBox
JingsongLi commented on a change in pull request #17939: URL: https://github.com/apache/flink/pull/17939#discussion_r764511367 ## File path: flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/common/CommonExecSink.java ## @@ -232,26

[GitHub] [flink] JingsongLi commented on a change in pull request #17939: [FLINK-20370][table] part2: introduce 'table.exec.sink.pk-shuffle' option to auto keyby on sink's pk if parallelism are not th

2021-12-07 Thread GitBox
JingsongLi commented on a change in pull request #17939: URL: https://github.com/apache/flink/pull/17939#discussion_r764511041 ## File path: flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/common/CommonExecSink.java ## @@ -232,26

  1   2   3   4   5   6   7   8   >